Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131220681
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2363,7 +2363,7 @@ private CommonTopoInfo getCommonTopoInfo(Stri
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219950
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the A
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219624
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/persistence/WindowState.java ---
@@ -0,0 +1,422 @@
+/**
+ * Licensed to the Apache So
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219546
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apa
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219599
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apa
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219494
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the A
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131119473
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Sof
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131123972
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apache Softw
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131126237
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/persistence/WindowState.java ---
@@ -0,0 +1,422 @@
+/**
+ * Licensed to the Apache Software Fo
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131125567
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apache Softw
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131120403
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Sof
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131127445
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2363,7 +2363,7 @@ private CommonTopoInfo getCommonTopoInfo(String
topoI
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131123215
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apache Softw
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131121321
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apache Softw
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130528810
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130528860
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent) {
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130528788
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Ap
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130462981
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent) {
LOG
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130433567
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WatermarkCountEvictionPolicy.java
---
@@ -17,20 +17,28 @@
*/
package org.apache.storm.wind
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130433067
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Apache Soft
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130432729
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Apache Soft
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130274015
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/TupleWindowIterImpl.java ---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Softwar
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273957
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent) {
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130274003
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent) {
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273929
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2363,7 +2363,7 @@ private CommonTopoInfo getCommonTopoInfo(Stri
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273915
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273903
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273891
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273846
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273878
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273860
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273816
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WatermarkCountEvictionPolicy.java
---
@@ -17,20 +17,28 @@
*/
package org.apache.s
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273840
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273783
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent) {
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273789
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -289,4 +414,22 @@ public String toString() {
"
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273736
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273719
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273744
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273697
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273758
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -53,28 +61,34 @@
public static final int EXPIRE_EVENTS_THR
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273727
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273647
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowPartitionCache.java ---
@@ -0,0 +1,142 @@
+/**
+ * Licensed to the Apache Softwa
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273679
--- Diff: docs/Windowing.md ---
@@ -266,3 +266,108 @@ tuples can be received within the timeout period.
An example toplogy `SlidingWindowTopology`
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273666
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273640
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273607
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/base/BaseStatefulWindowedBolt.java
---
@@ -151,6 +158,38 @@
return this;
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130235112
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache Software
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130233654
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache Softw
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130228748
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent) {
LOG
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130228532
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent) {
LOG
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130228711
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/TupleWindowIterImpl.java ---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundat
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227637
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130228071
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227685
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130225941
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Apache Soft
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130226940
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WatermarkCountEvictionPolicy.java
---
@@ -17,20 +17,28 @@
*/
package org.apache.storm.wind
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130226675
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -289,4 +414,22 @@ public String toString() {
", trigger
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130225936
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Apache Soft
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130228086
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2363,7 +2363,7 @@ private CommonTopoInfo getCommonTopoInfo(String
topoI
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130225676
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Apache Soft
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130226080
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/StatefulBoltExecutor.java ---
@@ -123,6 +123,11 @@ protected void handleCheckpoint(Tuple checkpointTupl
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130228020
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227794
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227512
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227886
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227746
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227409
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227210
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130225984
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Apache Soft
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130225709
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Apache Soft
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130226013
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227459
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130226994
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -53,28 +61,34 @@
public static final int EXPIRE_EVENTS_THRESHOLD =
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227123
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent) {
LOG
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130010224
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache Softw
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129809356
--- Diff: docs/Windowing.md ---
@@ -266,3 +266,108 @@ tuples can be received within the timeout period.
An example toplogy `SlidingWindowTopology` shows
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r128993342
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed to the Apache S
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129003027
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed to the Apache S
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129791075
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed to the Apache S
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r128991661
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/base/BaseStatefulWindowedBolt.java
---
@@ -151,6 +158,38 @@
return this;
}
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r128992641
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/IStatefulWindowedBolt.java ---
@@ -15,12 +15,33 @@
* See the License for the specific language
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129760482
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed to the Apache S
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129803794
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowPartitionCache.java ---
@@ -0,0 +1,142 @@
+/**
+ * Licensed to the Apache Software Fou
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129804787
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache Softw
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763588
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763692
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763781
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/TupleWindowIterImpl.java ---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Softwar
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763573
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763661
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763759
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -127,26 +154,30 @@ private void validate(Map topoConf,
Count
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763707
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -102,6 +109,18 @@ private int getMaxSpoutPending(Map
topoCon
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763468
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763520
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763418
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/PersistentWindowingTopology.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to t
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763373
--- Diff: docs/Windowing.md ---
@@ -266,3 +266,105 @@ tuples can be received within the timeout period.
An example toplogy `SlidingWindowTopology`
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763340
--- Diff: docs/Windowing.md ---
@@ -266,3 +266,105 @@ tuples can be received within the timeout period.
An example toplogy `SlidingWindowTopology`
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763359
--- Diff: docs/Windowing.md ---
@@ -266,3 +266,105 @@ tuples can be received within the timeout period.
An example toplogy `SlidingWindowTopology`
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129139943
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed to the Apache Soft
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129663556
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -102,6 +109,18 @@ private int getMaxSpoutPending(Map
topoConf) {
1 - 100 of 130 matches
Mail list logo
