Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2710
---
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208340502
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java ---
@@ -365,6 +384,7 @@ void addReferencesToBlobs(PortAndAssignment pna,
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208292571
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -346,6 +358,10 @@ public void cleanUp() throws IOException
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208286166
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -346,6 +358,10 @@ public void cleanUp() throws IOException
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208279317
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
---
@@ -28,11 +29,14 @@
import
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208092337
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -346,6 +358,10 @@ public void cleanUp() throws IOException {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208095554
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -1008,6 +1015,13 @@ public void close() throws Exception {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208279468
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java ---
@@ -251,11 +261,18 @@ private LocalizedResource getUserFile(String
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r208096352
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -1147,8 +1162,19 @@ public DynamicState
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r207645153
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
---
@@ -28,11 +29,14 @@
import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r207578433
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -1147,8 +1162,19 @@ public DynamicState
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r207576736
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
---
@@ -28,11 +29,14 @@
import
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r199710919
--- Diff: storm-server/src/main/java/org/apache/storm/daemon/drpc/DRPC.java
---
@@ -208,6 +208,7 @@ public void failRequest(String id,
13 matches
Mail list logo