[GitHub] storm pull request: STORM-1071 : Task Message format to include so...

2015-09-29 Thread bourneagain
GitHub user bourneagain opened a pull request: https://github.com/apache/storm/pull/768 STORM-1071 : Task Message format to include source task id. As part of gathering inputs for Resource Aware Scheduler, understanding the tuple network characteristics between tasks would be helpfu

[jira] [Commented] (STORM-1071) Task Message format to include source task id.

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934874#comment-14934874 ] ASF GitHub Bot commented on STORM-1071: --- GitHub user bourneagain opened a pull reque

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-29 Thread wangli1426
Github user wangli1426 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-144032486 Hi @HeartSaVioR, Sorry to interrupt, but could please kindly review the code? I am looking forward to your response. Thanks --- If your project is set up for

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935023#comment-14935023 ] ASF GitHub Bot commented on STORM-1057: --- Github user wangli1426 commented on the pul

Does Storm work with Spring

2015-09-29 Thread Ankur Garg
Hi , I am building a Storm topology with set of Spouts and Bolts and also using Spring for Dependency Injection . Unfortunately , none of my fields are getting autowired even though I have declared all my spouts and Bolts as @Components . However the place where I am declaring my topology , Spr

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-144044727 @wangli1426 Sorry to response later. We're having holidays in South Korea, 'Chuseok', very similar to 'Mid-autumn festival'. It ends just Today, so it'll

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935090#comment-14935090 ] ASF GitHub Bot commented on STORM-1057: --- Github user HeartSaVioR commented on the pu

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-29 Thread wangli1426
Github user wangli1426 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-144050232 Thank you for your prompt reply. Please review the code when you come back. Wish you have a good time. > On Sep 29, 2015, at 20:30, Jungtaek Lim wrote: >

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935121#comment-14935121 ] ASF GitHub Bot commented on STORM-1057: --- Github user wangli1426 commented on the pul

Re: Does Storm work with Spring

2015-09-29 Thread Ravi Sharma
Bolts and Spouts are created by Storm and not known to Spring Context. You need to manually add them to SpringContext, there are few methods available i.e. SpringContext.getContext().getAutowireCapableBeanFactory().autowireBeanProperties(this, AutowireCapableBeanFactory.AUTOWIRE_AUTODETECT, false)

Re: Does Storm work with Spring

2015-09-29 Thread Ankur Garg
Hi Ravi , Thanks for your reply . I am using annotation based configuration and using Spring Boot. Any idea how to do it using annotations ? On Tue, Sep 29, 2015 at 6:41 PM, Ravi Sharma wrote: > Bolts and Spouts are created by Storm and not known to Spring Context. You > need to manually add

[GitHub] storm pull request: Disruptor batching v2

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/765#issuecomment-144059813 @mjsax The difference is not that huge yet. It is 2x in a number of use cases. But we have a lot of slowness in the metrics processing code, which, at least in the

[GitHub] storm pull request: [STORM-855] Add tuple batching

2015-09-29 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/storm/pull/694#issuecomment-144060581 I just realized, that some commits from other people got added to this PR. This confuses me. Can you guide me through the process Storm development is following here? I am

[jira] [Commented] (STORM-855) Add tuple batching

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935175#comment-14935175 ] ASF GitHub Bot commented on STORM-855: -- Github user mjsax commented on the pull reques

[GitHub] storm pull request: [STORM-412] Allow users to modify logging leve...

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/766#discussion_r40671792 --- Diff: storm-core/src/clj/backtype/storm/command/set_log_level.clj --- @@ -0,0 +1,75 @@ +;; Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (STORM-412) Allow users to modify logging levels of running topologies.

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935179#comment-14935179 ] ASF GitHub Bot commented on STORM-412: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-412] Allow users to modify logging leve...

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/766#issuecomment-144064554 I had one minor nit, but I am +1 overall with or without the small fix, assuming you can address/answer @Parth-Brahmbhatt's comment. The test failures look unrela

[jira] [Commented] (STORM-412) Allow users to modify logging levels of running topologies.

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935188#comment-14935188 ] ASF GitHub Bot commented on STORM-412: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-855] Add tuple batching

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/694#issuecomment-144066244 @mjsax the issue is with how you upmerge. If you just do a git merge or a git pull github can become confused because it thinks you are still based off of the original c

[jira] [Commented] (STORM-855) Add tuple batching

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935192#comment-14935192 ] ASF GitHub Bot commented on STORM-855: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-1069], add check case for external chan...

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/763#issuecomment-144071299 Still +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] storm pull request: [STORM-855] Add tuple batching

2015-09-29 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/storm/pull/694#issuecomment-144071648 I see. It's a github issue... Usually I rebase before updating a PR. This time I did not... Thanks for the quick response. --- If your project is set up for it, you can re

[jira] [Commented] (STORM-1069) Usage of System.currentTimeMillis() in KafkaSpout can create delays

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935207#comment-14935207 ] ASF GitHub Bot commented on STORM-1069: --- Github user revans2 commented on the pull r

[jira] [Commented] (STORM-855) Add tuple batching

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935209#comment-14935209 ] ASF GitHub Bot commented on STORM-855: -- Github user mjsax commented on the pull reques

[jira] [Commented] (STORM-412) Allow users to modify logging levels of running topologies.

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935227#comment-14935227 ] ASF GitHub Bot commented on STORM-412: -- Github user kishorvpatil commented on a diff i

[GitHub] storm pull request: [STORM-412] Allow users to modify logging leve...

2015-09-29 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/766#discussion_r40676193 --- Diff: storm-core/src/clj/backtype/storm/cluster.clj --- @@ -518,6 +540,13 @@ (catch KeeperException e (log-warn-error e

[jira] [Commented] (STORM-1069) Usage of System.currentTimeMillis() in KafkaSpout can create delays

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935232#comment-14935232 ] ASF GitHub Bot commented on STORM-1069: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1069], add check case for external chan...

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/763 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (STORM-1069) Usage of System.currentTimeMillis() in KafkaSpout can create delays

2015-09-29 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1069. Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~3dragan], I merged this int

Re: Does Storm work with Spring

2015-09-29 Thread Ravi Sharma
Yes this is for annotation also... you can call this method in prepare() method of bolt and onOpen() method in every Spout and make sure you don't use any autowire bean before this call. Ravi. On Tue, Sep 29, 2015 at 2:22 PM, Ankur Garg wrote: > Hi Ravi , > > Thanks for your reply . I a

[jira] [Commented] (STORM-412) Allow users to modify logging levels of running topologies.

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935248#comment-14935248 ] ASF GitHub Bot commented on STORM-412: -- Github user kishorvpatil commented on a diff i

[GitHub] storm pull request: [STORM-412] Allow users to modify logging leve...

2015-09-29 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/766#discussion_r40678621 --- Diff: storm-core/src/clj/backtype/storm/command/set_log_level.clj --- @@ -0,0 +1,75 @@ +;; Licensed to the Apache Software Foundation (ASF) under o

[GitHub] storm pull request: STORM-1012 STORM-967 STORM-922 STORM-1042 Shad...

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/736#issuecomment-144106731 @ptgoetz If you are OK with doing a manual process instead of using the fancy plugin I think we can make it work. ``` mvn versions:set mvn clean install -P sto

[jira] [Commented] (STORM-1012) Shade Jackson dependency

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935374#comment-14935374 ] ASF GitHub Bot commented on STORM-1012: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/746#issuecomment-144111799 @HeartSaVioR @revans2 Can I get a review for my PR. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on G

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935405#comment-14935405 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on the pull re

[GitHub] storm pull request: [STORM-1063] support relative log4j conf dir f...

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/760#issuecomment-144137713 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[jira] [Commented] (STORM-1063) Workers cannot find log4j configuration files since default value of storm.log4j2.conf.dir is relative

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935543#comment-14935543 ] ASF GitHub Bot commented on STORM-1063: --- Github user jerrypeng commented on the pull

[GitHub] storm pull request: [STORM-1066] add current directory for worker ...

2015-09-29 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/storm/pull/769 [STORM-1066] add current directory for worker process launcher Currently, when supervisor launches a worker, the current directory of the worker process is not specified. In that case, the worker wil

[jira] [Commented] (STORM-1066) Specify current directory when supervisor launches a worker

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935586#comment-14935586 ] ASF GitHub Bot commented on STORM-1066: --- GitHub user zhuoliu opened a pull request:

[GitHub] storm pull request: [STORM-820] Aggregate topo stats on nimbus, no...

2015-09-29 Thread d2r
GitHub user d2r reopened a pull request: https://github.com/apache/storm/pull/554 [STORM-820] Aggregate topo stats on nimbus, not ui You can merge this pull request into a Git repository by running: $ git pull https://github.com/d2r/storm storm-820-agg-stats-on-nimbus Alterna

[jira] [Commented] (STORM-820) UI Topology & Component Pages have long load times with large, highly-connected Topologies

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935638#comment-14935638 ] ASF GitHub Bot commented on STORM-820: -- GitHub user d2r reopened a pull request:

[GitHub] storm pull request: [STORM-820] Aggregate topo stats on nimbus, no...

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/554#discussion_r40715660 --- Diff: storm-core/src/jvm/backtype/storm/generated/BoltStats.java --- @@ -51,7 +51,7 @@ import org.slf4j.LoggerFactory; @SuppressWarnings({"c

[jira] [Commented] (STORM-1058) create CLI kill_workers to kill workers on a supervisor node

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935679#comment-14935679 ] ASF GitHub Bot commented on STORM-1058: --- Github user jerrypeng commented on a diff i

[jira] [Commented] (STORM-820) UI Topology & Component Pages have long load times with large, highly-connected Topologies

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935675#comment-14935675 ] ASF GitHub Bot commented on STORM-820: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/756#discussion_r40716052 --- Diff: bin/storm.py --- @@ -348,6 +348,19 @@ def get_errors(*args): jvmtype="-client", extrajars=[USER_CONF_DIR, os.path.join(STO

[GitHub] storm pull request: [STORM-820] Aggregate topo stats on nimbus, no...

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/554#discussion_r40716500 --- Diff: storm-core/src/clj/backtype/storm/log.clj --- @@ -44,3 +46,11 @@ (defn log-stream [& args] (apply log/log-stream args)) + +

[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/756#issuecomment-144161813 other than my nit comment, looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Commented] (STORM-820) UI Topology & Component Pages have long load times with large, highly-connected Topologies

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935683#comment-14935683 ] ASF GitHub Bot commented on STORM-820: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-820) UI Topology & Component Pages have long load times with large, highly-connected Topologies

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935691#comment-14935691 ] ASF GitHub Bot commented on STORM-820: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-1059) Upgrade Storm to use Clojure 1.7.0

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935689#comment-14935689 ] ASF GitHub Bot commented on STORM-1059: --- Github user jerrypeng commented on the pull

[jira] [Commented] (STORM-1058) create CLI kill_workers to kill workers on a supervisor node

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935685#comment-14935685 ] ASF GitHub Bot commented on STORM-1058: --- Github user jerrypeng commented on the pull

[GitHub] storm pull request: [STORM-820] Aggregate topo stats on nimbus, no...

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/554#discussion_r40716909 --- Diff: storm-core/src/jvm/backtype/storm/generated/ClusterSummary.java --- @@ -51,7 +51,7 @@ import org.slf4j.LoggerFactory; @SuppressWarnin

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935697#comment-14935697 ] ASF GitHub Bot commented on STORM-1057: --- Github user jerrypeng commented on the pull

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-144163913 storm-core/src/genthrift.sh permssions should be changed back to -> 644 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: STORM-1059: Upgrade Storm to use Clojure 1.7.0

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/755#issuecomment-144162067 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] storm pull request: [STORM-820] Aggregate topo stats on nimbus, no...

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/554#issuecomment-144164575 For the most part this looks good. My only comment would be to update the REST API docs to describe what the new APIs are like. And did you change time to errorTime in

[jira] [Commented] (STORM-820) UI Topology & Component Pages have long load times with large, highly-connected Topologies

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935703#comment-14935703 ] ASF GitHub Bot commented on STORM-820: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-820] Aggregate topo stats on nimbus, no...

2015-09-29 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/554#discussion_r40718750 --- Diff: storm-core/src/clj/backtype/storm/log.clj --- @@ -44,3 +46,11 @@ (defn log-stream [& args] (apply log/log-stream args)) + +(def

[jira] [Commented] (STORM-820) UI Topology & Component Pages have long load times with large, highly-connected Topologies

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935721#comment-14935721 ] ASF GitHub Bot commented on STORM-820: -- Github user d2r commented on a diff in the pul

[jira] [Commented] (STORM-1059) Upgrade Storm to use Clojure 1.7.0

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935732#comment-14935732 ] ASF GitHub Bot commented on STORM-1059: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: STORM-1059: Upgrade Storm to use Clojure 1.7.0

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/755#issuecomment-144168351 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-820] Aggregate topo stats on nimbus, no...

2015-09-29 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/554#issuecomment-144169425 > And did you change time to errorTime in the JSON response? Good catch. Updated API doc with a note on the name change. --- If your project is set up for it, you ca

[jira] [Commented] (STORM-1059) Upgrade Storm to use Clojure 1.7.0

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935745#comment-14935745 ] ASF GitHub Bot commented on STORM-1059: --- Github user asfgit closed the pull request

[GitHub] storm pull request: STORM-1059: Upgrade Storm to use Clojure 1.7.0

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/755 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-820) UI Topology & Component Pages have long load times with large, highly-connected Topologies

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935746#comment-14935746 ] ASF GitHub Bot commented on STORM-820: -- Github user d2r commented on the pull request:

[jira] [Resolved] (STORM-1059) Upgrade Storm to use Clojure 1.7.0

2015-09-29 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1059. Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~knusbaum], I merged this in

[jira] [Commented] (STORM-820) UI Topology & Component Pages have long load times with large, highly-connected Topologies

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935752#comment-14935752 ] ASF GitHub Bot commented on STORM-820: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-820] Aggregate topo stats on nimbus, no...

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/554#issuecomment-144170034 Thanks for the update I am +1 on the change now. The aggregation code is a bit complex, but I cannot think of any way to make it less complex right now. --- If your pro

[GitHub] storm pull request: [STORM-1063] support relative log4j conf dir f...

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/760#issuecomment-144190457 +1 looks great, thanks for doing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[jira] [Commented] (STORM-1063) Workers cannot find log4j configuration files since default value of storm.log4j2.conf.dir is relative

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935846#comment-14935846 ] ASF GitHub Bot commented on STORM-1063: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: STORM-1012 STORM-967 STORM-922 STORM-1042 Shad...

2015-09-29 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/736#issuecomment-144190863 @revans2 That seems reasonable to me. Let me make sure that works for deploying to Nexus and get back to you. If it works then I'm fine with these changes. --- If your

[jira] [Commented] (STORM-1012) Shade Jackson dependency

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935847#comment-14935847 ] ASF GitHub Bot commented on STORM-1012: --- Github user ptgoetz commented on the pull r

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/746#issuecomment-144190888 Well first of all you need to upmerge at some point soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935848#comment-14935848 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40729530 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -308,15 +308,15 @@ (defn- all-supervisor-info ([storm-cluster-state] (all-super

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935853#comment-14935853 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40729915 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -167,6 +167,16 @@ public static final Object STORM_CLUSTER_MODE_SCHEMA = String.class;

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935856#comment-14935856 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40730129 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -1101,6 +1127,33 @@ public static final Object TOPOLOGY_TASKS_SCHEMA = ConfigValidation

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935863#comment-14935863 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: Disruptor batching v2

2015-09-29 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/storm/pull/765#discussion_r40730244 --- Diff: storm-core/src/clj/backtype/storm/cluster.clj --- @@ -489,10 +489,10 @@ (let [path (backpressure-path storm-id node port)

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40730329 --- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java --- @@ -187,7 +187,7 @@ public static void submitTopology(String name, Map stormConf, StormTopo

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935868#comment-14935868 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40730370 --- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java --- @@ -442,4 +444,36 @@ public static String submitJar(Map conf, String localJar, ProgressList

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935869#comment-14935869 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40730552 --- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java --- @@ -442,4 +444,36 @@ public static String submitJar(Map conf, String localJar, ProgressList

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40730558 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -167,6 +167,16 @@ public static final Object STORM_CLUSTER_MODE_SCHEMA = String.class;

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40730611 --- Diff: storm-core/src/jvm/backtype/storm/generated/AlreadyAliveException.java --- @@ -51,7 +51,7 @@ import org.slf4j.LoggerFactory; @Suppres

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935875#comment-14935875 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935874#comment-14935874 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935876#comment-14935876 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: Disruptor batching v2

2015-09-29 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/storm/pull/765#discussion_r40730661 --- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj --- @@ -123,12 +123,13 @@ port (:port worker) storm-cluster-stat

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40731147 --- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java --- @@ -187,7 +187,7 @@ public static void submitTopology(String name, Map stormConf, StormTo

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935883#comment-14935883 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935886#comment-14935886 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40731800 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/Topologies.java --- @@ -21,10 +21,17 @@ import java.util.HashMap; import java.util.Map;

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-29 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40731631 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -1101,6 +1127,33 @@ public static final Object TOPOLOGY_TASKS_SCHEMA = ConfigValidati

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935890#comment-14935890 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: Disruptor batching v2

2015-09-29 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/storm/pull/765#discussion_r40731960 --- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj --- @@ -137,14 +138,11 @@ check highWaterMark and lowWaterMark for backpressure" (di

  1   2   >