Re: Release note entry for 1.14.1 Fix for issue #4762 "authz doesn't combine global and repository rules"?

2021-01-29 Thread Stefan Sperling
On Fri, Jan 29, 2021 at 09:29:52PM +0100, Johan Corveleyn wrote: > I was wondering whether the change in authz behavior, by fixing #4762, > should be called out explicitly in the 1.14 release notes (maybe > somewhere in the "Known issues" section, describing the issue of > 1.14.0, and how it is fix

Re: preparing to release 1.14.1 and 1.10.7

2021-01-29 Thread Stefan Sperling
On Fri, Jan 22, 2021 at 02:36:56PM +0100, Stefan Sperling wrote: > I am volunteering to prepare release artifacts for new 1.14 and > 1.10 releases soon. Hopefully, these artifacts will be up for > testing and signing by the end of next week (January 29), to be > released within the fir

Re: preparing to release 1.14.1 and 1.10.7

2021-01-26 Thread Stefan Sperling
On Tue, Jan 26, 2021 at 11:57:50PM +0100, Johan Corveleyn wrote: > Yes, I agree we should stick to our established policy here. > > We recently loosened our backport-voting policy a bit for non-LTS > (Regular) releases, but we didn't for LTS releases (no time to dig up > the thread, but ISTR we di

Re: preparing to release 1.14.1 and 1.10.7

2021-01-26 Thread Stefan Sperling
On Tue, Jan 26, 2021 at 04:45:32PM -0500, Nathan Hartman wrote: > On Tue, Jan 26, 2021 at 4:28 PM Daniel Shahaf > wrote: > > > Stefan Sperling wrote on Fri, Jan 22, 2021 at 14:36:56 +0100: > > > [...] I will allow myself to merge any nominations which received at > >

Re: svn commit: r1885656 - /subversion/trunk/tools/hook-scripts/mailer/mailer.py

2021-01-22 Thread Stefan Sperling
On Fri, Jan 22, 2021 at 11:58:40PM +0900, Yasuhito FUTATSUKI wrote: > On 2021/01/22 21:05, Stefan Sperling wrote: > > On Fri, Jan 22, 2021 at 12:48:24PM +0100, Stefan Sperling wrote: > >> On Mon, Jan 18, 2021 at 04:30:27PM -, futat...@apache.org wrote: > >>> Au

preparing to release 1.14.1 and 1.10.7

2021-01-22 Thread Stefan Sperling
I am volunteering to prepare release artifacts for new 1.14 and 1.10 releases soon. Hopefully, these artifacts will be up for testing and signing by the end of next week (January 29), to be released within the first two weeks of February. Please go through STATUS files on the 1.14.x and 1.10.x bra

Re: svn commit: r1885600 - /subversion/trunk/tools/hook-scripts/mailer/mailer.py

2021-01-22 Thread Stefan Sperling
On Fri, Jan 22, 2021 at 12:50:29PM +0100, Stefan Sperling wrote: > On Sun, Jan 17, 2021 at 01:16:59PM -, futat...@apache.org wrote: > > Author: futatuki > > Date: Sun Jan 17 13:16:59 2021 > > New Revision: 1885600 > > > > URL: http://svn.apache.org/vi

Re: svn commit: r1885656 - /subversion/trunk/tools/hook-scripts/mailer/mailer.py

2021-01-22 Thread Stefan Sperling
On Fri, Jan 22, 2021 at 12:48:24PM +0100, Stefan Sperling wrote: > On Mon, Jan 18, 2021 at 04:30:27PM -, futat...@apache.org wrote: > > Author: futatuki > > Date: Mon Jan 18 16:30:27 2021 > > New Revision: 1885656 > > > > URL: http://svn.apache.org/vi

Re: svn commit: r1885600 - /subversion/trunk/tools/hook-scripts/mailer/mailer.py

2021-01-22 Thread Stefan Sperling
On Sun, Jan 17, 2021 at 01:16:59PM -, futat...@apache.org wrote: > Author: futatuki > Date: Sun Jan 17 13:16:59 2021 > New Revision: 1885600 > > URL: http://svn.apache.org/viewvc?rev=1885600&view=rev > Log: > Follow up to r1884427, r1885557: mailer.py: Fix mixture of bytes/str. This change se

Re: svn commit: r1885656 - /subversion/trunk/tools/hook-scripts/mailer/mailer.py

2021-01-22 Thread Stefan Sperling
On Mon, Jan 18, 2021 at 04:30:27PM -, futat...@apache.org wrote: > Author: futatuki > Date: Mon Jan 18 16:30:27 2021 > New Revision: 1885656 > > URL: http://svn.apache.org/viewvc?rev=1885656&view=rev > Log: > mailer.py: Restore Python 2 support. mailer.py's test suite starts failing with Pyth

Re: svn info tree conflicts bug using svn 1.10.6?

2021-01-20 Thread Stefan Sperling
On Wed, Jan 20, 2021 at 07:19:02PM +0900, Yasuhito FUTATSUKI wrote: > On 2021/01/20 14:24, Nathan Hartman wrote: > > [cc -= users] > > > > On Tue, Jan 19, 2021 at 10:50 PM Yasuhito FUTATSUKI > > wrote: > > > > > It looks like a simple copy-paste mistake when the new macros were > > introduced

Re: svn commit: r1884427 - in /subversion/trunk/tools/hook-scripts/mailer: mailer.py tests/mailer-t1.output tests/mailer-tweak.py

2021-01-14 Thread Stefan Sperling
On Fri, Jan 15, 2021 at 01:44:43AM +0900, Yasuhito FUTATSUKI wrote: > On 2020/12/29 0:49, Stefan Sperling wrote: > > On Tue, Dec 15, 2020 at 07:47:59PM +0900, Yasuhito FUTATSUKI wrote: > >> As far as I read the code again, it seems this is already support > >> loca

Re: mailer.py py2/py3 change: non-UTF-8 environments (was: svn commit: r1884427 - in /subversion/trunk/tools/hook-scripts/mailer: mailer.py tests/mailer-t1.output tests/mailer-tweak.py)

2020-12-28 Thread Stefan Sperling
On Mon, Dec 21, 2020 at 07:15:53AM +, Daniel Shahaf wrote: > s...@apache.org wrote on Mon, 14 Dec 2020 16:57 -: > > URL: http://svn.apache.org/viewvc?rev=1884427&view=rev > > Log: > > Make mailer.py work properly with Python 3, and drop Python 2 support. > > > > Most of the changes deal wi

Re: svn commit: r1884427 - in /subversion/trunk/tools/hook-scripts/mailer: mailer.py tests/mailer-t1.output tests/mailer-tweak.py

2020-12-28 Thread Stefan Sperling
On Tue, Dec 15, 2020 at 07:47:59PM +0900, Yasuhito FUTATSUKI wrote: > As far as I read the code again, it seems this is already support > locales other than C/C.UTF-8 if mailer.py is kicked with appropriate > LC_CTYPE environment. The REPOS-PATH argment comes from sys.argv[2] > already decoded in f

Re: svn commit: r1884427 - in /subversion/trunk/tools/hook-scripts/mailer: mailer.py tests/mailer-t1.output tests/mailer-tweak.py

2020-12-14 Thread Stefan Sperling
On Tue, Dec 15, 2020 at 03:51:03AM +0900, Yasuhito FUTATSUKI wrote: > First of all, thank you for doing this. I worried that mailer.py didn't > support Python 3 for a long time. > > In message <20201214165710.deb3517b...@svn01-us-east.apache.org>, > stsp@apache.o > rg writes: > >Author: stsp > >D

preparing for 1.14.1

2020-10-21 Thread Stefan Sperling
Since May we have accumulated quite a few fixes on the 1.14.x branch and there are still some outstanding backport proposals. I guess it is about time to focus on getting the remaining fixes merged and then begin a release process. Is anyone able to set aside some time for this? I would volunteer

Re: Fixing issue #4762 -- authz doesn't combine global and repository rules -- svn 1.10 regression [was: r1882186 ...]

2020-10-08 Thread Stefan Sperling
On Tue, Oct 06, 2020 at 06:26:06PM +0200, Stefan Sperling wrote: > I will see about whether this can be fixed in a follow-up patch. > Otherwise I will revert my commit and try to find a better approach. See https://svn.apache.org/r1882326 for a better fix, based on improved understanding

Re: svn commit: r1882318 - in /subversion/branches/1.14.x: STATUS subversion/tests/libsvn_repos/repos-test.c

2020-10-08 Thread Stefan Sperling
On Thu, Oct 08, 2020 at 03:24:33PM +0200, Johan Corveleyn wrote: > > Modified: > > subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c > > URL: > > http://svn.apache.org/viewvc/subversion/branches/1.14.x/subversion/tests/libsvn_repos/repos-test.c?rev=1882318&r1=1882317&r2=188231

Re: Fixing issue #4762 -- authz doesn't combine global and repository rules -- svn 1.10 regression [was: r1882186 ...]

2020-10-06 Thread Stefan Sperling
On Tue, Oct 06, 2020 at 03:24:01PM +0100, Julian Foad wrote: > A third group is pre-existing deployments in which the admins have now > adjusted their rules to match the 1.10+ behaviour. I can't guess which > group is biggest, which ones matter more or less than others, nor in what > proportion of

Re: Fixing issue #4762 -- authz doesn't combine global and repository rules -- svn 1.10 regression [was: r1882186 ...]

2020-10-06 Thread Stefan Sperling
On Tue, Oct 06, 2020 at 12:21:27PM +0100, Julian Foad wrote: > Doug Robinson: Would you please cast your eye over this, as an affected > party? Basically I'd ask if you want to offer your take on fixing this > authz semantics regression? > > I haven't been following this issue; I've just noticed

Re: svn commit: r1882186 - in /subversion/trunk/subversion: libsvn_repos/authz.c tests/cmdline/svnauthz_tests.py tests/libsvn_repos/authz-test.c tests/libsvn_repos/repos-test.c

2020-10-06 Thread Stefan Sperling
On Sat, Oct 03, 2020 at 06:07:49AM +, Daniel Shahaf wrote: > Sounds like this change merits an entry in the 1.14 release notes (if > it's backported) or in the 1.15 release notes if it's not backported. > Would you please add a placeholder (just a section header or a ToC > link) or file a corre

Re: [PATCH] svn_cmdline__edit_file_externally() may not be able to open the target file in locale other than UTF-8

2020-09-20 Thread Stefan Sperling
On Mon, Sep 21, 2020 at 01:18:54AM +0900, Yasuhito FUTATSUKI wrote: > On 2020/09/20 23:53, Yasuhito FUTATSUKI wrote: > > On 2020/09/20 23:41, Stefan Sperling wrote: > >> On Sun, Sep 20, 2020 at 11:06:21PM +0900, Yasuhito FUTATSUKI wrote: > >>> On 2020/09/19

Re: [PATCH] svn_cmdline__edit_file_externally() may not be able to open the target file in locale other than UTF-8

2020-09-20 Thread Stefan Sperling
On Sun, Sep 20, 2020 at 11:06:21PM +0900, Yasuhito FUTATSUKI wrote: > On 2020/09/19 5:26, Yasuhito FUTATSUKI wrote: > > Hi, > > > > While I tried to make an example that escape_path() does not work as > > expected in specific locale such as ja_JP.SJIS or CP932 (suggested by > > Jun), I found it se

Re: A strong WTF on compiling out plaintext password support by default?!

2020-08-07 Thread Stefan Sperling
On Thu, Aug 06, 2020 at 06:56:55PM -0700, Robby Zinchak wrote: > 2) Compiling my own subversion with the enable-plaintext-password-storage > flag -- obviously insecure since there's no way I'll be able to keep up > with software updates. And I've heard it's quite difficult to compile > subversion,

Re: [PATCH] Remove references to tigris.org from website

2020-07-15 Thread Stefan Sperling
On Wed, Jul 15, 2020 at 03:20:23PM +0900, Yasuhito FUTATSUKI wrote: > (An echo reply for the broadcast echo request...) > > On 2020/07/10 6:27, Daniel Sahlberg wrote: > > Regarding the link to cvs2svn I tried to find if it was rehosted somewhere > > else but couldn't find someone who actually had

Re: [announce-ow...@apache.org: Returned post for annou...@apache.org]

2020-05-28 Thread Stefan Sperling
On Thu, May 28, 2020 at 08:13:26AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Thu, 28 May 2020 09:53 +0200: > > On Thu, May 28, 2020 at 07:59:07AM +0200, Branko Čibej wrote: > > > On 28.05.2020 07:40, Daniel Shahaf wrote: > > > > Someone could start a di

Re: [announce-ow...@apache.org: Returned post for annou...@apache.org]

2020-05-28 Thread Stefan Sperling
On Thu, May 28, 2020 at 07:59:31AM +, Daniel Shahaf wrote: > Seems to cover everything. I took a stab at a slight reorganization; > WDYT? — Sure, your wording changes are fine with me. +1 to commit :) > Index: releasing.part.html >

Re: [announce-ow...@apache.org: Returned post for annou...@apache.org]

2020-05-28 Thread Stefan Sperling
On Thu, May 28, 2020 at 07:59:07AM +0200, Branko Čibej wrote: > On 28.05.2020 07:40, Daniel Shahaf wrote: > > Someone could start a discussion with the announce@a.o moderators. The > > escalation path, IIRC, is: announce-owner@, press@, VP M&P (= Sally), > > operations@, board@, members@. > > Did

Re: [announce-ow...@apache.org: Returned post for annou...@apache.org]

2020-05-27 Thread Stefan Sperling
On Thu, May 28, 2020 at 06:27:54AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Thu, 28 May 2020 08:07 +0200: > > +++ releasing.part.html (working copy) > > @@ -1300,6 +1300,20 @@ Ensure that your mailer doesn't wrap the URLs over > > NOTE: We announce t

Re: HACKING += release-lines.yaml? (was: svn commit: r1878162 - /subversion/trunk/tools/dist/release-lines.yaml)

2020-05-27 Thread Stefan Sperling
On Thu, May 28, 2020 at 03:03:40AM +, Daniel Shahaf wrote: > s...@apache.org wrote on Wed, 27 May 2020 14:34 -: > > Author: stsp > > Date: Wed May 27 14:34:18 2020 > > New Revision: 1878162 > > > > URL: http://svn.apache.org/viewvc?rev=1878162&view=rev > > Log: > > * tools/dist/release-lin

Re: [announce-ow...@apache.org: Returned post for annou...@apache.org]

2020-05-27 Thread Stefan Sperling
On Thu, May 28, 2020 at 07:59:48AM +0200, Stefan Sperling wrote: > Receiving such a message at the end of a long release preparation day is > indeed rather discouraging. Since this is recurring behaviour and can > potentially have toxic results in affected project communities, I think &g

Re: [announce-ow...@apache.org: Returned post for annou...@apache.org]

2020-05-27 Thread Stefan Sperling
On Wed, May 27, 2020 at 09:41:18PM +0100, Julian Foad wrote: > Branko Čibej wrote: > > > > On 27.05.2020 19:30, Stefan Sperling wrote: > > > > > Out of the blue, I have received nitpicking of changes I made to the > > > > > website and the announc

Re: [announce-ow...@apache.org: Returned post for annou...@apache.org]

2020-05-27 Thread Stefan Sperling
On Wed, May 27, 2020 at 07:48:41PM +0200, Branko Čibej wrote: > On 27.05.2020 19:30, Stefan Sperling wrote: > > Out of the blue, I have received nitpicking of changes I made to the > > website and the announce message I sent. I've received this feedback > > via t

[announce-ow...@apache.org: Returned post for annou...@apache.org]

2020-05-27 Thread Stefan Sperling
or 1.40.0 have different links for the KEYS files. Please fix the page and submit a corrected email. Thanks. <<<<< ---- <<<<< Date: Wed, 27 May 2020 17:56:06 +0200 From: Stefan Sperling To: annou...@subversion.apache.org, us...@subversion.apache.o

[ANNOUNCE] Apache Subversion 1.14.0 released

2020-05-27 Thread Stefan Sperling
https://www.apache.org/dist/subversion/subversion-1.14.0.tar.bz2.asc https://www.apache.org/dist/subversion/subversion-1.14.0.tar.gz.asc https://www.apache.org/dist/subversion/subversion-1.14.0.zip.asc For this release, the following people have provided PGP signatures: Stefan Sperling [

Re: Finalizing the 1.14.0 release notes

2020-05-27 Thread Stefan Sperling
On Wed, May 27, 2020 at 10:35:02AM -0400, Nathan Hartman wrote: > To finalize the release notes for 1.14.0, I think there are just these > three changes to make: > > (1) Document the test failures that occur on Windows with links to the > revisions (and/or patches) that fix them. Say that "the

Re: Subversion 1.14.0 up for testing/signing

2020-05-26 Thread Stefan Sperling
On Wed, May 20, 2020 at 02:34:41PM +0200, Stefan Sperling wrote: > The 1.14.0 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > > Thanks! The curren

Subversion 1.14.0 up for testing/signing

2020-05-20 Thread Stefan Sperling
The 1.14.0 release artifacts are now available for testing/signing. Please get the tarballs from https://dist.apache.org/repos/dist/dev/subversion and add your signatures there. Thanks! This release is essentially identical to 1.14.0-rc2 except for the designation of the version. The full diff

Re: Change build/find_python.sh and roll 1.14.0-rc3? (was: Re: py2.7 used by default when py2 and py3 are both available)

2020-05-16 Thread Stefan Sperling
On Fri, May 15, 2020 at 09:13:38PM +, Daniel Shahaf wrote: > IIRC the soak was to end on Wednesday and any change requires at least > a week's extension. > > Here's the patch. I smoke tested it and it passed, but I'm seeing tests > randomly fail even in unpatched trunk so I can't an unqualifi

schedule for 1.14.0 release

2020-04-22 Thread Stefan Sperling
The current prospected release date for 1.14 is May 6, which is no longer viable. The official soak period (which starts today) does not allow for a release this soon. We will also need to allocate at least another week to collect new signatures for the final release artifacts once they have become

[ANNOUNCE] Apache Subversion 1.14.0-rc2 released

2020-04-21 Thread Stefan Sperling
/dist/subversion/subversion-1.14.0-rc2.tar.gz.asc https://www.apache.org/dist/subversion/subversion-1.14.0-rc2.zip.asc For this release, the following people have provided PGP signatures: Stefan Sperling [2048R/4F7DBAA99A59B973] with fingerprint: 8BC4 DAE0 C5A4 D65F 4044 0107 4F7D BAA9

Re: Release Notes: TODO regarding Py3 support

2020-04-16 Thread Stefan Sperling
On Thu, Apr 16, 2020 at 10:54:34AM -0400, Nathan Hartman wrote: > The 1.14 Release Notes have only one remaining TODO item: > > [[[ > > TODO: Describe which minor releases of Python 3.x we plan to > support through the four-year LTS period of Subversion 1.14. Per > recent discussions on the dev@

Re: Subversion 1.14.0-rc2 up for testing/signing

2020-04-14 Thread Stefan Sperling
On Tue, Apr 14, 2020 at 08:50:03AM +0200, Branko Čibej wrote: > On 08.04.2020 12:18, Stefan Sperling wrote: > > Everyone, thanks for all the contributions you have made for -rc2! > > > > The 1.14.0-rc2 release artifacts are now available for testing/signing. > > P

Re: [PATCH] (Re?)allow the creation of release tarballs that support py2 bindings

2020-04-13 Thread Stefan Sperling
On Thu, Apr 09, 2020 at 06:09:30PM +, Michael Pilato wrote: > For your consideration, a patch to allow the creation of release tarballs > that support py2 bindings (instead of py3 ones). > > -- Mike I don't see why not. Without doubt we will see people trying to compile Subversion 1.14 on so

Re: ctypes-python and Python3 (Re: Subversion 1.14.0-rc2 up for testing/signing)

2020-04-13 Thread Stefan Sperling
On Sun, Apr 12, 2020 at 09:10:12PM -0400, James McCoy wrote: > On Sat, Apr 11, 2020 at 10:28:16AM +0100, Julian Foad wrote: > > Stefan Sperling wrote: > > > The 1.14.0-rc2 release artifacts are now available for testing/signing. > > > > +1 for release (Unix). &

Subversion 1.14.0-rc2 up for testing/signing

2020-04-08 Thread Stefan Sperling
Everyone, thanks for all the contributions you have made for -rc2! The 1.14.0-rc2 release artifacts are now available for testing/signing. Please get the tarballs from https://dist.apache.org/repos/dist/dev/subversion and add your signatures there. If everything goes well we can rebrand this re

Re: [PATCH] Fix undefined behavior when constructing ID for txn_node_cache in fsfs

2020-04-02 Thread Stefan Sperling
On Thu, Apr 02, 2020 at 06:29:06PM +0300, Denis Kovalchuk wrote: > Hello. > > I think I have found an undefined behavior in the code that constructs ID for > per-transaction DAG node cache. > > In make_txn_root() function, the txn variable of type svn_fs_fs__id_part_t * > is passed to apr_pstrcat

Re: SVN 1.14 release: please fix your buildbot

2020-04-02 Thread Stefan Sperling
On Mon, Mar 16, 2020 at 09:27:28AM +0100, Stefan Sperling wrote: > Hi Bert and Brane, > > Your windows-ra and macosx-apr1.3-nothread buildbots are currently failing. > > If possible please fix them, or retire them if they are no longer needed. > > For release management it

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/

2020-04-02 Thread Stefan Sperling
On Thu, Apr 02, 2020 at 01:08:05AM +, Daniel Shahaf wrote: > Daniel Shahaf wrote on Thu, 02 Apr 2020 00:05 +00:00: > > Stefan Sperling wrote on Wed, 01 Apr 2020 11:58 +00:00: > > > If it makes you feel any better, I'd be happy to stop voluteering for the > > >

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/

2020-04-02 Thread Stefan Sperling
On Thu, Apr 02, 2020 at 12:05:27AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Wed, 01 Apr 2020 11:58 +00:00: > > FWIW, "You are expected to fix it" could also be interpreted as hostile. > > It's a direct order from you directed at me, telling me what I s

Re: [PATCH] svnadmin build-repcache command

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 10:50:12PM +0300, Denis Kovalchuk wrote: > > > This seems to fix it. > > > > > > I don't understand why this is necessary but the regular code path for > > > access to node revision data in fsfs also seems to apply this always. > > > > > > Can an fsfs expert confirm? > > > >

Re: [PATCH] svnadmin build-repcache command

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 06:40:27PM +0200, Stefan Sperling wrote: > This seems to fix it. > > I don't understand why this is necessary but the regular code path for > access to node revision data in fsfs also seems to apply this always. > > Can an fsfs expert confirm

Re: [PATCH] svnadmin build-repcache command

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 06:25:12PM +0200, Stefan Sperling wrote: > On Wed, Apr 01, 2020 at 11:45:04AM -0400, Nathan Hartman wrote: > > On Wed, Apr 1, 2020 at 8:05 AM Daniel Shahaf > > wrote: > > > The failure is 100% reproducible with «./svnadmin_tests.py > > > -

Re: [PATCH] svnadmin build-repcache command

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 11:45:04AM -0400, Nathan Hartman wrote: > On Wed, Apr 1, 2020 at 8:05 AM Daniel Shahaf wrote: > > The failure is 100% reproducible with «./svnadmin_tests.py > > --fs-type=fsfs --fsfs-version=6 74» on Linux. > > I'm experimenting with this also. So far I have nothing defini

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 11:43:05AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Wed, 01 Apr 2020 11:51 +0200: > > On Wed, Apr 01, 2020 at 09:34:39AM +, Daniel Shahaf wrote: > > > Stefan Sperling wrote on Wed, 01 Apr 2020 10:31 +0200: > > > > On Wed, Ap

Re: [PATCH] svnadmin build-repcache command

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 10:26:40AM +, Daniel Shahaf wrote: > If you haven't already, re-run that builder using subversion-bot to > check if the bug is reproducible. Can you please do this yourself when you find time for it? You provide a lot of good ideas, while at the same time asking others

Re: [PATCH] svnadmin build-repcache command

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 09:59:41AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Wed, 01 Apr 2020 11:13 +0200: > > https://ci.apache.org/builders/svn-x64-macosx-fsfs-v6/builds/2941/steps/Test%20ra_local%2Bfsfs-v6/logs/faillog > > > > The svnadmin build-repcache test

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 09:34:39AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Wed, 01 Apr 2020 10:31 +0200: > > On Wed, Apr 01, 2020 at 01:43:28AM +, Daniel Shahaf wrote: > > > Daniel Shahaf wrote on Tue, 31 Mar 2020 09:23 +00:00: > > &g

Re: [PATCH] svnadmin build-repcache command

2020-04-01 Thread Stefan Sperling
On Tue, Mar 31, 2020 at 12:48:21PM +0200, Stefan Sperling wrote: > On Tue, Mar 31, 2020 at 01:35:54PM +0300, Denis Kovalchuk wrote: > > > This has caused a test failure on the windows buildbot: > > > > > > https://ci.apache.org/builders/svn-windows-local/builds/3392/

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/

2020-04-01 Thread Stefan Sperling
On Wed, Apr 01, 2020 at 01:43:28AM +, Daniel Shahaf wrote: > Daniel Shahaf wrote on Tue, 31 Mar 2020 09:23 +00:00: > > Please add a docstring. > > I've gone ahead and added this to STATUS so it doesn't slip through any > cracks. Feel free to remove the -0 vote once it's been addressed (you >

Re: [PATCH] svnadmin build-repcache command

2020-03-31 Thread Stefan Sperling
On Tue, Mar 31, 2020 at 01:35:54PM +0300, Denis Kovalchuk wrote: > > This has caused a test failure on the windows buildbot: > > > > https://ci.apache.org/builders/svn-windows-local/builds/3392/steps/Test%20fsfs%2Blocal/logs/faillog > > > > Can you please check what we should do about that? > > I

Re: [PATCH] svnadmin build-repcache command

2020-03-31 Thread Stefan Sperling
On Tue, Mar 31, 2020 at 10:55:07AM +0200, Stefan Sperling wrote: > On Tue, Mar 24, 2020 at 07:53:21PM +0300, Denis Kovalchuk wrote: > > Introduce 'svnadmin build-repcache' command. > > Committed in r1875921. Thanks! This has caused a test failure on the windows buildbo

Re: [PATCH] svnadmin build-repcache command

2020-03-31 Thread Stefan Sperling
On Tue, Mar 24, 2020 at 07:53:21PM +0300, Denis Kovalchuk wrote: > Introduce 'svnadmin build-repcache' command. Committed in r1875921. Thanks! I will now nominate both patches for backport to 1.14.x.

Re: [PATCH] rep-cache.db insert optimization (was: Re: [PATCH] svnadmin build-repcache command)

2020-03-31 Thread Stefan Sperling
On Mon, Mar 30, 2020 at 11:40:38PM +0300, Denis Kovalchuk wrote: > rep-cache.db insert optimization. Committed in r1875918. Thank you!

Re: [PATCH] svnadmin build-repcache command

2020-03-28 Thread Stefan Sperling
On Fri, Mar 27, 2020 at 10:58:48PM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Fri, 27 Mar 2020 14:41 +0100: > > On Thu, Mar 26, 2020 at 08:32:38PM +, Daniel Shahaf wrote: > > > What I'm worried about is that we'll apply the "backwards compatib

Re: Late night unix-build weirdness

2020-03-27 Thread Stefan Sperling
On Fri, Mar 27, 2020 at 01:41:31PM -0400, Nathan Hartman wrote: > On Fri, Mar 27, 2020 at 1:21 PM Stefan Sperling wrote: > > > On Fri, Mar 27, 2020 at 11:28:26AM -0400, Nathan Hartman wrote: > > > I made the following change and then was able to run the serf x fsfs > >

Re: Late night unix-build weirdness

2020-03-27 Thread Stefan Sperling
On Fri, Mar 27, 2020 at 11:28:26AM -0400, Nathan Hartman wrote: > I wanted to run a full build and test all ra and backends overnight > using my slightly modified variant of tools/dev/unix-build (mostly > just different/newer versions of dependencies). > > It built everything and ran through local

Re: [PATCH] svnadmin build-repcache command

2020-03-27 Thread Stefan Sperling
On Thu, Mar 26, 2020 at 08:32:38PM +, Daniel Shahaf wrote: > What I'm worried about is that we'll apply the "backwards compatibility > until 2.0" promise to something we shouldn't. As I said, issues of > this nature can't generally be found by tests; they can only be found > by code review. I

Re: SWIG_PY_OPTS question (Re: svn commit: r1875742 - /subversion/trunk/build/generator/gen_make.py)

2020-03-27 Thread Stefan Sperling
On Fri, Mar 27, 2020 at 11:55:16AM +0900, Yasuhito FUTATSUKI wrote: > On 2020/03/27 8:55, Stefan Sperling wrote: > > Can anyone tell whether we need to pass additional options to > > swig via SWIG_PY_OPTS at this stage? Do we need -py3 for example? > > If we use 3.0.10 <=

SWIG_PY_OPTS question (Re: svn commit: r1875742 - /subversion/trunk/build/generator/gen_make.py)

2020-03-26 Thread Stefan Sperling
Can anyone tell whether we need to pass additional options to swig via SWIG_PY_OPTS at this stage? Do we need -py3 for example? On Thu, Mar 26, 2020 at 11:24:54PM -, s...@apache.org wrote: > Author: stsp > Date: Thu Mar 26 23:24:54 2020 > New Revision: 1875742 > > URL: http://svn.apache.org/v

Re: Subversion 1.14.0-rc1 up for testing/signing

2020-03-26 Thread Stefan Sperling
On Thu, Mar 26, 2020 at 06:45:46PM +0100, Stefan Sperling wrote: > On Thu, Mar 26, 2020 at 04:30:26PM +0100, Stefan Sperling wrote: > > On Thu, Mar 26, 2020 at 02:23:05PM +, Michael Pilato wrote: > > > Maybe it's just been too long for me, but I thought our rele

Re: Subversion 1.14.0-rc1 up for testing/signing

2020-03-26 Thread Stefan Sperling
On Thu, Mar 26, 2020 at 04:30:26PM +0100, Stefan Sperling wrote: > On Thu, Mar 26, 2020 at 02:23:05PM +, Michael Pilato wrote: > > Maybe it's just been too long for me, but I thought our releases and release > > candidates were supposed to have the SWIG-generated st

Re: Subversion 1.14.0-rc1 up for testing/signing

2020-03-26 Thread Stefan Sperling
On Thu, Mar 26, 2020 at 02:23:05PM +, Michael Pilato wrote: > Maybe it's just been too long for me, but I thought our releases and release > candidates were supposed to have the SWIG-generated stuff included? I see > those files in, say, subversion-1.13.1.tar.bz2, but not in this new rc1 drop.

Re: [PATCH] svnadmin build-repcache command

2020-03-26 Thread Stefan Sperling
On Wed, Mar 25, 2020 at 09:56:23PM +, Daniel Shahaf wrote: > Nathan Hartman wrote on Wed, 25 Mar 2020 17:30 -0400: > > FYI, I tested 1.14.0-rc1 today, but I'm not rushing to sign (yet) > > because I'm waiting to see if we'll get Denis's patch (or a later > > version of it) into 1.14. I don't s

Re: [PATCH] svnadmin build-repcache command

2020-03-25 Thread Stefan Sperling
On Tue, Mar 24, 2020 at 07:53:21PM +0300, Denis Kovalchuk wrote: > + /** @since New in 1.14. */ > + SVN_ERRDEF(SVN_ERR_FS_REP_SHARING_NOT_ALLOWED, > + SVN_ERR_FS_CATEGORY_START + 69, > + "Rep-sharing is not allowed.") > + > + /** @since New in 1.14. */ > + SVN_ERRDEF(SVN

Subversion 1.14.0-rc1 up for testing/signing

2020-03-25 Thread Stefan Sperling
The 1.14.0-rc1 release artifacts are now available for testing/signing. Please get the tarballs from https://dist.apache.org/repos/dist/dev/subversion and add your signatures there. If everything goes well we can rebrand this release candidate as the actual 1.14.0 release with minimal effort. T

SVN 1.14 release: please fix your buildbot

2020-03-16 Thread Stefan Sperling
Hi Bert and Brane, Your windows-ra and macosx-apr1.3-nothread buildbots are currently failing. If possible please fix them, or retire them if they are no longer needed. For release management it would help us to have a set of only green buildbots to start with, so we can easily identify any new

Re: branching 1.14.x

2020-03-16 Thread Stefan Sperling
On Mon, Mar 16, 2020 at 12:26:18AM -0400, James McCoy wrote: > On Sat, Mar 14, 2020 at 10:32:04AM -0400, James McCoy wrote: > > I'm working on it now. I should be able to have something that avoids > > regressions on Windows this weekend. > > Done in r1875230. Thanks James. Looks good to me. Ba

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 02:16:51PM +, Julian Foad wrote: > Mark Phippard wrote: > > Anyway, I am just trying to suggest things to help us get unstuck. > > Agreed. Stefan, other readers may read it differently, but I found Mark's > input here to be useful and on-topic, as well as bluntly direc

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 03:47:44PM +, Daniel Shahaf wrote: > What is it that I'm supposed to share my assessment of? My involvement > in shelving consisted of little more than conducting two commit > reviews. Whether you're OK with that code you've reviewed to be shipped as it is. It sounds l

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 10:32:04AM -0400, James McCoy wrote: > I'm working on it now. I should be able to have something that avoids > regressions on Windows this weekend. > > Cheers, > -- > James > GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB Great news. Thank you James!

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 10:12:41AM -0400, Mark Phippard wrote: > I do not fully understand where we are at on shelving. I believe ideas were > proposed to make it a compile time feature that would be off by default or > something. I am fine with that. You raised it as being a blocker still so I > a

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 09:25:21AM -0400, Mark Phippard wrote: > > On Mar 14, 2020, at 8:51 AM, Stefan Sperling wrote: > > On Sat, Mar 14, 2020 at 08:03:28AM -0400, Mark Phippard wrote: > > I don't think asking "why are we even doing this" is helpful. >

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 08:03:28AM -0400, Mark Phippard wrote: > Personally, I do not care at all about experimental features and shelving. I > would favor ripping it all out and let it come back in a future release if > someone wants to finish and turn it into a feature that we are willing to > s

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Tue, Mar 10, 2020 at 12:23:49PM +0100, Stefan Sperling wrote: > As previously discussed, I would like to create the 1.14.x branch > soon in order to begin the release process for 1.14.0. > > There are two changes being worked on which look important and > which, I believe

Re: A little pre-packaging help, please?

2020-03-10 Thread Stefan Sperling
On Tue, Mar 10, 2020 at 01:51:26PM +, Michael Pilato wrote: > Hey, all! > > I've been watching the Python 3.x support shaping up over the course of the > past couple of release cycles, and would like to begin converting ViewVC to > Python3 now that doing so won't immediately have the effect

Re: future of our "experimental" features

2020-03-10 Thread Stefan Sperling
On Fri, Feb 28, 2020 at 10:30:12PM +, Julian Foad wrote: > Nathan Hartman wrote: > > Julian Foad wrote: > > > I did already make the experimental features hidden by default in "svn > > > help"; and revealed with "-v" option. > > > > > > We don't necessarily need more than that. > > > > > > If

branching 1.14.x

2020-03-10 Thread Stefan Sperling
As previously discussed, I would like to create the 1.14.x branch soon in order to begin the release process for 1.14.0. There are two changes being worked on which look important and which, I believe, could only be introduced in a dot zero release since they violate our patch release compatibilit

Re: Release Management, Subversion 1.14

2020-02-20 Thread Stefan Sperling
On Thu, Feb 20, 2020 at 09:29:00AM -0500, Nathan Hartman wrote: > On Fri, Feb 14, 2020 at 7:26 AM Stefan Sperling wrote: > > > - Release notes and CHANGES need to be updated. > > There are relatively few changes since we only have to document what > > changed since S

Re: svn commit: r1874227 - /subversion/site/publish/docs/release-notes/1.14.html

2020-02-20 Thread Stefan Sperling
Thank you Nathan! All these 1.14 release notes changes of yours are very nice :) On Wed, Feb 19, 2020 at 09:51:08PM -, hartmannat...@apache.org wrote: > Author: hartmannathan > Date: Wed Feb 19 21:51:08 2020 > New Revision: 1874227 > > URL: http://svn.apache.org/viewvc?rev=1874227&view=rev >

Re: Segmentation fault (core dumped) for svn mkdir

2020-02-19 Thread Stefan Sperling
On Wed, Feb 19, 2020 at 12:48:14PM +, Geraldine McCormack wrote: > Hi svn dev - > > I am seeing a Segmentation fault (core dumped) for svn mkdir in Version > 1.8.5. > > I cannot see that this is a know issue fixed in later versions - is > anyone aware ? The crash is not triggered by Subv

Re: Release Management, Subversion 1.14

2020-02-14 Thread Stefan Sperling
On Fri, Feb 14, 2020 at 02:22:10PM +, Daniel Shahaf wrote: > One addition: Shall we announce that 1.10.x will be end-of-life 24 > months after 1.14.0-GA? 1.10.0 was released on 2018-10-30. The current release schedule offers 4 years of support for 1.10 so it becomes obsolete after 2022-10-30.

Re: Release Management, Subversion 1.14

2020-02-14 Thread Stefan Sperling
On Fri, Feb 14, 2020 at 07:36:43AM -0500, Nathan Hartman wrote: > On Fri, Feb 14, 2020 at 7:26 AM Stefan Sperling wrote: > > > - Release notes and CHANGES need to be updated. > > There are relatively few changes since we only have to document what > > changed since S

Re: Release Management, Subversion 1.14

2020-02-14 Thread Stefan Sperling
On Fri, Jan 24, 2020 at 12:22:19PM +0100, Stefan Sperling wrote: > On Fri, Jan 24, 2020 at 10:47:49AM +, Julian Foad wrote: > > Please can someone volunteer to be the release manager for Subversion 1.14? > > > > I won't be able to do that myself, although I w

Re: future of our "experimental" features

2020-02-12 Thread Stefan Sperling
On Fri, Jan 31, 2020 at 03:08:35PM +, Julian Foad wrote: > In terms of whether it is visible by default to an users, I agree. In terms > of where the source code lives, I don't mind -- I would be equally happy if > it were on trunk and disabled by a compile time or run time feature flag. > >

Re: RFE: "svn mv --keep-local" (and perhaps "svn cp --keep-local")

2020-02-12 Thread Stefan Sperling
On Wed, Feb 12, 2020 at 05:21:55AM -0500, Nathan Hartman wrote: > On Wed, Feb 12, 2020 at 1:32 AM Nogin, Aleksey wrote: > > > Currently, “svn rm” supports “--keep-local” (as in – record the change in > > the db, but do not change the working copy files), but neither svn mv, nor > > svn cp do. > >

Re: ra_serf redirect URL canonicalization fix

2020-02-01 Thread Stefan Sperling
On Sat, Feb 01, 2020 at 02:23:49PM +0100, Stefan Sperling wrote: > Here is a patch I am running tests on now. With this, the RA layer returns > the redirect URL in both non-canonicalized and canonicalized forms. I'll note also that apparently we don't have tests for pro

Re: ra_serf redirect URL canonicalization fix

2020-02-01 Thread Stefan Sperling
On Sat, Feb 01, 2020 at 12:31:16PM +0100, Branko Čibej wrote: > On 01.02.2020 12:17, Stefan Sperling wrote: > > On Fri, Jan 31, 2020 at 04:12:20AM +, Daniel Shahaf wrote: > >> So in balance, how about — > >> > >> - ra_serf should not canonicalize re

Re: ra_serf redirect URL canonicalization fix

2020-02-01 Thread Stefan Sperling
On Fri, Jan 31, 2020 at 04:12:20AM +, Daniel Shahaf wrote: > So in balance, how about — > > - ra_serf should not canonicalize redirection URLs before accessing them. > > - After following all redirections (that is, once we get a 2xx response > or a 5xx response), canonicalize the resultant

Re: ra_serf redirect URL canonicalization fix

2020-01-30 Thread Stefan Sperling
On Thu, Jan 30, 2020 at 07:43:00PM +, Julian Foad wrote: > > Meh... What a mess. > > One part of the clean up: we should make very clear where a URL variable > holds a 'canonical' URL (in this conversation, that means according to svn's > own cannonicalisation rules) and where it does not. As

<    1   2   3   4   5   6   7   8   9   10   >