Re: svn: E000005: Can't check path '/net/.svn': Input/output error

2013-11-07 Thread Blair Zajac
On 11/06/2013 08:05 PM, Ben Reser wrote: On 11/6/13 6:21 PM, Blair Zajac wrote: I'm wondering if its a regression with older versions of Subversion as it walks up the tree to find a .svn directory. Well the error is coming from io_check_path() in subversion/libsvn_subr/io.c. Specifical

Re: svn: E000005: Can't check path '/net/.svn': Input/output error

2013-11-06 Thread Blair Zajac
On 11/06/2013 05:54 PM, Ben Reser wrote: On 11/6/13 5:15 PM, Blair Zajac wrote: Using a MacPorts build of svn 1.8.4 on a 10.7.5 MacBook Air: $ uname -a Darwin foo.example.com 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64 i386

svn: E000005: Can't check path '/net/.svn': Input/output error

2013-11-06 Thread Blair Zajac
Using a MacPorts build of svn 1.8.4 on a 10.7.5 MacBook Air: $ uname -a Darwin foo.example.com 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64 i386 MacBookAir4,2 Darwin $ cd /net/yum/blair $ mkdir tmp $ svn checkout -N http://svn.ap

Re: svn commit: r1519275 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

2013-09-01 Thread Blair Zajac
On 09/01/2013 09:20 AM, Branko Čibej wrote: On 01.09.2013 16:40, danie...@apache.org wrote: Author: danielsh Date: Sun Sep 1 14:40:55 2013 New Revision: 1519275 URL: http://svn.apache.org/r1519275 Log: Fix a compiler warning. No functional change. * subversion/libsvn_subr/cache-membuffer.c

Re: otool -L and svn --version --verbose inconsistency

2013-08-16 Thread Blair Zajac
On 08/16/2013 02:19 PM, Ben Reser wrote: On Fri Aug 16 13:08:59 2013, Blair Zajac wrote: MacPorts uses nothing from the OS if it can avoid it. Here's the Check to see if the apr-util you're using isn't linked against the system sqlite. Could also be some other dependency

Re: otool -L and svn --version --verbose inconsistency

2013-08-16 Thread Blair Zajac
On 08/16/2013 12:43 PM, Ben Reser wrote: On Fri Aug 16 12:39:10 2013, Ben Reser wrote: dyld is loading both for some reason. Even with the amalgamation I'm seeing: $ svn-trunk --version --verbose | grep -i sqlite - SQLite 3.7.12 (static) - /usr/lib/libsqlite3.dylib (Intel 64-bit) But

otool -L and svn --version --verbose inconsistency

2013-08-16 Thread Blair Zajac
On my MacPorts svn 1.8.1 build on PPC otool -L reports only MacPorts' sqlite: $ otool -L /opt/local/bin/svn | grep sqlite /opt/local/lib/libsqlite3.0.dylib (compatibility version 9.0.0, current version 9.6.0) However, svn --version --verbose also reports the system's sqlite: $ /opt/local/bi

Re: Semantics of Move

2013-08-16 Thread Blair Zajac
On 08/16/2013 04:14 AM, Julian Foad wrote: Branko Čibej wrote: On 16.08.2013 04:48, Blair Zajac wrote: On 08/15/2013 08:01 AM, Julian Foad wrote: I propose the following logical semantics of the versioned move operation that is the basis of move tracking, independent of any

Re: Semantics of Move

2013-08-15 Thread Blair Zajac
On 08/15/2013 08:01 AM, Julian Foad wrote: I propose the following logical semantics of the versioned move operation that is the basis of move tracking, independent of any implementation. A versioned move of the node with node id “N”, with respect to two revisions rX and rY (X < Y), shall mean:

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-06-23 Thread Blair Zajac
On 06/23/2013 07:47 PM, Greg Stein wrote: On Sun, Jun 23, 2013 at 3:56 PM, Blair Zajac wrote: On 6/22/13 1:22 AM, Lieven Govaerts wrote: Even better if we could cache this info somewhere automatically. So that the first time svn connects to a server ever it will use this 'slow' proc

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-06-23 Thread Blair Zajac
On 6/22/13 1:22 AM, Lieven Govaerts wrote: Even better if we could cache this info somewhere automatically. So that the first time svn connects to a server ever it will use this 'slow' procedure, and then persists the results http/1.0 vs http/1.1 and chunked-encoding supported somewhere. Like we

Re: svn commit: r1495204 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2013-06-20 Thread Blair Zajac
On 06/20/2013 02:40 PM, stef...@apache.org wrote: Author: stefan2 Date: Thu Jun 20 21:40:50 2013 New Revision: 1495204 URL: http://svn.apache.org/r1495204 Log: Follow-up to r1495063: integer overflows result in an inefficient hash function and reduce cache effectiveness. * subversion/libsvn_fs_

Re: [JavaHL] Reported incompatibility

2013-06-12 Thread Blair Zajac
On 06/12/2013 07:07 AM, Branko Čibej wrote: On 12.06.2013 14:42, Vladimir Berezniker wrote: Hi All, I came across a bug in one of the Atlassian tools that suggests that there was an API compatibility break in the JavaHL between versions 1.6 and 1.7. I am not sure when/if I get time to look mor

Re: AW: C++ thoughts for Berlin

2013-06-03 Thread Blair Zajac
On 06/02/2013 10:53 PM, Markus Schaber wrote: Hi, Blair, Von: Blair Zajac [mailto:bl...@orcaware.com] [Discussion whether to use (part of) C++ for SVN development] I agree it's not worth going to C++. Where I'm coming from is a frustration on the number of times I've seen poo

Re: C++ thoughts for Berlin

2013-06-01 Thread Blair Zajac
On 5/29/13 6:17 PM, Justin Erenkrantz wrote: On Wed, May 29, 2013 at 6:03 PM, Blair Zajac mailto:bl...@orcaware.com>> wrote: Yup, I've had lots of issues with this. Putting C++ pool wrappers in C++ classes and having them destroy in the correct order can be tricky to ge

Re: C++ thoughts for Berlin

2013-05-29 Thread Blair Zajac
On 05/29/2013 05:48 PM, Justin Erenkrantz wrote: On Wed, May 29, 2013 at 12:05 PM, Blair Zajac mailto:bl...@orcaware.com>> wrote: I'm generally in favor of a move to C++, it would be nice to get features that we work around now in C. Rewriting even some of our core librari

C++ thoughts for Berlin

2013-05-29 Thread Blair Zajac
Given I won't be at the Berlin hackathon, here's my thought on the C++ topic [1]. I'm generally in favor of a move to C++, it would be nice to get features that we work around now in C. Questions/issues: 1) How old g++ do we maintain? We have RHEL 6 boxes that have 4.4.6, so we wouldn't be

Re: svn commit: r1485499 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2013-05-22 Thread Blair Zajac
On 05/22/2013 04:22 PM, stef...@apache.org wrote: Author: stefan2 Date: Wed May 22 23:22:22 2013 New Revision: 1485499 URL: http://svn.apache.org/r1485499 Log: Reduce ra_svn protocol parsing overhead. * subversion/libsvn_ra_svn/marshal.c (vparse_tuple): test for the most frequent item types

Nominating your r1481848 and r1481870

2013-05-13 Thread Blair Zajac
Hi Brane, Just saw the veto on my compiler warning commits for 1.8.x. I nominated your two commits on top of my commits (to avoid merge conflicts), which should resolve the veto, but I left it in the vetoed section to be safe. Pinging you here so you can take a look. Blair

Re: svn commit: r1469520 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2013-05-13 Thread Blair Zajac
On 4/19/13 8:04 AM, Philip Martin wrote: Daniel Shahaf writes: What would a better fix be? It's hard to say which is probably why these warnings have not been addressed so far. The warning is a 'maybe': ../src/subversion/libsvn_fs_fs/tree.c:929:27: warning: 'directory' may be used uniniti

Re: svn commit: r1469520 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2013-05-13 Thread Blair Zajac
On 4/18/13 11:53 AM, Philip Martin wrote: bl...@apache.org writes: Author: blair Date: Thu Apr 18 18:41:55 2013 New Revision: 1469520 URL: http://svn.apache.org/r1469520 Log: open_path(): silence compiler warning. subversion/libsvn_fs_fs/tree.c: In function 'open_path': subversion/libsvn_fs_f

Re: Issue 4359 fix not merged to 1.8.x

2013-04-24 Thread Blair Zajac
have been moved > below the "Approved" header and given three +1 votes if it had a revnum > typo. (But it should be easy to inject an 'svn log -qvr | wc -l > 4' type > check, if people prefer that.) > > Philip Martin wrote on Wed, Apr 24, 2013 at 09:02:14

Issue 4359 fix not merged to 1.8.x (was svn commit: r1471243 - in /subversion/branches/1.8.x: ./ STATUS)

2013-04-23 Thread Blair Zajac
It looks like the wrong revision number was given in STATUS, as it's a tomcat commit: http://svn.apache.org/viewvc?view=revision&revision=r1471029 Blair --- Begin Message --- Author: svn-role Date: Wed Apr 24 04:01:30 2013 New Revision: 1471243 URL: http://svn.apache.org/r1471243 Log: Merge r1

Caching svn_fs_t and friends

2013-04-03 Thread Blair Zajac
Hi guys, Saw my name mentioned in IRC regarding caching svn_*_t. In our custom svn RPC server that exposes svn_repos_t and svn_fs_t, we cache svn_repos_t, svn_fs_root_t (for both revisions and txns). I pulled some stats from our live server, here is the svn_repos_t cache: Max=238 N=238 InUse

Re: 1.8 new public API review (mostly) complete.

2013-04-01 Thread Blair Zajac
On 4/1/13 10:25 AM, C. Michael Pilato wrote: On 03/31/2013 12:31 AM, Blair Zajac wrote: Question on svn_repos_load_fs4() and svn_repos_get_fs_build_parser4() (maybe other functions have a similar text): * @note If @a start_rev and @a end_rev are valid revisions, this * function presumes

Re: 1.8 new public API review (mostly) complete.

2013-03-30 Thread Blair Zajac
On 03/29/2013 01:17 PM, C. Michael Pilato wrote: Devs, I've just completed my review of the new-in-1.8 public APIs, minus the bits that Philip reviewed (thanks!) and the new merge-related stuff which, if I understand from recent threads correctly, is still subject to some churn. The results of

Re: svn commit: r1442071 - in /subversion/trunk/subversion/libsvn_fs_fs: dag.c temp_serializer.c

2013-02-04 Thread Blair Zajac
On 02/04/2013 02:38 AM, stef...@apache.org wrote: Author: stefan2 Date: Mon Feb 4 10:38:45 2013 New Revision: 1442071 URL: http://svn.apache.org/viewvc?rev=1442071&view=rev Log: Speed up serialization of DAG and noderev structures for our caches. Turns out that 503 bytes is often not sufficient

Re: packages tree

2013-01-29 Thread Blair Zajac
On 01/29/2013 10:04 AM, Ben Reser wrote: Should we remove the packages tree? The packages are almost certainly terribly out of date. There's been 1 functional commit (not including things like URL and license changes from the ASF changeover) since 2009. To give an example the RedHat rpm packag

Re: svn commit: r1431072 - in /subversion/trunk/subversion: include/svn_types.h libsvn_client/copy.c libsvn_ra_serf/commit.c libsvn_subr/named_atomic.c libsvn_subr/stream.c mod_dav_svn/reports/replay.

2013-01-09 Thread Blair Zajac
On 01/09/2013 01:02 PM, julianf...@apache.org wrote: Author: julianfoad Date: Wed Jan 9 21:02:33 2013 New Revision: 1431072 URL: http://svn.apache.org/viewvc?rev=1431072&view=rev Log: Consistify a few remaining redundant or odd expressions involving boolean constants, such as "foo == FALSE" to

Re: svn commit: r1405539 - /subversion/trunk/subversion/bindings/javahl/native/

2012-11-04 Thread Blair Zajac
On 11/04/2012 04:48 AM, stef...@apache.org wrote: Author: stefan2 Date: Sun Nov 4 12:47:59 2012 New Revision: 1405539 URL: http://svn.apache.org/viewvc?rev=1405539&view=rev Log: Make all explicit casts, i.e. those not inside some APR macro, use the C++ cast operators static_cast, const_cast and

Re: svn commit: r1405517 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.cpp CreateJ.cpp SVNClient.cpp StringArray.cpp Targets.cpp

2012-11-04 Thread Blair Zajac
On Nov 4, 2012, at 2:14 AM, stef...@apache.org wrote: > Author: stefan2 > Date: Sun Nov 4 10:14:56 2012 > New Revision: 1405517 > > URL: http://svn.apache.org/viewvc?rev=1405517&view=rev > Log: > Silence integer size conversion warnings in JavaHL under Win64 by casting > the values explicitly.

Re: svn commit: r1403982 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-10-30 Thread Blair Zajac
On 10/30/12 9:59 PM, bre...@apache.org wrote: Author: breser Date: Wed Oct 31 04:59:42 2012 New Revision: 1403982 URL: http://svn.apache.org/viewvc?rev=1403982&view=rev Log: Fix a compile warning and a memory leak in rep_write_cleanup. * subversion/libsvn_fs_fs/fs_fs.c (rep_write_cleanup): t

Re: svn commit: r1391641 - /subversion/trunk/subversion/libsvn_subr/cache-memcache.c

2012-09-29 Thread Blair Zajac
On 09/28/2012 01:34 PM, cmpil...@apache.org wrote: Author: cmpilato Date: Fri Sep 28 20:34:50 2012 New Revision: 1391641 URL: http://svn.apache.org/viewvc?rev=1391641&view=rev Log: * subversion/libsvn_subr/cache-memcache.c (add_memcache_server): Convert time-to-live value from seconds to

Re: svn commit: r1388816 - in /subversion/branches/10Gb/subversion: include/private/svn_pseudo_md5.h libsvn_subr/cache-membuffer.c libsvn_subr/pseudo_md5.c tests/libsvn_subr/checksum-test.c

2012-09-22 Thread Blair Zajac
On 09/22/2012 08:14 AM, stef...@apache.org wrote: Author: stefan2 Date: Sat Sep 22 15:14:25 2012 New Revision: 1388816 URL: http://svn.apache.org/viewvc?rev=1388816&view=rev Log: On the 10Gb branch: Introduce MD5-based hash functions optimized for short input lengths. Use these to speed up mem

Re: svn commit: r1383214 - in /subversion/trunk: build.conf tools/fsfs/ tools/fsfs/reorg.c

2012-09-10 Thread Blair Zajac
On 9/10/12 6:42 PM, stef...@apache.org wrote: Author: stefan2 Date: Tue Sep 11 01:42:01 2012 New Revision: 1383214 URL: http://svn.apache.org/viewvc?rev=1383214&view=rev Log: Add a very early prototype of an FSFS pack optimization tool. * tools/fsfs (new folder) Suggest one of two things w

Re: svn commit: r1375675 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/fs-wrap.c libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h tests/cmdline/commit_tests.py test

2012-08-21 Thread Blair Zajac
On 08/21/2012 11:56 AM, C. Michael Pilato wrote: On 08/21/2012 02:45 PM, Philip Martin wrote: Blair Zajac writes: On 08/21/2012 11:09 AM, C. Michael Pilato wrote: I actually considered using "post-create-txn" and renaming "start-commit" to "pre-create-txn" (

Re: svn commit: r1375675 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/fs-wrap.c libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h tests/cmdline/commit_tests.py test

2012-08-21 Thread Blair Zajac
On 08/21/2012 11:45 AM, Philip Martin wrote: Blair Zajac writes: On 08/21/2012 11:09 AM, C. Michael Pilato wrote: I actually considered using "post-create-txn" and renaming "start-commit" to "pre-create-txn" (with code to run "start-commit" iff not

Re: svn commit: r1375675 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/fs-wrap.c libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h tests/cmdline/commit_tests.py test

2012-08-21 Thread Blair Zajac
On 08/21/2012 11:09 AM, C. Michael Pilato wrote: On 08/21/2012 01:54 PM, Blair Zajac wrote: On 08/21/2012 10:29 AM, cmpil...@apache.org wrote: Author: cmpilato Date: Tue Aug 21 17:29:40 2012 New Revision: 1375675 URL: http://svn.apache.org/viewvc?rev=1375675&view=rev Log: Introduce a

Re: svn commit: r1375675 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/fs-wrap.c libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h tests/cmdline/commit_tests.py test

2012-08-21 Thread Blair Zajac
On 08/21/2012 10:29 AM, cmpil...@apache.org wrote: Author: cmpilato Date: Tue Aug 21 17:29:40 2012 New Revision: 1375675 URL: http://svn.apache.org/viewvc?rev=1375675&view=rev Log: Introduce a new 'init-commit' hook script which runs immediately after the commit txn is created and populated with

Re: Please move mod_dontdothat back from tools/server-side/mod_dontdothat to subversion/mod_dontdothat

2012-08-19 Thread Blair Zajac
On 08/19/2012 11:02 AM, Branko Čibej wrote: On 18.08.2012 16:53, Nico Kadel-Garcia wrote: mod_dontdothat is not a core module. It's effectively a debugging tool. Whereas mod_dav_svn and mod_authz_svn are part of the core Subversion functionality. The different locations aren't accidental. The ma

Re: svn commit: r1372665 - /subversion/branches/master-passphrase/subversion/libsvn_auth_kwallet/kwallet.cpp

2012-08-13 Thread Blair Zajac
On 08/13/2012 04:24 PM, phi...@apache.org wrote: Author: philip Date: Mon Aug 13 23:24:06 2012 New Revision: 1372665 URL: http://svn.apache.org/viewvc?rev=1372665&view=rev Log: Fix C++ compile errors. * subversion/libsvn_auth_kwallet/kwallet.cpp (): Include svn_base64.h. (kwallet_master_p

Re: svn commit: r1366209 - in /subversion/trunk/subversion: libsvn_wc/externals.c tests/libsvn_client/client-test.c

2012-07-26 Thread Blair Zajac
On 07/26/2012 03:04 PM, rhuij...@apache.org wrote: Author: rhuijben Date: Thu Jul 26 22:04:03 2012 New Revision: 1366209 URL: http://svn.apache.org/viewvc?rev=1366209&view=rev Log: * subversion/libsvn_wc/externals.c (svn_wc__resolve_relative_external_url): Deny /../ syntax in urls in ext

Re: svnmerge.py (Was: Re: mergeinfo ignorance)

2012-07-23 Thread Blair Zajac
On 07/23/2012 08:55 AM, Jim Jagielski wrote: Is this still useful: svnmerge.py ? http://www.orcaware.com/svn/wiki/Svnmerge.py It still gets occasional usage and people occasionally ask questions about it (such as today) but I recommend people switch to svn's builtin merge tracking if

Re: svn commit: r1362480 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

2012-07-17 Thread Blair Zajac
On 7/17/12 6:17 AM, phi...@apache.org wrote: Author: philip Date: Tue Jul 17 13:17:34 2012 New Revision: 1362480 URL: http://svn.apache.org/viewvc?rev=1362480&view=rev Log: * subversion/libsvn_fs/fs-loader.c (load_module): Only allow alphanumeric characters in name. apr_status_t sta

Re: svn commit: r1358322 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2012-07-06 Thread Blair Zajac
On 7/6/12 11:04 AM, stef...@apache.org wrote: Author: stefan2 Date: Fri Jul 6 18:04:09 2012 New Revision: 1358322 URL: http://svn.apache.org/viewvc?rev=1358322&view=rev Log: Relax overly strict consistency check that is not covered by the FSFS format specification. * subversion/libsvn_fs_fs/tr

Re: Revprop packing implemented

2012-07-06 Thread Blair Zajac
On 7/6/12 6:27 AM, C. Michael Pilato wrote: On 07/06/2012 04:32 AM, Stefan Fuhrmann wrote: Hi devs, This week I had one of my "how hard can it be?" moments and finally implemented revprop packing (did that mainly offline). It passes all tests and seems to work pretty well. Cool! [...] Sinc

Re: svn commit: r1352400 - in /subversion/branches/javahl-ra/subversion/bindings/javahl: native/SVNBase.cpp native/SVNBase.h src/org/apache/subversion/javahl/JNIObject.java

2012-06-21 Thread Blair Zajac
On 06/20/2012 08:34 PM, v...@apache.org wrote: Author: vmpn Date: Thu Jun 21 03:34:05 2012 New Revision: 1352400 URL: http://svn.apache.org/viewvc?rev=1352400&view=rev Log: On the javahl-ra branch: JavaHL: New method for creating java objects linked to their C++ counterpart [ in subversion/bin

How high are the revision numbers in your repo?

2012-06-13 Thread Blair Zajac
Hi Hyrum, Just got home and saw your question on IRC. Here are the statistics on our svn repositories: N is 105 sum is 51557790 meanis 491026.571428571 SD Nis 1609852.27973539 SD N-1 is 1617573.43808371 min is 1 25% is 5 50% is 3028 75% is 35981 90% is 714

Re: svn commit: r1349314 - /subversion/trunk/configure.ac

2012-06-12 Thread Blair Zajac
On 06/12/2012 06:15 AM, hwri...@apache.org wrote: Author: hwright Date: Tue Jun 12 13:15:07 2012 New Revision: 1349314 URL: http://svn.apache.org/viewvc?rev=1349314&view=rev Log: Add a hack which prevents a trivial compiler warning for me when building with clang. * configure.ac: Filter out

Re: Serf 1.1.0 has been released

2012-06-07 Thread Blair Zajac
On 06/07/2012 01:40 PM, Greg Stein wrote: Hello all, I'm pleased to announce the serf 1.1.0 release! MacPorts has been updated. port -v sync && port -v upgrade --enforce-variants outdated Blair

Re: svn commit: r1340253 - /subversion/trunk/COMMITTERS

2012-05-29 Thread Blair Zajac
On 05/21/2012 04:18 AM, Vladimir Berezniker wrote: Hyrum, 4. Use runtime rather than checked exceptions. I strongly dislike checked exceptions in code paths where there is no expected recovery logic that can be applied. This just forces people to either write a lot of try catch blocks that

Re: subversion pull request: port to new style classes - http://stackoverflow.c...

2012-05-25 Thread Blair Zajac
On 05/24/2012 01:32 AM, Greg Stein wrote: Hey all, I moderated this through, in order to start a discussion. My feeling is: this is not how we want to accept patches. This approach is completely disconnected from our community. How do we talk to the person providing the change? How do we ask fo

Re: Trunk checkout fails with serf but not neon

2012-05-16 Thread Blair Zajac
On 05/16/2012 11:15 AM, Justin Erenkrantz wrote: On Wed, May 16, 2012 at 11:10 AM, Mark Phippard wrote: I found another tool that worked ( I think I just needed to run wireshark as root), however this tool and tcpdump both do not give what I want. I am going through a VPN and it looks like all

Deleting svn-fast-backup

2012-04-29 Thread Blair Zajac
[cc'ing previous svn-fast-backup authors or patchers.] Reviewing my svn training deck I noticed I still recommend using svn- fast-backup, but I don't think I trust it any more, given it hasn't been updated with recent fsfs repository changes. There's been no substantial commits since it wa

Re: svn commit: r1329083 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/editor.c

2012-04-23 Thread Blair Zajac
On Apr 23, 2012, at 1:01 PM, Greg Stein wrote: On Apr 23, 2012 8:00 AM, "Blair Zajac" wrote: > > > On Apr 23, 2012, at 2:45 AM, gst...@apache.org wrote: > >> Author: gstein >> Date: Mon Apr 23 06:45:46 2012 >> New Revision: 1329083 >> >> UR

Re: svn commit: r1329083 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/editor.c

2012-04-23 Thread Blair Zajac
On Apr 23, 2012, at 2:45 AM, gst...@apache.org wrote: Author: gstein Date: Mon Apr 23 06:45:46 2012 New Revision: 1329083 URL: http://svn.apache.org/viewvc?rev=1329083&view=rev Log: Add a flag that we'll need. mod_dav_svn wants to keep the txn alive, and will manually commit it. libsvn_repos n

Re: svn commit: r1328939 - /subversion/trunk/subversion/libsvn_subr/io.c

2012-04-22 Thread Blair Zajac
On 4/22/12 11:52 PM, Blair Zajac wrote: On Apr 22, 2012, at 3:14 PM, stef...@apache.org wrote: Author: stefan2 Date: Sun Apr 22 19:14:50 2012 New Revision: 1328939 URL: http://svn.apache.org/viewvc?rev=1328939&view=rev Log: * subversion/libsvn_subr/io.c (svn_io_lock_open_

Re: svn commit: r1328939 - /subversion/trunk/subversion/libsvn_subr/io.c

2012-04-22 Thread Blair Zajac
On Apr 22, 2012, at 3:14 PM, stef...@apache.org wrote: Author: stefan2 Date: Sun Apr 22 19:14:50 2012 New Revision: 1328939 URL: http://svn.apache.org/viewvc?rev=1328939&view=rev Log: * subversion/libsvn_subr/io.c (svn_io_lock_open_file, svn_io_unlock_open_file): fix handling of APR errors

Re: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-20 Thread Blair Zajac
On Apr 20, 2012, at 5:22 PM, Hyrum K Wright wrote: On Fri, Apr 20, 2012 at 6:19 PM, Blair Zajac wrote: I just got this on my MacPorts svn, the revision number output is missing: $ svnversion svn: E200030: sqlite: callback requested query abort svn: E200030: sqlite: callback requested

sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-20 Thread Blair Zajac
I just got this on my MacPorts svn, the revision number output is missing: $ svnversion svn: E200030: sqlite: callback requested query abort svn: E200030: sqlite: callback requested query abort $ echo $? 1 I've seen a number of other reports of this issue, including freebsd: https://www.google.

Re: svn commit: r1327703 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_fs_base/util/fs_skels.c libsvn_subr/checksum.c

2012-04-18 Thread Blair Zajac
On 04/18/2012 03:45 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 18:42, Blair Zajac wrote: On 04/18/2012 03:35 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 18:11,wrote: Author: blair Date: Wed Apr 18 22:11:43 2012 New Revision: 1327703 URL: http://svn.apache.org/viewvc?rev=1327703

Re: svn commit: r1327703 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_fs_base/util/fs_skels.c libsvn_subr/checksum.c

2012-04-18 Thread Blair Zajac
On 04/18/2012 03:35 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 18:11, wrote: Author: blair Date: Wed Apr 18 22:11:43 2012 New Revision: 1327703 URL: http://svn.apache.org/viewvc?rev=1327703&view=rev Log: Add and use svn_checksum__from_digest_sha1(). This replaces svn_checksum__from_digest(

Re: svn commit: r1327695 - /subversion/trunk/subversion/libsvn_subr/checksum.c

2012-04-18 Thread Blair Zajac
On 04/18/2012 02:57 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 17:52, wrote: Author: blair Date: Wed Apr 18 21:52:01 2012 New Revision: 1327695 URL: http://svn.apache.org/viewvc?rev=1327695&view=rev Log: Refactor svn_checksum_create() to avoid two switch statements. * subversion/libsvn_sub

Re: svn commit: r1327695 - /subversion/trunk/subversion/libsvn_subr/checksum.c

2012-04-18 Thread Blair Zajac
On 04/18/2012 02:54 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 17:52, wrote: ... +++ subversion/trunk/subversion/libsvn_subr/checksum.c Wed Apr 18 21:52:01 2012 @@ -56,25 +56,43 @@ validate_kind(svn_checksum_kind_t kind) return svn_error_create(SVN_ERR_BAD_CHECKSUM_KIND, NULL, NULL);

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Blair Zajac
On 04/18/2012 12:15 AM, Julian Foad wrote: Blair Zajac wrote: In case of an illegal svn_checksum_kind_t being passed to svn_checksum__from_digest(), I want to change it from svn_checksum_t * svn_checksum__from_digest(const unsigned char *digest, svn_checksum_kind_t

Changing svn_checksum__from_digest()'s signature

2012-04-17 Thread Blair Zajac
In case of an illegal svn_checksum_kind_t being passed to svn_checksum__from_digest(), I want to change it from svn_checksum_t * svn_checksum__from_digest(const unsigned char *digest, svn_checksum_kind_t kind, apr_pool_t *result_pool); to svn

Re: fs_fs core dumps in checksum code

2012-04-17 Thread Blair Zajac
On 04/16/2012 02:16 AM, Julian Foad wrote: Blair Zajac wrote: On 04/13/2012 12:45 AM, Julian Foad wrote: Blair Zajac wrote: Having the empty files, such as changes, is that odd? Could that be a hint? No, that's not interesting, that's just the result of crashing out at

Re: svn commit: r1326354 - in /subversion/trunk/subversion: include/private/svn_named_atomic.h libsvn_fs_fs/fs_fs.c libsvn_subr/svn_named_atomic.c

2012-04-15 Thread Blair Zajac
On 04/15/2012 07:49 AM, stef...@apache.org wrote: Author: stefan2 Date: Sun Apr 15 14:49:21 2012 New Revision: 1326354 URL: http://svn.apache.org/viewvc?rev=1326354&view=rev Log: Disable the revprop cache if our sync. mechanisms are too expensive. * subversion/include/private/svn_named_atomic.h

Re: svn commit: r1326307 - in /subversion/trunk: ./ build/ac-macros/ subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/libsvn_subr/ subversion/mod_dav_svn/ subversion

2012-04-15 Thread Blair Zajac
On 04/15/2012 04:20 AM, stef...@apache.org wrote: Author: stefan2 Date: Sun Apr 15 11:20:58 2012 New Revision: 1326307 URL: http://svn.apache.org/viewvc?rev=1326307&view=rev Log: Merge all changes (-r1298521-1326293) from branches/revprop-cache to trunk and resolve minor conflicts. +/* Test w

Re: Use "1.7.7" for next release

2012-04-15 Thread Blair Zajac
On 04/15/2012 07:05 AM, Ashod Nakashian wrote: - Original Message - From: Daniel Shahaf To: Ashod Nakashian; Stefan Küng; "dev@subversion.apache.org" Cc: Sent: Sunday, April 15, 2012 2:06 PM Subject: Re: Use "1.7.7" for next release On Sun, Apr 15, 2012, at 02:36, Ashod Nakashian wro

Re: svn commit: r1298587 - in /subversion/branches/revprop-cache: build.conf subversion/include/private/svn_named_atomic.h subversion/include/svn_error_codes.h subversion/libsvn_subr/svn_named_atomic.

2012-04-15 Thread Blair Zajac
On 03/08/2012 01:18 PM, stef...@apache.org wrote: Author: stefan2 Date: Thu Mar 8 21:18:45 2012 New Revision: 1298587 URL: http://svn.apache.org/viewvc?rev=1298587&view=rev Log: Define and implement svn_named_atomic__t and associated API. * subversion/include/private/svn_named_atomic.h new

Re: Use "1.7.7" for next release (was: Re: 1.7.5 in one/two weeks?)

2012-04-14 Thread Blair Zajac
On 4/14/12 12:24 PM, Konstantin Kolinko wrote: 2012/4/12 Daniel Shahaf: We released 1.6.18 today and 1.7.4 just over a month ago. There are a few useful items merged already, and STATUS has a truckload of pending changes. Shall we roll 1.7.5 in two weeks from today? If we can clear STATUS and

svn_checksum__from_digest() core dump on invalid input

2012-04-14 Thread Blair Zajac
In tracking down spurious coredumps we have in our custom RPC server, I found one in svn_checksum__from_digest() due to bad input: svn_checksum_t * svn_checksum__from_digest(const unsigned char *digest, svn_checksum_kind_t kind, apr_pool_t *res

Re: fs_fs core dumps in checksum code

2012-04-13 Thread Blair Zajac
On 04/13/2012 06:33 PM, Daniel Shahaf wrote: Blair Zajac wrote on Fri, Apr 13, 2012 at 13:08:12 -0700: To do valgrind well, do I need to recompile APR with specific flags to enable pool debugging? Other than --enable-pool-debugging=N (aka -DAPR_POOL_DEBUG=N) (where N is placeholder for a

Re: fs_fs core dumps in checksum code

2012-04-13 Thread Blair Zajac
On 04/13/2012 12:45 AM, Julian Foad wrote: Blair Zajac wrote: Since we discussed this, we moved the Subversion server to a new box and from RAID to FusionIO storage and we're still getting the core dumps with the same stack trace, so I don't think its memory corruption. I meant

Re: fs_fs core dumps in checksum code

2012-04-12 Thread Blair Zajac
On 08/04/2010 09:32 AM, Blair Zajac wrote: On 08/04/2010 05:38 AM, Julian Foad wrote: Again due to in-lining, I presume, fs_fs.c:2859 calls svn_checksum_dup() but the debugger shows, in this case, only its subroutine svn_checksum__from_digest(). #0 0x2ac15f8bd28c in

Re: 1.6.18 tarballs up for testing/signing

2012-03-29 Thread Blair Zajac
On 03/29/2012 11:44 AM, Blair Zajac wrote: On 03/29/2012 06:10 AM, Stefan Sperling wrote: On Fri, Mar 23, 2012 at 03:54:13PM +0100, Stefan Sperling wrote: Subversion-1.6.18 tarballs are now available for testing/signing by committers. To obtain them please check out a working copy from https

Re: 1.6.18 tarballs up for testing/signing

2012-03-29 Thread Blair Zajac
On 03/29/2012 06:10 AM, Stefan Sperling wrote: On Fri, Mar 23, 2012 at 03:54:13PM +0100, Stefan Sperling wrote: Subversion-1.6.18 tarballs are now available for testing/signing by committers. To obtain them please check out a working copy from https://dist.apache.org/repos/dist/dev/subversion

Re: 1.6.18 tarballs up for testing/signing

2012-03-24 Thread Blair Zajac
On 03/24/2012 01:40 PM, Daniel Shahaf wrote: Blair Zajac wrote on Sat, Mar 24, 2012 at 13:17:17 -0700: BTW, any chance of getting the new svnadmin verify work into 1.6.x? I was thinking it may be worth cutting .19 just to get that in as people may want to easily know if they have an issue with

Re: 1.6.18 tarballs up for testing/signing

2012-03-24 Thread Blair Zajac
On 03/24/2012 03:13 AM, Stefan Sperling wrote: On Fri, Mar 23, 2012 at 03:54:13PM +0100, Stefan Sperling wrote: Since this is a 1.6.x release there are -dep tarballs which should also be signed by those who test them. I've run a test build with these dependencies on a Debian Linux system. I ma

Re: serf 1.0.3 released

2012-03-20 Thread Blair Zajac
On 03/20/2012 01:00 PM, Greg Stein wrote: Hi all, I've just released serf version 1.0.3. This contains a small fix from Bert to map more OpenSSL error codes into serf's UNKNOWNCA code. This allows Subversion's certificate verification prompt to provide the "(p) permanent" acceptance option. Ple

Re: [RFC] bump min serf version, or degrade? (was: svn commit: r1302682 ...)

2012-03-20 Thread Blair Zajac
On 03/19/2012 05:18 PM, Hyrum K Wright wrote: On Mon, Mar 19, 2012 at 5:11 PM, Greg Stein wrote: Hey all, With the change below, we can send all requests using Content-Length rather than chunking. This is the core work for fixing issue 3979. My question: should we simply bump the minimum serf

Re: svn commit: r1296604 - in /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.h fs_fs.c

2012-03-06 Thread Blair Zajac
On 03/05/2012 01:57 PM, Stefan Fuhrmann wrote: On 05.03.2012 15:20, Daniel Shahaf wrote: Philip Martin wrote on Mon, Mar 05, 2012 at 13:58:18 +: Daniel Shahaf writes: Philip Martin wrote on Mon, Mar 05, 2012 at 12:23:40 +: Daniel Shahaf writes: You're right, I misread the code: I m

Re: svn commit: r1294455 - /subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh

2012-02-28 Thread Blair Zajac
On 02/28/2012 05:46 AM, Mark Phippard wrote: On Tue, Feb 28, 2012 at 8:36 AM, Hyrum K Wright wrote: I'm not sure I understand what you mean here. People will be using Java 7 to attempt to build the JavaHL bindings, so I think it makes sense to use them on our tests. In fact, this entire thi

Re: svn commit: r1294455 - /subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh

2012-02-27 Thread Blair Zajac
On 2/27/12 8:34 PM, Blair Zajac wrote: On 2/27/12 8:32 PM, hwri...@apache.org wrote: Author: hwright Date: Tue Feb 28 04:32:21 2012 New Revision: 1294455 URL: http://svn.apache.org/viewvc?rev=1294455&view=rev Log: * tools/buildbot/slaves/ubuntu-x64/svnbuild.sh: Update configure args to ref

Re: svn commit: r1294455 - /subversion/trunk/tools/buildbot/slaves/ubuntu-x64/svnbuild.sh

2012-02-27 Thread Blair Zajac
On 2/27/12 8:32 PM, hwri...@apache.org wrote: Author: hwright Date: Tue Feb 28 04:32:21 2012 New Revision: 1294455 URL: http://svn.apache.org/viewvc?rev=1294455&view=rev Log: * tools/buildbot/slaves/ubuntu-x64/svnbuild.sh: Update configure args to reflect new java version. Modified: sub

Re: APR hash order

2012-02-21 Thread Blair Zajac
On 2/21/12 5:00 AM, Daniel Shahaf wrote: Philip Martin wrote on Tue, Feb 21, 2012 at 12:32:43 +: The dumpfile order is more interesting. Although we don't specify the dumpfile order until now it has been repeatable, at least when using the same executable/libraries. I can see that this rep

Time for 1.6.18?

2012-02-06 Thread Blair Zajac
With a fsfs corruption bug found and fixed this week [1], should we cut a 1.6.18? 1.6.17 was tagged 8 months ago. If we don't cut a new release, then we should probably let downstream distributions know about the issue so they can patch their builds. Blair [1] http://svn.apache.org/viewvc?v

Re: svn commit: r1240755 - /subversion/branches/1.7.x/STATUS

2012-02-05 Thread Blair Zajac
On 02/05/2012 08:08 AM, Daniel Shahaf wrote: stef...@apache.org wrote on Sun, Feb 05, 2012 at 16:03:51 -: Author: stefan2 Date: Sun Feb 5 16:03:51 2012 New Revision: 1240755 URL: http://svn.apache.org/viewvc?rev=1240755&view=rev Log: * STATUS: Add r1240752 and vote for it. Modified:

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-02 Thread Blair Zajac
On 02/02/2012 05:07 PM, Stefan Sperling wrote: On Thu, Feb 02, 2012 at 03:41:48PM -0800, Blair Zajac wrote: It doesn't look like it's multithreaded safe to set, but should it be? I am not sure. Note that this isn't changing the environment of the currently running process. It

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-02 Thread Blair Zajac
On 02/02/2012 04:03 PM, Daniel Shahaf wrote: Blair Zajac wrote on Thu, Feb 02, 2012 at 15:41:48 -0800: On 02/02/2012 03:29 PM, s...@apache.org wrote: +/** Set the environment that @ repos's hooks will inherit. + * If this function is not called, hooks will run in an empty enviro

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

2012-02-02 Thread Blair Zajac
On 02/02/2012 03:29 PM, s...@apache.org wrote: Author: stsp Date: Thu Feb 2 23:29:11 2012 New Revision: 1239926 URL: http://svn.apache.org/viewvc?rev=1239926&view=rev Log: Add a public libsvn_repos API to set the environment of hook scripts. Modified: subversion/trunk/subversion/include/s

New warnings from Xcode 4.2's clang

2011-10-15 Thread Blair Zajac
I upgraded my Xcode to 4.2 following the iOS 5 release and then compiled svn 1.7.0 for MacPorts, which updated this weekend. The new clang compiler generates many more, higher level warnings then I've seen before, which is pretty cool. Definitely worth upgrading your Xcode and switching to cla

Re: svn commit: r1176416 - /subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp

2011-09-27 Thread Blair Zajac
On Sep 27, 2011, at 7:56 AM, hwri...@apache.org wrote: > Author: hwright > Date: Tue Sep 27 14:56:56 2011 > New Revision: 1176416 > > > Modified: subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/nat

Re: svn commit: r1157172 - in /subversion/trunk/subversion: libsvn_client/revert.c tests/cmdline/copy_tests.py

2011-08-12 Thread Blair Zajac
On Aug 12, 2011, at 9:05 AM, s...@apache.org wrote: > Author: stsp > Date: Fri Aug 12 16:05:15 2011 > New Revision: 1157172 > > URL: http://svn.apache.org/viewvc?rev=1157172&view=rev > Log: > Make 'svn revert' error out if only one side of a move is reverted. I actually find this useful sometim

Re: Problems compiling 1.7.0 on redhat el4 64bit

2011-08-11 Thread Blair Zajac
On Aug 11, 2011, at 8:32 AM, wrote: > No luck with that option, still crashing. Try running the process under valgrind to see if it finds anything. Blair

Re: [VOTE]: Default http-client for 1.7 Serf or Neon

2011-08-04 Thread Blair Zajac
On Aug 4, 2011, at 7:52 PM, C. Michael Pilato wrote: > On 08/04/2011 09:47 PM, Blair Zajac wrote: >> On the veto issue, it's odd that Greg is veto a revert of a commit change >> that originally occurred on trunk and is now sitting on the branch. It >> does seem odd one

Re: [VOTE]: Default http-client for 1.7 Serf or Neon

2011-08-04 Thread Blair Zajac
On Aug 4, 2011, at 1:50 PM, C. Michael Pilato wrote: > On 08/04/2011 03:36 PM, Greg Stein wrote: >> On Thu, Aug 4, 2011 at 15:20, Mark Phippard wrote: >>> ... >>> vote for their preference. I am not saying that the simple majority >>> decision of this vote should become the default. >> >> Not

Re: svn commit: r1150368 - in /subversion/trunk/subversion/libsvn_client: commit.c commit_util.c

2011-07-24 Thread Blair Zajac
On Jul 24, 2011, at 6:50 AM, rhuij...@apache.org wrote: > Author: rhuijben > Date: Sun Jul 24 13:50:44 2011 > New Revision: 1150368 > > URL: http://svn.apache.org/viewvc?rev=1150368&view=rev > Log: > Clear iterpools in two error conditions during commit to avoid deleting files > with open handle

Re: serf 1.0.0 released

2011-07-16 Thread Blair Zajac
On Jul 15, 2011, at 3:16 PM, Greg Stein wrote: On Fri, Jul 15, 2011 at 18:06, Blair Zajac wrote: On Jul 15, 2011, at 3:03 PM, Greg Stein wrote: Hi all, I'm pleased to finally announce the 1.0.0 release of serf! The serf 1.0.x series is intended to support Apache Subversion 1.6.x an

  1   2   3   >