Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Sam Firke
I can confirm both that: - my reports broke with 2.1.0rc2, and - they are now working, including attaching screenshots, using the docker image with Tai's fixes: apache/superset:pr-23388-dev I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting. But I think Tai's PR provides a suitable fix

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Tai Dupree
Personally, I believe that the out of the box support for alerts/reports is mostly provided for convenience so users can test the feature out and was never meant to be part of the official release distros (hence why driver support was only added to the dev image). However, I can already see the

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Sam Firke
I can confirm both that: - my reports broke with 2.1.0rc2, and - they are now working, including attaching screenshots, using the docker image with Tai's fixes: apache/superset:pr-23388-dev I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting. But I think Tai's PR provides a suitable

Re: 3.0 change proposals for consensus (Wave 1)

2023-03-17 Thread Tai Dupree
Hi, Regarding (3), can we have some deprecation period where we return a 308 from the singular to plural names? That should make the transition less disruptive given that it's hard to find all api use cases during an upgrade. On Fri, Mar 17, 2023 at 10:37 AM John Bodley wrote: > Hi Evan, > >

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Tai Dupree
Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev. On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj wrote: > Hi, > Are you also able to get screenshots in the mail? > As per your suggestion I tried your fix from recently

Re: 3.0 change proposals for consensus (Wave 1)

2023-03-17 Thread John Bodley
Hi Evan, Thanks for sharing. Regarding (5) is it possible to delay this? We (Airbnb) are currently working on a revised migration workflow from legacy filters (filter-box charts, filter scopes, et al.) to native filters (see SIP-64 for details). It seems potentially prudent to have this logic

RE: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Soni, Pankaj
Hi, Are you also able to get screenshots in the mail? As per your suggestion I tried your fix from recently pushed image: "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39" This incorporates the fix for webdriver. I am able to get reports but still screenshot gives same error

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Ville Brofeldt
Hi, I wonder if this PR might have caused the issues you're seeing? https://github.com/apache/superset/pull/21995 I have a faint recollection of running into issues with the updated versions, and I believe I reverted back to the previous versions (by setting GECKODRIVER_VERSION and

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Tai Dupree
I was just able to receive an email report just fine, so I don't think the issue is with this release (aside from what's addressed in my PR). That connection timeout error is usually networking/config related. Are you sure you can reach the superset web server from the worker, and that smtp is