Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Thank you for volunteering Ville & Gianluca! I think that would sort out the Python side deps. Follow the process here: https://github.com/apache/incubator-superset/pull/7643 Though as mentioned many times before, the JS side is more intricate. The dep tree is huge and dynamic (the tree changes as

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Gianluca, I will be happy to let you take the lead! If you open up a WIP PR I can help with testing and such. Ville On Wed, May 29, 2019, 16:30 Gianluca Ciccarelli wrote: > Hm, it appears that Ville volunteered before me. > > @Ville: Feel free to get in touch if you think I can be of some hel

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Hm, it appears that Ville volunteered before me. @Ville: Feel free to get in touch if you think I can be of some help. Best, Gianluca Ciccarelli Data Engineer @ Bolt On 29 May 2019, 10:04 +0300, Gianluca Ciccarelli , wrote: > Hi Maxime, > > I’d be glad to help with this. Haven’t read the whole

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Hi Maxime, I’d be glad to help with this. Haven’t read the whole thread and I might need a little guidance but seems doable. Is there already an issue for this on GitHub? I’ll check anyway and in case there isn’t I’ll open one. Best, Gianluca Ciccarelli Data Engineer @ Bolt On 28 May 2019, 21:

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Hi all, I volunteer to start work on making `requests` an optional dependency. It would be great if this could wait until the next release as Alan suggests to make sure there is enough time to ensure the transition goes smoothly. Ville On Tue, May 28, 2019, 22:24 Alan Gates wrote: > Again, I

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Again, I don't think this has to be fixed for your first incubator release. It will need to be fixed before you do a second release. And if you were a TLP you couldn't release with this. But for now, as a learning exercise and to get a release out ASAP, I'm ok without fixing it first. Especially

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

@community, it'd be great if someone could volunteer to do this (making the python library "requests" an optional dependency). It appears it's used in its simplest form in a few places (requests.get) which should be easy to replace with urrlib2. The Druid connector uses a more advanced feature (ba

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

https://issues.apache.org/jira/browse/LEGAL-192 Details why. It comes down to that you can use LGPL, but only if it’s an optional dependency. This is policy of the ASF in order not to limit downstream usage of its own products. Ie. A Non optional dependency would require downstream usage of Sup

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Related, about requests/chardet https://github.com/kennethreitz/requests/issues/3389 For the source code release, do [unbundled] deps need to be cleared? From my understanding we only needed to clear the code we ship. If that's the case we've got work to do on the JS side. Max On Wed, May 22, 2

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

> click BSD-3 > jsonschema MIT > python-dateutil Dual License (Apache 2) > python-dotenv Bsd 3 > python-geohash Apache 2 > python3-openid Apache 2 Verstuurd vanaf mijn iPad > Op 23 mei 2019 om 00:03 heeft Alan Gates het volgen

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Oef chardet is pulled in by requests. The usage of chardet (ie triggered) is unlikely as it is only used when the encoding is not set in headers. You could ask the maintainer of chardet to release under another license. This can be tough as their might be several people to contact that need to a

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

+1 with caveats, see below. I looked at the LICENSE, NOTICE, and DISCLAIMER files, checked for any binary files (executables, there's plenty of image files in the distribution), and looked over the licenses of the dependencies. More information on the dependencies: I found https://pypi.org/projec

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Oh actually the commands above just shows the dep tree. For deps in python there's https://github.com/dhatim/python-license-check On the JS side I did some work here to attempt building the LICENSE file dynamically as the dep tree evolves https://github.com/apache/incubator-superset/pull/5801 I

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Python: pip install pipdeptree && pipdeptree NPM: cd superset/assets && npm ls On Wed, May 22, 2019 at 11:09 AM Alan Gates wrote: > Yes, I checked, it works now. I just haven't yet because I'm still looking > at all the dependencies it pulls in. Maven makes this super easy to do, > but I need

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Yes, I checked, it works now. I just haven't yet because I'm still looking at all the dependencies it pulls in. Maven makes this super easy to do, but I need to learn enough about python setuptools to figure out how to check the licenses on those modules. Alan. On Wed, May 22, 2019 at 10:56 AM

Re: [RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Is the signature now verifiable? Otherwise it won’t pass the IPMC ... Verstuurd vanaf mijn iPad > Op 22 mei 2019 om 19:26 heeft Maxime Beauchemin > het volgende geschreven: > > Oops, changing thread title this time around > > Vote passes! > > +3 binding votes (Max, Jeff & Abhishek) > +1 non-

[RESULT][VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Oops, changing thread title this time around Vote passes! +3 binding votes (Max, Jeff & Abhishek) +1 non-binding vote (Ville) No neutral or negative votes. On Tue, May 21, 2019 at 12:31 AM Jeff Feng wrote: > +1 binding > > On Mon, May 20, 2019 at 3:54 PM Maxime Beauchemin < > maximebeauche...

Re: [VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Vote passes! +3 binding votes (Max, Jeff & Abhishek) +1 non-binding vote (Ville) No neutral or negative votes. On Tue, May 21, 2019 at 12:31 AM Jeff Feng wrote: > +1 binding > > On Mon, May 20, 2019 at 3:54 PM Maxime Beauchemin < > maximebeauche...@gmail.com> wrote: > > > @Alan, looks like I m

Re: [VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

+1 binding On Mon, May 20, 2019 at 3:54 PM Maxime Beauchemin < maximebeauche...@gmail.com> wrote: > @Alan, looks like I messed up the signature somehow. I got tangled into > adding a new entry (moving from my gmail to my apache.org address), > deleting the old one and my svn kungfu is beyond rust

Re: [VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

@Alan, looks like I messed up the signature somehow. I got tangled into adding a new entry (moving from my gmail to my apache.org address), deleting the old one and my svn kungfu is beyond rusty... Oh I think I just forgot to run "svn commit" (maybe i ran "svn update" instead?), so you should just

Re: [VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

+1 binding. Newly built docker image working fine. Thanks Abhishek On Mon, May 20, 2019 at 2:03 PM Alan Gates wrote: > Max, when I check the signature (gpg --verify ) it tells me: > gpg: Signature made Sat May 1

Re: [VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Max, when I check the signature (gpg --verify ) it tells me: gpg: Signature made Sat May 18 15:36:55 2019 PDT gpg:using RSA key 8CA186C4568E92301E5F2491A3B3BE2CCC1BB7E4 gpg: Can't check signature: No public key I imported the KEYS file referenced in your message, but it doesn't app

Re: [VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

+1 binding Built locally from source and tested without problems. Third time's the charm! Ville On Sun, May 19, 2019 at 2:01 AM Maxime Beauchemin < maximebeauche...@gmail.com> wrote: > Dear all, > > The source release 0.33.0 RC1 for Apache Superset is baked and available > at: > https://dist.a

[VOTE] Release Superset 0.33.0 based on Superset 0.33.0rc1

Dear all, The source release 0.33.0 RC1 for Apache Superset is baked and available at: https://dist.apache.org/repos/dist/dev/incubator/superset/, public keys are available at https://dist.apache.org/repos/dist/release/incubator/superset/KEYS We're now attempting to use 0.33 as the base for the f