Re: Getting ready for 5.4.2

2017-04-06 Thread Thiago H. de Paula Figueiredo
Thank you very much for your help and time, Jochen! On Thu, Apr 6, 2017 at 6:30 AM, Jochen Kemnade wrote: > Should be fixed now. > > > Am 06.04.2017 um 10:50 schrieb Jochen Kemnade: > >> Hi, >> >> Am 06.04.2017 um 04:52 schrieb Thiago H. de Paula Figueiredo: >> >>> The test I've added passes loc

Re: Getting ready for 5.4.2

2017-04-06 Thread Jochen Kemnade
Should be fixed now. Am 06.04.2017 um 10:50 schrieb Jochen Kemnade: Hi, Am 06.04.2017 um 04:52 schrieb Thiago H. de Paula Figueiredo: The test I've added passes locally but it's failing in Travis. I'll rewrite it a little bit. It works with jQuery but fails with Prototype. Jochen -

Re: Getting ready for 5.4.2

2017-04-06 Thread Jochen Kemnade
Hi, Am 06.04.2017 um 04:52 schrieb Thiago H. de Paula Figueiredo: The test I've added passes locally but it's failing in Travis. I'll rewrite it a little bit. It works with jQuery but fails with Prototype. Jochen - To unsubs

Re: Getting ready for 5.4.2

2017-04-05 Thread Thiago H. de Paula Figueiredo
Hello, Jochen! dom.getEventUrl fixed (again, a Coffee issue, a missing return statement makes the function return something else) and test added (I had already written it, but somehow it didn't make it to Git). Build failed and I'll take a look tomorrow. The test I've added passes locally but it's

Re: Getting ready for 5.4.2

2017-04-05 Thread Jochen Kemnade
Now, dom.getEventUrl is broken on both branches. Thiago, can you please add tests? - On Apr 4, 2017, at 6:49 PM, Thiago H. de Paula Figueiredo thiag...@gmail.com wrote: > On Tue, Apr 4, 2017 at 9:37 AM, Jochen Kemnade > wrote: > >> Thiago, >> > > Hello, Jochen! > > >> the JavaDoc for Pu

Re: Getting ready for 5.4.2

2017-04-05 Thread Jochen Kemnade
Hi, - On Apr 4, 2017, at 6:49 PM, Thiago H. de Paula Figueiredo thiag...@gmail.com wrote: > Are the Travis builds configured to send e-mails to any Tapestry mailing > list? I didn't get any e-mails from them. I tried to configure that [1] but it doesn't work. Apparently, you can only have e

Re: Getting ready for 5.4.2

2017-04-04 Thread Thiago H. de Paula Figueiredo
On Tue, Apr 4, 2017 at 9:37 AM, Jochen Kemnade wrote: > Thiago, > Hello, Jochen! > the JavaDoc for PublishEvent is broken, please fix it. > https://travis-ci.org/apache/tapestry-5/builds/218065676#L570 > https://travis-ci.org/apache/tapestry-5/jobs/217885298#L897 Thanks for noticing it. I've

Re: Getting ready for 5.4.2

2017-04-04 Thread Lance Java
There's a typescript gradle plugin https://github.com/sothmann/typescript-gradle-plugin The Tapestry build could use this at build time to convert Typescript to Javascript which is published to maven central. So downstream consumers wouldn't need nodejs installed On 4 Apr 2017 12:13 p.m., "Joche

Re: Getting ready for 5.4.2

2017-04-04 Thread Jochen Kemnade
Thiago, the JavaDoc for PublishEvent is broken, please fix it. https://travis-ci.org/apache/tapestry-5/builds/218065676#L570 https://travis-ci.org/apache/tapestry-5/jobs/217885298#L897 Jochen Am 03.04.2017 um 15:01 schrieb Thiago H. de Paula Figueiredo: On Mon, Apr 3, 2017 at 3:45 AM, Jochen K

Re: Getting ready for 5.4.2

2017-04-04 Thread Jochen Kemnade
Hi, Am 04.04.2017 um 13:05 schrieb Bob Harner: As I understand it the Typescript compiler is written Typescript, which can be compiled to JavaScript, and then that compiled compiler can be run in any compliant JavaScript engine, including Rhino that Tapestry already employs as well as the Nashor

Re: Getting ready for 5.4.2

2017-04-04 Thread Bob Harner
As I understand it the Typescript compiler is written Typescript, which can be compiled to JavaScript, and then that compiled compiler can be run in any compliant JavaScript engine, including Rhino that Tapestry already employs as well as the Nashorn engine built into Java 8. So it should be possib

Re: Getting ready for 5.4.2

2017-04-03 Thread Thiago H. de Paula Figueiredo
> > Has there been any discussion of integrating TypeScript into Tapestry as a > native feature/option? That would be high on my feature wish list. > You mean on-the-fly compilation of TypeScript sources to JS? Hmm, that would be hard, as the TypeScript compiler, as far as I know, is only impleme

Re: Getting ready for 5.4.2

2017-04-03 Thread Michael Gentry
On Mon, Apr 3, 2017 at 9:01 AM, Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: > Hmm, I wouldn't consider changing the whole JS codebase from Coffee to > vanilla JS, ES6 or not, a good use of *my* very scarce time for Tapestry. > Of course, if someone wants to do that, I'd love it. :)

Re: Getting ready for 5.4.2

2017-04-03 Thread Thiago H. de Paula Figueiredo
On Mon, Apr 3, 2017 at 3:45 AM, Jochen Kemnade wrote: > Hi, Hello! > Am 03.04.2017 um 00:35 schrieb Thiago H. de Paula Figueiredo: > >> I've investigated and I've found that the place I've added the getEventUrl >> function in the Coffee file has caused some weird issues with the way the >> Ja

Re: Getting ready for 5.4.2

2017-04-02 Thread Jochen Kemnade
Hi, Am 03.04.2017 um 00:35 schrieb Thiago H. de Paula Figueiredo: I've investigated and I've found that the place I've added the getEventUrl function in the Coffee file has caused some weird issues with the way the JavaScript was output. Yes, I'd fixed that already in [1]. I'm really not a f

Re: Getting ready for 5.4.2

2017-04-02 Thread Thiago H. de Paula Figueiredo
Hello, Jochen! I've investigated and I've found that the place I've added the getEventUrl function in the Coffee file has caused some weird issues with the way the JavaScript was output. I'm really not a fan of Coffee. But it's now fixed in the 5.4.x branch and master and at least that tapestry-be

Re: Getting ready for 5.4.2

2017-03-28 Thread Jochen Kemnade
Thiago, do you think you'll find the time to address those issues in the near future? I'd rather create a new 5.4.2 release than shipping the current build with known issues. Jochen - On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo thiag...@gmail.com wrote: > On Fri, Mar 24, 2

Re: Getting ready for 5.4.2

2017-03-24 Thread Jochen Kemnade
Hi, - On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo thiag...@gmail.com wrote: >> Shouldn't dom.getEventUrl throw or at least warn if it cannot determine >> the url for the event, e.g. if you forget to add the @PublishEvent >> annotation? >> > > Right now it returns null. Well, a

Re: Getting ready for 5.4.2

2017-03-24 Thread Thiago H. de Paula Figueiredo
On Fri, Mar 24, 2017 at 5:03 AM, Jochen Kemnade wrote: > Thiago, > Hello! > I've had a look at the new code and here's what I've found so far: > > The @PublishEvent JavaDoc is misleading: > It says that the event handler method is "to be called in JavaScript > through the t5/core/triggerServer

Re: Getting ready for 5.4.2

2017-03-24 Thread Jochen Kemnade
Btw.: Are there any tests for the new feature or just the demo page? - On Mar 24, 2017, at 9:03 AM, Jochen Kemnade jochen.kemn...@eddyson.de wrote: > Thiago, > > I've had a look at the new code and here's what I've found so far: > > The @PublishEvent JavaDoc is misleading: > It says that t

Re: Getting ready for 5.4.2

2017-03-24 Thread Jochen Kemnade
Thiago, I've had a look at the new code and here's what I've found so far: The @PublishEvent JavaDoc is misleading: It says that the event handler method is "to be called in JavaScript through the t5/core/triggerServerEvent function", but there is no such function. An ElementWrapper (e.g. dom.b

Re: Getting ready for 5.4.2

2017-03-20 Thread Thiago H. de Paula Figueiredo
Hello, Jochen! I'll try to take a look and fix them before the weekend. If not, feel free to revert it in the 5.4.x branch. On Mon, Mar 20, 2017 at 9:52 AM, Jochen Kemnade wrote: > Hi, > > Am 20.03.2017 um 09:53 schrieb Jochen Kemnade: > >> Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Fig

Re: Getting ready for 5.4.2

2017-03-20 Thread Jochen Kemnade
Hi, Am 20.03.2017 um 09:53 schrieb Jochen Kemnade: Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Figueiredo: https://issues.apache.org/jira/browse/TAP5-2225 finished and committed to both 5.4.2 and 5.5 (master). Feedback welcome! ./gradlew tapestry-beanvalidator:test --tests org.apache.ta

Re: Getting ready for 5.4.2

2017-03-20 Thread Jochen Kemnade
Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Figueiredo: https://issues.apache.org/jira/browse/TAP5-2225 finished and committed to both 5.4.2 and 5.5 (master). Feedback welcome! ./gradlew tapestry-beanvalidator:test --tests org.apache.tapestry5.beanvalidator.integration.TapestryBeanValida

Re: Getting ready for 5.4.2

2017-03-20 Thread Jochen Kemnade
Great. I just merged the tapestry-json changes into the 5.4.x branch. I'll probably start a vote tomorrow. Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Figueiredo: https://issues.apache.org/jira/browse/TAP5-2225 finished and committed to both 5.4.2 and 5.5 (master). Feedback welcome! On We

Re: Getting ready for 5.4.2

2017-03-19 Thread Thiago H. de Paula Figueiredo
https://issues.apache.org/jira/browse/TAP5-2225 finished and committed to both 5.4.2 and 5.5 (master). Feedback welcome! On Wed, Mar 8, 2017 at 11:45 AM, Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: > I've started https://issues.apache.org/jira/browse/TAP5-2225 but I > haven't finis

Re: Getting ready for 5.4.2

2017-03-09 Thread Jochen Kemnade
Hi, Am 08.03.2017 um 15:45 schrieb Thiago H. de Paula Figueiredo: I've started https://issues.apache.org/jira/browse/TAP5-2225 but I haven't finished yet. I was planning to work on this next week's weekend. Jochen, if you want to go ahead, I can make another release later. You want to do that

Re: Getting ready for 5.4.2

2017-03-08 Thread Thiago H. de Paula Figueiredo
I've started https://issues.apache.org/jira/browse/TAP5-2225 but I haven't finished yet. I was planning to work on this next week's weekend. Jochen, if you want to go ahead, I can make another release later. Also, thank you very, very much for taking TAP5-2575. :) On Wed, Mar 8, 2017 at 7:45 AM, J

Re: Getting ready for 5.4.2

2017-03-08 Thread Christian Riedel
That blocker maybe? https://issues.apache.org/jira/browse/TAP5-2391 The last comment makes it seem as if the fix would be a simple one-liner. > Am 08.03.2017 um 11:45 schrieb Jochen Kemnade : > > Hi, > > due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to > address that i

Getting ready for 5.4.2

2017-03-08 Thread Jochen Kemnade
Hi, due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to address that issue. Is there anything we want to pick from master? Or anything else we want to include? Jochen - To unsubscribe, e-mail: dev-unsubscr.