DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-2100125078
Hi @b49020 Could you review the updated README which added the `no-std`
description?
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/128
jforissier commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1875077034
> > Perhaps just make it ?= y by default, but it is always good to have a
way to disable things in case they break.
>
> That sounds reasonable. I will do
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1875052776
> Perhaps just make it ?= y by default, but it is always good to have a way
to disable things in case they break.
That sounds reasonable. I will do that as a
jforissier commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1874024214
> > This might help:
[OP-TEE/optee_os@788069f](https://github.com/OP-TEE/optee_os/commit/788069fa88ed8bf376a07991196fbf80c36b7e06)
(although minimizing the clon
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1873912783
> This might help:
https://github.com/OP-TEE/optee_os/commit/788069fa88ed8bf376a07991196fbf80c36b7e06
(although minimizing the cloned data is certainly a good idea
jforissier commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1873798034
> > The CI reports `No space left on device`, are there any space
constraints for CI?
>
> The Github actions provide at least 14G storage (reference:
htt
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1872127303
> We should rather depend on TA_DEV_KIT_DIR environment variable to provide
path to pre-build OP-TEE utee libraries. This is quite similar to C development
environm
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1871784821
@DemesneGH With `no-std` changes merged, the next step is to publish
`optee-utee` crate.
> todo: support for inter-TA APIs
Although I agree it is an im
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1871049110
@DemesneGH Created PR for `no-std` here:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/115
--
This is an automated message from the Apache Git S
DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1870981056
https://github.com/apache/incubator-teaclave-trustzone-sdk/tree/no-std,
thanks! @b49020
--
This is an automated message from the Apache Git Service.
To respon
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1870975882
> Sure, after we finished the stage 1 which means the no-std is stable I'm
okay to set the no-std as main branch.
Fair enough, let's go with `no-std` branch t
DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1870971101
> if we rather have `std` as a separate branch and keep `master` as the main
development branch then it would be even better
Sure, after we finished the st
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1870966511
> if we rather have std as a separate branch and keep master as the main
development branch then it would be even better.
So once we have the `aarch64-unknown
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1870959974
@DemesneGH I mostly agree with your stage 1 but for stage 2 I think once we
have published `optee-utee` crate on crates.io then we can just drop
`optee-utee` from `
DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-187095
> The CI reports `No space left on device`, are there any space constraints
for CI?
The Github actions provide at least 14G storage (reference:
https://do
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1870821795
@DemesneGH The CI reports `No space left on device`, are there any space
constraints for CI? BTW, I don't think this PR adds anything extra apart from
extra latest
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1870317029
> do you need a new release on https://crates.io/crates/optee-utee?
Yeah once we have sufficient functionality implemented to enable standalone
rust TAs devel
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1870312898
@daniel-thompson @DemesneGH So I gave `no_std` being an optional feature a
try for `optee-utee` and `optee-utee-sys` crates, it turns out that I found a
way to keep
DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1869562935
@b49020 do you need a new release on https://crates.io/crates/optee-utee?
--
This is an automated message from the Apache Git Service.
To respond to the message
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1869524609
> The current CI failure is due to following missing patch to OP-TEE build
repo as I have stated above:
The patch has been posted here: https://github.com/OP-
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1869494073
@DemesneGH How about we rather stick the `std` based TAs to `v0.2.0` of
`optee-utee` crate and merge `no-std` feature in a later version of
`optee-utee` crate using
DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1869462037
> That sounds fine but for `std` counterpart I am not sure if the current
custom OP-TEE toolchain target (along with libc and compiler builtin forks) can
support
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1869459472
Thanks @Ablu for your review.
> It looks like there is interest to optimize for size. Since you are using
nightly anyway, you may want to try:
Binary s
b49020 commented on code in PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#discussion_r1436397206
##
rust-toolchain.toml:
##
@@ -18,6 +18,5 @@
# Toolchain override for rustup
[toolchain]
-channel = "nightly-2021-09-20"
-components = ["rust
b49020 commented on code in PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#discussion_r1436390028
##
examples/authentication-rs/ta/build.rs:
##
@@ -58,5 +82,12 @@ fn main() -> std::io::Result<()> {
println!("cargo:rustc-link-search={}",
Ablu commented on code in PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#discussion_r1435265884
##
rust-toolchain.toml:
##
@@ -18,6 +18,5 @@
# Toolchain override for rustup
[toolchain]
-channel = "nightly-2021-09-20"
-components = ["rust-s
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1867656134
The current CI failure is due to following missing patch to OP-TEE build
repo as I have stated above:
```
build$ git diff
diff --git
a/br-ext/package/o
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1867654954
> Seems there are some license issue on CI:
`dyn_list` files are generated by `/ta/link.mk` and to be consumed
directly by the linker. So I don't think they d
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1867653132
> Rather than create a branch is it possible to introduce a no_std feature
to optee-utee crate (similar to crates like serde which support no_std but it
is optional
DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1867548910
@b49020 Seems there are some license issue on CI:
```
ERROR the following files don't have a valid license header:
examples/acipher-rs/ta/dyn_list
exa
DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1867546355
> Rather than create a branch is it possible to introduce a no_std feature
to optee-utee crate (similar to crates like serde which support no_std but it
is optio
daniel-thompson commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1867542344
Rather than create a branch is it possible to introduce a no_std feature to
optee-utee crate (similar to crates like serde which support no_std but it is
o
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1867496382
Thanks @DemesneGH for your comments.
> Since the std still fits some cases which relying on serde, network, and
other crates that have not support no-std yet,
DemesneGH commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1867381182
@b49020 Thanks so much for your contributions!
Since the `std` still fits some cases which relying on `serde`, `network`,
and other crates that have not su
b49020 commented on PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1866227575
@DemesneGH @Sword-Destiny @jbech-linaro @jenswi-linaro @jforissier
@etienne-lms @daniel-thompson @Ablu Fyi..
Feedback/comments are very much welcome, thanks.
b49020 opened a new pull request, #114:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114
Existing OP-TEE rust environment required a custom rust toolchain target for
OP-TEE based TAs. I suppose back in 2019 when this SDK was created, rust
embedded ecosystem (especial
36 matches
Mail list logo
