AW: [DISCUSS] CMake for Apache Thrift

2014-11-25 Thread Jens Geyer
So Visual Projects could be removed from repo and generated for example as part of release. Or development process. Right? Von: Konrad Grochowski Gesendet: 25.11.2014 01:00 An: dev@thrift.apache.org Betreff: Re: [DISCUSS] CMake for Apache Thrift cmake can

[GitHub] thrift pull request: THRIFT-2844: Nodejs support broken when runni...

2014-11-25 Thread cameronr
Github user cameronr commented on the pull request: https://github.com/apache/thrift/pull/251#issuecomment-64324675 ah crap, messed up while updating to the recent changes. will close this PR and open a new one with the appropriate changes --- If your project is set up for it, you

[jira] [Commented] (THRIFT-2844) Nodejs support broken when running under Browserify

2014-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224219#comment-14224219 ] ASF GitHub Bot commented on THRIFT-2844: Github user cameronr commented on the

[jira] [Commented] (THRIFT-2844) Nodejs support broken when running under Browserify

2014-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224230#comment-14224230 ] ASF GitHub Bot commented on THRIFT-2844: GitHub user cameronr opened a pull

Re: AW: [DISCUSS] CMake for Apache Thrift

2014-11-25 Thread Konrad Grochowski
So Visual Projects could be removed from repo and generated for example as part of release. Or development process. Right? Yes, if you want to work in VS the easiest way is to use cmake to generate vcxproj. Because it's done automatically you can be pretty sure you're changes will be properly

Re: [DISCUSS] CMake for Apache Thrift

2014-11-25 Thread Sergei Nikulov
2014-11-24 23:36 GMT+03:00 Roger Meier ro...@bufferoverflow.ch: Hi all The Apache Thrift compiler is optionally using CMake already and we had very good experience by using CMake also for the cpp library to get it up and running on Linux-ARM, Linux-x86, Windows CE and Windows. I like to

[jira] [Created] (THRIFT-2855) Move contributing.md to the root of the repository

2014-11-25 Thread Cash Costello (JIRA)
Cash Costello created THRIFT-2855: - Summary: Move contributing.md to the root of the repository Key: THRIFT-2855 URL: https://issues.apache.org/jira/browse/THRIFT-2855 Project: Thrift Issue

[jira] [Commented] (THRIFT-2855) Move contributing.md to the root of the repository

2014-11-25 Thread Cash Costello (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224774#comment-14224774 ] Cash Costello commented on THRIFT-2855: --- Complicating the generation of your

[jira] [Commented] (THRIFT-2855) Move contributing.md to the root of the repository

2014-11-25 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225132#comment-14225132 ] Roger Meier commented on THRIFT-2855: - I agree on a CONTRIBUTING.md file, this is

[jira] [Commented] (THRIFT-2855) Move contributing.md to the root of the repository

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225157#comment-14225157 ] Jens Geyer commented on THRIFT-2855: Sounds good. Move contributing.md to the root

[jira] [Updated] (THRIFT-2851) Remove strange public Peek() from Go transports

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2851: --- Summary: Remove strange public Peek() from Go transports (was: Remove strange public Peek() from GO

[jira] [Resolved] (THRIFT-2851) Remove strange public Peek() from Go transports

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2851. Resolution: Fixed After sleeping a night about it, I think you are right. In its current form

[jira] [Updated] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2854: --- Summary: Go Struct writer and reader looses important error information (was: GO Struct writer and

[jira] [Comment Edited] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225211#comment-14225211 ] Jens Geyer edited comment on THRIFT-2854 at 11/25/14 9:10 PM:

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225211#comment-14225211 ] Jens Geyer commented on THRIFT-2854: The generated code has some known flaws with

[jira] [Updated] (THRIFT-1976) Javascript client unable to serialize/deserialize maps with struct keys

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-1976: --- Description: The Javascript compiler is unable to serialize maps where a struct is a key due to

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225235#comment-14225235 ] Chi Vinh Le commented on THRIFT-2854: - I just scanned the generated code. It seems to

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225237#comment-14225237 ] Chi Vinh Le commented on THRIFT-2854: - One thing though: Why does the {{Process()}}

[jira] [Commented] (THRIFT-2855) Move contributing.md to the root of the repository

2014-11-25 Thread Cash Costello (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225239#comment-14225239 ] Cash Costello commented on THRIFT-2855: --- Is the website managed through your svn

[jira] [Commented] (THRIFT-2851) Remove strange public Peek() from Go transports

2014-11-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225289#comment-14225289 ] Hudson commented on THRIFT-2851: SUCCESS: Integrated in Thrift #1372 (See

[jira] [Commented] (THRIFT-2855) Move contributing.md to the root of the repository

2014-11-25 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225299#comment-14225299 ] Konrad Grochowski commented on THRIFT-2855: --- yep, exactly, also snippet could

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225305#comment-14225305 ] Jens Geyer commented on THRIFT-2854: {quote}where are the flaws?{quote}

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225330#comment-14225330 ] Chi Vinh Le commented on THRIFT-2854: - Just asking :-) I saw that part of code, but

[jira] [Comment Edited] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Chi Vinh Le (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225330#comment-14225330 ] Chi Vinh Le edited comment on THRIFT-2854 at 11/25/14 11:00 PM:

[jira] [Commented] (THRIFT-2851) Remove strange public Peek() from Go transports

2014-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225388#comment-14225388 ] ASF GitHub Bot commented on THRIFT-2851: Github user asfgit closed the pull

[GitHub] thrift pull request: THRIFT-2851 Remove strange public Peek() from...

2014-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] CMake for Apache Thrift

2014-11-25 Thread Henrique Mendonça
Hey guys, I think Roger also meant to only have one build system. Probably only having both while we port everything to cmake, but only one will be officially supported at a time. Not sure how much work is involved for the non-C libraries, wasn't facebook also using cmake? can we get anything

[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information

2014-11-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225422#comment-14225422 ] Jens Geyer commented on THRIFT-2854: Ok. Go Struct writer and reader looses

[jira] [Created] (THRIFT-2856) refactor erlang basic transports and unify interfaces

2014-11-25 Thread alisdair sullivan (JIRA)
alisdair sullivan created THRIFT-2856: - Summary: refactor erlang basic transports and unify interfaces Key: THRIFT-2856 URL: https://issues.apache.org/jira/browse/THRIFT-2856 Project: Thrift

[GitHub] thrift pull request: thrift-2856 refactor erlang basic transports ...

2014-11-25 Thread talentdeficit
GitHub user talentdeficit opened a pull request: https://github.com/apache/thrift/pull/288 thrift-2856 refactor erlang basic transports and unify interfaces patch: alisdair sullivan client: erlang (library) You can merge this pull request into a Git repository by running:

[jira] [Commented] (THRIFT-2789) TNonblockingServer leaks socket FD's under load

2014-11-25 Thread Qiao Mu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225628#comment-14225628 ] Qiao Mu commented on THRIFT-2789: - I may have the same issue here. I had a running