[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38551876 --- Diff: build/cmake/DefineOptions.cmake --- @@ -62,8 +62,10 @@ endif() find_package(OpenSSL QUIET) CMAKE_DEPENDENT_OPTION(WITH_OPENSSL "Build with

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552069 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552467 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552677 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

Re: Thrift // CMake build system state

Hi Sergei The goal for that ticket is for our 1.0 release to be able to replace all existing functionality currently with the build framework with cmake counter parts. I took an initial stab at it and Roger was also working on this, but both efforts have been put on hold while working on the 0.9.3

[jira] [Commented] (THRIFT-3087) Pass on errors like "connection closed"

[ https://issues.apache.org/jira/browse/THRIFT-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727386#comment-14727386 ] ASF GitHub Bot commented on THRIFT-3087: Github user NOMORECOFFEE closed the pull request at:

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

GitHub user snikulov opened a pull request: https://github.com/apache/thrift/pull/598 cmake // fixes for std/boost::thread detection; security test; qt test Hello All! Relates to https://issues.apache.org/jira/browse/THRIFT-2850 1. Will use BOOST if not explicitly

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727265#comment-14727265 ] ASF GitHub Bot commented on THRIFT-2850: GitHub user snikulov opened a pull request:

Thrift // CMake build system state

Hello developers. Could you please provide me with some hint what current state of cmakeable build for Apache Thrift? Do we have any requirements and goals to achieve? What is definition of done for https://issues.apache.org/jira/browse/THRIFT-2850? Thank you! -- Best Regards, Sergei Nikulov

[GitHub] thrift pull request: THRIFT-3087 Pass on errors like "connection c...

Github user NOMORECOFFEE closed the pull request at: https://github.com/apache/thrift/pull/431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: Thrift-1857: Python 3 support, redux

Github user jeroenvlek commented on the pull request: https://github.com/apache/thrift/pull/213#issuecomment-137107351 Well, I'm still waiting for an answer on my question above on UTF-8. Other than that, my patch should be easy to apply. If work permits, I'll rebase my patch on the

[GitHub] thrift pull request: Thrift-1857: Python 3 support, redux

Github user lababidi commented on the pull request: https://github.com/apache/thrift/pull/213#issuecomment-137105035 @jfarrell @jeroenvlek Any progress on this? I'd be happy to help out in any way. --- If your project is set up for it, you can reply to this email and have your reply