Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146446009
The biggest change is that simple types (bool, byte, etc) are now mapped
differently to allow the proper use of NSError. These types now map to NSNumber
instead. Aside
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146440075
What about the compat breaks?
Von: Kevin Wooten
Gesendet: 07.10.2015 22:11
An: apache/thrift
Cc: Jens Geyer
Gonzalo Aguilar created THRIFT-3370:
---
Summary: errno extern variable redefined. Not compiling in Android
Key: THRIFT-3370
URL: https://issues.apache.org/jira/browse/THRIFT-3370
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948622#comment-14948622
]
david bennett commented on THRIFT-3370:
---
Looks like Thrift is in the wrong. The C standard says:
[
https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948860#comment-14948860
]
ASF GitHub Bot commented on THRIFT-3253:
GitHub user phongphan opened a pull request:
GitHub user phongphan opened a pull request:
https://github.com/apache/thrift/pull/636
THRIFT-3253
Hi
These changesets would fixed the deprecation warnings when compiling with
latest D compiler. I have tested with 2.067.1.
I have to change the `thriftToHashImpl` a
Hi Randy,
But the apache rules specify to upload a patch done with git and upload
to thrift. That's what I did.
I will try the pull request.
Best regards,
El 08/10/15 a las 14:53, Randy Abernethy escribió:
Hello Gonzalo,
You can head over to https://github.com/apache/thrift and fork a
[
https://issues.apache.org/jira/browse/THRIFT-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948896#comment-14948896
]
Gonzalo Aguilar commented on THRIFT-3370:
-
Hi I have already fixed and tested on x86_64, i386 and
Github user c4urself commented on the pull request:
https://github.com/apache/thrift/pull/213#issuecomment-146635657
Note: I've tried this branch on Python3 and Python2 and while things seem
to work correctly on Python 3; In Python2, the `six.BytesIO` object is not
recognised
Github user eevee commented on the pull request:
https://github.com/apache/thrift/pull/213#issuecomment-146636829
Yeah, like I said in the OP, `fastbinary.c` uses a private C interface to
cStringIO that was removed in Python 3, and I'm not familiar enough with it to
fix it.
[
https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-3253:
--
Assignee: Jens Geyer
> Using latest version of D gives deprecation notices
>
[
https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3253.
Resolution: Fixed
Fix Version/s: 1.0
Committed, thank you!
> Using latest version of D
[
https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3253:
---
Assignee: Phongphan Phuttha (was: Jens Geyer)
> Using latest version of D gives deprecation notices
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/636#issuecomment-146661017
Committed per 855cf7f089730a7df657f45e25afa0b6043a72c8
Please close the PR by hand, thanks.
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949202#comment-14949202
]
ASF GitHub Bot commented on THRIFT-3253:
Github user Jens-G commented on the pull request:
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146701420
With regard to the C++ and Cocoa exception codes matching... It doesn't
seem like the exceptions are being thrown in the same circumstances in most
cases. Maybe we
Pavlo Penenko created THRIFT-3371:
-
Summary: Abstract namespace Unix domain sockets broken in C++
Key: THRIFT-3371
URL: https://issues.apache.org/jira/browse/THRIFT-3371
Project: Thrift
GitHub user ppenenko opened a pull request:
https://github.com/apache/thrift/pull/637
THRIFT-3371
As for the test, I have added a new socket type to the suite named
"abstract" and it works if added to tests.json but I'm not sure how to only
enable it on Linux (and not say OS X) so
As a very achievable alternative...
How about a simple switch on the current compiler to output the parsed data
model as an XML or JSON file? Checks like reserved words should be suppressed,
but otherwise it's just another really simple generator.
The point about XML is that it's easily loaded
[
https://issues.apache.org/jira/browse/THRIFT-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949317#comment-14949317
]
Jens Geyer commented on THRIFT-3100:
{{make cross}} is a good start :-)
The test mentioned here is
Jens Geyer created THRIFT-3372:
--
Summary: Add dart generator to Visual Studio project
Key: THRIFT-3372
URL: https://issues.apache.org/jira/browse/THRIFT-3372
Project: Thrift
Issue Type:
[
https://issues.apache.org/jira/browse/THRIFT-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949508#comment-14949508
]
Hudson commented on THRIFT-3372:
SUCCESS: Integrated in Thrift #1679 (See
[
https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949354#comment-14949354
]
Hudson commented on THRIFT-3253:
SUCCESS: Integrated in Thrift #1678 (See
[
https://issues.apache.org/jira/browse/THRIFT-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3372.
Resolution: Fixed
Fix Version/s: 1.0
Committed.
> Add dart generator to Visual Studio
[
https://issues.apache.org/jira/browse/THRIFT-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949605#comment-14949605
]
ASF GitHub Bot commented on THRIFT-3371:
GitHub user ppenenko opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949317#comment-14949317
]
Jens Geyer edited comment on THRIFT-3100 at 10/8/15 8:22 PM:
-
{{make cross}}
[
https://issues.apache.org/jira/browse/THRIFT-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3372:
---
Attachment: THRIFT-3372-Add-dart-generator-to-Visual-Studio-proj.patch
> Add dart generator to
Github user phongphan commented on the pull request:
https://github.com/apache/thrift/pull/636#issuecomment-146737394
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user phongphan closed the pull request at:
https://github.com/apache/thrift/pull/636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949771#comment-14949771
]
ASF GitHub Bot commented on THRIFT-3253:
Github user phongphan commented on the pull request:
[
https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949772#comment-14949772
]
ASF GitHub Bot commented on THRIFT-3253:
Github user phongphan closed the pull request at:
GitHub user gadLinux opened a pull request:
https://github.com/apache/thrift/pull/639
Implements ssl sockets on c_glib
Adds dependencies to gobject at compile time because it needs it.
Server side is not complete so some tests are failing. Looking to fix them
all.
I
[
https://issues.apache.org/jira/browse/THRIFT-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949777#comment-14949777
]
ASF GitHub Bot commented on THRIFT-3370:
GitHub user gadLinux opened a pull request:
GitHub user gadLinux opened a pull request:
https://github.com/apache/thrift/pull/638
Fix problem on #THRIFT-3370
This comments out the line with the extern of errno so we can reenable if
someone complains about it.
Compiled against x86_64, i686 and arm android and it worked.
[
https://issues.apache.org/jira/browse/THRIFT-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949130#comment-14949130
]
Jens Geyer commented on THRIFT-2905:
from [the mail
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146663420
Common mistake:
case t_base_type::TYPE_BYTE:
return "UInt8";
All Thrift integers are *signed*. The naming of the `byte` is a bit
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146665847
@Jens-G Should I change Objective-C as well? It was, and still is,
treating ```byte``` as unsigned
---
If your project is set up for it, you can reply to this email and
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-14197
I just found myself asking why we have ObjectiveC and Swift code liiving in
one folder called Cocoa? I know the name already existed before, but does it
make sense?
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-14369
> Should I change Objective-C as well? It was, and still is, treating byte
as unsigned
Sure. As I said, very common mistake.
---
If your project is set up
Hey Gonzalo,
There was a time not too long ago when only Jira attached patches were
accepted but we now also take Jira attached pull requests. More here:
https://thrift.apache.org/docs/HowToContribute
Best,
Randy
On Thu, Oct 8, 2015 at 8:48 AM, Gonzalo Aguilar Delgado <
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146668825
There are some files (mostly *.swift) that do not have the ASF header on
top.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146669211
Will ensure the ASF header is atop all files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146668993
I had considered changing the generator name to "objc" for this exact
reason. As I mentioned previously, the Swift generated code uses the same
library implementation;
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146670456
Re cocoa/objc/swift: I see. Leave it as it is.
Question: Are the eror codes from TTransportError.h (and mybe others) only
used internally or are they visible to
44 matches
Mail list logo
