Haskell Thrift Bindings

2016-02-03 Thread Noam Zilberstein
Hello, I work on the Haxl Team (https://code.facebook.com/posts/302060973291128/open-sourcing-haxl-a-library-for-haskell/) at Facebook, and we have been working on improving the Thrift bindings for Haskell in order to address issues that we have seen both internally and externally. For

[jira] [Commented] (THRIFT-3593) Add new IDL keyword 'signal' to be able that a server can actively send messages to all its connected clients to prevent polling

2016-02-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131254#comment-15131254 ] Jens Geyer commented on THRIFT-3593: Thanks for the link. However, the below section reads just like

[jira] [Commented] (THRIFT-3593) Add new IDL keyword 'signal' to be able that a server can actively send messages to all its connected clients to prevent polling

2016-02-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131268#comment-15131268 ] Jens Geyer commented on THRIFT-3593: Let me just add another aspect. There are a few samples in the

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131098#comment-15131098 ] John Sirois commented on THRIFT-2157: - [~jensg] or [~mbreslow] Is there more coming in this fix? As

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131143#comment-15131143 ] John Sirois commented on THRIFT-3583: - Adding THRIFT-2157 as a blocker even though its not really

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131140#comment-15131140 ] John Sirois commented on THRIFT-3583: - Ran into this 1/2-way refactoring of TBase when rebasing my

[GitHub] thrift pull request: THRIFT-3584 Lua: To check element of self whe...

2016-02-03 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/826#issuecomment-179283037 OK, "read" was not a precise word. The problem I was trying to describe is about receiving boolean return value (not field) that happened to be `false`. At a quick

[jira] [Commented] (THRIFT-3584) the value(false) for parameter self.argBool will be lost when condition is 'if self.argBool then' .

2016-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130529#comment-15130529 ] ASF GitHub Bot commented on THRIFT-3584: Github user nsuke commented on the pull request:

Re: Build failed in Jenkins: thrift #598

2016-02-03 Thread Aki Sukegawa
> Access denied for user 'sonar'@'localhost' (using password: YES) This appears to be a Jenkins job misconfiguration. What should we do for this ? Open an INFRA issue ? On Wed, Feb 3, 2016 at 3:37 AM wrote: > See

Re: Haskell Thrift Bindings

2016-02-03 Thread Jake Farrell
Hi Noam Thanks for bring this up and looking to contribute your work to Apache Thrift. We are always happy to review patches and discuss new additions that can help improve Thrift and the user experience for the community. I would suggest that you open a jira ticket for this and submit a patch set

[GitHub] thrift pull request: Fix hang in go tests.

2016-02-03 Thread jsirois
Github user jsirois commented on the pull request: https://github.com/apache/thrift/pull/833#issuecomment-179546030 Tested with `make check`, which no-longer hangs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [PROPOSAL] Have jenkins run `make check`

2016-02-03 Thread John Sirois
I just noticed there is a Thrift-precommit job that _does_ have `make check`: $ curl --netrc -sS https://builds.apache.org/job/Thrift-precommit/config.xml | xmllint --xpath "//command/text()" - sh bootstrap.sh sloccount --duplicates --wide --details lib tutorial test sloccount.sc cppcheck

[jira] [Created] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
John Sirois created THRIFT-3597: --- Summary: `make check` hangs in go tests Key: THRIFT-3597 URL: https://issues.apache.org/jira/browse/THRIFT-3597 Project: Thrift Issue Type: Bug

[GitHub] thrift pull request: Fix hang in go tests.

2016-02-03 Thread jsirois
Github user jsirois commented on the pull request: https://github.com/apache/thrift/pull/833#issuecomment-179546686 @dimiro1 - if you have a chance to review, I'd be grateful. This is re #785 and a test hang under `make check` that I bisected to it. --- If your project is set up

[jira] [Commented] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131412#comment-15131412 ] John Sirois commented on THRIFT-3597: - I can't find how to self-assign but I have a patch and will

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131416#comment-15131416 ] John Sirois commented on THRIFT-3583: - THRIFT-3597 doesn't really block, but hit this one too and

[GitHub] thrift pull request: Fix hang in go tests.

2016-02-03 Thread jsirois
GitHub user jsirois opened a pull request: https://github.com/apache/thrift/pull/833 Fix hang in go tests. Previously tests would hang in a forground call to `server.Serve()`. Kill this call since `server.Listen(); go server.AcceptLoop()` is already performed and is the

[PROPOSAL] Have jenkins run `make check`

2016-02-03 Thread John Sirois
In the course of working on a new feature for thrift java, I rebased against master and hit a test hang runing `make check`. I tracked this down and have a fix out [1], but I was curious how this hang slipped by. I happen to have jenkins rights through Apache Aurora to view the job configuration

[jira] [Commented] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131433#comment-15131433 ] John Sirois commented on THRIFT-3597: - [~dimi...@gmail.com], if you have a chance to review

Re: [PROPOSAL] Have jenkins run `make check`

2016-02-03 Thread John Sirois
On Wed, Feb 3, 2016 at 5:33 PM, John Sirois wrote: > In the course of working on a new feature for thrift java, I rebased > against master and hit a test hang runing `make check`. I tracked this > down and have a fix out [1], but I was curious how this hang slipped by. I >

[jira] [Commented] (THRIFT-3578) Make THeaderTransport detect TCompact framed and unframed

2016-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131458#comment-15131458 ] ASF GitHub Bot commented on THRIFT-3578: Github user jsirois commented on the pull request:

[GitHub] thrift pull request: THRIFT-3578 Make THeaderTransport detect TCom...

2016-02-03 Thread jsirois
Github user jsirois commented on the pull request: https://github.com/apache/thrift/pull/819#issuecomment-179552975 @nsuke - could you kill the 2 hung shards in https://travis-ci.org/apache/thrift/builds/106198835 ? They >24hrs old and are blocking the Apache TravisCI pipeline

[jira] [Comment Edited] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131518#comment-15131518 ] John Sirois edited comment on THRIFT-3597 at 2/4/16 1:31 AM: - [~nsuke] - I

[jira] [Commented] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131518#comment-15131518 ] John Sirois commented on THRIFT-3597: - [~nsuke] - I think this is the real fix for your paper-over

[GitHub] thrift pull request: `make check` hangs in go tests

2016-02-03 Thread jsirois
Github user jsirois commented on the pull request: https://github.com/apache/thrift/pull/833#issuecomment-179569186 Looks like python tests are broken or flaky: https://travis-ci.org/apache/thrift/jobs/106875786 ``` .

Build failed in Jenkins: Thrift-precommit #32

2016-02-03 Thread Apache Jenkins Server
See -- [...truncated 4202 lines...] Making all in py make[3]: Entering directory ` ../../compiler/cpp/thrift --gen py -r

Re: [PROPOSAL] Have jenkins run `make check`

2016-02-03 Thread John Sirois
I did some more digging on the `make check` hang I encountered which led to this proposal. The originating github PR actually failed TravisCI in the go shard with exactly this same hang: https://travis-ci.org/apache/thrift/jobs/101493938 I'm an Apache Thrift dev newcomer (though long-time user

[jira] [Commented] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131432#comment-15131432 ] John Sirois commented on THRIFT-3597: - https://github.com/apache/thrift/pull/833 > `make check`

[jira] [Commented] (THRIFT-3599) Validate client IP address against cert's SubjectAltName

2016-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131795#comment-15131795 ] ASF GitHub Bot commented on THRIFT-3599: GitHub user nsuke opened a pull request:

[jira] [Commented] (THRIFT-2103) [python] Support for SSL certificates with Subject Alternative Names

2016-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131794#comment-15131794 ] ASF GitHub Bot commented on THRIFT-2103: GitHub user nsuke opened a pull request:

[GitHub] thrift pull request: THRIFT-3599 Validate client IP address agains...

2016-02-03 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/835 THRIFT-3599 Validate client IP address against cert's SubjectAltName https://issues.apache.org/jira/browse/THRIFT-3599 You can merge this pull request into a Git repository by running: $ git

[GitHub] thrift pull request: THRIFT-2103 [python] Support for SSL certific...

2016-02-03 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/834 THRIFT-2103 [python] Support for SSL certificates with Subject Altern… …ative Names https://issues.apache.org/jira/browse/THRIFT-2103 You can merge this pull request into a Git

Build failed in Jenkins: Thrift-precommit #33

2016-02-03 Thread Apache Jenkins Server
See Changes: [nsuke] THRIFT-2103 [python] Support for SSL certificates with Subject [nsuke] THRIFT-3599 Validate client IP address against cert's SubjectAltName -- [...truncated 4116 lines...]

[jira] [Commented] (THRIFT-3599) Validate client IP address against cert's SubjectAltName

2016-02-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131833#comment-15131833 ] Hudson commented on THRIFT-3599: FAILURE: Integrated in Thrift-precommit #33 (See

[jira] [Commented] (THRIFT-2103) [python] Support for SSL certificates with Subject Alternative Names

2016-02-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131834#comment-15131834 ] Hudson commented on THRIFT-2103: FAILURE: Integrated in Thrift-precommit #33 (See

[jira] [Resolved] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3597. -- Resolution: Fixed Assignee: John Sirois Fix Version/s: 0.9.4 Committed, it's

[jira] [Resolved] (THRIFT-3596) Better conformance to PEP8

2016-02-03 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3596. -- Resolution: Fixed Assignee: Aki Sukegawa Fix Version/s: 0.9.4 > Better

[jira] [Assigned] (THRIFT-2103) [python] Support for SSL certificates with Subject Alternative Names

2016-02-03 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa reassigned THRIFT-2103: Assignee: Aki Sukegawa > [python] Support for SSL certificates with Subject Alternative

[jira] [Created] (THRIFT-3598) TBufferedTransport doesn't instantiate client connection

2016-02-03 Thread Phongphan Phuttha (JIRA)
Phongphan Phuttha created THRIFT-3598: - Summary: TBufferedTransport doesn't instantiate client connection Key: THRIFT-3598 URL: https://issues.apache.org/jira/browse/THRIFT-3598 Project: Thrift

[GitHub] thrift pull request: THRIFT-3596 Better conformance to PEP8

2016-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: `make check` hangs in go tests

2016-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/833 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3596) Better conformance to PEP8

2016-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131758#comment-15131758 ] ASF GitHub Bot commented on THRIFT-3596: Github user asfgit closed the pull request at:

[jira] [Created] (THRIFT-3599) Validate client IP address against cert's SubjectAltName

2016-02-03 Thread Aki Sukegawa (JIRA)
Aki Sukegawa created THRIFT-3599: Summary: Validate client IP address against cert's SubjectAltName Key: THRIFT-3599 URL: https://issues.apache.org/jira/browse/THRIFT-3599 Project: Thrift

[GitHub] thrift pull request: THRIFT-3585 Lua: compact protocol implement o...

2016-02-03 Thread mygityf
Github user mygityf commented on the pull request: https://github.com/apache/thrift/pull/828#issuecomment-179694517 Tested with test/lua/test_basic_client.lua and test_basic_server.lua, result is expected. new comment(df693bf) added for the bug. --- If your project is set up for

[jira] [Commented] (THRIFT-3585) compact protocol implement of lua for thrift.

2016-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131881#comment-15131881 ] ASF GitHub Bot commented on THRIFT-3585: Github user mygityf commented on the pull request: