[jira] [Created] (THRIFT-3627) Missing basic code style consistency of JavaScript.

Kazuki Matsuda created THRIFT-3627: -- Summary: Missing basic code style consistency of JavaScript. Key: THRIFT-3627 URL: https://issues.apache.org/jira/browse/THRIFT-3627 Project: Thrift

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145924#comment-15145924 ] ASF GitHub Bot commented on THRIFT-3627: GitHub user kazuki-ma opened a pull request:

[GitHub] thrift pull request: THRIFT-3627 fix missing basic code style cons...

GitHub user kazuki-ma opened a pull request: https://github.com/apache/thrift/pull/858 THRIFT-3627 fix missing basic code style consistency of JavaScript. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kazuki-ma/thrift

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145948#comment-15145948 ] Hudson commented on THRIFT-3627: SUCCESS: Integrated in Thrift-precommit #118 (See

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145953#comment-15145953 ] Aki Sukegawa commented on THRIFT-3627: -- +1 for white space changes, as git history pollution can be

[GitHub] thrift pull request: THRIFT-3627 fix missing basic code style cons...

Github user kazuki-ma closed the pull request at: https://github.com/apache/thrift/pull/858 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3627 fix missing basic code style cons...

GitHub user kazuki-ma reopened a pull request: https://github.com/apache/thrift/pull/858 THRIFT-3627 fix missing basic code style consistency of JavaScript. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kazuki-ma/thrift

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145960#comment-15145960 ] ASF GitHub Bot commented on THRIFT-3627: Github user kazuki-ma closed the pull request at:

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145961#comment-15145961 ] ASF GitHub Bot commented on THRIFT-3627: GitHub user kazuki-ma reopened a pull request:

[jira] [Commented] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145968#comment-15145968 ] Jake Farrell commented on THRIFT-3620: -- +1 to adding the exec script for jenkins to

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145977#comment-15145977 ] Hudson commented on THRIFT-3627: SUCCESS: Integrated in Thrift-precommit #120 (See

[GitHub] thrift pull request: THRIFT-3623 Fix cpp/lib/test/TSSLSocketInterr...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/854#discussion_r52828211 --- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp --- @@ -91,8 +90,6 @@ BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL); BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL)

[jira] [Commented] (THRIFT-3623) Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145980#comment-15145980 ] ASF GitHub Bot commented on THRIFT-3623: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3617 cmake: include `gv` and `xml` gen...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3621 Fix lib/cpp/test/SecurityTest.cpp...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/853 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3625 Kill unused #include "TestPortFix...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/856 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3612 Add Python C extension for compac...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/844 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3613 Port Python C extension to Python...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/845 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3625) Kill unused #include "TestPortFixture.h" in lib/cpp/test/TServerTransportTest.cpp.

[ https://issues.apache.org/jira/browse/THRIFT-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145987#comment-15145987 ] ASF GitHub Bot commented on THRIFT-3625: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3621) Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145985#comment-15145985 ] ASF GitHub Bot commented on THRIFT-3621: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3613) Port Python C extension to Python 3

[ https://issues.apache.org/jira/browse/THRIFT-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145988#comment-15145988 ] ASF GitHub Bot commented on THRIFT-3613: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3617) CMake does not build gv/xml generators

[ https://issues.apache.org/jira/browse/THRIFT-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145983#comment-15145983 ] ASF GitHub Bot commented on THRIFT-3617: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3618) Python TSSLSocket deprecation message should print caller's location

[ https://issues.apache.org/jira/browse/THRIFT-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145986#comment-15145986 ] ASF GitHub Bot commented on THRIFT-3618: Github user asfgit closed the pull request at:

[jira] [Updated] (THRIFT-3617) CMake does not build gv/xml generators

[ https://issues.apache.org/jira/browse/THRIFT-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa updated THRIFT-3617: - Assignee: Stig Bakken > CMake does not build gv/xml generators >

[jira] [Resolved] (THRIFT-3617) CMake does not build gv/xml generators

[ https://issues.apache.org/jira/browse/THRIFT-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3617. -- Resolution: Fixed Fix Version/s: 0.9.4 committed, thanks ! > CMake does not build

[jira] [Resolved] (THRIFT-3621) Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3621. -- Resolution: Fixed Fix Version/s: 0.9.4 committed, thanks ! > Fix

[jira] [Resolved] (THRIFT-3625) Kill unused #include "TestPortFixture.h" in lib/cpp/test/TServerTransportTest.cpp.

[ https://issues.apache.org/jira/browse/THRIFT-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3625. -- Resolution: Fixed Fix Version/s: 0.9.4 committed, thanks ! > Kill unused #include

[jira] [Commented] (THRIFT-1805) Thrift should not swallow ALL exceptions

[ https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146005#comment-15146005 ] Jens Geyer commented on THRIFT-1805: I said very intentionally "*last* line of defense" and "catch

Build failed in Jenkins: Thrift-precommit #121

See Changes: [roshan] THRIFT-2877 Generate hashCode using primitives and static utility [roshan] THRIFT-2877 simplify hashcode generation [roshan] THRIFT-2877 use original long hashCode [roshan] TYPE_BYTE is now TYPE_I8 [roshan]

[jira] [Commented] (THRIFT-2877) Optimize generated hashCode

[ https://issues.apache.org/jira/browse/THRIFT-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146104#comment-15146104 ] Hudson commented on THRIFT-2877: FAILURE: Integrated in Thrift-precommit #121 (See

[GitHub] thrift pull request: THRIFT-2877 Generate hashCode using primitive...

Github user roshan commented on the pull request: https://github.com/apache/thrift/pull/448#issuecomment-183718878 Thanks for the comments, @nsuke . I will squash after builds pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (THRIFT-2877) Optimize generated hashCode

[ https://issues.apache.org/jira/browse/THRIFT-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146113#comment-15146113 ] ASF GitHub Bot commented on THRIFT-2877: Github user roshan commented on the pull request:

Build failed in Jenkins: thrift #604

See Changes: [nsuke] THRIFT-3617 cmake: include `gv` and `xml` generators in build Client: [nsuke] THRIFT-3612 Add Python C extension for compact protocol Client: Python [nsuke] THRIFT-3613 Port Python C extension to Python 3 Client:

[jira] [Commented] (THRIFT-3621) Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146132#comment-15146132 ] Hudson commented on THRIFT-3621: SUCCESS: Integrated in Thrift-precommit #122 (See

[jira] [Commented] (THRIFT-3612) Add Python C extension for compact protocol

[ https://issues.apache.org/jira/browse/THRIFT-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146131#comment-15146131 ] Hudson commented on THRIFT-3612: SUCCESS: Integrated in Thrift-precommit #122 (See

[jira] [Commented] (THRIFT-3613) Port Python C extension to Python 3

[ https://issues.apache.org/jira/browse/THRIFT-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146129#comment-15146129 ] Hudson commented on THRIFT-3613: SUCCESS: Integrated in Thrift-precommit #122 (See

[jira] [Commented] (THRIFT-3618) Python TSSLSocket deprecation message should print caller's location

[ https://issues.apache.org/jira/browse/THRIFT-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146127#comment-15146127 ] Hudson commented on THRIFT-3618: SUCCESS: Integrated in Thrift-precommit #122 (See

[jira] [Commented] (THRIFT-3617) CMake does not build gv/xml generators

[ https://issues.apache.org/jira/browse/THRIFT-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146128#comment-15146128 ] Hudson commented on THRIFT-3617: SUCCESS: Integrated in Thrift-precommit #122 (See

[GitHub] thrift pull request: THRIFT-3623 Fix cpp/lib/test/TSSLSocketInterr...

Github user jsirois commented on a diff in the pull request: https://github.com/apache/thrift/pull/854#discussion_r52832288 --- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp --- @@ -91,8 +90,6 @@ BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL); BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL)

[jira] [Created] (THRIFT-3628) Fix lib/cpp/test/TServerIntegrationTest.cpp to use ephemeral ports

John Sirois created THRIFT-3628: --- Summary: Fix lib/cpp/test/TServerIntegrationTest.cpp to use ephemeral ports Key: THRIFT-3628 URL: https://issues.apache.org/jira/browse/THRIFT-3628 Project: Thrift

[GitHub] thrift pull request: THRIFT-3628 Fix lib/cpp/test/TServerIntegrati...

GitHub user jsirois opened a pull request: https://github.com/apache/thrift/pull/859 THRIFT-3628 Fix lib/cpp/test/TServerIntegrationTest.cpp to use epheme… …ral ports. This was already the case for most of the suite, which, besides the one fixed constructor,

[jira] [Commented] (THRIFT-3628) Fix lib/cpp/test/TServerIntegrationTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146152#comment-15146152 ] ASF GitHub Bot commented on THRIFT-3628: GitHub user jsirois opened a pull request:

[jira] [Commented] (THRIFT-3626) Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral ports.

[ https://issues.apache.org/jira/browse/THRIFT-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146159#comment-15146159 ] Hudson commented on THRIFT-3626: SUCCESS: Integrated in Thrift-precommit #123 (See

[jira] [Commented] (THRIFT-3624) Fix lib/cpp/test/TServerSocketTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146167#comment-15146167 ] Hudson commented on THRIFT-3624: SUCCESS: Integrated in Thrift-precommit #124 (See

[jira] [Commented] (THRIFT-3624) Fix lib/cpp/test/TServerSocketTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146171#comment-15146171 ] Hudson commented on THRIFT-3624: SUCCESS: Integrated in Thrift-precommit #126 (See

[jira] [Commented] (THRIFT-3621) Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146170#comment-15146170 ] Hudson commented on THRIFT-3621: SUCCESS: Integrated in Thrift-precommit #125 (See

[jira] [Commented] (THRIFT-3623) Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146172#comment-15146172 ] John Sirois commented on THRIFT-3623: - CI went green here:

Build failed in Jenkins: Thrift-precommit #127

See Changes: [jsirois] THRIFT-3628 Fix lib/cpp/test/TServerIntegrationTest.cpp to use ephemeral -- [...truncated 44337 lines...] /bin/bash ../../../libtool --tag=CXX --mode=compile g++

[jira] [Commented] (THRIFT-3628) Fix lib/cpp/test/TServerIntegrationTest.cpp to use ephemeral ports

[ https://issues.apache.org/jira/browse/THRIFT-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146174#comment-15146174 ] Hudson commented on THRIFT-3628: FAILURE: Integrated in Thrift-precommit #127 (See

[jira] [Assigned] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

[ https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reassigned THRIFT-3622: --- Assignee: John Sirois > Fix deprecated uses of std::auto_ptr >

[GitHub] thrift pull request: THRIFT-3622 Fix deprecated uses of std::auto_...

GitHub user jsirois opened a pull request: https://github.com/apache/thrift/pull/860 THRIFT-3622 Fix deprecated uses of std::auto_ptr You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsirois/thrift THRIFT-3622 Alternatively you

[jira] [Commented] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

[ https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146180#comment-15146180 ] ASF GitHub Bot commented on THRIFT-3622: GitHub user jsirois opened a pull request:

[GitHub] thrift pull request: THRIFT-2877 Generate hashCode using primitive...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/448#discussion_r52825710 --- Diff: compiler/cpp/src/generate/t_java_generator.cc --- @@ -1886,24 +1889,57 @@ void t_java_generator::generate_java_struct_equality(ofstream& out,

[GitHub] thrift pull request: THRIFT-2877 Generate hashCode using primitive...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/448#discussion_r52825719 --- Diff: compiler/cpp/src/generate/t_java_generator.cc --- @@ -1886,24 +1889,57 @@ void t_java_generator::generate_java_struct_equality(ofstream& out,

[jira] [Commented] (THRIFT-2877) Optimize generated hashCode

[ https://issues.apache.org/jira/browse/THRIFT-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145903#comment-15145903 ] ASF GitHub Bot commented on THRIFT-2877: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-2877 Generate hashCode using primitive...

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/448#issuecomment-183632632 @roshan I've added comments on minor points. Other than that I think we're good to proceed :+1: --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (THRIFT-2877) Optimize generated hashCode

[ https://issues.apache.org/jira/browse/THRIFT-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145904#comment-15145904 ] ASF GitHub Bot commented on THRIFT-2877: Github user nsuke commented on the pull request:

[jira] [Commented] (THRIFT-2877) Optimize generated hashCode

[ https://issues.apache.org/jira/browse/THRIFT-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145899#comment-15145899 ] ASF GitHub Bot commented on THRIFT-2877: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-2877 Generate hashCode using primitive...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/448#discussion_r52825674 --- Diff: compiler/cpp/src/generate/t_java_generator.cc --- @@ -1886,24 +1889,57 @@ void t_java_generator::generate_java_struct_equality(ofstream& out,

[GitHub] thrift pull request: THRIFT-2877 Generate hashCode using primitive...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/448#discussion_r52825698 --- Diff: compiler/cpp/src/generate/t_java_generator.cc --- @@ -1886,24 +1889,57 @@ void t_java_generator::generate_java_struct_equality(ofstream& out,

[jira] [Commented] (THRIFT-2877) Optimize generated hashCode

[ https://issues.apache.org/jira/browse/THRIFT-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145901#comment-15145901 ] ASF GitHub Bot commented on THRIFT-2877: Github user nsuke commented on a diff in the pull

Jenkins build is back to normal : Thrift-precommit #128

See

[jira] [Commented] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

[ https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146218#comment-15146218 ] John Sirois commented on THRIFT-3622: - CI went green here:

[jira] [Created] (THRIFT-3629) Parser sets exitcode on errors, but generator does not

Jens Geyer created THRIFT-3629: -- Summary: Parser sets exitcode on errors, but generator does not Key: THRIFT-3629 URL: https://issues.apache.org/jira/browse/THRIFT-3629 Project: Thrift Issue

[jira] [Reopened] (THRIFT-3362) make check fails for C++ at the SecurityTest

[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reopened THRIFT-3362: Assignee: John Sirois (was: James E. King, III) > make check fails for C++ at the SecurityTest

[jira] [Closed] (THRIFT-3362) make check fails for C++ at the SecurityTest

[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-3362. -- Works for me. > make check fails for C++ at the SecurityTest >

[jira] [Closed] (THRIFT-3362) make check fails for C++ at the SecurityTest

[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-3362. -- Resolution: Fixed Fix Version/s: 1.0 > make check fails for C++ at the SecurityTest >

[jira] [Commented] (THRIFT-3605) Have the compiler complain about invalid arguments and options

[ https://issues.apache.org/jira/browse/THRIFT-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146287#comment-15146287 ] ASF GitHub Bot commented on THRIFT-3605: GitHub user Jens-G opened a pull request:

[jira] [Commented] (THRIFT-3629) Parser sets exitcode on errors, but generator does not

[ https://issues.apache.org/jira/browse/THRIFT-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146286#comment-15146286 ] ASF GitHub Bot commented on THRIFT-3629: GitHub user Jens-G opened a pull request:

[GitHub] thrift pull request: THRIFT-3629 Parser sets exitcode on errors, b...

GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/861 THRIFT-3629 Parser sets exitcode on errors, but generator does not Client: Compiler (general) Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-3605) Have the compiler complain about invalid arguments and options

[ https://issues.apache.org/jira/browse/THRIFT-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146292#comment-15146292 ] Jens Geyer commented on THRIFT-3605: A few comments: - A few generators did not document all

Build failed in Jenkins: Thrift-precommit #131

See Changes: [jensg] THRIFT-3605 Have the compiler complain about invalid arguments and -- [...truncated 3463 lines...] [javac] /thrift/lib/java/src/org/apache/thrift/TUnion.java:217:

[jira] [Commented] (THRIFT-3629) Parser sets exitcode on errors, but generator does not

[ https://issues.apache.org/jira/browse/THRIFT-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146295#comment-15146295 ] Hudson commented on THRIFT-3629: FAILURE: Integrated in Thrift-precommit #130 (See

[jira] [Commented] (THRIFT-3605) Have the compiler complain about invalid arguments and options

[ https://issues.apache.org/jira/browse/THRIFT-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146296#comment-15146296 ] Hudson commented on THRIFT-3605: FAILURE: Integrated in Thrift-precommit #131 (See

Build failed in Jenkins: Thrift-precommit #135

See -- GitHub pull request #863 to apache/thrift GitHub pull request #863 to apache/thrift [EnvInject] - Loading node environment variables. Building remotely on H10 (docker Ubuntu ubuntu yahoo-not-h2)

Build failed in Jenkins: Thrift-precommit #133

See Changes: [jensg] THRIFT-3605 Have the compiler complain about invalid arguments and -- [...truncated 3462 lines...] [javac] S extends IScheme declared in method getScheme()

Jenkins build is back to normal : Thrift-precommit #132

See

[jira] [Updated] (THRIFT-3630) Debian/Ubuntu install docs need an update

[ https://issues.apache.org/jira/browse/THRIFT-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy updated THRIFT-3630: Attachment: 0001-THRIFT-3630-Debian-and-Ubuntu-install-docs-update.patch patch >

[jira] [Commented] (THRIFT-3605) Have the compiler complain about invalid arguments and options

[ https://issues.apache.org/jira/browse/THRIFT-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146306#comment-15146306 ] Hudson commented on THRIFT-3605: FAILURE: Integrated in Thrift-precommit #133 (See

[jira] [Commented] (THRIFT-3631) JSON protocol implementation for Lua

[ https://issues.apache.org/jira/browse/THRIFT-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146367#comment-15146367 ] ASF GitHub Bot commented on THRIFT-3631: GitHub user mygityf reopened a pull request:

[GitHub] thrift pull request: THRIFT-3631 Lua-This is JSON protocol impleme...

GitHub user mygityf reopened a pull request: https://github.com/apache/thrift/pull/863 THRIFT-3631 Lua-This is JSON protocol implement for thrift-lua library. TJsonProtocol.lua is new source of lua for thrift JSON protocol. Test result is expected of test_basic_server.lua,

[GitHub] thrift pull request: THRIFT-3631 Lua-This is JSON protocol impleme...

Github user mygityf closed the pull request at: https://github.com/apache/thrift/pull/863 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3631) JSON protocol implementation for Lua

[ https://issues.apache.org/jira/browse/THRIFT-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146365#comment-15146365 ] ASF GitHub Bot commented on THRIFT-3631: Github user mygityf closed the pull request at:

[jira] [Resolved] (THRIFT-3630) Debian/Ubuntu install docs need an update

[ https://issues.apache.org/jira/browse/THRIFT-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy resolved THRIFT-3630. - Resolution: Fixed committed > Debian/Ubuntu install docs need an update >

[jira] [Commented] (THRIFT-3605) Have the compiler complain about invalid arguments and options

[ https://issues.apache.org/jira/browse/THRIFT-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146331#comment-15146331 ] Hudson commented on THRIFT-3605: SUCCESS: Integrated in Thrift-precommit #134 (See

[jira] [Commented] (THRIFT-3631) JSON protocol implementation for Lua

[ https://issues.apache.org/jira/browse/THRIFT-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146368#comment-15146368 ] WangYaofu commented on THRIFT-3631: --- pull request:

[jira] [Created] (THRIFT-3630) Debian/Ubuntu install docs need an update

Randy Abernethy created THRIFT-3630: --- Summary: Debian/Ubuntu install docs need an update Key: THRIFT-3630 URL: https://issues.apache.org/jira/browse/THRIFT-3630 Project: Thrift Issue Type:

Build failed in Jenkins: Thrift-Compiler-Windows #1946

See Changes: [ra] THRIFT-3630:Debian and Ubuntu install docs update Client: Docs Patch: -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

[GitHub] thrift pull request: THRIFT-3631 Lua-This is JSON protocol impleme...

GitHub user mygityf opened a pull request: https://github.com/apache/thrift/pull/863 THRIFT-3631 Lua-This is JSON protocol implement for thrift-lua library. TJsonProtocol.lua is new source of lua for thrift JSON protocol. Test result is expected of test_basic_server.lua,

[jira] [Commented] (THRIFT-3631) JSON protocol implementation for Lua

[ https://issues.apache.org/jira/browse/THRIFT-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146363#comment-15146363 ] ASF GitHub Bot commented on THRIFT-3631: GitHub user mygityf opened a pull request:

Jenkins build is back to normal : Thrift-precommit #134

See