[
https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175796#comment-16175796
]
ASF GitHub Bot commented on THRIFT-4251:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1313
It means nobody replied to my requests for comments, so I assumed nobody
has an issue or nobody cares; whatever the case, I committed it to the
project. :)
On Thu, Sep 21, 2017 at
[
https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175786#comment-16175786
]
ASF GitHub Bot commented on THRIFT-4251:
Github user xiaohu-zhang commented on the issue:
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/thrift/pull/1313
MY english is poor. could you please explain what is the it's been crickets
mean ? thank you very much!
---
Github user Heromyth commented on the issue:
https://github.com/apache/thrift/pull/1263
So sad, there is a bug in phobos64.lib. It will make the examples failed.
---
Github user djzort commented on the issue:
https://github.com/apache/thrift/pull/1261
I will get to it :)
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1367
@dhull thank you! Now we just need a Jira item for the change, and
hopefully it sails through CI.
---
Github user dhull commented on the issue:
https://github.com/apache/thrift/pull/1367
This fix looks correct to me. The `read` and `read_exact` functions both
pull the wrapped transport out of their state, and need to put the updated
wrapped transport back into their state on return.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1261
Post the Jira issue (THRIFT-) in here when you have one as well -
thanks.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1367
Thanks for the fix - changes need a Jira ticket so we can track them
through release notes. See:
https://thrift.apache.org/docs/HowToContribute
Thanks!
---
Anthony Molinaro created THRIFT-4339:
Summary: Thrift Framed Transport in Erlang crashes server when
client disconnects
Key: THRIFT-4339
URL: https://issues.apache.org/jira/browse/THRIFT-4339
GitHub user djnym opened a pull request:
https://github.com/apache/thrift/pull/1367
Fix a crash on client close
When a client closes a connection to a framed server the server was
crashing because the fact that the transport was framed was being
lost. Looking through the
[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175524#comment-16175524
]
ASF GitHub Bot commented on THRIFT-4233:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175523#comment-16175523
]
ASF GitHub Bot commented on THRIFT-4326:
Github user benweint commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4233.
Resolution: Fixed
Fix Version/s: 0.11.0
> Make THsHaServer.invoker
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1366
---
Github user benweint commented on the issue:
https://github.com/apache/thrift/pull/1352
Ah, interesting! It looks like the nodejs tests are using a Ruby server as
part of some integration testing? I'll see if I can repro this failure locally
and figure out what's up. Thanks!
---
[
https://issues.apache.org/jira/browse/THRIFT-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175518#comment-16175518
]
ASF GitHub Bot commented on THRIFT-4326:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1352
@benweint so this error is reproducible in the ubuntu-xenial docker image,
and it looks like it is related to ruby and wasn't happening before, so it's
likely related to these changes.
```
[
https://issues.apache.org/jira/browse/THRIFT-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175459#comment-16175459
]
ASF GitHub Bot commented on THRIFT-4326:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1352
Ugh, clearly we STILL have some build issues. They are in js though. I'll
pull your commit into my local system and try to reproduce this build issue
and/or get a clean set of cross tests so I
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1253
---
[
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175455#comment-16175455
]
ASF GitHub Bot commented on THRIFT-3357:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-3357:
--
Assignee: James E. King, III
> Generate EnumSet/EnumMap where elements/keys
[
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3357.
Resolution: Fixed
Fix Version/s: 0.11.0
Committed, thanks.
> Generate
Github user dmvolod commented on the issue:
https://github.com/apache/thrift/pull/1366
@jeking3 , please review. The static is not acceptable to getInvoker as
invoker is not static context
---
[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175424#comment-16175424
]
ASF GitHub Bot commented on THRIFT-4233:
Github user dmvolod commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175405#comment-16175405
]
ASF GitHub Bot commented on THRIFT-4233:
Github user dmvolod commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175406#comment-16175406
]
ASF GitHub Bot commented on THRIFT-4233:
Github user dmvolod closed the pull request at:
Github user dmvolod closed the pull request at:
https://github.com/apache/thrift/pull/1294
---
Github user dmvolod commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1294#discussion_r140350410
--- Diff: lib/java/src/org/apache/thrift/server/THsHaServer.java ---
@@ -154,7 +154,10 @@ protected static ExecutorService
createInvokerPool(Args options)
[
https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175366#comment-16175366
]
ASF GitHub Bot commented on THRIFT-4187:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1263
@Heromyth any progress on this?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
This pull request needs to be completed. *nudge*
---
[
https://issues.apache.org/jira/browse/THRIFT-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175364#comment-16175364
]
ASF GitHub Bot commented on THRIFT-4206:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1273
Could you rebase on master and refresh the PR so we get a clean build, now
that CI is stable again? Thanks.
---
[
https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175362#comment-16175362
]
ASF GitHub Bot commented on THRIFT-4207:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1274
Could you rebase on master and refresh the PR so we get a clean build, now
that CI is stable again? Thanks.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1289
Could you open a Jira ticker for this?
https://thrift.apache.org/docs/HowToContribute
Also could you rebase on master and refresh the PR so we get a clean build,
now that CI is
[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175358#comment-16175358
]
ASF GitHub Bot commented on THRIFT-4233:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1294#discussion_r140344024
--- Diff: lib/java/src/org/apache/thrift/server/THsHaServer.java ---
@@ -154,7 +154,10 @@ protected static ExecutorService
createInvokerPool(Args options)
[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4233:
--
Assignee: James E. King, III
> Make THsHaServer.invoker available (get method
[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4233:
---
Priority: Minor (was: Major)
> Make THsHaServer.invoker available (get method only)
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1306
@wenshin first of all my apologies for having no comments or interactions
since you submitted the PR a month ago. As you may have seen we had some CI
build issues which are now resolved, and your
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1311
@davinchia we've cleared out the CI build issues, so if you could squash
your changes to one commit then rebase on master, then do a force push to
refresh this pull request, it'll kick off a new
[
https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175340#comment-16175340
]
ASF GitHub Bot commented on THRIFT-4251:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4251:
---
Summary: Java Epoll Selector Bug (was: Epoll Selector Bug)
> Java Epoll Selector
[
https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4251.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1313
---
[
https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175313#comment-16175313
]
ASF GitHub Bot commented on THRIFT-4251:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1313
So I asked on the mailing list and it's been crickets, so I'm going to
merge this. It passed all the tests.
---
[
https://issues.apache.org/jira/browse/THRIFT-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175116#comment-16175116
]
ASF GitHub Bot commented on THRIFT-4326:
Github user benweint commented on the issue:
Github user benweint commented on the issue:
https://github.com/apache/thrift/pull/1352
Yup, rebased!
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1315
@norrs now that the CI builds have been stabilized, if you could rebase on
master and refresh this PR, we'll try to get a clean build out of it.
---
[
https://issues.apache.org/jira/browse/THRIFT-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175115#comment-16175115
]
ASF GitHub Bot commented on THRIFT-4264:
Github user jeking3 commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1333
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1318
@Jens-G does the current cross suite exercise asynchronous sufficiently to
test these changes?
---
[
https://issues.apache.org/jira/browse/THRIFT-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175111#comment-16175111
]
ASF GitHub Bot commented on THRIFT-4287:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4287:
--
Assignee: James E. King, III
> Add c++ compiler "no_skeleton" flag option
>
[
https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175104#comment-16175104
]
ASF GitHub Bot commented on THRIFT-4288:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1334
@Equim-chan now that the CI build environment has been stabilized, could
you rebase on master and refresh this PR so we can get a clean build on it?
Thanks.
---
[
https://issues.apache.org/jira/browse/THRIFT-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175099#comment-16175099
]
ASF GitHub Bot commented on THRIFT-4309:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1339
@cclauss now that the CI build issues should be squared away, could you
rebase on master so we get another CI build? Thanks.
---
[
https://issues.apache.org/jira/browse/THRIFT-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4327.
Resolution: Fixed
Fix Version/s: 0.11.0
> Improve TimerManager API to allow
[
https://issues.apache.org/jira/browse/THRIFT-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175098#comment-16175098
]
ASF GitHub Bot commented on THRIFT-4326:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4327:
---
Priority: Minor (was: Major)
> Improve TimerManager API to allow removing specific
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1352
@benweint would you be able to rebase on master? The CI build issues
should be resolved now.
---
[
https://issues.apache.org/jira/browse/THRIFT-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175095#comment-16175095
]
ASF GitHub Bot commented on THRIFT-4327:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1353
---
[
https://issues.apache.org/jira/browse/THRIFT-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4338:
---
Environment: docker ubuntu-xenial, autoconf build (was: docker
ubuntu-xenial)
>
James E. King, III created THRIFT-4338:
--
Summary: c_glib config.h header leaking into lib/cpp build and
others
Key: THRIFT-4338
URL: https://issues.apache.org/jira/browse/THRIFT-4338
Project:
[
https://issues.apache.org/jira/browse/THRIFT-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4327:
--
Assignee: James E. King, III
> Improve TimerManager API to allow removing
[
https://issues.apache.org/jira/browse/THRIFT-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175033#comment-16175033
]
ASF GitHub Bot commented on THRIFT-4232:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4232.
Resolution: Fixed
Fix Version/s: 0.11.0
> ./configure does bad ant version
[
https://issues.apache.org/jira/browse/THRIFT-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4232:
--
Assignee: James E. King, III
> ./configure does bad ant version check
>
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1354
---
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175028#comment-16175028
]
ASF GitHub Bot commented on THRIFT-4329:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
Now that the build issues seem to be out of the way, I've merged the
previous 3 PRs from you and I'd ask that you squash and rebase this on the
current master and submit it again. I'd like to see
[
https://issues.apache.org/jira/browse/THRIFT-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4212:
---
Affects Version/s: (was: 1.0)
0.10.0
> c_glib flush tries
[
https://issues.apache.org/jira/browse/THRIFT-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175020#comment-16175020
]
ASF GitHub Bot commented on THRIFT-4212:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4212.
Resolution: Fixed
Merged - thanks.
> c_glib flush tries to close SSL even if
[
https://issues.apache.org/jira/browse/THRIFT-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4212:
---
Fix Version/s: (was: 1.0)
0.11.0
> c_glib flush tries to
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1279
---
[
https://issues.apache.org/jira/browse/THRIFT-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Volodin updated THRIFT-4337:
---
Fix Version/s: (was: 1.0)
> Able to set keyStore and trustStore as InputStream in the
>
Dmitry Volodin created THRIFT-4337:
--
Summary: Able to set keyStore and trustStore as InputStream in the
TSSLTransportFactory.TSSLTransportParameters
Key: THRIFT-4337
URL:
[
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174935#comment-16174935
]
ASF GitHub Bot commented on THRIFT-4211:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1278
---
[
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4211.
Resolution: Fixed
Fix Version/s: 0.11.0
Merged.
> Fix GError glib
[
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4211:
---
Fix Version/s: (was: 1.0)
> Fix GError glib management under Thrift
>
[
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174927#comment-16174927
]
ASF GitHub Bot commented on THRIFT-4205:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4205.
Resolution: Fixed
Merged.
> c_glib is not linking against glib + gobject
>
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1272
---
[
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4205:
---
Affects Version/s: (was: 1.0)
0.10.0
> c_glib is not
[
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4205:
---
Fix Version/s: (was: 1.0)
0.11.0
> c_glib is not linking
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174844#comment-16174844
]
Can Celasun commented on THRIFT-4285:
-
Just had a chance to review. The patch doesn't apply cleanly
[
https://issues.apache.org/jira/browse/THRIFT-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4104:
--
Assignee: (was: James E. King, III)
> Add a CI build job that runs
[
https://issues.apache.org/jira/browse/THRIFT-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4142:
--
Assignee: (was: James E. King, III)
> Add a functional test to check
[
https://issues.apache.org/jira/browse/THRIFT-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174832#comment-16174832
]
ASF GitHub Bot commented on THRIFT-4331:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1363
If you could do me a favor and rebase on the current master, I finally got
all the CI build issues resolved so I'd like to see a clean build before I
merge. There are some minor formatting
[
https://issues.apache.org/jira/browse/THRIFT-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4331:
---
Fix Version/s: (was: 0.10.0)
(was: 1.0)
> C++:
1 - 100 of 115 matches
Mail list logo
