[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174844#comment-16174844 ]
Can Celasun commented on THRIFT-4285: ------------------------------------- Just had a chance to review. The patch doesn't apply cleanly to {{master}} because {{mock_handler.go}} is now in {{.gitignore}}. I've manually fixed the patch and ran the tests, [all seems fine|https://travis-ci.org/dcelasun/thrift/builds/278182132] (failure is unrelated). [~Zariel] If you can update the patch, I think this is ready to merge. cc [~jensg] > Pull generated send/recv into library to allow behaviour to be customised > ------------------------------------------------------------------------- > > Key: THRIFT-4285 > URL: https://issues.apache.org/jira/browse/THRIFT-4285 > Project: Thrift > Issue Type: Improvement > Components: Go - Compiler, Go - Library > Reporter: Chris Bannister > Assignee: Chris Bannister > Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch, > 0001-go-pull-generated-send-recv-into-lib-v7.patch > > > Currently it is difficult to change how thrift writes messages onto the > transport because they are in the generated code. Instead the generated > send/recv methods should be in the library. This will greatly simplify the > client code and remove many duplicate methods whilst allowing users more > flexibility to implement connection pools and other features such as THeader. -- This message was sent by Atlassian JIRA (v6.4.14#64029)