[jira] [Commented] (THRIFT-5776) Cpp cross test fail

[ https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856676#comment-17856676 ] Carel commented on THRIFT-5776: --- [~sveneld] Can you maybe just confirm at least if this issue can be

[jira] [Comment Edited] (THRIFT-5773) UUID wrapper for C++

[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853789#comment-17853789 ] Carel edited comment on THRIFT-5773 at 6/10/24 7:30 PM: [~Triton] Again thank

[jira] [Commented] (THRIFT-5773) UUID wrapper for C++

[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853789#comment-17853789 ] Carel commented on THRIFT-5773: --- [~Triton] Again thank you for taking the time to provide feedback. I

[jira] [Commented] (THRIFT-5773) UUID wrapper for C++

[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853601#comment-17853601 ] Carel commented on THRIFT-5773: --- [~jensg] bq. Not sure what "consider" means Sorry I am just politely

[jira] [Comment Edited] (THRIFT-5773) UUID wrapper for C++

[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853533#comment-17853533 ] Carel edited comment on THRIFT-5773 at 6/9/24 7:48 PM: --- [~Triton] Thanks for your

[jira] [Commented] (THRIFT-5773) UUID wrapper for C++

[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853533#comment-17853533 ] Carel commented on THRIFT-5773: --- [~Triton] Thanks for your feedback. See my latest comments on my PR, I

[jira] [Closed] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

[ https://issues.apache.org/jira/browse/THRIFT-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carel closed THRIFT-5790. - Resolution: Invalid I see this was already fixed We are still using Thrift 0.17 and this was fixed in 0.19

[jira] [Commented] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

[ https://issues.apache.org/jira/browse/THRIFT-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850938#comment-17850938 ] Carel commented on THRIFT-5790: --- I will make a PR for this hopefully over the weekend, for now just making

[jira] [Commented] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

[ https://issues.apache.org/jira/browse/THRIFT-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850937#comment-17850937 ] Carel commented on THRIFT-5790: --- I also have notes of this warning happening but I suspect it does respect

[jira] [Updated] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

[ https://issues.apache.org/jira/browse/THRIFT-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carel updated THRIFT-5790: -- Description: When building a C++ application using MSVC (2019) the following warnings are raised:

[jira] [Created] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

Carel created THRIFT-5790: - Summary: Thrift headers raise compiler warnings on MSVC Key: THRIFT-5790 URL: https://issues.apache.org/jira/browse/THRIFT-5790 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-5773) UUID wrapper for C++

[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850913#comment-17850913 ] Carel commented on THRIFT-5773: --- [~Triton] [~jensg]  Any feedback on this? I am still not sure how to

[jira] [Commented] (THRIFT-5776) Cpp cross test fail

[ https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842843#comment-17842843 ] Carel commented on THRIFT-5776: --- [~sveneld] Which docker image are you using? I am using the

[jira] [Commented] (THRIFT-5773) UUID wrapper for C++

[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841769#comment-17841769 ] Carel commented on THRIFT-5773: --- [~jensg] Can you please look at this PR. It would be good if this can be

[jira] [Commented] (THRIFT-5776) Cpp cross test fail

[ https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841762#comment-17841762 ] Carel commented on THRIFT-5776: --- [~sveneld] It appears that my last (force)push on my branch fixed the

[jira] [Comment Edited] (THRIFT-5776) Cpp cross test fail

[ https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841690#comment-17841690 ] Carel edited comment on THRIFT-5776 at 4/28/24 6:56 PM: [~sveneld] [~jensg] -Any

[jira] [Commented] (THRIFT-5776) Cpp cross test fail

[ https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841690#comment-17841690 ] Carel commented on THRIFT-5776: --- [~sveneld] [~jensg] Any help on how to reproduce? I have made

[jira] [Commented] (THRIFT-5776) Cpp cross test fail

[ https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841519#comment-17841519 ] Carel commented on THRIFT-5776: --- [~sveneld] Looking into this. > Cpp cross test fail >

[jira] [Commented] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834790#comment-17834790 ] Carel commented on THRIFT-5772: --- I made a new ticket and associated PR for the TUuid wrapper: THRIFT-5773

[jira] [Created] (THRIFT-5773) UUID wrapper for C++

Carel created THRIFT-5773: - Summary: UUID wrapper for C++ Key: THRIFT-5773 URL: https://issues.apache.org/jira/browse/THRIFT-5773 Project: Thrift Issue Type: New Feature Reporter: Carel

[jira] [Commented] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834707#comment-17834707 ] Carel commented on THRIFT-5772: --- [~jensg] Thank you for the information and the links. I pushed a new

[jira] [Comment Edited] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833823#comment-17833823 ] Carel edited comment on THRIFT-5772 at 4/4/24 5:06 AM: --- I don't have a comment on

[jira] [Commented] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833823#comment-17833823 ] Carel commented on THRIFT-5772: --- I don't have a comment on the byte order yet, given the following

[jira] [Commented] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831968#comment-17831968 ] Carel commented on THRIFT-5772: --- I have updated the

[jira] [Commented] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831934#comment-17831934 ] Carel commented on THRIFT-5772: --- In my [wrapper PR|https://github.com/CJCombrink/thrift/pull/2] I made the

[jira] [Commented] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831565#comment-17831565 ] Carel commented on THRIFT-5772: --- My work for a wrapper is here:

[jira] [Commented] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831554#comment-17831554 ] Carel commented on THRIFT-5772: --- Quick response: # Wrapper class: Almost done, want to do a quick test

[jira] [Updated] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carel updated THRIFT-5772: -- Description: Starting the discussion to add UUID support for C++. I have started with an implementation (See

[jira] [Commented] (THRIFT-5772) Add UUID support for C++

[ https://issues.apache.org/jira/browse/THRIFT-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831510#comment-17831510 ] Carel commented on THRIFT-5772: --- This ticket probably belongs as a task on THRIFT-5587 > Add UUID support

[jira] [Created] (THRIFT-5772) Add UUID support for C++

Carel created THRIFT-5772: - Summary: Add UUID support for C++ Key: THRIFT-5772 URL: https://issues.apache.org/jira/browse/THRIFT-5772 Project: Thrift Issue Type: New Feature Reporter:

[jira] [Created] (THRIFT-5766) Replace std::endl with "\n"

Carel created THRIFT-5766: - Summary: Replace std::endl with "\n" Key: THRIFT-5766 URL: https://issues.apache.org/jira/browse/THRIFT-5766 Project: Thrift Issue Type: Improvement Components: