Re: [Announcement]: New Commiter: Nobuaki Sukegawa

2015-10-23 Thread Henrique Mendonça
Welcome Aki! On 23 Oct 2015 12:51 am, "Randy Abernethy" wrote: > Welcome Nobuaki Sukegawa! > > On Wed, Oct 21, 2015 at 9:41 PM, Jake Farrell wrote: > > > On behalf of the Apache Thrift PMC, I would like to welcome our newest > > committer to the project: > > > > Nobuaki Sukegawa > > > > He

Re: [VOTE]: Release Apache Thrift 0.9.3

2015-10-06 Thread Henrique Mendonça
Great stuff Jake, thanks a lot! On 2 October 2015 at 23:03, Roger Meier wrote: > Thanks Jake! > > +1 > > > Quoting Jake Farrell : > > All, >> I propose that we accept the following release candidate as the official >> Apache Thrift 0.9.3 release. >> >> http://people.apache.org/~jfarrell/thrift/0

Re: [VOTE] Switch Apache Thrift from autoconf to cmake

2015-05-16 Thread Henrique Mendonça
+1 On 14 May 2015 at 02:51, Nobuaki Sukegawa wrote: > +1 > > I really liked the flexibility and the degree of Windows support when > dealing with both tools for patches. > Only downside for me has been having two systems. > > On Wed, May 13, 2015 at 10:29 PM, Ben Craig wrote: > > > +0 > > > > I

Re: [jira] [Commented] (THRIFT-3083) C++ Consolidate server processing loops in TSimpleServer, TThreadedServer, TThreadPoolServer

2015-04-29 Thread Henrique Mendonça
First, thanks for all your contribution here James. It's really appreciated! My point was just that if you had a hook there, you'd have a travis build for your commit in your repo, before you submitted the PR. It can still fail after, as we've seen, but it's normally quite rare. Most instability is

Re: [jira] [Commented] (THRIFT-2940) Allow installing Thrift from git as NPM module by providing package.json in top level directory

2015-02-02 Thread Henrique Mendonça
hm... "make dist" fails on jenkins after this any ideas? On 3 February 2015 at 08:17, Hudson (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301943#comment-14301943 > ] > > Hudson

Re: i32 vs int

2014-12-04 Thread Henrique Mendonça
As no one else commented I just wanted to point out that probably both 2a and 2b are acceptable as long the implementation is generic enough to avoid duplicated code on different generators. I believe 2a should use warnings to avoid restricting current working IDL's and 2b could give errors directl

Re: i32 vs int

2014-12-01 Thread Henrique Mendonça
@Konrad, that might be a good idea to have a 'reserved type and members names', perhaps a little table on each generator/parser. So the c++ generator can throw a warning or error before it gets to the compiler (e.g. gcc), since 'typedef i32 int' might work in some languages but it's definitely not

Re: [DISCUSS] CMake for Apache Thrift

2014-11-25 Thread Henrique Mendonça
Hey guys, I think Roger also meant to only have one build system. Probably only having both while we port everything to cmake, but only one will be officially supported at a time. Not sure how much work is involved for the non-C libraries, wasn't facebook also using cmake? can we get anything fro

Re: Travis build failure due to linking new boost library.

2014-08-09 Thread Henrique Mendonça
Hi Chamila, It should be ok to add the two libraries but please make sure if you really can't make without them as there are already enough dependencies. As I said before you can add them to the contrib/installCXX script. Best, Henrique On 9 August 2014 08:18, Chamila Wijayarathna wrote: > Hell

Re: git.apache.org/thrift.git/lib/go/thrift returns 404?

2014-07-29 Thread Henrique Mendonça
Hi Mark, I also cannot access the official repo today, hopefully this is only something temporary. Otherwise we have to open a ticket under https://issues.apache.org/jira/browse/INFRA Cheers, Henrique On 29 July 2014 07:38, Mark Mandel wrote: > I noticed today that my Go CI builds where fail

Re: [VOTE][RESULT] Release Apache Thrift 0.9.2

2014-07-22 Thread Henrique Mendonça
Hey, I think I would actually prefer releasing the rc0 than the current master. I was talking to Roger and he seems to be OK with the minor issue that lib D won't build with 1.11 We could leave the fixes after rc0 and the dependency to 1.12 to 1.0 and get this rolling right now. What do you guys th

Re: Release Apache Thrift 0.9.2

2014-07-12 Thread Henrique Mendonça
Hi Jens, I can only find "serial-tests" on lib/d Have you tried to configure without this lib to see if it works? I had an issue with parallel tests before but adding this option is not very back compatible, as we can see... so this is actually a bug there IMHO. Best, Henrique On 12 July 2014 1

Re: [jira] [Commented] (THRIFT-2602) Fix missing dist files

2014-07-08 Thread Henrique Mendonça
Cheers Jake It'd be great if you could have a quick look. As far as I know Travis uses a ubuntu 12.04 but we update everything to 14.04, so I don't get why it wouldn't work there. Worst case we remove "make dist", but I think it would be nice if we could build everything there. On 6 July 2014 21:

Re: [jira] [Commented] (THRIFT-2571) Simplify cross compilation using CMake

2014-06-17 Thread Henrique Mendonça
se/THRIFT-2571 > > Project: Thrift > > Issue Type: Improvement > > Components: Compiler (General) > >Affects Versions: 1.0 > >Reporter: Pascal Bach > >Assignee: Henrique Mendonça > >Pri

Re: [jira] [Commented] (THRIFT-2571) Simplify cross compilation using CMake

2014-06-11 Thread Henrique Mendonça
ject: Thrift > Issue Type: Improvement > Components: Compiler (General) >Affects Versions: 1.0 > Reporter: Pascal Bach >Assignee: Henrique Mendonça >Priority: Minor > > Using CMake would simplify cross compilation. > The for example

Re: Thrift Nodejs tests

2014-05-22 Thread Henrique Mendonça
ents and servers alone, > but still when I ran test.sh, it gives empty log files for nodejs clients > and servers, any idea on how to run them using test.sh? > Thank You! > > > On Thu, May 22, 2014 at 9:27 PM, Henrique Mendonça >wrote: > > > Hi Chamila, > > >

Re: Thrift Nodejs tests

2014-05-22 Thread Henrique Mendonça
Hi Chamila, I've changed it on this commit because it was already using "node" in "make check", i.e. https://github.com/apache/thrift/blob/master/lib/nodejs/test/testAll.sh Depending on the OS version you use, you might have node or nodejs but you can use a alias: alias node="nodejs" Best, Henr

Re: [jira] [Commented] (THRIFT-1743) Add composer.json for new Symfony 2.1 Dependency Manager

2014-04-05 Thread Henrique Mendonça
Hi guys, Is there any functional difference from what we can achieve? If not, I think B is probably easier to maintain, as I believe both use the repo. labels for versioning, but whatever works easier. B2) What if we'd keep them in their lib folders and symlink them back to the root? So then we h

Re: reconsidering the Apache CMS...

2014-03-19 Thread Henrique Mendonça
Hi Joe, Thanks for your effort. I just wanted to add that the code snippets are a crucial feature for this project, which has way more target languages than active contributors. In our case, reducing manual maintenance costs is much more important than the total site build time. Perhaps we can als

Re: Node.js npm deployment of Apache Thrift

2014-03-15 Thread Henrique Mendonça
Hi Randy, I agree it doesn't make sense to deploy tests that don't work. Then, only the source will do it. What about another package thrift-dev for test+lib/nodejs+compiler? Although we can get everything directly from the source, NPM handles versioning quite nicely. On 15 March 2014 20:41, Ra

Re: AW: source doc to website

2014-03-15 Thread Henrique Mendonça
Hi guys, 1. I think we can simply rename all the readme's to .md since some of them are already markdown anyway. I think nobody is against it, right? I was going to do that already in /lib/js, so I can do it for the others too... 2. merging the tutorials to the tests would be quite complicated wi

Re: File Upload through thrift

2014-03-05 Thread Henrique Mendonça
Hi, You can do this, how big are your files? You might find that some implementations do have a size limit, not sure about Java, though. Anyway, is generally faster to send a URL and download it separately, if it fits you... On 5 March 2014 20:56, Sachith Withana wrote: > I'm planning on conver

Re: [jira] [Closed] (THRIFT-2001) http://thrift.apache.org/ Example "C++ Server" tab is broken

2014-02-12 Thread Henrique Mendonça
t; Key: THRIFT-2001 > > URL: https://issues.apache.org/jira/browse/THRIFT-2001 > > Project: Thrift > > Issue Type: Documentation > > Components: Website > > Environment: Chrome, IE, Opera > >

Re: Re: [jira] [Commented] (THRIFT-2190) Add the JavaScript thrift.js lib to the Bower registry

2014-02-02 Thread Henrique Mendonça
; 0.9.1 > > > We should add the bower.json file to the root folder > > -roger > > > -Original Message- > From: hmendo...@gmail.com [mailto:hmendo...@gmail.com] On Behalf Of > Henrique Mendonça > Sent: Sonntag, 2. Februar 2014 13:43 > To: dev@thrift.apache.org &

Re: [jira] [Commented] (THRIFT-2190) Add the JavaScript thrift.js lib to the Bower registry

2014-02-02 Thread Henrique Mendonça
Hi Randy, I think you can test it with your own fork like: https://github.com/henrique/thrift/blob/master/bower.json bower install https://github.com/henrique/thrift.git I don't really use bower so I am not sure if this reference to /lib/js/src works. However, if it does we would only need to hav

Re: [jira] [Commented] (THRIFT-2338) First doctext wrongly interpreted as program doctext in some cases

2014-02-01 Thread Henrique Mendonça
-Compiler-Windows/1051/changes > > In your travis log, why is thrifty.h updated AFTER it is searched? Is that > by intention? Shouldn't it be reversed: first create/update the file, > before we use it? > > JensG > > > -Ursprüngliche Nachricht- From: Henrique

Re: [jira] [Commented] (THRIFT-2338) First doctext wrongly interpreted as program doctext in some cases

2014-02-01 Thread Henrique Mendonça
rror 2 The command "make -j$NUM_CPU" exited with 2. the job fails but after the make check runs normally again! Not sure what's causing it. - Henrique On 1 February 2014 13:16, Henrique Mendonça wrote: > Hi Jens, > > > https://travis-ci.org/apache/thrift/builds/180

Re: [jira] [Commented] (THRIFT-2338) First doctext wrongly interpreted as program doctext in some cases

2014-02-01 Thread Henrique Mendonça
Hi Jens, https://travis-ci.org/apache/thrift/builds/18011132 line 1509 thriftl.ll:64:21: fatal error: thrifty.h: No such file or directory compilation terminated. updating thrifty.h ... make: *** [all] Error 2 The command "make -j$NUM_CPU" exited with 2. $ make check -j$NUM_CPU && sh test/

Re: AW: thrift pull request: README update

2014-01-11 Thread Henrique Mendonça
Awesome! Thank you guys! @Roger: in test.sh, are those 100 seconds timeout for the java tests really necessary? I think the whole build would run under 15-20 min with more reasonable waiting times On 11 January 2014 02:45, Jake Farrell wrote: > Travis hook is now enabled > > -Jake > > > On Fr

Re: TTornado.py

2013-11-06 Thread Henrique Mendonça
Hi Brian, Could you please open a Jira issue for the formalities? http://thrift.apache.org/docs/HowToContribute/ Cheers, Henrique On 6 November 2013 09:40, Bryan Pham wrote: > Hi, it looks like TTornado.py isn't running because tcpserver is not inside > netutil anymore. > > index af309c3..d90

Re: updating to longer ints

2013-03-26 Thread Henrique Mendonça
Hi Jens, That's an interesting proposition, sorry for the delayed answer, but if I'm not wrong with your example it would generate exceptions independently of the side you update first. Since the i16 side wouldn't be able to read the i32's that would came either as an input or output of your func

Re: How to post a multi-issue patch?

2012-11-10 Thread Henrique Mendonça
Hi Ben, You can create the ticket and post the patch (against the trunk) and we'll have a look. I think some of the mentioned points were already committed to the trunk. Cheers, Henrique On 9 November 2012 21:58, Ben Craig wrote: > I have a patch that I am ready to post to JIRA. It resolves a

Re: thrift/concurrency/Mutex.h bug

2012-11-07 Thread Henrique Mendonça
Hi Bud, I wonder why we are not using boost mutex and scoped mutex instead but those two macros are probably not necessary anyways. Would you create a patch and copy/adapt those comments to the thrift Mutex classes themselves? Thank you! http://thrift.apache.org/docs/HowToContribute/ Henrique On

Re: Python JSON protocol implementation

2012-10-30 Thread Henrique Mendonça
Hi Fred, Awesome to hear that! Would you be able to create a short ticket on Jira for that... so we can better track it. Cheers, Henrique http://thrift.apache.org/docs/HowToContribute/ On 30 October 2012 12:15, Frederic Delbos wrote: > Hi, > > thrift python json protocol now passes all tests,

Re: Python JSON protocol implementation

2012-10-24 Thread Henrique Mendonça
Hi Frederic, This is awesome news! It would be really great if you could add a little inline web server to test it against the JavaScript version. But that's totally up to you, at least Java and C++ implement this protocol already. Merci! Henrique On 24 October 2012 23:25, Frederic Delbos wrote

Re: [jira] [Commented] (THRIFT-539) struct hash and print methods for C++

2012-10-08 Thread Henrique Mendonça
That would be awesome Martin! Thank you already, Henrique On 8 October 2012 14:01, Martin Vogt wrote: > On Sun, Oct 7, 2012 at 9:56 PM, Roger Meier (JIRA) wrote: >>> The current thrift compiler for C++ generates methods for structs like >>> operator== and operator< since it uses maps,sets, etc

Re: tutorial for javascript

2012-08-26 Thread Henrique Mendonça
Hi Richard It does work with you have the java lib built On 25 August 2012 17:51, Juan Moreno wrote: > This is what I see in the HTML page: > > function calc() { > var transport = new Thrift.Transport("/thrift/service/tutorial/"); > var protocol = new Thrift.Protocol(transport); > v