[GitHub] thrift issue #672: Fix package.json to include only the needed files

2017-01-31 Thread bufferoverflow
Github user bufferoverflow commented on the issue: https://github.com/apache/thrift/pull/672 @jfarrell you are the npm publisher, could you please push 0.10.0 to the npm registry? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request #1158: chore: install ruby-bundler

2017-01-16 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/1158 chore: install ruby-bundler @jeking3 @Jens-G this should fix the travis build You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] thrift issue #1126: Ant fixes.

2016-11-10 Thread bufferoverflow
Github user bufferoverflow commented on the issue: https://github.com/apache/thrift/pull/1126 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-3779 Qt Client Android and Windows QTc...

2016-04-06 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/979#discussion_r58678766 --- Diff: lib/cpp/libthriftQt.pro --- @@ -0,0 +1,161 @@ +QT += core network + +CONFIG += c++11 + +greaterThan

[GitHub] thrift pull request: THRIFT-3667 C++: Add TLS SNI support to clien...

2016-02-27 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/894#issuecomment-189621494 committed 937228e030569bf25ceb379c9491426709792701 could you please close the PR --- If your project is set up for it, you can reply to this email and have your

[GitHub] thrift pull request: THRIFT-3573 c_glib: No rule to make target is...

2016-01-21 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/811 THRIFT-3573 c_glib: No rule to make target issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/bufferoverflow/thrift THRIFT-3573

[GitHub] thrift pull request: THRIFT-3555 'configure' script does not honor...

2016-01-21 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/805#issuecomment-173731839 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3568 THeader server crashes on readSlo...

2016-01-21 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/807#issuecomment-173733541 +1 Thanks for the details, I've never used THeader... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: THRIFT-3571 Make feature test result browsabl...

2016-01-21 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/809#issuecomment-173740248 nice! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: THRIFT-3568 THeader server crashes on readSlo...

2016-01-18 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/807#issuecomment-172632943 @andrewcox similar issues at fb with this code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...

2016-01-17 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/795#issuecomment-172357194 Great work! Could you please add this to ``test/tests.json`` as well --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-3439 Run make cross using Python3 when...

2016-01-13 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/792#issuecomment-171334306 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3544 Let cross test fail when server p...

2016-01-13 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/793#issuecomment-171334638 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3474 Docker: thrift-compiler

2016-01-10 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/733#issuecomment-170337691 rework done ready to merge to 0.9.3 branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift pull request: THRIFT-3503 Enable py:utf8string by default

2016-01-10 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/779#issuecomment-170361468 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-2790 thrift -gen all => an option to g...

2016-01-10 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/782 THRIFT-2790 thrift -gen all => an option to generate all languages an… …d features You can merge this pull request into a Git repository by running: $ git pull https://github.

[GitHub] thrift pull request: THRIFT-3539 Use self.process_foo instead of P...

2016-01-10 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/784#issuecomment-170397488 I have some issues using this, did you ran **make check** or **make cross** --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-3531 Create cross lang feature test fo...

2016-01-09 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/780#issuecomment-170220971 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3474 Docker: thrift-compiler

2016-01-03 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/768 THRIFT-3474 Docker: thrift-compiler some tuning suggested by Aki Sukegawa You can merge this pull request into a Git repository by running: $ git pull https://github.com/bufferoverflow

[GitHub] thrift pull request: THRIFT-3474 Docker: thrift-compiler

2015-12-26 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/733#issuecomment-167294979 @nsuke You are right is about pushing an additional commit on top of 0.9.3 branch. Thank's for the links, I did some rework [here](https://github.com

[GitHub] thrift pull request: THRIFT-3506 Eliminate old style classes from ...

2015-12-24 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/758#issuecomment-167066055 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3438 Enable py:new_style by default

2015-12-24 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/759#issuecomment-167066082 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3469 Docker: Debian support

2015-12-16 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/746 THRIFT-3469 Docker: Debian support This is an initial version of Debian Docker. Haskell is still broken... You can merge this pull request into a Git repository by running

[GitHub] thrift pull request: THRIFT-3474 Docker: thrift-compiler

2015-12-16 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/733#issuecomment-165277884 @nsuke @Jens-G @jfarrell What do you think about this? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] thrift pull request: THRIFT-3328 A callback is not called when a s...

2015-12-08 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/734#issuecomment-162988381 Thanks for the fix! Could you close the ticket, I forgot to mention the PR within the commit. --- If your project is set up for it, you can reply

[GitHub] thrift pull request: THRIFT-3433 Doubles aren't interpreted correc...

2015-12-08 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/736#issuecomment-163014841 :+1: tested on Debian Jessie amd64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-3469 Docker: Debian support

2015-12-08 Thread bufferoverflow
Github user bufferoverflow closed the pull request at: https://github.com/apache/thrift/pull/727 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: Support for float type (part 1: cpp)

2015-12-07 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/731#issuecomment-162651073 Yes, CI will re-run. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] thrift pull request: THRIFT-3474 Docker: thrift-compiler

2015-12-06 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/732 THRIFT-3474 Docker: thrift-compiler You can merge this pull request into a Git repository by running: $ git pull https://github.com/bufferoverflow/thrift THRIFT-3474 Alternatively you

[GitHub] thrift pull request: THRIFT-3474 Docker: thrift-compiler

2015-12-06 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/733 THRIFT-3474 Docker: thrift-compiler Would be nice to provide support of 0.9.3 compiler as container. This closes #732 ``` $ docker pull thrift/thrift-compiler:0.9.3

[GitHub] thrift pull request: Support for float type (part 1: cpp)

2015-12-06 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/731#issuecomment-162352720 Great patch Andrew! I would really like to get FLOAT up and running here. The blocker for not merging now is breaking other languages with this at the moment

[GitHub] thrift pull request: Support for float type (part 1: cpp)

2015-12-04 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/731#issuecomment-162083194 Thanks Andrew! I will review this during the weekend... Could you please add THRIFT-2457 as prefix within your commits as mentioned within

[GitHub] thrift pull request: THRIFT-3464 THRIFT-3455 c_glib fixes

2015-12-02 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/724#issuecomment-161341921 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3469 Docker: Debian support

2015-12-02 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/727 THRIFT-3469 Docker: Debian support You can merge this pull request into a Git repository by running: $ git pull https://github.com/bufferoverflow/thrift docker Alternatively you can

[GitHub] thrift pull request: THRIFT-3454 Python Tornado tutorial is broken

2015-12-02 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/725#issuecomment-161297008 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3460 Improve provided Debian packaging...

2015-12-01 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/721#issuecomment-160955847 Nice, could you please stash the commits and fix this: https://travis-ci.org/apache/thrift/jobs/93935078 --- If your project is set up for it, you can reply

[GitHub] thrift pull request: THRIFT-3453 remove rat_exclude

2015-11-28 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/719 THRIFT-3453 remove rat_exclude rat_exclude file within root of our source tree is not in use anymore. It has its origin from incubating phase, where the Tool Apache Rat was used

[GitHub] thrift pull request: THRIFT-3451 thrift_protocol PHP extension mis...

2015-11-27 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/718 THRIFT-3451 thrift_protocol PHP extension missing config.m4 file You can merge this pull request into a Git repository by running: $ git pull https://github.com/bufferoverflow/thrift

[GitHub] thrift pull request: THRIFT-3421 rebar as dependency instead of bu...

2015-11-14 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/693 THRIFT-3421 rebar as dependency instead of bundling You can merge this pull request into a Git repository by running: $ git pull https://github.com/bufferoverflow/thrift THRIFT-3421

[GitHub] thrift pull request: Run test for THRIFT-2413

2015-11-14 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/695#issuecomment-156718453 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3350 Python JSON protocol does not enc...

2015-11-14 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/697#issuecomment-156718622 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3200 JS and nodejs do not encode JSON ...

2015-11-14 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/698#issuecomment-156718579 :+1: great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: THRIFT-3200 JS and nodejs do not encode JSON ...

2015-11-14 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/698#issuecomment-156721497 I think it is ok to not support IE < v10 This change needs to be committed base64 can be another step. test integration done here is awesome! --- If y

[GitHub] thrift pull request: THRIFT-2073: Fixed Thrift C++ THttpClient err...

2015-11-08 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/543#issuecomment-154861060 @cmhe could you please close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-2423: Facebook's THeader protocol and ...

2015-11-03 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/357#issuecomment-153325696 @nsuke Yes, please do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] thrift pull request: Thrift 1857 redux 2

2015-11-03 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/680#issuecomment-153534017 :+1: tested with autoconf running **make cross** and cmake **make** on Debian Jessie amd64 with Python 2.7.9 -roger --- If your project is set up

[GitHub] thrift pull request: Fix package.json to include only the needed f...

2015-11-03 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/672#issuecomment-153511243 Thanks for the PR! We need a strong YES to according to the contribution guidelines as mentioned here https://thrift.apache.org/docs/HowToContribute

[GitHub] thrift pull request: THRIFT-3380 nodejs Fix broken transport and p...

2015-10-13 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/651#issuecomment-147880525 This change is needed on top of the existing PR to make the nodejs testsuite up and running again: ``` diff --git a/lib/nodejs/test/testAll.sh b/lib

[GitHub] thrift pull request: THRIFT-2794 Suppress warnings in autogenerate...

2015-10-11 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/649#discussion_r41715826 --- Diff: compiler/cpp/src/generate/t_java_generator.cc --- @@ -441,7 +441,7 @@ string t_java_generator::java_type_imports() { } string

[GitHub] thrift pull request: THRIFT-2794 Suppress warnings in autogenerate...

2015-10-10 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/649#discussion_r41702403 --- Diff: compiler/cpp/src/generate/t_java_generator.cc --- @@ -441,7 +441,7 @@ string t_java_generator::java_type_imports() { } string

[GitHub] thrift pull request: THRIFT-3329: fix test incompatibility with bo...

2015-09-23 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/620#discussion_r40186729 --- Diff: lib/cpp/test/SecurityTest.cpp --- @@ -75,13 +75,17 @@ struct GlobalFixture if (!boost::filesystem::exists(certFile

[GitHub] thrift pull request: THRIFT-3340 Python: enable json tests again

2015-09-21 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/613 THRIFT-3340 Python: enable json tests again You can merge this pull request into a Git repository by running: $ git pull https://github.com/bufferoverflow/thrift THRIFT-3340

[GitHub] thrift pull request: THRIFT-2918 Race condition in Python TProcess...

2015-09-17 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/606#issuecomment-140994555 committed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: THRIFT-2918 Race condition in Python TProcess...

2015-09-17 Thread bufferoverflow
Github user bufferoverflow closed the pull request at: https://github.com/apache/thrift/pull/606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2918 Race condition in Python TProcess...

2015-09-16 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/606 THRIFT-2918 Race condition in Python TProcessPoolServer test This makes python test pass on my machine. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift pull request: THRIFT-3219: Provide a C++ tutorial on server...

2015-07-04 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/538#discussion_r33885850 --- Diff: tutorial/cpp/CppLogIPServer.cpp --- @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] thrift pull request: THRIFT-3219: Provide a C++ tutorial on server...

2015-07-04 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/538#discussion_r33885841 --- Diff: CMakeLists.txt --- @@ -73,6 +73,7 @@ endif() if(BUILD_CPP) add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/lib/cpp

[GitHub] thrift pull request: THRIFT-3219: Provide a C++ tutorial on server...

2015-07-04 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/538#issuecomment-118548352 Thanks Ben! Could you commit this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: Limit lists to 10,000 items in fastbinary dec...

2015-06-03 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/511#discussion_r31599161 --- Diff: lib/py/src/protocol/fastbinary.c --- @@ -1028,7 +1043,7 @@ decode_val(DecodeBuffer* input, TType type, PyObject* typeargs

[GitHub] thrift pull request: Limit lists to 10,000 items in fastbinary dec...

2015-06-03 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/511#discussion_r31599079 --- Diff: lib/py/src/protocol/fastbinary.c --- @@ -936,7 +951,7 @@ decode_struct(DecodeBuffer* input, PyObject* output, PyObject* spec_seq

[GitHub] thrift pull request: THRIFT-3155 move contrib/mingw32-toolchain.cm...

2015-05-16 Thread bufferoverflow
Github user bufferoverflow closed the pull request at: https://github.com/apache/thrift/pull/495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2850 CMake: improve Windows support

2015-05-15 Thread bufferoverflow
Github user bufferoverflow closed the pull request at: https://github.com/apache/thrift/pull/494 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2850 CMake: improve Windows support

2015-05-15 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/494#issuecomment-102401826 committed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: THRIFT-2850 CMake: improve Windows support

2015-05-15 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/494 THRIFT-2850 CMake: improve Windows support use YY_NO_UNISTD_H and remove --wincompat Signed-off-by: Roger Meier ro...@apache.org You can merge this pull request into a Git

[GitHub] thrift pull request: THRIFT-3122 Convert plain js objects given as...

2015-05-13 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/476#issuecomment-101799446 What about Jasmine, Karma and PhantomJS as unit test suite? and Protractor if we do e2e, what's best for nodejs? or node.js io.js and javascript all in one

[GitHub] thrift pull request: Thrift 3138

2015-05-10 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/487#issuecomment-100665372 Thanks! committed, you can close this PR -roger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: THRIFT-3121 Librt does not exist on OSX

2015-05-09 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/475#issuecomment-100552112 please close this, it is committed here: https://github.com/apache/thrift/commit/9e78ed81a94dde86f4ac4207c39334255c102a5a --- If your project is set up

[GitHub] thrift pull request: THRIFT-3122 Convert plain js objects given as...

2015-05-03 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/476#issuecomment-98530788 nice idea, but the introduction of new structs within test/ThriftTest.thrift breaks many other language tests, do you really need new structs? e.g. BonkMap

[GitHub] thrift pull request: THRIFT-3109 Cross test log file cannot be bro...

2015-04-26 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/457#issuecomment-96396299 committed, you can close this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] thrift pull request: Thrift 3103

2015-04-26 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/449#issuecomment-96396686 @marco-m this is committed, could you please close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: Thrift 3113 c++11 check issue

2015-04-26 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/462#issuecomment-96393589 committed, please close the issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-13 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/424#discussion_r28270114 --- Diff: lib/cpp/src/thrift/transport/TSocket.cpp --- @@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) { goto

[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)

2015-04-12 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203488 --- Diff: build/cmake/DefinePlatformSpecifc.cmake --- @@ -58,8 +58,9 @@ if(MSVC) endif(WITH_MT) endif(MSVC) -# GCC Specific

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/424#discussion_r28204494 --- Diff: lib/cpp/src/thrift/transport/TSocket.cpp --- @@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) { goto

[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...

2015-04-07 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/429#issuecomment-90697644 @jeking3 please do not use square brackets [] around the thrift issue identifer, this will be removed when I use git am toi apply the patch. --- If your project

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-04-07 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-90731296 Thanks Simon! just committed this, please check this for the next PR https://thrift.apache.org/docs/HowToContribute --- If your project is set up

[GitHub] thrift pull request: Facebook's THeader protocol and transport for...

2015-03-01 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/357#issuecomment-76593090 could you rebase to master and I commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-2926: JS: Binary protocol with unit te...

2015-01-11 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/345#issuecomment-69494103 Thanks @radekg for this udate. any idea about the jslint issues? cd lib/js/test make check lib/js/test/build.xml:216: JSLint

[GitHub] thrift pull request: THRIFT-2923 Initialise tpos and tstack in the...

2015-01-06 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/342#issuecomment-68956070 committed here 1d30558c8c09d08a60f6ddc602b6994cfc9f74b3 please close this PR --- If your project is set up for it, you can reply to this email and have your

[GitHub] thrift pull request: THRIFT-2901

2015-01-06 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/332#issuecomment-68956159 committed 6d9a3ca7d912482fb1321efae80a07eff9de2b85 please close PR --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-2926: JS: Binary protocol with unit te...

2015-01-03 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/345#issuecomment-68587476 jslint is used via lib/js/test/build.xml which also runs the unit tests test.js/test.html My favorite would be integration of your tests into test.js

[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift

2014-12-13 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/318#issuecomment-66887590 @hcorg this is https://issues.apache.org/jira/browse/THRIFT-2850 Pascal Bach, Sergei Nikulov and I worked on this together. I suggest to merge

[GitHub] thrift pull request: Fix THRIFT-2779 - PHP TJSONProtocol encode un...

2014-12-13 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/313#issuecomment-66888731 lib/php/test/Test/Thrift/Protocol/TestTJSONProtocol.php:103 this breaks the test suite *make check* and what about *make cross* 2) test\Thrift\Protocol

[GitHub] thrift pull request: Add moveable_types option to C++ generator

2014-12-08 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/271#issuecomment-66181001 I'm fine with this, could you fix the merge conflicts and I will commit. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-2855 Move contributing.md to the root ...

2014-12-07 Thread bufferoverflow
Github user bufferoverflow closed the pull request at: https://github.com/apache/thrift/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: Add moveable_types option to C++ generator

2014-12-07 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/271#issuecomment-65940029 Is there any specific reason for adding an option for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: fix bugs when using lua string in TMemoryBuff...

2014-12-07 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/296#issuecomment-65941781 thanks for the patch, please check this https://thrift.apache.org/docs/HowToContribute --- If your project is set up for it, you can reply to this email and have

[GitHub] thrift pull request: THRIFT-2855 Move contributing.md to the root ...

2014-12-01 Thread bufferoverflow
GitHub user bufferoverflow opened a pull request: https://github.com/apache/thrift/pull/298 THRIFT-2855 Move contributing.md to the root of the repository You can merge this pull request into a Git repository by running: $ git pull https://github.com/bufferoverflow/thrift

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-19 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16448295 --- Diff: lib/java/test/org/apache/thrift/test/TestClient.java --- @@ -642,7 +684,28 @@ public static void main(String [] args

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16374731 --- Diff: lib/java/test/org/apache/thrift/test/TestClient.java --- @@ -642,7 +684,28 @@ public static void main(String [] args

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16374767 --- Diff: test/cpp/src/TestClient.cpp --- @@ -698,5 +756,28 @@ int main(int argc, char** argv) { printf(Max time: % PRIu64 us\n, time_max

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/190#issuecomment-52357551 The changes within .travis.yml and contrib/installDependencies.sh are not required. you can do this: {noformat} diff --git a/lib/hs/Thrift.cabal b/lib

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/190#issuecomment-52358999 please fix all the white space issues e.g contrib/installDependencies.sh and many other areas had no changes --- If your project is set up for it, you can

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/190#issuecomment-52359230 You also might start using --port=${THRIFT_TEST_PORT} --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/190#issuecomment-52360323 sorry, I did not recognized that. Perfect! committed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: make thrift cocoa lib support TMultiplexedPro...

2014-08-08 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/150#discussion_r16017819 --- Diff: lib/cocoa/src/protocol/TMultiplexedProtocol.h --- @@ -0,0 +1,19 @@ +// --- End diff -- please add apache license header

[GitHub] thrift pull request: make thrift cocoa lib support TMultiplexedPro...

2014-08-08 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/150#discussion_r16017873 --- Diff: lib/cocoa/src/protocol/TMultiplexedProtocol.m --- @@ -0,0 +1,36 @@ +// +// TMultiplexedProtocol.m +// TaLiCaiCommunity

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-07 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/173#discussion_r15929760 --- Diff: test/test.py --- @@ -90,14 +92,18 @@ def runServiceTest(test_name, server_lib, server_executable, server_extra_args

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-06 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/173#discussion_r15914261 --- Diff: test/test.py --- @@ -90,14 +92,18 @@ def runServiceTest(test_name, server_lib, server_executable, server_extra_args

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-06 Thread bufferoverflow
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/173#discussion_r15914326 --- Diff: test/tests.json --- @@ -4,7 +4,7 @@ description: Python TestClient, lib: py, executable

  1   2   >