[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-08 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/598#issuecomment-138574945 @snikulov sorry if there was any misunderstanding but I'm just reviewing as a peer contributor and I have no way to "approve." That said, I believe it's good to merge.

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-07 Thread snikulov
Github user snikulov commented on the pull request: https://github.com/apache/thrift/pull/598#issuecomment-138227255 @nsuke updated pull request per your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-04 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38807967 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-03 Thread snikulov
Github user snikulov commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38620073 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-03 Thread snikulov
Github user snikulov commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38619873 --- Diff: build/cmake/DefineOptions.cmake --- @@ -62,8 +62,10 @@ endif() find_package(OpenSSL QUIET) CMAKE_DEPENDENT_OPTION(WITH_OPENSSL "Build

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38551876 --- Diff: build/cmake/DefineOptions.cmake --- @@ -62,8 +62,10 @@ endif() find_package(OpenSSL QUIET) CMAKE_DEPENDENT_OPTION(WITH_OPENSSL "Build with

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552069 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552467 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38552677 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-02 Thread snikulov
GitHub user snikulov opened a pull request: https://github.com/apache/thrift/pull/598 cmake // fixes for std/boost::thread detection; security test; qt test Hello All! Relates to https://issues.apache.org/jira/browse/THRIFT-2850 1. Will use BOOST if not explicitly