-29T13:39:10Z
Increase readability in go generator
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C
to coding_standards.md in branch later.
make style added :) (requires clang-format 3.5)
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
/cpp/src/thrift/qt/TQTcpServer.cpp
* compiler/cpp/src/globals.h
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C
* compiler/cpp/src/generate/t_lua_generator.cc
* compiler/cpp/src/md5.h
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
/TDenseProtocol.cpp
* lib/cpp/src/thrift/server/TSimpleServer.h
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C
style*.
;-r
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C++ - Library
Reporter: Konrad Grochowski
to find more such tools for other libs
(clang-format can be used also for java and javascript, but I have to check how
it behaves)
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project
of the lib/cpp/README.md about code
style and clang-format usage
we can add *make style* as part of THRIFT-2724
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
support for that commit I can push it to repo :)
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C++ - Library
about test/cpp and tutorial/cpp directory?
I thought about a *make style* target to automate the clang-format process
somehow?
;-r
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
possible to create .clang-format consistent with c_glib library...
currently I run clang-format this way, adding it to makefile should be simple:
{{find tutorial/cpp -name \*\.h -or -name \*\.cpp -or -name \*\.cc | xargs
clang-format -i}}
C++ coding standards
to the source tree and cleanup the code.
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C++ - Library
Reporter
and most files where not changed.
If we could accept 'namespace change' than reformating via clang-format is
possible,
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
'namespace change' than reformating via clang-format is
possible,
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C
to differ in so many places from standards
currently seen in Thrift code, that CPPLINT.cfg has to disable most of filters.
So it does check almost nothing...
I'll try with clang-format - it's much more configurable
C++ coding standards
Key: THRIFT-2729
as default)
clang 3.6 has more config options, which would make it even more usable.
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
with emacs, which makes me happy :)
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C++ - Library
Reporter
stick with
cpplint)
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C++ - Library
Reporter: Konrad
[
https://issues.apache.org/jira/browse/THRIFT-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157251#comment-14157251
]
Roger Meier commented on THRIFT-2728:
-
+1, please commit
C# coding standards
all
standards are ready.
C# coding standards
---
Key: THRIFT-2728
URL: https://issues.apache.org/jira/browse/THRIFT-2728
Project: Thrift
Issue Type: Sub-task
Components: C# - Library
Reporter: Konrad
/thrift/commit/1cb5f94aeabe88643d8ac855b0339b1c50e4a637
covers it?
C# coding standards
---
Key: THRIFT-2728
URL: https://issues.apache.org/jira/browse/THRIFT-2728
Project: Thrift
Issue Type: Sub-task
Components: C
-style casts*
C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Components: C++ - Library
Reporter: Konrad Grochowski
Hey,
Are C++ coding standards for thrift defined anywhere? I see that lib/cpp
looks like this 'ClassName::methodName' but compiler code look more like
't_class_name::method_name'. I definitely prefer first style, but
currently I'm playing around compiler. Can I use 'lib' style, assuming
be
preferred.
Can you create a ticket for style guides and lets start a page for the
website on this topic for contributors and committers
-Jake
On Fri, Sep 26, 2014 at 9:03 AM, Konrad Grochowski hc...@minions.org.pl
wrote:
Hey,
Are C++ coding standards for thrift defined anywhere? I see that lib
@thrift.apache.org,
Date: 09/26/2014 08:04 AM
Subject: C++ coding standards
Hey,
Are C++ coding standards for thrift defined anywhere? I see that lib/cpp
looks like this 'ClassName::methodName' but compiler code look more like
't_class_name::method_name'. I definitely prefer first style
already is, but it isn't a large
concern of mine.
Konrad Grochowski hc...@minions.org.pl wrote on 09/26/2014 08:03:45 AM:
From: Konrad Grochowski hc...@minions.org.pl
To: dev@thrift.apache.org,
Date: 09/26/2014 08:04 AM
Subject: C++ coding standards
Hey,
Are C++ coding standards for thrift defined
Konrad Grochowski created THRIFT-2728:
-
Summary: C# coding standards
Key: THRIFT-2728
URL: https://issues.apache.org/jira/browse/THRIFT-2728
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2729:
-
Summary: C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/THRIFT-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2728:
--
Component/s: C# - Library
C# coding standards
[
https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2729:
--
Component/s: C++ - Library
C++ coding standards
already is, but it isn't a large
concern of mine.
Konrad Grochowski hc...@minions.org.pl wrote on 09/26/2014 08:03:45 AM:
From: Konrad Grochowski hc...@minions.org.pl
To: dev@thrift.apache.org,
Date: 09/26/2014 08:04 AM
Subject: C++ coding standards
Hey,
Are C++ coding standards
That was exactly what I felt.
Von: Rush Manbert
Gesendet: 26.09.2014 17:44
An: dev@thrift.apache.org
Betreff: Re: C++ coding standards
I think this veers off into territory that should be avoided for this project.
I am not against having coding standards
To: dev@thrift.apache.org dev@thrift.apache.org,
Date: 09/26/2014 11:34 AM
Subject: AW: C++ coding standards
That was exactly what I felt.
Von: Rush Manbert
Gesendet: 26.09.2014 17:44
An: dev@thrift.apache.org
Betreff: Re: C++ coding standards
I think
: 26.09.2014 17:44
An: dev@thrift.apache.org
Betreff: Re: C++ coding standards
I think this veers off into territory that should be avoided for this project.
I am not against having coding standards. Not at all. But Thrift is a fairly
mature product. Disregarding new language support, I suspect
An: dev@thrift.apache.org
Betreff: Re: C++ coding standards
I think this veers off into territory that should be avoided for this project.
I am not against having coding standards. Not at all. But Thrift is a fairly
mature product. Disregarding new language support, I suspect that the bulk
35 matches
Mail list logo
