Re: [VOTE] TinkerPop 3.2.1 Release

2016-07-20 Thread Stephen Mallette
Thanks Hadrian - I read that section you referenced to remind myself of how Apache viewed the -1 and I understood it as you described, however I went so far as to say a "-1 means aborting the release" because as the release manager I was taking the the non-binding -1 pretty seriously with the likel

[jira] [Updated] (TINKERPOP-1379) unaccounted excess in TailGlobalStep

2016-07-20 Thread Jason Plurad (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad updated TINKERPOP-1379: Affects Version/s: 3.1.3 > unaccounted excess in TailGlobalStep > --

Re: [VOTE] TinkerPop 3.2.1 Release

2016-07-20 Thread Hadrian Zbarcea
+1 Stephen, a -1 on a release is not a veto, see the "votes on package releases" section on the foundation site [1]. It is up to the release manager to decide how to proceed. Usually releases are redone not because of the -1, but because there is a valid reason behind the -1. Experienced comm

[DISCUSS] interrupt

2016-07-20 Thread pieter-gmail
The current interrupt implementation is failing on Sqlg's HSQLDB implementation. The reason for this is that HSQLDB itself relies on Thread.interrupt() for its own internal logic. When TinkerPop interrupts the thread it thinks it has to do with its own logic and as a result the interrupt flag is re

[jira] [Updated] (TINKERPOP-1380) dedup() doesn't dedup in rare cases

2016-07-20 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1380: Fix Version/s: 3.2.2 > dedup() doesn't dedup in rare cases > ---

[jira] [Commented] (TINKERPOP-1380) dedup() doesn't dedup in rare cases

2016-07-20 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386472#comment-15386472 ] stephen mallette commented on TINKERPOP-1380: - I just noticed this which [

[jira] [Commented] (TINKERPOP-1382) As a developer we should be able to create user-defined gremlin step using latest Tinkerpop 3.x

2016-07-20 Thread Kaniska Mandal (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386436#comment-15386436 ] Kaniska Mandal commented on TINKERPOP-1382: --- Thanks much Stephen for the qui

[jira] [Commented] (TINKERPOP-1382) As a developer we should be able to create user-defined gremlin step using latest Tinkerpop 3.x

2016-07-20 Thread Kaniska Mandal (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386411#comment-15386411 ] Kaniska Mandal commented on TINKERPOP-1382: --- How can I register a Custom Tra

[jira] [Updated] (TINKERPOP-1382) As a developer we should be able to create user-defined gremlin step using latest Tinkerpop 3.x

2016-07-20 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1382: Affects Version/s: 3.2.0-incubating Priority: Major (was: Critical)

[jira] [Updated] (TINKERPOP-1382) As a developer we should be able to create user-defined gremlin step using latest Tinkerpop 3.x

2016-07-20 Thread Kaniska Mandal (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaniska Mandal updated TINKERPOP-1382: -- Summary: As a developer we should be able to create user-defined gremlin step using

[jira] [Created] (TINKERPOP-1382) need to create user-defined step using latest Tinkerpop 3.x

2016-07-20 Thread Kaniska Mandal (JIRA)
Kaniska Mandal created TINKERPOP-1382: - Summary: need to create user-defined step using latest Tinkerpop 3.x Key: TINKERPOP-1382 URL: https://issues.apache.org/jira/browse/TINKERPOP-1382 Project:

[jira] [Updated] (TINKERPOP-1381) improve test coverage of graphs with random ids

2016-07-20 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1381: Issue Type: Improvement (was: Test) > improve test coverage of graphs with rand

Re: [VOTE] TinkerPop 3.2.1 Release

2016-07-20 Thread pieter-gmail
After some discussion in HipChat I have had a change of heart. VOTE +1 As an aside if the code freeze can include 2 weekends it'll be great. Thanks Pieter On 20/07/2016 18:59, Stephen Mallette wrote: > w that we dont' have to go through incubator for release. Perhaps we plan > to get a 3.2.2 ou

[jira] [Created] (TINKERPOP-1381) improve test coverage of graphs with random ids

2016-07-20 Thread Jason Plurad (JIRA)
Jason Plurad created TINKERPOP-1381: --- Summary: improve test coverage of graphs with random ids Key: TINKERPOP-1381 URL: https://issues.apache.org/jira/browse/TINKERPOP-1381 Project: TinkerPop

Re: [VOTE] TinkerPop 3.2.1 Release

2016-07-20 Thread Stephen Mallette
I'll clarify a little bit - I missed a piece of Pieter's email. I focused on the "thread interruption" but he also mentioned a problem with tail() - which Jason Plurad has already submitted a PR for: https://github.com/apache/tinkerpop/pull/363 In this case the bug is on our side in TinkerPop but

Re: [VOTE] TinkerPop 3.2.1 Release

2016-07-20 Thread Daniel Kuppitz
> > imo, a -1 should be reserved for when there is a massive bug that brings down > the house I concur. I've also found some nasty bugs in OLAP during my tests and even if without a workaround I would probably have voted +1, as this has nothing to do with the release. you have a single backend f

[jira] [Commented] (TINKERPOP-1379) unaccounted excess in TailGlobalStep

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386177#comment-15386177 ] ASF GitHub Bot commented on TINKERPOP-1379: --- GitHub user pluradj opened a pu

[GitHub] tinkerpop pull request #363: TINKERPOP-1379 remove excess bulk in tail buffe...

2016-07-20 Thread pluradj
GitHub user pluradj opened a pull request: https://github.com/apache/tinkerpop/pull/363 TINKERPOP-1379 remove excess bulk in tail buffer https://issues.apache.org/jira/browse/TINKERPOP-1379 You can merge this pull request into a Git repository by running: $ git pull https://git

Re: [VOTE] TinkerPop 3.2.1 Release

2016-07-20 Thread Stephen Mallette
Pieter, Thanks as usual for testing. I would offer than this is not a case for a -1. Note that a -1 says we abort the release completely. imo, a -1 should be reserved for when there is a massive bug that brings down the house - meaning the system is abend in some way and there are no workarounds.

Re: [VOTE] TinkerPop 3.2.1 Release

2016-07-20 Thread pieter-gmail
Hi, Ran all Sqlg's tests and the process and structured test suites. But alas there are failures. TraversalInterruptionTest are failing on HSQLDB as the Thread.interrupt() is intercepted by them and the interrupt flag is reset. The TraversalInterruptionTest tests themselves suffers from this as

Re: [VOTE] TinkerPop 3.1.3 Release

2016-07-20 Thread Ted Wilmes
valitedate-distribution.sh looked good from my end along with manual tests and a review of the generated java and other docs. VOTE: +1 --Ted On Tue, Jul 19, 2016 at 1:50 PM, Dylan Millikin wrote: > Added tests for all the new features in the PHP driver. > Installed gremlin-neo4j and ran the te

Re: [DISCUSS] New IO format for GLVs/Gremlin Server

2016-07-20 Thread gallardo.kev...@gmail.com
On 2016-07-19 22:28 (+0100), Marko Rodriguez wrote: > Hi, > > However, in general we just need an “object mapper pattern.” For instance: > > For any JSON object { } that has a @type field, the @type value maps to a > deserializer. Thus, while we need to be able to serialize/deserialize t

[jira] [Commented] (TINKERPOP-1179) AppVeyor Windows build is not stable

2016-07-20 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385718#comment-15385718 ] stephen mallette commented on TINKERPOP-1179: - [~velobr] i noticed that ap

[jira] [Updated] (TINKERPOP-1380) dedup() doesn't dedup in rare cases

2016-07-20 Thread Daniel Kuppitz (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kuppitz updated TINKERPOP-1380: -- Description: I stumbled across this issue when I tried to solve a problem on the mai

[jira] [Updated] (TINKERPOP-1380) dedup() doesn't dedup in rare cases

2016-07-20 Thread Daniel Kuppitz (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kuppitz updated TINKERPOP-1380: -- Description: I stumbled across this issue when I tried to solve a problem on the mai

[jira] [Created] (TINKERPOP-1380) dedup() doesn't dedup in rare cases

2016-07-20 Thread Daniel Kuppitz (JIRA)
Daniel Kuppitz created TINKERPOP-1380: - Summary: dedup() doesn't dedup in rare cases Key: TINKERPOP-1380 URL: https://issues.apache.org/jira/browse/TINKERPOP-1380 Project: TinkerPop Issue

[jira] [Commented] (TINKERPOP-1379) unaccounted excess in TailGlobalStep

2016-07-20 Thread pieter martin (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385507#comment-15385507 ] pieter martin commented on TINKERPOP-1379: -- This is causing Sqlg's tests to f