[
https://issues.apache.org/jira/browse/TINKERPOP-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-2007.
---
Resolution: Won't Do
See the discussion on the pull request
https://github.com/
[
https://issues.apache.org/jira/browse/TINKERPOP-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564296#comment-16564296
]
ASF GitHub Bot commented on TINKERPOP-2007:
---
Github user asfgit closed the
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/892
---
[
https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564106#comment-16564106
]
ASF GitHub Bot commented on TINKERPOP-2006:
---
Github user spmallette comment
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/891
oh - and if your build is failing on the `gremlin-python` module then that
is a known issue at this point. i only just fixed my local build and i'm still
not sure how i did that. feel free to i
[
https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564100#comment-16564100
]
ASF GitHub Bot commented on TINKERPOP-2006:
---
Github user spmallette comment
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/891
you should have been able to just keep pushing commits to the same branch
you had and they would have reflected here in this pull request.
if you destroyed your repo and re-cloned then
[
https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564086#comment-16564086
]
ASF GitHub Bot commented on TINKERPOP-2006:
---
Github user svanteschubert com
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/891
What is the correct GitHub / Tinkerpop procedure to update a patch? Do you
have a pointer?
I decided to start from scratch and cloned a fresh Tinkerpop repro, to
start a fresh git
I don't know what I did to fix it but my local environment builds again
(updated all kinda things in no particular orderugh, rage updating) -
docker is still hosed for me
On Tue, Jul 31, 2018 at 11:08 AM Stephen Mallette
wrote:
> master
>
> On Tue, Jul 31, 2018 at 11:04 AM Robert Dale wrote
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563917#comment-16563917
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user dimas-b commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206594732
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
---
@@ -72,8 +73,19 @@ protected AbstractOpProcess
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/892
Thanks for understanding - i'll see you over on #891
---
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/892
Yes, let us not waste any further time on such a trivial topic.
If everyone else feels fine with an optional normalization of integer keys
jumping around than it should be fine for
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/892
Ok - personally, I'm not in favor of an `Integer` only approach because it
is too narrow a case and only helps TinkerGraph in one specific situation. I
think that for your use case of regressio
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563855#comment-16563855
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user dimas-b commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206581828
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
---
@@ -72,8 +73,19 @@ protected AbstractOpProcess
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/892
Exactly, in case of normalization of GraphML output use the existing string
sort heuristic as a fallback and test the keys for Integer and cast them.
Perhaps the goal to allow natural s
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/892
I'm sorry but I'm not following what you're proposing for the id sorting.
Just to be clear, are you saying you want to convert to integer if the id is
integer and sort on that otherwise, use th
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563824#comment-16563824
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206571425
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
---
@@ -252,15 +264,29 @@ protected boolean isF
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206570383
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
---
@@ -222,9 +223,33 @@ protected Abstract
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563818#comment-16563818
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563812#comment-16563812
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206569252
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
---
@@ -222,9 +223,33 @@ protected Abstract
[
https://issues.apache.org/jira/browse/TINKERPOP-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1983.
---
Resolution: Won't Do
> Update Log4j to Log4j2
> --
>
>
master
On Tue, Jul 31, 2018 at 11:04 AM Robert Dale wrote:
> what branch are you building?
>
> Robert Dale
>
>
> On Tue, Jul 31, 2018 at 11:03 AM Stephen Mallette
> wrote:
>
> > now 3.5 doesn't even work for me. docker doesn't work either :(
> >
> > On Tue, Jul 31, 2018 at 7:38 AM Stephen Malle
what branch are you building?
Robert Dale
On Tue, Jul 31, 2018 at 11:03 AM Stephen Mallette
wrote:
> now 3.5 doesn't even work for me. docker doesn't work either :(
>
> On Tue, Jul 31, 2018 at 7:38 AM Stephen Mallette
> wrote:
>
> > As of this morning I noticed that gremlinpython doesn't buil
now 3.5 doesn't even work for me. docker doesn't work either :(
On Tue, Jul 31, 2018 at 7:38 AM Stephen Mallette
wrote:
> As of this morning I noticed that gremlinpython doesn't build anymore on
> python 3.4 - I get that awful:
>
> > Python.h: No such file or directory compilation terminated.
>
Github user dimas-b commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206559210
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/ResponseHandlerContext.java
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to t
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563784#comment-16563784
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/892
@robertdale Generally you are right, but here we are talking about
normalisation, which implies a certain order.
I find your statement to test XML with XML tools and graphs with g
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563763#comment-16563763
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user dimas-b commented on the issue:
https://github.com/apache/tinkerpop/pull/899
I see a test failure related to log message interception in the automated
build:
```
[ERROR] shouldAllowAtMostOneFinalResponse[writeAndFlush(ResponseStatusCode,
Object)](org.apache.ti
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/892
I don't like this patch. If the regression tests rely on some sort order
in xml, they're doing it wrong. If it's the graph being validated, then the
test should pull it into a graph engine an
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563747#comment-16563747
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user dimas-b commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206549700
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/ResponseHandlerContext.java
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to t
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563744#comment-16563744
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user dimas-b commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206549368
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/message/ResponseStatusCodeTest.java
---
@@ -0,0 +1,35 @@
+/*
+ * Licen
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/892
As we do not know anything about the nature of the user given keys, we can
not provide the 'correct' sorting algorithm for normalization. In this case, I
tend to favour the natural ordering
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563738#comment-16563738
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user dimas-b commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206547429
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
---
@@ -252,15 +264,29 @@ protected boolean isForc
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563723#comment-16563723
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user dimas-b commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206542682
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
---
@@ -222,9 +223,33 @@ protected AbstractEva
[
https://issues.apache.org/jira/browse/TINKERPOP-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563721#comment-16563721
]
Florian Hockmann commented on TINKERPOP-1983:
-
First, thanks for the link
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563716#comment-16563716
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user dimas-b commented
Github user dimas-b commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206540558
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
---
@@ -222,9 +223,33 @@ protected AbstractEva
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/892
> at least reachable by API via Gremlin console for GraphML serialization
It's reachable - just configured the `GraphWriter`
[directly](http://tinkerpop.apache.org/docs/current/referenc
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/892
a) Regression testing seems easier when there is a deterministic way of
serialization, in case this is already, the normalization is fine to be
optional but at least reachable by API via Gr
[
https://issues.apache.org/jira/browse/TINKERPOP-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563662#comment-16563662
]
stephen mallette commented on TINKERPOP-1983:
-
I did a quick look around
[
https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563605#comment-16563605
]
ASF GitHub Bot commented on TINKERPOP-2006:
---
Github user svanteschubert com
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/891
1) Yes, "Collection vertexKeySet.." and same for the edge can still
be made final, good catch.
2) No, I did not make any performance test, do you have one for Tinkerpop,
what would
[
https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563604#comment-16563604
]
stephen mallette commented on TINKERPOP-2006:
-
regarding (4) - I think it
[
https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563574#comment-16563574
]
Svante Schubert commented on TINKERPOP-2006:
1) Yes, "Collection vertexKe
[
https://issues.apache.org/jira/browse/TINKERPOP-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1996.
---
Resolution: Done
> Introduce read() and write() steps
> -
[
https://issues.apache.org/jira/browse/TINKERPOP-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563560#comment-16563560
]
ASF GitHub Bot commented on TINKERPOP-1996:
---
Github user asfgit closed the
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/893
---
As of this morning I noticed that gremlinpython doesn't build anymore on
python 3.4 - I get that awful:
> Python.h: No such file or directory compilation terminated.
I upgrade to 3.5 and it works fine - anyone know why? and what does this
mean? do we also need to manage 3.4 and 3.5 builds? can w
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563479#comment-16563479
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206486615
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
---
@@ -252,15 +264,29 @@ protected boolean isF
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563477#comment-16563477
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563476#comment-16563476
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206486032
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
---
@@ -72,8 +73,19 @@ protected AbstractOpProc
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206485952
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
---
@@ -72,8 +73,19 @@ protected AbstractOpProc
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563474#comment-16563474
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206485044
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
---
@@ -222,9 +223,33 @@ protected Abstract
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563471#comment-16563471
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206483583
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
---
@@ -222,9 +223,33 @@ protected Abstract
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563470#comment-16563470
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206483311
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/ResponseHandlerContext.java
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed t
[
https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563468#comment-16563468
]
ASF GitHub Bot commented on TINKERPOP-2005:
---
Github user spmallette comment
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206482636
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/message/ResponseStatusCodeTest.java
---
@@ -0,0 +1,35 @@
+/*
+ * Li
[
https://issues.apache.org/jira/browse/TINKERPOP-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1174.
---
Resolution: Won't Do
> addVertex(Map properties) method
> ---
73 matches
Mail list logo
