Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
Rebased again to fix a merge conflict.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/867
VOTE +1 - thanks again @FlorianHockmann for dealing with another PR that
the required a lot of back/forth review
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
I just rebased and made the changes so that now the template is only packed
with:
`mvn clean install -Dnuget`.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/867
> Shouldn't the template be built and tested in the same phases as
Gremlin.Net itself?
Yes, I probably didn't make it clear :) I wanted to say any maven phase for
generating and building.
-
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
> we require nuget (to run nuget pack) only as part of the deploy phase.
I understand that part and I don't have anything against it, especially
when we add something to the "Pre-f
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/867
I tend to agree with @jorgebay unless there is some high risk of something
breaking in the template packaging (as i understand it we need nuget so that we
can do `nuget pack`) on release day wh
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/867
I would like to propose that we generate and build `Gremlin.Net.Template`
project and run its tests as part of the `package` phase but we require nuget
(to run `nuget pack`) only as part of the `
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
> so if the version changed from 4..4.1
Good point, I haven't considered that. I amended my last commit to include
the solution you proposed. The downloaded exe now simply contains
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/867
I guess that will workI wonder if this should be a bit more bulletproof
though? on `deploy` phase we used to get a fresh nuget every time so if the
version changed from 4..4.1 we were in go
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
You're right. It shouldn't be necessary to have an internet connection when
all dependencies are already available. I thought that nuget.exe would only be
downloaded once as we have the `a
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/867
Your approach with `mono` works pretty nicely. It still bothers me a little
bit that every build though requires download of nuget though for just a `mvn
package`. That of course means that you
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
Turns out that it was very easy to add a check if mono is present and
otherwise skip the package of the template:
```xml
```
I rebased and squashed the commit
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
> Or, would it be crazy to only package templates if mono is present?
I think that would be the best solution here. It wouldn't introduce any new
dependencies to the build and it w
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/867
@FlorianHockmann i don't know if any of the following makes any sense, but
would it be crazy to only package templates on deploy (since mono is already
required there)? or do we need to continu
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
Rebased and I extended the `gremlin-archetypes` section in the reference
docs by splitting it into two sections: _Maven Archetypes_ and _Gremlin.Net
Template_. In the future, we can add mo
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/867
Maybe we could wait until `dotnet` toolchain supports packaging and pushing
templates (is there a ticket for it?), instead of increasing the complexity of
the deploy process by requiring Mono.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/867
Cool. A few comments/questions:
1. sorry - you will need to rebase as i just updated dev docs and now this
PR is conflicted
2. I guess the Giraph failure doesn't matter - it seems l
17 matches
Mail list logo
