Re: io and graphson-v3

alle...@gmail.com] > Sent: Wednesday, September 06, 2017 1:45 PM > To: dev@tinkerpop.apache.org > Subject: Re: io and graphson-v3 > > never mind - i see what's messed up > > On Wed, Sep 6, 2017 at 1:43 PM, Stephen Mallette <spmalle...@gmail.com> > wrote: > > &g

RE: io and graphson-v3

This v3 looks like a <3 heart where the top broke off. Sad. -Original Message- From: Stephen Mallette [mailto:spmalle...@gmail.com] Sent: Wednesday, September 06, 2017 1:45 PM To: dev@tinkerpop.apache.org Subject: Re: io and graphson-v3 never mind - i see what's messed up On Wed,

Re: io and graphson-v3

never mind - i see what's messed up On Wed, Sep 6, 2017 at 1:43 PM, Stephen Mallette wrote: > Which tests in particular are failing for SerializationTest? all of them? > > On Wed, Sep 6, 2017 at 1:35 PM, pieter gmail > wrote: > >> Hi, >> >> Pulled

Re: io and graphson-v3

Which tests in particular are failing for SerializationTest? all of them? On Wed, Sep 6, 2017 at 1:35 PM, pieter gmail wrote: > Hi, > > Pulled TINKERPOP-1767 branch, changed SqlgGraph's io method and ran the > tests. > > All the io tests are passing. > Only

Re: io and graphson-v3

Hi, Pulled TINKERPOP-1767 branch, changed SqlgGraph's io method and ran the tests. All the io tests are passing. Only SerializationTest fails for the same reason. It too needs the version specified. I did that locally and then all tests passes. Thanks Pieter On 06/09/2017 18:09, Stephen

Re: io and graphson-v3

Thanks, I'll have a look. For now on 3.3.0 I'll OptOut of some io tests. I'll let you know the OptOut list. Thanks Pieter On 06/09/2017 18:09, Stephen Mallette wrote: Pieter, I created this issue: https://issues.apache.org/jira/browse/TINKERPOP-1767 and made an effort to try to figure a

Re: io and graphson-v3

Pieter, I created this issue: https://issues.apache.org/jira/browse/TINKERPOP-1767 and made an effort to try to figure a way to fix it: https://github.com/apache/tinkerpop/tree/TINKERPOP-1767 Note the change to TinkerGraph and its io() method. I suppose you could do something similar to get

Re: io and graphson-v3

Ok, at present there is only one SimpleModule, the default. I can make it v2 or v3 but not both. Lets say I make the SimpleModule support V2. Then when calling IoEdgeTest for     {"graphson-v3", true, true,     (Function) g ->

Re: io and graphson-v3

I guess I'm trying to understand why it matters for purpose of the test. If you mix/match versions I can't think of why the test would care one way or the other. does sqlg serialize its id to a JSON Map? On Tue, Sep 5, 2017 at 11:19 AM, pieter gmail wrote: > I looked at

Re: io and graphson-v3

I looked at TinkerGraph's implementation. In fact I copied it. TinkerGraph does not have any special id serialization. In fact both its TinkerIoRegistryV3d0 andTinkerIoRegistryV2d0 registry uses TinkerModuleV2d0. In IoCustomTest tests you call

Re: io and graphson-v3

You have registries for each version as well and default to v3. Please see TinkerGraph: https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java#L198 If the user wants to override that then that's their

Re: io and graphson-v3

Afraid I still don't quite get it. How do I register the different SimpleModules depending on the version. Currently it starts in SqlgGraph, @Override public I io(final Io.Builder builder) {     return (I) builder.graph(this).onMapper(mapper ->

Re: io and graphson-v3

I think you should just create a new SimpleModule for each version - don't try to put them in the same SqlgSimpleModule. It's a naming convention that users will have to follow rather than something explicitly enforced through code. On Sun, Sep 3, 2017 at 3:20 PM, pieter gmail

RE: io and graphson-v3

Hi, I am getting IO tests failures on 3.3.0. Sqlg has a SimpleModule which add serializers for its custom id.     SqlgSimpleModule() {     super("custom"); //    addSerializer(RecordId.class, new RecordId.RecordIdJacksonSerializerV2d0()); //    addDeserializer(RecordId.class, new