Request logging with async examples

2010-10-21 Thread Jeremy Boynes
When I run the async1 example in trunk, the request gets logged twice in the access log: 0:0:0:0:0:0:0:1%0 - - [20/Oct/2010:21:32:39 -0700] GET /examples/async/async1 HTTP/1.1 200 - 0:0:0:0:0:0:0:1%0 - - [20/Oct/2010:21:32:42 -0700] GET /examples/async/async1 HTTP/1.1 200 863 Is this the

buildbot success in ASF Buildbot on tomcat-trunk

2010-10-21 Thread buildbot
The Buildbot has detected a restored build of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/656 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk]

Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
Hi, Seems we are fine for 1.2.31 now that httpd 2.3 compiles without problems. I plan to tag 1.2.31_RC1 and make release candidate set of sources and bin at the ususal place. If voted we would just need to svn mv 1.2.31_RC1 1.2.31 If someone again needs more time for testing :) the release

DO NOT REPLY [Bug 50126] EL for JSF 1.2 doesn't work on JSP-Tag-Files (*.tag)

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50126 --- Comment #2 from lofwyr lof...@apache.org 2010-10-21 05:14:29 EDT --- Thanks for the quick reply. After defining the version in the implicit.tld it works fine. -- Configure bugmail:

svn commit: r1025899 - in /tomcat/trunk: java/org/apache/catalina/ha/session/BackupManager.java webapps/docs/changelog.xml

2010-10-21 Thread kfujino
Author: kfujino Date: Thu Oct 21 09:21:10 2010 New Revision: 1025899 URL: http://svn.apache.org/viewvc?rev=1025899view=rev Log: Add support for maxActiveSessions attributes to BackupManager. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java

DO NOT REPLY [Bug 50135] New: IPV6 problem: unable to connect from other host

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50135 Summary: IPV6 problem: unable to connect from other host Product: Tomcat Native Version: 1.1.20 Platform: PC Status: NEW Severity: normal Priority: P2

svn commit: r1025917 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-21 Thread kfujino
Author: kfujino Date: Thu Oct 21 09:59:19 2010 New Revision: 1025917 URL: http://svn.apache.org/viewvc?rev=1025917view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

DO NOT REPLY [Bug 50135] IPV6 problem: unable to connect from other host

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50135 michael.we...@hsh-berlin.com changed: What|Removed |Added OS/Version||Windows Server 2008

svn commit: r1025924 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml

2010-10-21 Thread kfujino
Author: kfujino Date: Thu Oct 21 10:15:26 2010 New Revision: 1025924 URL: http://svn.apache.org/viewvc?rev=1025924view=rev Log: Improve sending an access message in DeltaManager. maxInactiveInterval of not Manager but the session is used. If maxInactiveInterval is negative, an access message is

svn commit: r1025925 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-21 Thread kfujino
Author: kfujino Date: Thu Oct 21 10:19:06 2010 New Revision: 1025925 URL: http://svn.apache.org/viewvc?rev=1025925view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1025927 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-10-21 Thread kfujino
Author: kfujino Date: Thu Oct 21 10:21:02 2010 New Revision: 1025927 URL: http://svn.apache.org/viewvc?rev=1025927view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL:

svn commit: r1025932 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-21 Thread kfujino
Author: kfujino Date: Thu Oct 21 10:29:08 2010 New Revision: 1025932 URL: http://svn.apache.org/viewvc?rev=1025932view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1025936 - /tomcat/jk/trunk/native/common/jk_global.h

2010-10-21 Thread timw
Author: timw Date: Thu Oct 21 10:52:06 2010 New Revision: 1025936 URL: http://svn.apache.org/viewvc?rev=1025936view=rev Log: Fixing build for VS 2005 with Apache 2.0 The Apache 2.0 apr.h includes windows.h but doesn't include ws2tcpip.h, so we have to explicitly include it. Modified:

Re: Tagging JK 1.2.31

2010-10-21 Thread Tim Whittington
+1 I just committed a minor fix for the Apache 2.0 build with VS 2005 - not a blocker. cheers tim On Thu, Oct 21, 2010 at 8:02 PM, Mladen Turk mt...@apache.org wrote: Hi, Seems we are fine for 1.2.31 now that httpd 2.3 compiles without problems. I plan to tag 1.2.31_RC1 and make release

DO NOT REPLY [Bug 50135] IPV6 problem: unable to connect from other host

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50135 Pid pids...@apache.org changed: What|Removed |Added OS/Version||All --- Comment #1 from

DO NOT REPLY [Bug 50135] IPV6 problem: unable to connect from other host

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50135 michael.we...@hsh-berlin.com changed: What|Removed |Added OS/Version|All |Windows Server 2008

DO NOT REPLY [Bug 50130] Start Tomcat if $CATALINA_PID present and process not found.

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50130 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 50084] catalina.sh fix in #49728 breaks PID handling again

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50084 Mark Thomas ma...@apache.org changed: What|Removed |Added CC||mike...@gulik.co.nz

DO NOT REPLY [Bug 50135] IPV6 problem: unable to connect from other host

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50135 michael.we...@hsh-berlin.com changed: What|Removed |Added OS/Version||All --- Comment #3

Re: Request logging with async examples

2010-10-21 Thread Mark Thomas
On 21/10/2010 01:09, Jeremy Boynes wrote: When I run the async1 example in trunk, the request gets logged twice in the access log: 0:0:0:0:0:0:0:1%0 - - [20/Oct/2010:21:32:39 -0700] GET /examples/async/async1 HTTP/1.1 200 - 0:0:0:0:0:0:0:1%0 - - [20/Oct/2010:21:32:42 -0700] GET

DO NOT REPLY [Bug 50135] IPV6 problem: unable to connect from other host

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50135 michael.we...@hsh-berlin.com changed: What|Removed |Added OS/Version|All |Windows Server 2008

Re: Tagging JK 1.2.31

2010-10-21 Thread Rainer Jung
On 21.10.2010 09:02, Mladen Turk wrote: Hi, Seems we are fine for 1.2.31 now that httpd 2.3 compiles without problems. Yep. I plan to tag 1.2.31_RC1 and make release candidate set of sources and bin at the ususal place. If voted we would just need to svn mv 1.2.31_RC1 1.2.31 Hmmm, the

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 02:29 PM, Rainer Jung wrote: On 21.10.2010 09:02, Mladen Turk wrote: Hi, Hmmm, the problem with the RCs is: - either we don't want to change any contents of the release between the last RC and the release. Then the RCs do not contain any indication that they are actually

svn commit: r1025975 - /tomcat/jk/trunk/native/common/jk.rc

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 12:47:58 2010 New Revision: 1025975 URL: http://svn.apache.org/viewvc?rev=1025975view=rev Log: Set eol-style. Modified: tomcat/jk/trunk/native/common/jk.rc (contents, props changed) Modified: tomcat/jk/trunk/native/common/jk.rc URL:

Re: svn commit: r1025975 - /tomcat/jk/trunk/native/common/jk.rc

2010-10-21 Thread Mladen Turk
On 10/21/2010 02:47 PM, rj...@apache.org wrote: Propchange: tomcat/jk/trunk/native/common/jk.rc -- svn:eol-style = native Not needed, but it doesn't hurt :) rc.exe can compile a .rc with LF line endings.

[RESULT] [VOTE] Release Apache Tomcat 7.0.4

2010-10-21 Thread Mark Thomas
This vote passes with 5 votes for beta. They were: markt- PMC member Martin Dubuc - contributor timw - committer funkman - PMC member rjung- PMC member Thanks to everyone who took the time to test this release and vote. I'll move the release artifacts now and

DO NOT REPLY [Bug 50138] New: Lack of synchronization in org.apache.catalina.security.SecurityUtil

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50138 Summary: Lack of synchronization in org.apache.catalina.security.SecurityUtil Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: Linux Status: NEW

Re: svn commit: r1025975 - /tomcat/jk/trunk/native/common/jk.rc

2010-10-21 Thread Rainer Jung
On 21.10.2010 15:01, Mladen Turk wrote: On 10/21/2010 02:47 PM, rj...@apache.org wrote: Propchange: tomcat/jk/trunk/native/common/jk.rc -- svn:eol-style = native Not needed, but it doesn't hurt :) rc.exe can

Empty maven repos for servletapi / problem building extras

2010-10-21 Thread Rainer Jung
Hi, the maven repos configured in build.properties seems to be empty for the servletapi: http://repo1.maven.org/maven/servletapi/jars/ Should we switch to http://repo1.maven.org/maven2/javax/servlet/servlet-api/2.3/ or is that not a viable alternative? The jar file is needed to build our

DO NOT REPLY [Bug 50138] Lack of synchronization in org.apache.catalina.security.SecurityUtil

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50138 --- Comment #1 from Sebb s...@apache.org 2010-10-21 09:51:59 EDT --- That may not be the only bug. There are two instances of the following code: if(objectCache.containsKey(targetObject)){ methodsCache =

svn commit: r1026005 - in /tomcat/jk/trunk/native: common/jk_version.h configure.in

2010-10-21 Thread mturk
Author: mturk Date: Thu Oct 21 14:08:02 2010 New Revision: 1026005 URL: http://svn.apache.org/viewvc?rev=1026005view=rev Log: Version step needed for a release Modified: tomcat/jk/trunk/native/common/jk_version.h tomcat/jk/trunk/native/configure.in Modified:

svn commit: r1026009 - in /tomcat/jk/trunk/native: Makefile.am apache-1.3/Makefile.apxs.in apache-1.3/Makefile.in apache-2.0/Makefile.apxs.in apache-2.0/Makefile.in common/Makefile.in

2010-10-21 Thread mturk
Author: mturk Date: Thu Oct 21 14:17:31 2010 New Revision: 1026009 URL: http://svn.apache.org/viewvc?rev=1026009view=rev Log: Make maintainer-clean target usable Modified: tomcat/jk/trunk/native/Makefile.am tomcat/jk/trunk/native/apache-1.3/Makefile.apxs.in

svn commit: r1026011 - /tomcat/jk/trunk/native/Makefile.am

2010-10-21 Thread mturk
Author: mturk Date: Thu Oct 21 14:22:39 2010 New Revision: 1026011 URL: http://svn.apache.org/viewvc?rev=1026011view=rev Log: Cleanup everything with maintainer-clean Modified: tomcat/jk/trunk/native/Makefile.am Modified: tomcat/jk/trunk/native/Makefile.am URL:

Re: Tagging JK 1.2.31

2010-10-21 Thread Rainer Jung
On 21.10.2010 14:48, Mladen Turk wrote: On 10/21/2010 02:29 PM, Rainer Jung wrote: On 21.10.2010 09:02, Mladen Turk wrote: Hi, Hmmm, the problem with the RCs is: - either we don't want to change any contents of the release between the last RC and the release. Then the RCs do not contain

Re: Tagging JK 1.2.31

2010-10-21 Thread sebb
On 21 October 2010 16:02, Rainer Jung rainer.j...@kippdata.de wrote: On 21.10.2010 14:48, Mladen Turk wrote: On 10/21/2010 02:29 PM, Rainer Jung wrote: On 21.10.2010 09:02, Mladen Turk wrote: Hi, Hmmm, the problem with the RCs is: - either we don't want to change any contents of the

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 05:02 PM, Rainer Jung wrote: On 21.10.2010 14:48, Mladen Turk wrote: My point is: once we circulate something, ... But the point is that we don't circulate that. It's supposed to be used only by PMC members that would vote or no vote for that release. We are not creating

Re: Tagging JK 1.2.31

2010-10-21 Thread Igor Galić
- Rainer Jung rainer.j...@kippdata.de wrote: On 21.10.2010 14:48, Mladen Turk wrote: On 10/21/2010 02:29 PM, Rainer Jung wrote: On 21.10.2010 09:02, Mladen Turk wrote: Hi, Hmmm, the problem with the RCs is: - either we don't want to change any contents of the release

DO NOT REPLY [Bug 50139] New: System tray tool should include a Restart service option.

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50139 Summary: System tray tool should include a Restart service option. Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows Vista Status: NEW

DO NOT REPLY [Bug 50139] System tray tool should include a Restart service option.

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50139 Mladen Turk mt...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: Tagging JK 1.2.31

2010-10-21 Thread Rainer Jung
On 21.10.2010 17:47, Igor Galić wrote: tags are cheap (: I know that slogan, but from a users perspective I think missing versions are always strange. It's OK if it happens every now and then but it give a very strange feeling, if a lot of versions are not released. Regards, Rainer

svn commit: r1026042 - in /tomcat/trunk: java/org/apache/catalina/security/SecurityUtil.java webapps/docs/changelog.xml

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 15:58:21 2010 New Revision: 1026042 URL: http://svn.apache.org/viewvc?rev=1026042view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50138 Fix threading issues Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java

Re: Tagging JK 1.2.31

2010-10-21 Thread Rainer Jung
On 21.10.2010 17:44, Mladen Turk wrote: On 10/21/2010 05:02 PM, Rainer Jung wrote: On 21.10.2010 14:48, Mladen Turk wrote: My point is: once we circulate something, ... But the point is that we don't circulate that. It's supposed to be used only by PMC members that would vote or no vote for

svn commit: r1026045 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 16:00:27 2010 New Revision: 1026045 URL: http://svn.apache.org/viewvc?rev=1026045view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

DO NOT REPLY [Bug 50138] Lack of synchronization in org.apache.catalina.security.SecurityUtil

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50138 --- Comment #2 from Mark Thomas ma...@apache.org 2010-10-21 12:02:00 EDT --- Thanks for the report. Fixed in trunk for 7.0.5 onwards and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 05:58 PM, Rainer Jung wrote: On 21.10.2010 17:47, Igor Galić wrote: tags are cheap (: I know that slogan, but from a users perspective I think missing versions are always strange. It's OK if it happens every now and then but it give a very strange feeling, if a lot of versions

svn commit: r1026047 - /tomcat/trunk/webapps/docs/appdev/sample/src/mypackage/Hello.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 16:07:11 2010 New Revision: 1026047 URL: http://svn.apache.org/viewvc?rev=1026047view=rev Log: Remove unused imports from webapps Modified: tomcat/trunk/webapps/docs/appdev/sample/src/mypackage/Hello.java Modified:

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 05:59 PM, Rainer Jung wrote: 1.2.31 (r1003456) What file name do you plan for the RC source tarball? The same as a release. I'll put them in the p.a.o/~mturk for potential voters. Again, this is not a release, release candidate or something third. It is my proposal made from

svn commit: r1026049 - in /tomcat/trunk/test/org/apache: el/TestELEvaluation.java el/TestELInJsp.java jasper/compiler/TestAttributeParser.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 16:09:50 2010 New Revision: 1026049 URL: http://svn.apache.org/viewvc?rev=1026049view=rev Log: Allow Checkstyle's unused imports test to be used with the unit testcode Modified: tomcat/trunk/test/org/apache/el/TestELEvaluation.java

svn commit: r1026051 - in /tomcat/trunk/java/javax/servlet: ServletRequest.java ServletResponse.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 16:12:42 2010 New Revision: 1026051 URL: http://svn.apache.org/viewvc?rev=1026051view=rev Log: Allow Checkstyle's unused imports test to be used with the api classes Modified: tomcat/trunk/java/javax/servlet/ServletRequest.java

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:05 PM, Mladen Turk wrote: Before we were using tomcat.apache.org/dev/dist and this should be axed completely. What I mean, anything that we dist *must* be voted before. Since our entire site is mirrored anything on the site must be voted for (even if the readme says This is

svn commit: r1026054 - in /tomcat/trunk/java/org/apache/tomcat/util: http/fileupload/disk/DiskFileItem.java modeler/ManagedBean.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 16:18:12 2010 New Revision: 1026054 URL: http://svn.apache.org/viewvc?rev=1026054view=rev Log: Allow Checkstyle's unused imports test to be used with the o.a.tomcat.util classes Modified:

svn commit: r1026057 - /tomcat/trunk/java/org/apache/naming/SelectorContext.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 16:26:50 2010 New Revision: 1026057 URL: http://svn.apache.org/viewvc?rev=1026057view=rev Log: Allow Checkstyle's unused imports test to be used with this class Fix Eclipse warnings Modified: tomcat/trunk/java/org/apache/naming/SelectorContext.java Modified:

svn commit: r1026061 - in /tomcat/trunk/java/org/apache/naming/resources: DirContextURLStreamHandler.java DirContextURLStreamHandlerFactory.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 16:41:40 2010 New Revision: 1026061 URL: http://svn.apache.org/viewvc?rev=1026061view=rev Log: Fix Eclipse warnings Modified: tomcat/trunk/java/org/apache/naming/resources/DirContextURLStreamHandler.java

Re: Tagging JK 1.2.31

2010-10-21 Thread Rainer Jung
On 21.10.2010 18:05, Mladen Turk wrote: On 10/21/2010 05:58 PM, Rainer Jung wrote: On 21.10.2010 17:47, Igor Galić wrote: tags are cheap (: I know that slogan, but from a users perspective I think missing versions are always strange. It's OK if it happens every now and then but it give a

svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 16:52:56 2010 New Revision: 1026064 URL: http://svn.apache.org/viewvc?rev=1026064view=rev Log: Add svn revision to the end of the exposed version. The exposed version is only used during startup logging and in the jk status display. The revision in the

DO NOT REPLY [Bug 50140] New: Silent installation into wrong target directory

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50140 Summary: Silent installation into wrong target directory Product: Tomcat 6 Version: 6.0.26 Platform: PC Status: NEW Severity: normal Priority: P2 Component:

svn commit: r1026067 - /tomcat/jk/trunk/tools/jkrelease.sh

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 16:57:58 2010 New Revision: 1026067 URL: http://svn.apache.org/viewvc?rev=1026067view=rev Log: Replace JK_REVISION in jk_version.h by the actual revision of the whole tree when the tar is rolled. Also do it for release bundles. For those we don't add the revision

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:44 PM, Rainer Jung wrote: On 21.10.2010 18:05, Mladen Turk wrote: I will commit a small change to the release script, that will add the svn revision number to the end of JK_EXPOSED_VERSION. For me that is sufficient. And this would mean that this cannot be used as a

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung /* Source Control Revision as a suffix, e.g. -r12345 */ -#define JK_REVISION +#define JK_REVISION $Revision$ /** END OF AREA TO MODIFY BEFORE RELEASING */ @@ -65,7 +65,7 @@ #if (JK_VERRC != 0)

DO NOT REPLY [Bug 50140] Silent installation into wrong target directory

2010-10-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50140 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung -#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT +#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT JK_REVISION Ok, it seems I have to do it officially, so here it is: -1 veto Please revert adding this to the exposed version. (or

Re: Tagging JK 1.2.31

2010-10-21 Thread Rainer Jung
On 21.10.2010 19:05, Mladen Turk wrote: On 10/21/2010 06:44 PM, Rainer Jung wrote: On 21.10.2010 18:05, Mladen Turk wrote: I will commit a small change to the release script, that will add the svn revision number to the end of JK_EXPOSED_VERSION. For me that is sufficient. And this would

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Rainer Jung
On 21.10.2010 19:12, Mladen Turk wrote: On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung /* Source Control Revision as a suffix, e.g. -r12345 */ -#define JK_REVISION +#define JK_REVISION $Revision$ /** END OF AREA TO MODIFY BEFORE RELEASING */ @@ -65,7

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Rainer Jung
On 21.10.2010 20:01, Mladen Turk wrote: On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung -#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT +#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT JK_REVISION Ok, it seems I have to do it officially, so here it is: -1 veto Please

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 21/10/2010 20:33, Rainer Jung wrote: On 21.10.2010 19:12, Mladen Turk wrote: It means that we won't have jk-1.2.31 but jk-1.2.31-rSomething even for a release? You mean It means we won't have? or It means we will have? Guess it's a typo. Well, I meant we wont have just mod_jk-1.2.31

svn commit: r1026100 - in /tomcat/jk/trunk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_status.c common/jk_version.h iis/jk_isapi_plugin.c netscape/jk_nsapi_plugin.c

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 18:53:41 2010 New Revision: 1026100 URL: http://svn.apache.org/viewvc?rev=1026100view=rev Log: Remove revision from JK_EXPOSED_VERSION. New define JK_FULL_EXPOSED_VERSION contains the revision number, but only if release script is used. Keyword substitution doesn't

[PROPOSAL] Parallel deployment

2010-10-21 Thread Mark Thomas
All, As most of you are probably aware I work for SpringSource and SpringSource has an application server product - tc Server - that is heavily based on Apache Tomcat. When talking to prospective clients about tc Server, one of the things we often hear is WebSphere/WebLogic has XYZ feature -

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 21/10/2010 20:36, Rainer Jung wrote: On 21.10.2010 20:01, Mladen Turk wrote: On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung -#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT +#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT JK_REVISION Ok, it seems I have to do it

Re: svn commit: r1026100 - in /tomcat/jk/trunk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_status.c common/jk_version.h iis/jk_isapi_plugin.c netscape/jk_nsapi_plugin.c

2010-10-21 Thread Mladen Turk
On 21/10/2010 20:53, rj...@apache.org wrote: Author: rjung The new JK_FULL_EXPOSED_VERSION is used during init/startup/shutdown logging, not for the short version numbers. Ok that makes more sense, although I still don't get the what's the point and the *problem* you had to solve with adding

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Rainer Jung
On 21.10.2010 20:50, Mladen Turk wrote: On 21/10/2010 20:33, Rainer Jung wrote: On 21.10.2010 19:12, Mladen Turk wrote: It means that we won't have jk-1.2.31 but jk-1.2.31-rSomething even for a release? You mean It means we won't have? or It means we will have? Guess it's a typo. Well, I

svn commit: r1026111 - /tomcat/jk/trunk/native/common/jk_connect.c

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 19:30:57 2010 New Revision: 1026111 URL: http://svn.apache.org/viewvc?rev=1026111view=rev Log: Fix Netware runtime error. Patch provided by Guenter Knauf. Modified: tomcat/jk/trunk/native/common/jk_connect.c Modified: tomcat/jk/trunk/native/common/jk_connect.c

Re: [PROPOSAL] Parallel deployment

2010-10-21 Thread Sylvain Laurent
I discovered this feature a while ago in Weblogic and I found this interesting. But as I always had classloader leaks, I had to restart the JVM anyway so that it defeated the purpose of the feature and I gave up dreaming of zero-downtime deployments. Now with tomcat memory leak protection

svn commit: r1026119 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 19:53:34 2010 New Revision: 1026119 URL: http://svn.apache.org/viewvc?rev=1026119view=rev Log: Update changelog. Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL:

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Rainer Jung
On 21.10.2010 21:21, Mladen Turk wrote: On 10/21/2010 09:16 PM, Rainer Jung wrote: On 21.10.2010 20:50, Mladen Turk wrote: OK? OK :) Let's put this to the end. Peace. I hope it works now as expected. Do you have anything to add to the changelog? Regards, Rainer

svn commit: r1026132 - /tomcat/jk/trunk/tools/jkrelease.sh

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 20:38:51 2010 New Revision: 1026132 URL: http://svn.apache.org/viewvc?rev=1026132view=rev Log: Allow to release from a tag that does not conform to the format JK_MAJOR_MIDDLE_MINOR. - changed version number flag from -t to -v. This is the version that is used

svn commit: r1026133 - /tomcat/jk/trunk/HOWTO-RELEASE.txt

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 20:42:45 2010 New Revision: 1026133 URL: http://svn.apache.org/viewvc?rev=1026133view=rev Log: Fix wrong subversion path in Howto. Modified: tomcat/jk/trunk/HOWTO-RELEASE.txt Modified: tomcat/jk/trunk/HOWTO-RELEASE.txt URL:

svn commit: r1026134 - /tomcat/jk/tags/JK_1.2.31_JUST_A_TEST/

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 20:43:45 2010 New Revision: 1026134 URL: http://svn.apache.org/viewvc?rev=1026134view=rev Log: Just a test for the release script. Tag will be removed soon. Added: tomcat/jk/tags/JK_1.2.31_JUST_A_TEST/ - copied from r1026133, tomcat/jk/trunk/

svn commit: r1026135 - /tomcat/jk/tags/JK_1.2.31_JUST_A_TEST/

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 20:45:46 2010 New Revision: 1026135 URL: http://svn.apache.org/viewvc?rev=1026135view=rev Log: Remove test tag, another test needed. Removed: tomcat/jk/tags/JK_1.2.31_JUST_A_TEST/ - To

svn commit: r1026136 - /tomcat/jk/tags/JK_1_2_31_JUST_A_TEST/

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 20:46:21 2010 New Revision: 1026136 URL: http://svn.apache.org/viewvc?rev=1026136view=rev Log: Just a test for the release script. Tag will be removed soon. Added: tomcat/jk/tags/JK_1_2_31_JUST_A_TEST/ - copied from r1026135, tomcat/jk/trunk/

svn commit: r1026139 - /tomcat/jk/tags/JK_1_2_31_JUST_A_TEST/

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 20:58:38 2010 New Revision: 1026139 URL: http://svn.apache.org/viewvc?rev=1026139view=rev Log: Test done. Removed: tomcat/jk/tags/JK_1_2_31_JUST_A_TEST/ - To unsubscribe, e-mail:

svn commit: r1026142 - /tomcat/jk/trunk/tools/jkrelease.sh

2010-10-21 Thread rjung
Author: rjung Date: Thu Oct 21 21:02:24 2010 New Revision: 1026142 URL: http://svn.apache.org/viewvc?rev=1026142view=rev Log: Add a little verbosity to release script. Fix forgotten renames tag to version. Modified: tomcat/jk/trunk/tools/jkrelease.sh Modified:

Re: [PROPOSAL] Parallel deployment

2010-10-21 Thread Mark Thomas
On 21/10/2010 14:51, Sylvain Laurent wrote: Though I can see how this can be done for a standalone tomcat instance, how do you plan to do with clustered sessions ? Should the old version of the application wait for all sessions in the cluster to expire ? TBD. I haven't looked at this at all

Changes to jk release script

2010-10-21 Thread Rainer Jung
To simplify Mladen's plan to use RCs for jk release, but not including the RC name in the tarballs I adjusted the jk release script a bit: - flag -t is now -v for version and works as before - new optional flag -t allows to explicitely give a tag from which to release in case the default tag

Re: [PROPOSAL] Parallel deployment

2010-10-21 Thread Rainer Jung
On 21.10.2010 20:52, Mark Thomas wrote: All, As most of you are probably aware I work for SpringSource and SpringSource has an application server product - tc Server - that is heavily based on Apache Tomcat. When talking to prospective clients about tc Server, one of the things we often hear

Re: [PROPOSAL] Parallel deployment

2010-10-21 Thread Rainer Jung
On 21.10.2010 23:11, Mark Thomas wrote: On 21/10/2010 14:51, Sylvain Laurent wrote: Though I can see how this can be done for a standalone tomcat instance, how do you plan to do with clustered sessions ? Should the old version of the application wait for all sessions in the cluster to expire

svn commit: r1026150 - /tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 21:48:01 2010 New Revision: 1026150 URL: http://svn.apache.org/viewvc?rev=1026150view=rev Log: Allow Checkstyle's unused imports test to be used with this class Fix Eclipse warnings Align modifyAttributes() with WARDirContext Modified:

svn commit: r1026152 - /tomcat/trunk/java/org/apache/naming/resources/jndi/Handler.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 21:53:09 2010 New Revision: 1026152 URL: http://svn.apache.org/viewvc?rev=1026152view=rev Log: Clean-up Modified: tomcat/trunk/java/org/apache/naming/resources/jndi/Handler.java Modified: tomcat/trunk/java/org/apache/naming/resources/jndi/Handler.java URL:

svn commit: r1026157 - /tomcat/trunk/java/org/apache/naming/resources/ProxyDirContext.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 22:09:45 2010 New Revision: 1026157 URL: http://svn.apache.org/viewvc?rev=1026157view=rev Log: Allow Checkstyle's unused imports test to be used with this class Fix Eclipse warnings Modified: tomcat/trunk/java/org/apache/naming/resources/ProxyDirContext.java

svn commit: r1026163 - in /tomcat/trunk/java/org/apache/naming/resources: RecyclableNamingEnumeration.java Resource.java ResourceAttributes.java ResourceCache.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 22:14:58 2010 New Revision: 1026163 URL: http://svn.apache.org/viewvc?rev=1026163view=rev Log: Fix Eclipse warnings Modified: tomcat/trunk/java/org/apache/naming/resources/RecyclableNamingEnumeration.java

svn commit: r1026164 - /tomcat/trunk/java/org/apache/naming/resources/WARDirContext.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 22:20:32 2010 New Revision: 1026164 URL: http://svn.apache.org/viewvc?rev=1026164view=rev Log: Allow Checkstyle's unused imports test to be used with this class Fix Eclipse warnings Modified: tomcat/trunk/java/org/apache/naming/resources/WARDirContext.java

svn commit: r1026165 - /tomcat/trunk/java/org/apache/naming/NamingContext.java

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 22:24:01 2010 New Revision: 1026165 URL: http://svn.apache.org/viewvc?rev=1026165view=rev Log: Allow Checkstyle's unused imports test to be used with this class Fix some Eclipse warnings Modified: tomcat/trunk/java/org/apache/naming/NamingContext.java

svn commit: r1026166 - /tomcat/trunk/webapps/docs/changelog.xml

2010-10-21 Thread markt
Author: markt Date: Thu Oct 21 22:28:59 2010 New Revision: 1026166 URL: http://svn.apache.org/viewvc?rev=1026166view=rev Log: Add release date Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1026212 - in /tomcat/jk/trunk/native/netscape: Makefile.linux Makefile.solaris Makefile.vc nsapi.dsp

2010-10-21 Thread mturk
Author: mturk Date: Fri Oct 22 05:13:19 2010 New Revision: 1026212 URL: http://svn.apache.org/viewvc?rev=1026212view=rev Log: Unify the server variable across platforms. Oracle is now again calling that iPlanet, as once originaly was Modified: tomcat/jk/trunk/native/netscape/Makefile.linux

svn commit: r1026213 - /tomcat/jk/trunk/native/netscape/README

2010-10-21 Thread mturk
Author: mturk Date: Fri Oct 22 05:14:15 2010 New Revision: 1026213 URL: http://svn.apache.org/viewvc?rev=1026213view=rev Log: Update readme as well Modified: tomcat/jk/trunk/native/netscape/README Modified: tomcat/jk/trunk/native/netscape/README URL:

svn commit: r1026216 - /tomcat/jk/trunk/native/apache-2.0/Makefile.vc

2010-10-21 Thread mturk
Author: mturk Date: Fri Oct 22 05:25:49 2010 New Revision: 1026216 URL: http://svn.apache.org/viewvc?rev=1026216view=rev Log: Add support for Apache 2.3 Modified: tomcat/jk/trunk/native/apache-2.0/Makefile.vc Modified: tomcat/jk/trunk/native/apache-2.0/Makefile.vc URL: