Re: Refactoring and Cleanup of OS Name property usage

On 10/3/2018 4:41 AM, Mark Thomas wrote: On 03/10/18 00:48, Igal Sapir wrote: Regarding this: On 10/2/2018 3:54 PM, Igal Sapir wrote: Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

Chris, Thank you for the feedback: On 10/3/2018 10:01 AM, Christopher Schultz wrote: On 10/2/18 17:39, isa...@apache.org wrote: Author: isapir Date: Tue Oct 2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed test cases that errored due to path

Re: Refactoring and Cleanup of OS Name property usage

Regarding this: On 10/2/2018 3:54 PM, Igal Sapir wrote: Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field OS_NAME, as well as IS_LINUX and IS_MACOS, and use these fields instead of calling

Refactoring and Cleanup of OS Name property usage

Rainer pointed out to me the class JrePlatform [1], which has a helper field called IS_WINDOWS. I think that it would make sense to add a constant field OS_NAME, as well as IS_LINUX and IS_MACOS, and use these fields instead of calling System.getProperty("os.name") in multiple places - some

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

Rainer, On 10/2/2018 3:03 PM, Igal Sapir wrote: Hi Rainer, On 10/2/2018 2:54 PM, Rainer Jung wrote: Hi Igal, Am 02.10.2018 um 23:39 schrieb isa...@apache.org: Author: isapir Date: Tue Oct  2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

Hi Rainer, On 10/2/2018 2:54 PM, Rainer Jung wrote: Hi Igal, Am 02.10.2018 um 23:39 schrieb isa...@apache.org: Author: isapir Date: Tue Oct  2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed test cases that errored due to path case

Re: SSL Unit Tests Failing

Mark / Chris, On 10/2/2018 6:36 AM, Mark Thomas wrote: On 02/10/18 06:58, Igal Sapir wrote: When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures: org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2

Re: SSL Unit Tests Failing

Chris, On 10/2/2018 7:25 AM, Christopher Schultz wrote: On 10/2/18 01:58, Igal Sapir wrote: When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures: org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2

SSL Unit Tests Failing

When trying to run the unit test cases with `ant clean test` on the current trunk [1] I am getting two (per connector) failures: org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2] org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser FAILED [3]

Re: Proposed patch for o.a.c.users.MemoryUserDatabase

On 10/1/2018 12:08 PM, Mark Thomas wrote: On 27/09/18 16:57, Christopher Schultz wrote: All, I have a proposed patch to MemoryUserDatabase that changes the behavior when a triggered-reload fails. Recently, markt added code to allow database reloads, but if there is an error reloading the

Re: svn commit: r1840784 - in /tomcat/trunk: build.properties.default build.xml

On 9/13/2018 12:54 AM, Konstantin Kolinko wrote: 1. The version of Ant is already available as ${ant.version}. There is no need to call antversion task explicitly to get it. See built-in properties in Ant Manual http://ant.apache.org/manual-1.9.x/properties.html 2. This change can be mentioned

Re: JDBC drivers in WEB-INF/lib

On 9/11/2018 2:53 PM, Christopher Schultz wrote: On 9/11/18 3:33 PM, Michael Osipov wrote: ... plus numerous SO questions have been asked about this. ... Most of those questions haven't been answered by anyone who actually knows the answers. Sad but true. Igal

Re: Download Link on the Tomcat website

On 9/1/2018 7:33 AM, Konstantin Kolinko wrote: пт, 31 авг. 2018 г. в 20:49, Igal Sapir : Currently links to the Download pages can be either to the whichversion [1] page or the version-specific pages, e.g. "Tomcat 9" [2] etc. It will be very useful to have a generic dow

Download Link on the Tomcat website

Currently links to the Download pages can be either to the whichversion [1] page or the version-specific pages, e.g. "Tomcat 9" [2] etc.  It will be very useful to have a generic download.html that is future-proof.  For example, I am writing a blog post ATM and I want to link to a download

Re: JK release

On 8/21/2018 8:54 AM, Igal Sapir wrote: On 8/21/2018 2:42 AM, Mark Thomas wrote: There are quite a few open issues and enhancements and I very much doubt I'll be able to get to all of them so if any C coders have some spare cycles to help out that would be great (no JK experience necessary

Re: JK release

On 8/21/2018 2:42 AM, Mark Thomas wrote: Hi all, It is getting on for 6 months since the last JK release so I am planning on making a sweep of the open bugs, fixing what I can, tagging and calling a release vote. I'm hoping to be able to tag by the end of the week but, as always, circumstances

Re: makebase script and webapps

On 7/3/2018 1:48 PM, Michael Osipov wrote: Am 2018-07-03 um 22:37 schrieb Igal Sapir: On 7/3/2018 1:15 PM, Michael Osipov wrote: Am 2018-07-03 um 22:12 schrieb Mark Thomas: On 03/07/18 21:10, Michael Osipov wrote: Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov

Re: makebase script and webapps

On 7/3/2018 1:15 PM, Michael Osipov wrote: Am 2018-07-03 um 22:12 schrieb Mark Thomas: On 03/07/18 21:10, Michael Osipov wrote: Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov wrote: Am 2018-07-03 um 18:27 schrieb Mark Thomas: Hi, I've been looking at the

Re: makebase script and webapps

On 7/3/2018 9:27 AM, Mark Thomas wrote: Currently, we copy conf recursively but create an empty webapps. This is inconsistent as any directories under conf will (nearly always) be web application specific config. I think we should either copy web applications and config or not copy both. My

File Permissions in SVN/Git

The new files bin/makebase.bat and makebase.sh do not have the same permissions as the other files in bin, possibly because I committed them from a Windows machine. Specifically, the file bin/makebase.sh is missing the eXecute permission. Any idea how to fix that? drwxrwxr-x. 2 ux ux 4096 Jul

Re: svn commit: r1834798 - in /tomcat/trunk/bin: makebase.bat makebase.sh

On 7/1/2018 12:18 PM, Michael Osipov wrote: Am 2018-07-01 um 20:44 schrieb isa...@apache.org: Author: isapir Date: Sun Jul  1 18:44:38 2018 New Revision: 1834798 URL: http://svn.apache.org/viewvc?rev=1834798=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62500 Added scripts to

Re: Plans for AJP

On 6/27/2018 1:02 PM, Rainer Jung wrote: Not trying to deviate, but any header set with mod_headers RequestHeader directive should automatically be forwarded (I use it often eg. for request IDs). Alternatively one can use JkEnvVar to forward httpd request environment variables as request

Re: Plans for AJP

On 6/27/2018 11:28 AM, Rémy Maucherat wrote: On Wed, Jun 27, 2018 at 7:09 PM Mark Thomas wrote: On 27/06/18 17:50, Rainer Jung wrote: Since encryption would be most of the most useful features and IMHO we won't get there, I suggest we discuss deprecation and EOL dates for AJP - meaning

Re: [Git migration] Developer process

On 5/31/2018 3:00 AM, Mark Thomas wrote: Hi, The next issue to resolve for the Git migration is developer process. Note that this does not cover branch names, merge strategy etc. This is issue is about the options available for developers to organise their local development environment. The

Re: Thoughts on suggestions for new contributors

On 5/31/2018 3:28 AM, Mark Thomas wrote: As you may have noticed I have been working on the HttpParser unit tests over the last few days. This was prompted, as a result of the recent fqdn parsing issues, to ensure that the unit tests were covering all of the edge cases. While the fqdn parsing

Re: Fwd: Language for lists archives on Tomcat website

Chris, On 5/25/2018 4:48 PM, Christopher Schultz wrote: > > > All of the list archives are searchable. It's ironic that MARC has the > > worst interface of all of them, but 15 years ago when that page > waswritten, it was probably the only searchable one available. Looks like > MARC hasn't

SVN on Windows and new line characters

Hello, Commit r1832279 created a much larger diff than I expected. I am using TortoiseSVN on Windows and it looks like it recorded the NEW_LINE character changes. Does anyone know if there are settings to change that? Or can recommend a different SVN client? Another thing is that I couldn't

Re: Fwd: Language for lists archives on Tomcat website

On Fri, May 25, 2018 at 12:36 PM, Mark Thomas <ma...@apache.org> wrote: > On 25/05/18 20:31, Igal Sapir wrote: > > > > > I can either: > > > > 1) Add a [magnifying glass icon] next to each > > > > 2) Change the text to something like: &g

Fwd: Language for lists archives on Tomcat website

Hi all, The text for Archives currently reads: > at Apache, at MARC (searchable) , at MarkMail, at Nabble and at Mail Archive Which suggests that only MARC is searchable, but in fact MarkMail, at Nabble and Mail Archive are also searchable, and some provide a better search experience, so I want

Re: Responsive Website for tomcat.apache.org

Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642 which adjusts the search box alignment and adds a keyboard toggle with the Enter key when the hamburger menu icon has focus. Best, Igal On Thu, Jan 25, 2018 at 1:34 PM, Igal @ Lucee.org wrote: > On

Re: Responsive Website for tomcat.apache.org

UPDATE: On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir <i...@lucee.org> wrote: > To clarify, > > I have updated the code for the site. I have not updated the site itself > since I'm not a committer (my previous statement seemed unclear). > > A committer needs to patch the

Re: Responsive Website for tomcat.apache.org

To clarify, On Fri, Jan 19, 2018 at 4:24 PM, Igal Sapir <i...@lucee.org> wrote: > I have updated the site and it is now responsive. On browsers where the > width is 960px or smaller, the menu on the left is hidden and an hamburger > toggler button appears on the top left. Image

Re: Responsive Website for tomcat.apache.org

questions. Best, Igal On Fri, Jan 19, 2018 at 2:49 AM, Mark Thomas <ma...@apache.org> wrote: > On 19/01/18 08:34, Mark Thomas wrote: > > On 18/01/18 22:38, Igal Sapir wrote: > >> Hello, > >> > >> I have moved the static resources to a common directo

Re: Responsive Website for tomcat.apache.org

Hello, I have moved the static resources to a common directory at /res and I would like to push that as the first step of updating the website since that clean up makes the website's code easier to maintain. That will also get the process of updating the website started with a relatively

Responsive Website

Hi everyone, The Tomcat website at http://tomcat.apache.org/ is not using responsive design, and therefore is not very mobile-friendly. I have a lot of experience with Front End development and can fix that if given the approval. Any thoughts? Igal

<    1   2   3   4