Resources - Custom URL connections

2012-09-09 Thread Mark Thomas
This is issue f) in Konstantin's comments in TOMCAT-NEXT.txt This issue only applies if a custom URL scheme is required. I think we should park this issue until that question is answered. Mark - To unsubscribe, e-mail: dev-unsub

Re: svn commit: r1382367 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/ webapps/docs/config/

2012-09-10 Thread Mark Thomas
Keiichi Fujino wrote: >> /** >> + * Check for old versions of applications using parallel >deployment that are >> + * now unused (have no active sessions) and undeploy any that >are found. >> + */ >> +if (context != null) { >> +Manager man

Re: Resources - JarScanner / WebappClassLoader

2012-09-10 Thread Mark Thomas
On 09/09/2012 20:01, Mark Thomas wrote: > This is issue d) in Konstantin's comments in TOMCAT-NEXT.txt > > Konstantin is right to point out the inefficiencies in JarScanner. There > is no need to scan WEB-INF/lib and WEB-INF/classes as the class path > from the WebappClassLoa

Re: Resources - JarScanner / WebappClassLoader

2012-09-10 Thread Mark Thomas
On 10/09/2012 15:11, Mark Thomas wrote: > On 09/09/2012 20:01, Mark Thomas wrote: >> This is issue d) in Konstantin's comments in TOMCAT-NEXT.txt >> >> Konstantin is right to point out the inefficiencies in JarScanner. There >> is no need to scan WEB-INF/lib and W

Re: Resources - JarScanner / WebappClassLoader

2012-09-10 Thread Mark Thomas
On 10/09/2012 17:34, Mark Thomas wrote: > On 10/09/2012 15:11, Mark Thomas wrote: >> On 09/09/2012 20:01, Mark Thomas wrote: >>> This is issue d) in Konstantin's comments in TOMCAT-NEXT.txt >>> >>> Konstantin is right to point out the inefficiencies in Jar

Re: Resources - Remaining TODOs

2012-09-11 Thread Mark Thomas
On 09/09/2012 19:23, Mark Thomas wrote: > This thread is for tracking the remaining TODO items. > > An initial brain dump of to do items: > > 1. Run Tomcat 7 TCKs >a) To check they pass (minus the API tests which will fail) JSP TCK passes minus the API test which is expect

Re: svn commit: r1384102 - in /tomcat/sandbox/trunk-resources/java/org/apache/catalina/webresources: Constants.java FileResource.java JarResource.java LocalStrings.properties ResourceBase.java

2012-09-13 Thread Mark Thomas
On 12/09/2012 22:51, Konstantin Kolinko wrote: > 2012/9/12 : >> +public static final String Package = "org.apache.catalina.webresoucres"; > > There is a typo in the above constant value. Thanks. I'll fix that. Mark - To u

Re: Tomcat 7: NIO Connector SSL-Support

2012-09-14 Thread Mark Thomas
On 14/09/2012 16:40, Christian Kahlo wrote: > Are there any plans to make things more abstract, No. > i.e. the possibility to inject a > > ByteChannel (or NioChannel / SecureNioChannel) into the EndPoint > > implementation or is it a design goal to use SSLContext + SSLEngine > directly in NioEn

Re: Resources - The need for refactoring

2012-09-14 Thread Mark Thomas
On 09/09/2012 19:34, Mark Thomas wrote: > This is issue a) in Konstantin's comments in TOMCAT-NEXT.txt > > My expectation is that the need for refactoring in some form or another > is clear. Currently Tomcat has the following features: > - aliases > - resource JAR

Re: svn commit: r1381633 - in /tomcat/trunk: java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/manager-howto.xml

2012-09-15 Thread Mark Thomas
On 06/09/2012 16:02, schu...@apache.org wrote: > Author: schultz > Date: Thu Sep 6 15:02:42 2012 > New Revision: 1381633 > > URL: http://svn.apache.org/viewvc?rev=1381633&view=rev > Log: > Added multi-op modes to JMXProxyServlet. > > Modified: > tomcat/trunk/java/org/apache/catalina/manager/

Re: Resources - Remaining TODOs

2012-09-18 Thread Mark Thomas
On 09/09/2012 19:23, Mark Thomas wrote: > This thread is for tracking the remaining TODO items. > > An initial brain dump of to do items: > > 1. Run Tomcat 7 TCKs >a) To check they pass (minus the API tests which will fail) JSP TCK passes. Servlet TCK not yet tested. >

Re: Resources - The need for refactoring

2012-09-19 Thread Mark Thomas
On 14/09/2012 19:12, Mark Thomas wrote: > On 09/09/2012 19:34, Mark Thomas wrote: >> This is issue a) in Konstantin's comments in TOMCAT-NEXT.txt >> >> My expectation is that the need for refactoring in some form or another >> is clear. Currently Tomcat has the

Re: Resources - Is DirContext the right basis for the API?

2012-09-19 Thread Mark Thomas
On 09/09/2012 19:50, Mark Thomas wrote: > This is part of issue b) in Konstantin's comments in TOMCAT-NEXT.txt > > Konstantin has accurately summed up the issues with basing the API on > DirContext as: > - Unnecessary objects, e.g. NamingException instead of null.

Re: Resources - Remaining TODOs

2012-09-20 Thread Mark Thomas
On 18/09/2012 14:55, Mark Thomas wrote: > On 09/09/2012 19:23, Mark Thomas wrote: >> This thread is for tracking the remaining TODO items. >> >> An initial brain dump of to do items: >> >> 1. Run Tomcat 7 TCKs >>a) To check they pass (minus the AP

Re: Resources - Performance (caching)

2012-09-20 Thread Mark Thomas
On 09/09/2012 19:51, Mark Thomas wrote: > On 09/09/2012 19:44, Mark Thomas wrote: >> This is part of issue b) in Konstantin's comments in TOMCAT-NEXT.txt >> >> The current DirContext implementation supports caching in most but not >> all circumstances. It would be

Re: Resources - Performance (caching)

2012-09-20 Thread Mark Thomas
Konstantin Kolinko wrote: >2012/9/20 Mark Thomas : >> A simple JMeter test requesting the same static file over and over >again >> shows that the original DirContext implementation is around 5 times >> faster than the new Resources implementation. >> >> I t

Re: svn commit: r1388991 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/ExtendedAccessLogValve.java webapps/docs/config/valve.xml

2012-09-23 Thread Mark Thomas
On 23/09/2012 12:04, Rainer Jung wrote: > Hi Mark, > > On 23.09.2012 11:43, ma...@apache.org wrote: >> Author: markt >> Date: Sun Sep 23 09:43:43 2012 >> New Revision: 1388991 >> >> URL: http://svn.apache.org/viewvc?rev=1388991&view=rev >> Log: >> Use CharBuffer rather than StringBuilder to build

Recent performance tweaks in trunk

2012-09-23 Thread Mark Thomas
All, You will have a seen a handful of changes over the last few days related to performance and garbage generation. I wanted to provide a little background. As part of testing the new Resources implementation I have been running the follow ab test: ab -c 4 -k -n 100 http://localhost:8080/te

Re: svn commit: r1389023 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2012-09-23 Thread Mark Thomas
On 23/09/2012 15:10, Rainer Jung wrote: > On 23.09.2012 14:56, Konstantin Kolinko wrote: >> 2012/9/23 : >>> Author: markt >>> Date: Sun Sep 23 11:37:48 2012 >>> New Revision: 1389023 >>> >>> URL: http://svn.apache.org/viewvc?rev=1389023&view=rev >>> Log: >>> Review from rjung >>> >>> Modified: >>>

Re: svn commit: r1389076 - in /tomcat/trunk: java/org/apache/tomcat/util/collections/ test/org/apache/tomcat/util/collections/

2012-09-23 Thread Mark Thomas
On 23/09/2012 20:03, Konstantin Kolinko wrote: > 2012/9/23 : >> Author: markt >> Date: Sun Sep 23 15:20:38 2012 >> New Revision: 1389076 >> >> URL: http://svn.apache.org/viewvc?rev=1389076&view=rev >> Log: >> ConcurrentLinkedQueue is currently the biggest contributor to garbage in the >> load tes

Re: svn commit: r1389145 - in /tomcat/trunk/java/org/apache: catalina/connector/CoyoteAdapter.java tomcat/util/collections/ConcurrentWeakHashMap.java

2012-09-24 Thread Mark Thomas
Konstantin Kolinko wrote: >2012/9/24 : >> Author: markt >> Date: Sun Sep 23 21:09:22 2012 >> New Revision: 1389145 >> >> URL: http://svn.apache.org/viewvc?rev=1389145&view=rev >> Log: >> Some more low(ish) hanging fruit from the allocation hit list. This >accounts for ~8% due to the way Thread s

Re: Recent performance tweaks in trunk

2012-09-24 Thread Mark Thomas
On 24/09/2012 13:19, Remy Maucherat wrote: > On Sun, 2012-09-23 at 12:35 +0100, Mark Thomas wrote: >> ab -c 4 -k -n 100 http://localhost:8080/test-1k.txt > > The concurrency of the test is very low, there will be only 4 threads > used with that test, which means decent sync

Re: Recent performance tweaks in trunk

2012-09-24 Thread Mark Thomas
On 24/09/2012 16:04, Mark Thomas wrote: > On 24/09/2012 13:19, Remy Maucherat wrote: >> On Sun, 2012-09-23 at 12:35 +0100, Mark Thomas wrote: >>> ab -c 4 -k -n 100 http://localhost:8080/test-1k.txt >> >> The concurrency of the test is very low, there will be on

Re: WebClassLoader using SystemClassLoader to load ServletDef?

2012-09-25 Thread Mark Thomas
On 25/09/2012 13:19, Elgs Chen wrote: > Dear Tomcat Developers, > > I have a question regarding the behavior of the > WebClassLoader.loadClass(String name, boolean resolve) in the > org.apache.catalina.loader package. > > I have the following assumptions, please correct me if any is wrong: > 1,

Re: WebClassLoader using SystemClassLoader to load ServletDef?

2012-09-25 Thread Mark Thomas
On 25/09/2012 16:04, Elgs Chen wrote: > Hi Mark, > > Thanks for your fast answer. That helped me to narrow down the scope of this > problem. I understand line 262 is to initialize and create the common, shared > and catalina class loaders. But I'm still struggling how the > WebappClassLoader.lo

Re: to improve the performance of form-based upload for Tomcat 7

2012-09-25 Thread Mark Thomas
On 25/09/2012 15:14, Fastupload wrote: > Konstantin, to whom maybe concern, > > What's the right org that I can apply a commuter account of apache open > source project? You don't. You should read this [1]. Patches (in diff -u format) should be attached to Bugzilla issues. Mark [1] http://ww

Re: Resources - Is DirContext the right basis for the API?

2012-09-26 Thread Mark Thomas
On 19/09/2012 20:46, Mark Thomas wrote: > On 09/09/2012 19:50, Mark Thomas wrote: >> This is part of issue b) in Konstantin's comments in TOMCAT-NEXT.txt >> >> Konstantin has accurately summed up the issues with basing the API on >> DirContext as: &g

Re: Resources - Is DirContext the right basis for the API?

2012-09-27 Thread Mark Thomas
On 27/09/2012 10:09, Konstantin Kolinko wrote: > I am sure that DirContext is not the right API to define resources. > > At best is could be a [deprecated] view/proxy to the actual implementation. > > The only benefit I see in using this API by someone is that the API > itself is defined in javax

Re: Resources - Is DirContext the right basis for the API?

2012-09-27 Thread Mark Thomas
Costin Manolache wrote: >On Thu, Sep 27, 2012 at 2:14 AM, Mark Thomas wrote: > >> On 27/09/2012 10:09, Konstantin Kolinko wrote: >> > I am sure that DirContext is not the right API to define resources. >> > >> > At best is could be a [deprecated] vie

Time for Taglibs to be sent to the archive?

2012-10-01 Thread Mark Thomas
In the two+ years since Taglibs moved to the Tomcat project there have been a few short bursts of activity totalling just over 200 commits but no releases. There has also been no progress towards a migration to svnpubsub for the taglibs part of the web site. Given the lack of progress I would prop

Re: CMS or svnpubsub for Site

2012-10-01 Thread Mark Thomas
On 01/10/2012 07:48, Olivier Lamy wrote: > 2012/10/1 Konstantin Kolinko : >> 2012/10/1 Olivier Lamy : >>> Hi Folks, >>> I wonder what is the plan for CMS or svnpubsub for the web site ? >> >> The plan is to use svnpubsub. > Ok. >> >> The whole site is already in svn, except for subprojects that rel

Re: Tomcat 5.5.36

2012-10-01 Thread Mark Thomas
On 20/09/2012 17:45, Christopher Schultz wrote: > Jim, > > On 7/25/12 7:25 AM, Jim Jagielski wrote: >> >> On Jul 24, 2012, at 12:17 PM, Mark Thomas wrote: >> >>> On 24/07/2012 14:40, Jim Jagielski wrote: >>>> Any interest in seeing a 5.5.36 relea

Re: CMS or svnpubsub for Site

2012-10-01 Thread Mark Thomas
On 01/10/2012 10:36, Olivier Lamy wrote: > 2012/10/1 Mark Thomas : >> On 01/10/2012 07:48, Olivier Lamy wrote: >>> 2012/10/1 Konstantin Kolinko : >>>> 2012/10/1 Olivier Lamy : >>>>> Hi Folks, >>>>> I wonder what is the plan for CMS

Re: Tomcat 5.5.36

2012-10-01 Thread Mark Thomas
On 01/10/2012 09:11, Mark Thomas wrote: > On 20/09/2012 17:45, Christopher Schultz wrote: >> Jim, >> >> On 7/25/12 7:25 AM, Jim Jagielski wrote: >>> >>> On Jul 24, 2012, at 12:17 PM, Mark Thomas wrote: >>> >>>> On 24/07/2012 14:40, Jim Ja

[VOTE] Release Apache Tomcat 7.0.31

2012-10-01 Thread Mark Thomas
The proposed Apache Tomcat 7.0.31 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.31/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-073/ The svn tag is: http://svn.apache.org/r

Re: [VOTE] Release Apache Tomcat 7.0.31

2012-10-02 Thread Mark Thomas
On 01/10/2012 23:51, Konstantin Kolinko wrote: > 2012/10/2 Mark Thomas : >> The proposed Apache Tomcat 7.0.31 release is now available for voting. >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.31/ >> Th

[CANCELLED] [VOTE] Release Apache Tomcat 7.0.31

2012-10-02 Thread Mark Thomas
On 01/10/2012 22:07, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.31 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.31/ > The Maven staging repo is: > https://repository.apache.org/co

Re: svn commit: r1381633 - in /tomcat/trunk: java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/manager-howto.xml

2012-10-02 Thread Mark Thomas
On 15/09/2012 23:02, Mark Thomas wrote: > On 06/09/2012 16:02, schu...@apache.org wrote: >> Author: schultz >> Date: Thu Sep 6 15:02:42 2012 >> New Revision: 1381633 >> >> URL: http://svn.apache.org/viewvc?rev=1381633&view=rev >> Log: >> Added

Re: svn commit: r1381635 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/changelog.xml webapps/docs/manager-howto.xml

2012-10-02 Thread Mark Thomas
On 08/09/2012 14:37, Mark Thomas wrote: > On 08/09/2012 11:52, Konstantin Kolinko wrote: >> 2012/9/6 : >>> Author: schultz >>> Date: Thu Sep 6 15:08:58 2012 >>> New Revision: 1381635 >>> >>> URL: http://svn.apache.org/viewvc?rev

Re: svn commit: r1381633 - in /tomcat/trunk: java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/manager-howto.xml

2012-10-02 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/10/2012 17:30, Christopher Schultz wrote: > Mark, > > On 10/2/12 12:16 PM, Christopher Schultz wrote: >> Mark, >> >> On 10/2/12 5:16 AM, Mark Thomas wrote: >>> On 15/09/2012 23:02, Mark Thomas w

Re: svn commit: r1381635 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/changelog.xml webapps/docs/manager-howto.xml

2012-10-02 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/10/2012 17:41, Christopher Schultz wrote: > Yes, the code will become convoluted if we support more varieties > of operations but I figured that get/set or set/get (or invoke > replacing get or set in any of those) were by far to be the most > li

Re: trunk: An buffer exception in AccessLogValve.log(..)

2012-10-02 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/10/2012 21:37, Christopher Schultz wrote: > Konstantin, > > On 10/2/12 3:58 PM, Konstantin Kolinko wrote: >> 2012/10/2 Christopher Schultz : >>> Konstantin, >>> >>> On 10/2/12 2:32 PM, Konstantin Kolinko wrote: Running current trunk + Nio

[VOTE] Release Apache Tomcat 7.0.32

2012-10-03 Thread Mark Thomas
The proposed Apache Tomcat 7.0.32 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.32/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-087/ The svn tag is: http://svn.apache.org/r

Re: [VOTE] Release Apache Tomcat 7.0.32

2012-10-03 Thread Mark Thomas
On 03/10/2012 10:24, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.32 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.32/ > The Maven staging repo is: > https://repository.apache.org/co

Re: Tomcat 5.5.36

2012-10-05 Thread Mark Thomas
On 01/10/2012 10:52, Mark Thomas wrote: > OK. All the proposed patches are applied and 5.5.x is ready to tag and > roll the release. Jim? Jim is unlikely to be able to do this in the next few weeks so I propose to attempt this myself as 5.5.x is now end-of-life and we need to get the

Re: svn commit: r1394461 - /tomcat/tc5.5.x/trunk/build/build.properties.default

2012-10-05 Thread Mark Thomas
On 05/10/2012 12:55, ma...@apache.org wrote: > Author: markt > Date: Fri Oct 5 11:55:20 2012 > New Revision: 1394461 > > URL: http://svn.apache.org/viewvc?rev=1394461&view=rev > Log: > CTR: Version updates I assume no-one will object to these but it will take me a little while to figure out what

Re: svn commit: r1394473 - /tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml

2012-10-05 Thread Mark Thomas
On 05/10/2012 13:12, Konstantin Kolinko wrote: > 2012/10/5 : >> Author: markt >> Date: Fri Oct 5 12:08:20 2012 >> New Revision: 1394473 >> >> URL: http://svn.apache.org/viewvc?rev=1394473&view=rev >> Log: >> Update changelog >> >> Modified: >> tomcat/tc5.5.x/trunk/container/webapps/docs/chang

[VOTE] Release Apache Tomcat 5.5.36

2012-10-05 Thread Mark Thomas
The proposed Apache Tomcat 5.5.36 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-5/v5.5.36/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc5.5.x/tags/TOMCAT_5_5_36/ The proposed 5.5.36 release is: [ ] Broken - do not re

Re: svn commit: r1394104 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/

2012-10-06 Thread Mark Thomas
Konstantin Kolinko wrote: >2012/10/5 Christopher Schultz : >> RFCs 2616, 2068, and 1945 all agree that method name is >case-sensitive: >> http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1 >> > >OK. Agreed. > >Looking at Servlet spec 2.5, SRV.3.1.1 says "The HTTP method is POST". >

Re: [VOTE] Release Apache Tomcat 5.5.36

2012-10-07 Thread Mark Thomas
On 06/10/2012 21:33, Rainer Jung wrote: > - Minor things: > > - STATUS.txt in svn, but not in src tar and zip > (I guess that's expected) Yep. > - Some javadoc warnings (but no regression from 5.5.35), > TC 5.5 was never 100% clean for javadoc (details see below) Fixed in case ther

Re: [VOTE] Release Apache Tomcat 5.5.36

2012-10-07 Thread Mark Thomas
On 05/10/2012 14:49, Mark Thomas wrote: > The proposed Apache Tomcat 5.5.36 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-5/v5.5.36/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc5.5.x/

[VOTE][RESULT] Release Apache Tomcat 7.0.32

2012-10-07 Thread Mark Thomas
+1 (binding): markt, rjung, yoavs, olamy, kfujino +1 (non-binding): schultz No other votes were cast. The vote therefore passes. I'll start the release process. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [VOTE] Release Apache Tomcat 5.5.36

2012-10-09 Thread Mark Thomas
Ping. One more PMC +1 is required for this release. Mark On 05/10/2012 14:49, Mark Thomas wrote: > The proposed Apache Tomcat 5.5.36 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-5/v5.5.36/ > The svn

[ANN] Apache Tomcat 7.0.32 released

2012-10-09 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.32. Apache Tomcat is an open source software implementation of the Java Servlet and JavaServer Pages technologies. This release contains a small number of bug fixes and improvements compared to version 7.0.30. The no

Re: [VOTE] Release Apache Tomcat 5.5.36

2012-10-09 Thread Mark Thomas
On 09/10/2012 13:58, Konstantin Kolinko wrote: > 2012/10/5 Mark Thomas : >> The proposed Apache Tomcat 5.5.36 release is now available for voting. >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-5/v5.5.36/ >> The svn tag is: &

[VOTE][RESULT] Release Apache Tomcat 5.5.36

2012-10-09 Thread Mark Thomas
+1 (binding): markt, rjung, kkolinko No other votes were cast. The vote therefore passes. I'll start the release process. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev

Re: Resources - Custom URL scheme for unified access

2012-10-09 Thread Mark Thomas
On 09/09/2012 20:13, Mark Thomas wrote: > This is issue e) in Konstantin's comments in TOMCAT-NEXT.txt > I think this boils down to "Is there a requirement for a scheme that > provides unified URLs?" While it does hide the details of where stuff is > from an applicati

Resources - merging back the changes

2012-10-09 Thread Mark Thomas
I believe from the various threads on the Resources implementation for Tomcat 8 there is agreement that: - DirContext is not the right basis for the Resources API - Refactoring is required to simplify the multiple 'add-ons' and to provide a sound basis for overlays (which may slip to Servlet 3.2

Re: [Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-10 Thread Mark Thomas
Christopher Schultz wrote: >All, > >On 10/9/12 6:07 PM, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 >> >> --- Comment #4 from Christopher Schultz > --- >> (In reply to comment #3) >>> Possible cause: r1381417 >> >> Reverting that patch resolves the iss

[ANN] Apache Tomcat 5.5.36 released

2012-10-10 Thread Mark Thomas
The Apache Tomcat Team announces the immediate availability of Apache Tomcat 5.5.36. Apache Tomcat 5.5.36 is primarily a bug-fix release. As per the previous end of life announcement [1] this will almost certainly be the final Apache Tomcat 5.5.x release. Users of the 5.5.x series are strongly en

Time for 6.0.36?

2012-10-10 Thread Mark Thomas
It has been just over 10 months since the last 6.0.x release. The change log is looking pretty lengthy. I think we need a release. Jean-Frederic? Someone else? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

Re: svn commit: r1397390 - /tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java

2012-10-11 Thread Mark Thomas
On 12/10/2012 01:21, ma...@apache.org wrote: > Author: markt > Date: Fri Oct 12 00:21:23 2012 > New Revision: 1397390 > > URL: http://svn.apache.org/viewvc?rev=1397390&view=rev > Log: > Fix Eclipse Javadoc warning This commit is primarily to test buildbot as it now has Java 7 available and withou

Re: svn commit: r1397291 - in /tomcat/trunk/java/javax/servlet/http: HttpServletRequest.java HttpServletRequestWrapper.java ProtocolHandler.java WebConnection.java

2012-10-12 Thread Mark Thomas
On 12/10/2012 08:54, Konstantin Kolinko wrote: > 2012/10/12 : >> Author: markt >> Date: Thu Oct 11 20:29:01 2012 >> New Revision: 1397291 >> >> URL: http://svn.apache.org/viewvc?rev=1397291&view=rev >> Log: >> Fill in some of the HTTP upgrade Javadoc >> >> Modified: >> tomcat/trunk/java/javax/

Re: svn commit: r1397522 - in /tomcat/trunk/java/javax/net: ./ websocket/ websocket/annotations/ websocket/extensions/

2012-10-12 Thread Mark Thomas
On 12/10/2012 13:24, Martin Grigorov wrote: Please use quoting, particularly when you have a few short comments on a very large e-mail. Without quoting, your comments were more effort to find. >> Added: tomcat/trunk/java/javax/net/websocket/HandshakeRequest.java >> URL: >> http://svn.apache.org/

Re: Buidlbot for trunk (was: Re: svn commit: r1397390)

2012-10-12 Thread Mark Thomas
On 12/10/2012 09:01, Konstantin Kolinko wrote: > 2012/10/12 Mark Thomas : >> On 12/10/2012 01:21, ma...@apache.org wrote: >>> Author: markt >>> Date: Fri Oct 12 00:21:23 2012 >>> New Revision: 1397390 >>> >>> URL: http://svn.apache.org/viewvc

Re: Buidlbot for trunk (was: Re: svn commit: r1397390)

2012-10-13 Thread Mark Thomas
On 13/10/2012 12:45, Konstantin Kolinko wrote: > http://ci.apache.org/projects/tomcat/tomcat8/logs/1397390/TEST-org.apache.catalina.util.TestServerInfo.NIO.txt > > Architecture: amd64 > JVM Version:1.7.0_07-b10 > JVM Vendor: Oracle Corporation > > JDK 7u7. Nothing exotic there... > >

Re: svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread Mark Thomas
On 13/10/2012 22:43, ma...@apache.org wrote: > Author: markt > Date: Sat Oct 13 21:43:36 2012 > New Revision: 1397953 > > URL: http://svn.apache.org/viewvc?rev=1397953&view=rev > Log: > Run the UCDetector and remove unused code > Some follow-up remains. Drat. This clean-up was too aggressive. I n

Re: svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread Mark Thomas
On 14/10/2012 00:05, Konstantin Kolinko wrote: > 2012/10/14 Mark Thomas : >> On 13/10/2012 22:43, ma...@apache.org wrote: >>> Author: markt >>> Date: Sat Oct 13 21:43:36 2012 >>> New Revision: 1397953 >>> >>> URL: http://svn.apache.org/viewv

Re: svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread Mark Thomas
On 13/10/2012 23:57, Mark Thomas wrote: > On 13/10/2012 22:43, ma...@apache.org wrote: >> Author: markt >> Date: Sat Oct 13 21:43:36 2012 >> New Revision: 1397953 >> >> URL: http://svn.apache.org/viewvc?rev=1397953&view=rev >> Log: >> Run the UC

Re: [Bug 51698] ajp CPing/Forward-Request packet forgery, is a design decision? or a security vulnerability?

2012-10-15 Thread Mark Thomas
On 15/10/2012 10:21, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=51698 > > zhanqili changed: This idiot ^ has had their BZ account locked for messing about with this bug. I have restored the original values. Mark > >What|Removed

Re: Resources - merging back the changes

2012-10-16 Thread Mark Thomas
On 09/10/2012 22:27, Mark Thomas wrote: > I believe from the various threads on the Resources implementation for > Tomcat 8 there is agreement that: > > - DirContext is not the right basis for the Resources API > - Refactoring is required to simplify the multiple 'add-ons&#

Re: svn commit: r1389005 - in /tomcat/trunk/java/org/apache/catalina/valves: AccessLogValve.java Constants.java

2012-10-17 Thread Mark Thomas
On 17/10/2012 13:57, Konstantin Kolinko wrote: > 2012/9/23 : >> Author: markt >> Date: Sun Sep 23 10:36:58 2012 >> New Revision: 1389005 >> >> URL: http://svn.apache.org/viewvc?rev=1389005&view=rev >> Log: >> More GC reduction in the AccessLog. Integer.toString(response.getStatus()) >> was respon

Re: Resources - merging back the changes

2012-10-17 Thread Mark Thomas
On 17/10/2012 15:07, Konstantin Kolinko wrote: > 1. Are and able to inject individual files? Not yet, but that should be relatively simple to implement. > 2. I am -1 on removal of VirtualWebappLoader. > > The feature of injecting additional classpath entries into > WebappClassLoader.super.add

Re: SPDY/3

2012-10-17 Thread Mark Thomas
Costin Manolache wrote: >Hi, > >Most browsers are switching from SPDY/2 to 3, I'm working on updating >the >tomcat implementation as well. >I'm not sure if anyone has tried out or uses the SPDY support - or if >there >is still interest in supporting it ( >or doubts about keeping it ) - please let

Re: SPDY/3

2012-10-18 Thread Mark Thomas
On 17/10/2012 18:32, Mark Thomas wrote: > Costin Manolache wrote: > >> Hi, >> >> Most browsers are switching from SPDY/2 to 3, I'm working on >> updating the tomcat implementation as well. I'm not sure if anyone >> has tried out or uses the SPDY

Re: Where to start

2012-10-18 Thread Mark Thomas
Mridul Vishal wrote: >Hi, >I am a newcomer in the tomcat developers community. Welcome. > I tried to find out >the places where i can contribute something to the development >activities. However, not sure where to startI have few specific >queries. Hope you are the right person to answer it .

Re: [VOTE] Release build 6.0.36

2012-10-19 Thread Mark Thomas
On 19/10/2012 07:28, jean-frederic clere wrote: > Ok 4 +1: so I will process with release today. Great. FYI. I have updated the ASF Jira instance to use this release. It has only been a few hours but all looks OK so far. Sorry I didn't have time to do this earlier in the release vote. Mark ---

Re: Resources - merging back the changes

2012-10-23 Thread Mark Thomas
On 23/10/2012 01:01, Konstantin Kolinko wrote: > 2012/10/17 Mark Thomas : >> On 17/10/2012 15:07, Konstantin Kolinko wrote: >> >>> 1. Are and able to inject individual files? >> >> Not yet, but that should be relatively simple to implement. >> >&g

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-10-24 Thread Mark Thomas
On 24/10/2012 00:13, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/3484 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for t

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-10-24 Thread Mark Thomas
On 24/10/2012 09:35, Mark Thomas wrote: > On 24/10/2012 00:13, build...@apache.org wrote: >> The Buildbot has detected a new failure on builder tomcat-trunk while >> building ASF Buildbot. >> Full details are available at: >> http://ci.apache.org/builders/tomcat-trunk

Re: svn commit: r1402601 - /tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java

2012-10-26 Thread Mark Thomas
On 26/10/2012 19:35, Konstantin Kolinko wrote: > 2012/10/26 : >> Author: markt >> Date: Fri Oct 26 18:13:51 2012 >> New Revision: 1402601 >> >> URL: http://svn.apache.org/viewvc?rev=1402601&view=rev >> Log: >> Add test case for BZ 54044 >> >> Added: >> tomcat/trunk/test/org/apache/catalina/val

Re: svn commit: r1402601 - /tomcat/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java

2012-10-26 Thread Mark Thomas
On 26/10/2012 19:37, Mark Thomas wrote: > On 26/10/2012 19:35, Konstantin Kolinko wrote: >> 2012/10/26 : >>> Author: markt >>> Date: Fri Oct 26 18:13:51 2012 >>> New Revision: 1402601 >>> >>> URL: http://svn.apache.org/viewvc?rev=14

Re: Performance degrade

2012-10-28 Thread Mark Thomas
David Blevins wrote: >Seems there was a measurable decrease in large app deploy time between >Tomcat 7.0.28 and 7.0.29. I haven't yet had time to dig in with a >profiler. Hoping someone might go "oh, that's when we changed X" and >have a tip or two. No need for a profiler. The changelog for 7.

Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2012-11-01 Thread Mark Thomas
On 01/11/2012 00:03, Konstantin Kolinko wrote: > 2012/11/1 : >> The Buildbot has detected a new failure on builder tomcat-7-trunk while >> building ASF Buildbot. >> Full details are available at: >> http://ci.apache.org/builders/tomcat-7-trunk/builds/890 >> >> Buildbot URL: http://ci.apache.org/

Re: Resources - merging back the changes

2012-11-01 Thread Mark Thomas
dav/default servlet - but I don't see what use > case is optimized by not allowing overwrites. It looks like I didn't include an equivalent of rebind() in the new resources implementation. That was an oversight rather than an intentional decision. I'll fix that next. Mark >

Re: Resources - merging back the changes

2012-11-01 Thread Mark Thomas
On 01/11/2012 18:25, Mark Thomas wrote: > On 01/11/2012 05:21, Costin Manolache wrote: >> On Wed, Oct 31, 2012 at 4:41 PM, Costin Manolache wrote: >> >>> Hi Mark, >>> >>> I synced from HEAD - and noticed that DefaultServlet.PUT now fails with >>

Re: Estimate on Tomcat 7.0.33 release date?

2012-11-02 Thread Mark Thomas
Douglas Beachy wrote: >Hi all, > >Quick question: is there an estimate on when Tomcat 7.0.33 is scheduled >for >release? Our application runs on Tomcat and we will need Tomcat 7.0.33 >for >Bugfix 54022 (https://issues.apache.org/bugzilla/show_bug.cgi?id=54022, >already fixed) before we can ship

Re: Estimate on Tomcat 7.0.33 release date?

2012-11-02 Thread Mark Thomas
Thanks, > Doug > > > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Friday, November 02, 2012 11:49 AM > To: Tomcat Developers List > Subject: Re: Estimate on Tomcat 7.0.33 release date? > > Douglas Beachy wrote: > >>

Re: About Module Development

2012-11-04 Thread Mark Thomas
On 04/11/2012 19:35, Mayur Patil wrote: > Hi there, > > Greetings !! > > I want to ask if I am going to develop a module of Tomcat , > > how would I come to know lifetime/duration the module in which > > it can be developed !! Plz guide !! > > Thank you !! > Please do not cross-post. Please

[SECURITY] CVE-2012-2733 Apache Tomcat Denial of Service

2012-11-05 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 CVE-2012-2733 Apache Tomcat Denial of Service Severity: Important Vendor: The Apache Software Foundation Versions Affected: - - Tomcat 7.0.0 to 7.0.27 - - Tomcat 6.0.0 to 6.0.35 Description: The checks that limited the permitted size of request hea

[SECURITY] CVE-2012-3439 Apache Tomcat DIGEST authentication weaknesses

2012-11-05 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 CVE-2012-3439 Apache Tomcat DIGEST authentication weaknesses Severity: Moderate Vendor: The Apache Software Foundation Versions Affected: - - Tomcat 7.0.0 to 7.0.29 - - Tomcat 6.0.0 to 6.0.35 - - Tomcat 5.5.0 to 5.5.35 - - Earlier, unsupported versi

Re: svn commit: r1406156 - /tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java

2012-11-06 Thread Mark Thomas
On 06/11/2012 16:15, Konstantin Kolinko wrote: > 2012/11/6 : >> Author: markt >> Date: Tue Nov 6 14:52:00 2012 >> New Revision: 1406156 >> >> URL: http://svn.apache.org/viewvc?rev=1406156&view=rev >> Log: >> Fix where possible and silence where not possible some deprecation warnings >> >> Modifie

Re: Websocket ping/pong feature request

2012-11-09 Thread Mark Thomas
On 09/11/2012 16:03, Sean Winterberger wrote: > We are attempting to implement ping/pong functionality but have run into a > wall with the Tomcat Websocket implementation. Unless we are missing > something, there seems to be no way of modifying the opcode on a frame > prior to sending it without u

Re: Websocket ping/pong feature request

2012-11-09 Thread Mark Thomas
On 09/11/2012 17:14, Mark Thomas wrote: > On 09/11/2012 16:03, Sean Winterberger wrote: >> We are attempting to implement ping/pong functionality but have run into a >> wall with the Tomcat Websocket implementation. Unless we are missing >> something, there seems to be no

Re: svn commit: r1407596 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/NamingContextListener.java test/org/apache/catalina/core/TestNamingContextListener.java webapps/docs/changelog.xml

2012-11-11 Thread Mark Thomas
On 10/11/2012 09:31, Konstantin Kolinko wrote: > 2012/11/9 : >> Author: markt >> Date: Fri Nov 9 19:33:44 2012 >> New Revision: 1407596 >> >> URL: http://svn.apache.org/viewvc?rev=1407596&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54096 >> env-entry can use any typ

Plans for 7.0.33

2012-11-11 Thread Mark Thomas
I plan to run the TCKs tomorrow (strictly later today) but either way once I have got some sleep. If they and the unit tests pass, I'll tag 7.0.33 shortly afterwards. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-11-13 Thread Mark Thomas
On 12/11/2012 05:25, Konstantin Kolinko wrote: > 2012/11/12 : >> The Buildbot has detected a new failure on builder tomcat-trunk while >> building ASF Buildbot. >> Full details are available at: >> http://ci.apache.org/builders/tomcat-trunk/builds/3550 >> >> Buildbot URL: http://ci.apache.org/ >

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-11-13 Thread Mark Thomas
On 13/11/2012 11:31, Mark Thomas wrote: > On 12/11/2012 05:25, Konstantin Kolinko wrote: >> 2012/11/12 : >>> The Buildbot has detected a new failure on builder tomcat-trunk while >>> building ASF Buildbot. >>> Full details are available at: >>> http

Re: svn commit: r1408152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ test/org/apache/catalina/core/ webapps/docs/

2012-11-13 Thread Mark Thomas
On 13/11/2012 00:57, Konstantin Kolinko wrote: > 2012/11/12 : >> Author: markt >> Date: Sun Nov 11 23:35:41 2012 >> New Revision: 1408152 >> >> URL: http://svn.apache.org/viewvc?rev=1408152&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54123 >> There are two things goi

Re: svn commit: r1408150 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java webapps/docs/changelog.xml

2012-11-13 Thread Mark Thomas
On 13/11/2012 01:08, Konstantin Kolinko wrote: > 2012/11/12 : >> Author: markt >> Date: Sun Nov 11 23:32:43 2012 >> New Revision: 1408150 >> >> URL: http://svn.apache.org/viewvc?rev=1408150&view=rev >> Log: >> both timeout and complete, as with all container callbacks must be invoked >> with the

<    5   6   7   8   9   10   11   12   13   14   >