Re: Let's do better

2018-02-13 Thread Mark Struberg
Please all stop putting fuel into the fire. LieGrue, strub > Am 13.02.2018 um 08:48 schrieb Jean-Louis Monteiro : > > Instead of shooting to someone or start arguing. Simply asking would take > all misunderstand off and avoid this disgusting mess. > > Le 13 févr. 2018 08:33, "Mark Struberg"

Re: "Umbrella" discussion

2018-02-13 Thread Mark Struberg
Yes, I gonna tackle this with a broader explanation. Btw, I don't agree with the 2 weeks. If you would apply this rule to other topics then TomEE8 would clearly not happen. This is a discussion where everyone has a say and should be finished with either a clear outcome or a standard vote if ther

Re: Let's do better

2018-02-13 Thread Jean-Louis Monteiro
Morning Mark, I appreciate the feedback, but I disagree. Adding an @Ignore on a test failing does not fix the issue (either the test or the code) Putting a napkin over some c... does not clean it up. This is not the first time it happens, so I'd rather prefer the community to vent, put the probl

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Thiago Veronezi
Hi guys, I have some use for Chatterbox and I would like to contribute. Sheldon and Chatterbox are examples of awesome use of stack Java EE JCA, aren't they? What about creating a module "resource-adapters" and having these guys there? com.apache.tomee.rars chatterbox com.apache.tomee.rars she

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Romain Manni-Bucau
Hmm, what does hurt letting them having their own repo? I see the benefit to release them more easily and let them have their own lifecycle. I also see the drawback of all the tomee project if we put them as submodules. However I fail to see what would be the advantages in this last case. What do

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Mark Struberg
technically now since TomEE is hosted in GIT we even _have to_ give them own repos. Because those components will likely _not_ share the same lifecycle nor version number than the TomEE app server, isn't? GIT is not SVN. You technically cannot do sparse releases from a GIT repo. It's always a s

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Jean-Louis Monteiro
Hey Thiago. I have done all the change and prepared the donation. It needs some paperwork for IP clearance. I have followed the option where we have each in its own repo instead of the current TomEE repo. It appeared to be more flexible to me bit happy to change if the community thinks it's bette

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Thiago Veronezi
Awesome! Thanks guys. Thanks Jean-Louis for sort this out that fast! Count me in for the incubator work. []s, Thiago. On Tue, Feb 13, 2018 at 7:08 AM, Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Hey Thiago. > > I have done all the change and prepared the donation. It needs some >

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Jean-Louis Monteiro
I'll create the tickets for infra so we have the repos ready. Can you look at the other steps? I'm not very familiar with the steps in case of code donation. So I'll need to document myself as well. Le 13 févr. 2018 10:10, "Thiago Veronezi" a écrit : > Awesome! > > Thanks guys. > > Thanks Jean-

Re: Let's do better

2018-02-13 Thread Mark Struberg
It's our duty as PMC members to review committs. And of course a commit with the comment 'starting a thing which was decided not to be done' should spark EVERYONES curiosity. All the PMC members at TomEE and Geronimo have been aware of the discussions and nobody said anything against putting th

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Thiago Veronezi
Yes, looking at the steps now. I will ping you later for more guidance. At first glance, It looks like a very complex process. It's a good learning opportunity. Thanks man. []s, Thiago On Tue, Feb 13, 2018 at 7:15 AM, Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > I'll create the tick

Re: Let's do better

2018-02-13 Thread Romain Manni-Bucau
Agreeing with Mark. The answer to the first "why" mail would have removed the ambiguity my comment would have been "move the examples with others in examples/ instead of creating a new microprofile branch". Romain Manni-Bucau @rmannibucau | Blog

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Romain Manni-Bucau
side note: we don't need to go through asf@incubator here, the vote passed and the project can be imported as soon as the repos are created by infra. The only thing to take care (and a lot) is to make clear tomitribe gives (donates) this code to asf. A public message on a list is generally good and

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Thiago Veronezi
Are you sure we don't need the incubator? I know that Tomcat has multiple github repositories, but they are simple mirrors of the same svn repository on different branches (tc7, tc8 etc). >From https://incubator.apache.org/faq.html I get this... " 1.4. Someone has proposed that their code/project

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Romain Manni-Bucau
Yes, this doesn't apply for *sub*projects. Karaf, OpenWebBeans, ... are examples doing that without any issues. Also the fact the license - even if not explicit with a LICENSE file but only headers - is asf v2 in all projects helps to smooth that procedure. So public donation+license+subproject = n

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Mark Struberg
Yes, all the committers on those projects of course need to have an iCLA on file. And the PMC has to do an IP clearance. Once that's done it's fine to directly import it over here. LieGrue, strub PS: at OWB it was a bit different: with Meecrowave it was basically moving parts which existed in

Re: Let's do better

2018-02-13 Thread Andy Gumbrecht
Totally agree with you Mark. My initial response was polite as usual, I acknowledged my mistake and reverted quickly and explained my intention. Then comes the all too familiar b... slap, another one - Jean-Louis response is the best one, but that also can misfire - "What are you 'f'ing doing w

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Thiago Veronezi
Ok, iCLA is all set as everyone is asf committer. I guess the only thing missing is the IP paperwork. Jean-Louis, is there anything I can do to help us get this boring stuff ready? []s, Thiago. On Tue, Feb 13, 2018 at 7:58 AM, Mark Struberg wrote: > Yes, all the committers on those projects o

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread John D . Ament
On 2018/02/13 09:29:37, Romain Manni-Bucau wrote: > side note: we don't need to go through asf@incubator here, the vote passed > and the project can be imported as soon as the repos are created by infra. > The only thing to take care (and a lot) is to make clear tomitribe gives > (donates) this

Re: Implementing Microprofile JWT

2018-02-13 Thread John D . Ament
On 2018/02/12 20:42:58, Jonathan Gallimore wrote: > On Mon, Feb 12, 2018 at 8:20 PM, Romain Manni-Bucau > wrote: > > > No Andy, as mentionned in the discussion Geronimo hosts the microprofile > > @asf. This is why jwt should probably be done in geronimo which is the asf > > ee related projec

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread John D . Ament
On 2018/02/13 09:15:54, Jean-Louis Monteiro wrote: > I'll create the tickets for infra so we have the repos ready. > No infra ticket required. Git repos are fully self serve: git-wip-us hosted repos are requested via https://selfserve.apache.org/ gitbox hosted repos are requested via https

Re: [RESULT] Accept Code donations: Sheldon and Chatterbox

2018-02-13 Thread Jean-Louis Monteiro
I knew there was something. Thanks for the gitbox info Le 13 févr. 2018 12:26, "John D. Ament" a écrit : On 2018/02/13 09:29:37, Romain Manni-Bucau wrote: > side note: we don't need to go through asf@incubator here, the vote passed > and the project can be imported as soon as the repos are cr

Re: Implementing Microprofile JWT

2018-02-13 Thread Romain Manni-Bucau
2018-02-13 12:43 GMT+01:00 John D. Ament : > > > On 2018/02/12 20:42:58, Jonathan Gallimore > wrote: > > On Mon, Feb 12, 2018 at 8:20 PM, Romain Manni-Bucau < > rmannibu...@gmail.com> > > wrote: > > > > > No Andy, as mentionned in the discussion Geronimo hosts the > microprofile > > > @asf. This

Re: Implementing Microprofile JWT

2018-02-13 Thread Jean-Louis Monteiro
Thanks for the feedback Jon. I had a couple of exchanges with Rudy which is happy to contribute some code as well. >From what I have understood and seen, most of the code is integration code and there is at least from my current knowledge a little bit of code to put together in a reusable manner i

Re: Implementing Microprofile JWT

2018-02-13 Thread Romain Manni-Bucau
2018-02-13 15:28 GMT+01:00 Jean-Louis Monteiro : > Thanks for the feedback Jon. > > I had a couple of exchanges with Rudy which is happy to contribute some > code as well. > From what I have understood and seen, most of the code is integration code > and there is at least from my current knowledge

Re: Implementing Microprofile JWT

2018-02-13 Thread Mark Struberg
I know JWT a bit and I wonder whether doing the signing part is just a bit of Json (JSON-P) + commons-crypto? After all JWT is especially designed to be lightweight and straight forward. LieGrue, strub > Am 13.02.2018 um 15:33 schrieb Romain Manni-Bucau : > > 2018-02-13 15:28 GMT+01:00 Jean-L

Re: Implementing Microprofile JWT

2018-02-13 Thread Jean-Louis Monteiro
I was also thinking about a Johnzon extension (kinda) -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Feb 13, 2018 at 3:53 PM, Mark Struberg wrote: > I know JWT a bit and I wonder whether doing the signing part is just a bit > of Json (JSON-P) + commons

Re: Implementing Microprofile JWT

2018-02-13 Thread Mark Struberg
Might do as well. But the JSON-P part is really well abstracted. So this is easy to plug-in. I'm more worried about the authorisation and authentication interface. Anything EE security seems way too heavyweight for me. This might work out for TomEE, but would kill it's use in any more lightweig

Re: Implementing Microprofile JWT

2018-02-13 Thread Jean-Louis Monteiro
Too early for me to figure this out. Really need to get an example working so that I can think of a cleaner design. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Feb 13, 2018 at 4:58 PM, Mark Struberg wrote: > Might do as well. > But the JSON-P part i

Fwd: Implementing Microprofile JWT

2018-02-13 Thread Mark Struberg
Hi folks! Mike had a grat response on the imact and potential downsides of becoming an Umbrella project. I asked for his permisson to forward, so here we go. Txs Mike for the additional input! LieGrue, strub > > Von: Mike Kienenberger > Betreff: Aw: Implementing Microprofile JWT > Datum: 13.

IP Clearance for Sheldon and Chatterbox

2018-02-13 Thread David Blevins
John, can you put on your Incubator hat and remind me of the process? I vaguely recall we'll need: - Software Grant from Tomitribe for both codebases - iCLA for anyone who doesn't already have it I think we're good on iCLAs -- everyone is already a committer. Daniel Cunha is not yet a TomEE

Re: IP Clearance for Sheldon and Chatterbox

2018-02-13 Thread John D. Ament
Hey David & co Assuming all files in the donation already have the header as found at [1], then no an SGA wouldn't be required. We've been leaning towards keeping SGAs just when the license and copyrights need to change. It appears the original authors already had the ASF in mind so no need to c

Re: IP Clearance for Sheldon and Chatterbox

2018-02-13 Thread David Blevins
Thanks, John. > On Feb 13, 2018, at 9:43 AM, John D. Ament wrote: > > The overall IP Clearance process can be found at [2]. Someone will need to > commit the necessary files, call the vote etc. I would recommend separate > IP Clearances for each component. I believe I would be comfortable > p

Re: Implementing Microprofile JWT

2018-02-13 Thread Rudy De Busscher
> > I'm more worried about the authorisation and authentication interface. I used JASPIC as it seemed to most natural way to feed the EE system with authorisation and authentication into the system. But probably need deep integration with server code because otherwise, the JWT authentication mec

Re: IP Clearance for Sheldon and Chatterbox

2018-02-13 Thread Jean-Louis Monteiro
John, I have both cleaned up with the right headers, notice and license files. It's ready for review. I'll be creating the git repos tonight and push sources for review in a tomitribe repo. As soon as everyone is happy we can do the actual import @Apache -- Jean-Louis Monteiro http://twitter.com/

Re: IP Clearance for Sheldon and Chatterbox

2018-02-13 Thread Jonathan Gallimore
Can you post where we need to review? I'm more than happy to help with the review process. Jon On Tue, Feb 13, 2018 at 8:56 PM, Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > John, I have both cleaned up with the right headers, notice and license > files. > It's ready for review. I'll