Re: Forking for new PRs

2018-12-03 Thread Jean-Louis Monteiro
I agree with Romain and Bruno on this. I'm not a fan of squashing even if from time to time I think it's useful (See Bruno's example). Jean-Louis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Dec 3, 2018 at 6:49 PM César Hernández Mendoza wrote: >

PR review/merge status

2018-12-03 Thread Jean-Louis Monteiro
Hey TomEE community, I spent some time reviewing some PRs this morning. I could merge some in and commented out some others. Please, make sure you read the comments. If some PRs are outdate, please let me know with the number so I can close them. Thanks Jean-Louis -- Jean-Louis Monteiro

[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/176 @danielsoro and all Where are we at? Is it ready to go? ---

[GitHub] tomee issue #173: TOMEE-2247 - MicroProfile JWT Propagation 1.1

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/173 @radcortez where are we at? There is a conflict and I'm not sure you have seen it ---

[GitHub] tomee issue #204: fixed cdi-basic-typos

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/204 @cesarhernandezgt there is a conflict. Can you please fix? ---

[GitHub] tomee pull request #125: (WIP) TomEE 7.1.x port of MP-JWT

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/125 ---

[GitHub] tomee pull request #132: Adds test to JMS with JMSDestinationDefinition anno...

2018-12-03 Thread otaviojava
Github user otaviojava closed the pull request at: https://github.com/apache/tomee/pull/132 ---

[GitHub] tomee issue #132: Adds test to JMS with JMSDestinationDefinition annotation

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/132 Hey @otaviojava This PR seems to have a lot of commits in there. Not sure if there has been something wrong with the PR when you created it. Can you maybe create a new one or

[GitHub] tomee pull request #230: Grouping documents for some unrevised pages

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/230 ---

[GitHub] tomee issue #230: Grouping documents for some unrevised pages

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/230 Great, lemme me merge it then ---

[GitHub] tomee issue #230: Grouping documents for some unrevised pages

2018-12-03 Thread sendilkumarn
Github user sendilkumarn commented on the issue: https://github.com/apache/tomee/pull/230 Done @jeanouii ---

[GitHub] tomee issue #209: mp-metrics-counted fixed a couple of typos

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/209 Hey @cesarhernandezgt can you please fix the conflict and lemme know when it's done so I can merge this? ---

[GitHub] tomee issue #210: TOMEE-2297 - Added mp-rest-client example maven project

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/210 Hey @cesarhernandezgt What's up with this one? Is it still work in progress or we can review and merge if ok? ---

[GitHub] tomee issue #223: TOMEE-2301 - Concurrency utilities example

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/223 Hi all, How are we looking on this one? Is it ready to go? ---

[GitHub] tomee issue #230: Grouping documents for some unrevised pages

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/230 Hey, can you please solve the conflict so I can merge this for you? ---

[GitHub] tomee pull request #228: documentation updates

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/228 ---

[GitHub] tomee issue #228: documentation updates

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/228 This one is ready to go so I'll merge it ---

Re: How can I help?

2018-12-03 Thread Jean-Louis Monteiro
You did a great job. There is no need to be sorry here. When I started on the project someone told me, as soon as the contribution moves us forward and not backwards, we are fine. In that regard, your contribution definitely moves us forward. So feel free to continue. -- Jean-Louis Monteiro

Re: How can I help?

2018-12-03 Thread Hayri Cicek
Hi Louis, Yes saw your comment and I'm really sorry about that and will not rush and do it properly next time /Hayri Den tis 4 dec. 2018 08:06 skrev Jean-Louis Monteiro < jlmonte...@tomitribe.com>: > Hey Hayri! > > I have reviewed PR https://github.com/apache/tomee/pull/231 related to > code >

[GitHub] tomee issue #232: TOMEE-2313 - fixing tomee-webapp archetype.

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/232 Hey @cesarhernandezgt did you get a chance to push changes or do we merge this one and you create a new PR with improvements later? ---

[GitHub] tomee issue #231: TOMEE-2314 - Code cleanup in modules listed in description

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/231 Thank you. Lemme know when done, I'm happy to do the boilerplate under the cover to get this in. ---

[GitHub] tomee issue #231: TOMEE-2314 - Code cleanup in modules listed in description

2018-12-03 Thread cicekhayri
Github user cicekhayri commented on the issue: https://github.com/apache/tomee/pull/231 Yes sorry about that, I will not rush and do it properly next time and will try to fix the conflicts today ---

Re: How can I help?

2018-12-03 Thread Jean-Louis Monteiro
Hey Hayri! I have reviewed PR https://github.com/apache/tomee/pull/231 related to code clean up. It was a big long to review. Next time if you could make the PRs smaller so they are easier to review and merge, that'd me great. There is a conflict to solve and then it's ready to go. Thanks --

[GitHub] tomee issue #231: TOMEE-2314 - Code cleanup in modules listed in description

2018-12-03 Thread jeanouii
Github user jeanouii commented on the issue: https://github.com/apache/tomee/pull/231 Would you please fix the conflict so I can merge it for you? Yes next time, please prefer smaller PRs as they are easier to review ---

[GitHub] tomee pull request #216: WIP create a sample for java modules usage

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/216 ---

[GitHub] tomee pull request #224: Fixing documentation on some of the examples

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/224 ---

Re: [GitHub] tomee pull request #226: Fixing major JavaDoc errors for Tomee

2018-12-03 Thread David Blevins
All merged! Your first commit in TomEE!! Congratulations and more importantly Thank You, Dmitry! -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com > On Dec 2, 2018, at 8:01 AM, dalexandrov wrote: > > GitHub user dalexandrov opened a pull request: > >

[GitHub] tomee pull request #226: Fixing major JavaDoc errors for Tomee

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/226 ---

Re: [GitHub] tomee pull request #225: Added diamond operator usage, where appropriate

2018-12-03 Thread David Blevins
Thank you so much for this PR, David! It's merged! :) Congratulations on your first TomEE commit!! Can you add dheffelfinger (a) ensode com to your github account as a secondary email address? Then you'll get listed here: - https://github.com/apache/tomee/graphs/contributors As part of

[GitHub] tomee-site-generator pull request #8: adjust year from 2019 to 2018.

2018-12-03 Thread Daniel-Dos
GitHub user Daniel-Dos opened a pull request: https://github.com/apache/tomee-site-generator/pull/8 adjust year from 2019 to 2018. issue create -> https://issues.apache.org/jira/browse/TOMEE-2315 on the following site (http://tomee.apache.org/download-ng.html), the date of

[GitHub] tomee pull request #225: Added diamond operator usage, where appropriate

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/225 ---

Re: Anyone can help review PRs

2018-12-03 Thread Daniel Dias Dos Santos
very good this tips. -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em ter, 4 de dez de 2018 às 01:35, David Blevins escreveu: > Just a reminder that

Anyone can help review PRs

2018-12-03 Thread David Blevins
Just a reminder that anyone can help review PRs. In fact, you'd likely be prioritized for getting commit access far sooner :) Especially this month! I made a small script to help pull down PRs : purl - https://gist.github.com/dblevins/6e255634d84914beb051a4b3858ebfb4 Just: cd tomee git

Re: How can I help?

2018-12-03 Thread Daniel Dias Dos Santos
Hi Jon, One question, do you guys usually use SNAPSHOT versions in the examples? thank you. -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em seg, 3

[GitHub] tomee-site-generator pull request #6: TOMEE-2300 - Improvement for Community...

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee-site-generator/pull/6 ---

[GitHub] tomee pull request #233: TOMEE-2304 Improving MP-REST-JWT example (WIP)

2018-12-03 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/233 TOMEE-2304 Improving MP-REST-JWT example (WIP) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee TOMEE-2304

Re: Fix for tomee-webapp archetype

2018-12-03 Thread César Hernández Mendoza
Thank you, I'm going to update my pr with the improvement you highlighted. El lun., 3 dic. 2018 a las 16:58, Daniel Cunha () escribió: > Hey Cesar, > > I pushed a comment on your PR. Hope it helps. > > Em seg, 3 de dez de 2018 às 19:54, César Hernández Mendoza < > cesargu...@gmail.com> escreveu:

[GitHub] tomee issue #232: TOMEE-2313 - fixing tomee-webapp archetype.

2018-12-03 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/232 Thank you @danielsoro for the awesome approach. Tomorrow I'll update my PR with this improvement. ---

Re: Fix for tomee-webapp archetype

2018-12-03 Thread Daniel Cunha
Hey Cesar, I pushed a comment on your PR. Hope it helps. Em seg, 3 de dez de 2018 às 19:54, César Hernández Mendoza < cesargu...@gmail.com> escreveu: > Hi, > > I created a PR for fixing the issue reported on > https://issues.apache.org/jira/browse/TOMEE-2313 about the failure on the > maven

[GitHub] tomee issue #232: TOMEE-2313 - fixing tomee-webapp archetype.

2018-12-03 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/232 Hey @cesarhernandezgt, What do you think to use that approach: https://github.com/apache/tomee/blob/master/maven/tomee-webapp-archetype/pom.xml#L45 Than you can use the

Fix for tomee-webapp archetype

2018-12-03 Thread César Hernández Mendoza
Hi, I created a PR for fixing the issue reported on https://issues.apache.org/jira/browse/TOMEE-2313 about the failure on the maven project generated by tomee-webapp archetype. Could someone please review this PR? -- Atentamente: César Hernández Mendoza.

Re: JIRA ticket and PR's

2018-12-03 Thread César Hernández Mendoza
Hi Hayri, Awesome initiative. FYI, I saw today a PR from David Heffelfinger that also involves the usage of Diamon operator. https://github.com/apache/tomee/pull/225 As David B. mentioned above, in this scenario is highly possible that two people are working in the task. If David's H. PR

TOMEE-2291 - Fault Tolerance Microprofile example for @Retry

2018-12-03 Thread Jose Henrique Ventura
Hi Guys, I still have a few things to change/write in the README.md file before I send PR but looking at microprofile-fault-tolerance spec, I see [Metrics added for @Retry](http://download.eclipse.org/microprofile/microprofile-fault-tolerance-1.1/microprofile-fault-tolerance-spec.html) and

[GitHub] tomee pull request #232: TOMEE-2313 - fixing tomee-webapp archetype.

2018-12-03 Thread cesarhernandezgt
GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/232 TOMEE-2313 - fixing tomee-webapp archetype. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee TOMEE-2313

[GitHub] tomee pull request #231: TOMEE-2314 - Code cleanup in modules listed in desc...

2018-12-03 Thread cicekhayri
GitHub user cicekhayri opened a pull request: https://github.com/apache/tomee/pull/231 TOMEE-2314 - Code cleanup in modules listed in description This was little to big but next time will make JIRA ticket for each module before start coding Modules worked in :

Re: JIRA ticket and PR's

2018-12-03 Thread Hayri Cicek
Okej then I know, contributing to Open Source is new to me :) and better to ask , Yes I had forgotten to update my setting :( but now it's configured :) Den mån 3 dec. 2018 kl 21:21 skrev David Blevins : > Side note, your git client is configured to not have your email in it. It > has "Hayri

Re: JIRA ticket and PR's

2018-12-03 Thread David Blevins
Side note, your git client is configured to not have your email in it. It has "Hayri Cicek " So unfortunately you're not showing up here: - https://github.com/apache/tomee/graphs/contributors I don't know if there's anyway to fix the old commits, but definitely update your settings for the

Re: JIRA ticket and PR's

2018-12-03 Thread David Blevins
Most important thing I think is to say what code you'll be working on before you invest the time, just to make sure someone else is not also cleaning the same code (duplication). If two PRs come in at the same time and one has a JIRA "Cleaning openejb-ejbd module" and the other has no JIRA or

JIRA ticket and PR's

2018-12-03 Thread Hayri Cicek
Hi everybody, I have a question: I created JIRA ticket TOMEE-2314 and I don't want to have big PR's is it okej to make multiple PR for that ticket or should I create a ticket per branch/PR I work on, the thing is that I'm trying to make usage of diamond operator, final variables/parameters and

JMS Documentation PR

2018-12-03 Thread David Blevins
Hey Otavio, I see a PR from you that looks like it was never applied. - https://github.com/apache/tomee-site-generator/pull/4 Looks like there was a lot of discussion on that PR. What's the status of that? -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com

Re: How can I help?

2018-12-03 Thread Hayri Cicek
Thanks Richard Den mån 3 dec. 2018 kl 13:24 skrev Richard Monson-Haefel < monsonhae...@gmail.com>: > Welcome to TomEE, Hayri! > > On Fri, Nov 30, 2018 at 1:12 PM Hayri Cicek wrote: > > > Hi everyone, > > > > My name is Hayri Cicek and we use TomEE everyday where I work and would > > love to

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Michael Redlich
Thanks, Ivan! As you may have already seen, Richard explained everything to me! Mike. On Mon, Dec 3, 2018 at 8:20 AM Ivan Junckes Filho wrote: > Hi Michael, I am not sure I understand you question. > > If I get it right, the instructions were in my previous email. > > Can you elaborate? > >

Re: MicroProfile JWT 1.1

2018-12-03 Thread Roberto Cortez
Sure. If you don’t mind, I’ll merge your branch with mine and then submit a PR with everything. > On 3 Dec 2018, at 17:12, Jonathan Gallimore > wrote: > > If you have the cycles, it would be great if you could do it. > > Cheers! > > Jon > > On Mon, Dec 3, 2018 at 5:06 PM Roberto Cortez >

Re: Documentation Contribution Opportunities

2018-12-03 Thread David Blevins
> On Dec 3, 2018, at 1:46 AM, Matthew Broadhead > wrote: > > I would be happy to do this task. But how to avoid conflicting PRs? I think we need someone to volunteer to take the head and coordinate. This could be grouping the docs up and filing a few JIRAs. Maybe something like this:

Re: Forking for new PRs

2018-12-03 Thread César Hernández Mendoza
Thanks Bruno, I'm starting to follow your approach. +1 El lun., 3 dic. 2018 a las 5:24, Bruno Baptista () escribió: > Hi folks, > > I'm also not a big fan of squashing... > > I do however understand the need to easily find commits from a certain > PR for portability reasons. > > There are 2

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Ivan Junckes Filho
yw! You should not work on anything related to "tomitribe", the correct repository is apache/tomee. Apache is the owner of the project. https://github.com/apache/tomee On Mon, Dec 3, 2018 at 3:40 PM Michael Redlich wrote: > Thanks, Ivan! > > As you may have already seen, Richard explained

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Michael Redlich
Hi Richard: Thanks for taking the time to outline the process. I certainly appreciate it! My use of git has been somewhat limited to working on my own repositories. Now it makes sense. I originally cloned the *tomitribe\tomee* repository and started making my changes to add the Histogram

Re: How can I help?

2018-12-03 Thread Daniel Dias Dos Santos
wonderful, I'll do them. thank you very much -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em seg, 3 de dez de 2018 às 15:14, Jonathan Gallimore <

Re: How can I help?

2018-12-03 Thread Jonathan Gallimore
How about one example for each? A working example is cool, but it would be great to use a CXF-based example that we can use to drive out the issues so we can help fix them. I'm of course happy to help you out. Cheers! Jon On Mon, Dec 3, 2018 at 4:55 PM Daniel Dias Dos Santos <

Re: MicroProfile JWT 1.1

2018-12-03 Thread Jonathan Gallimore
If you have the cycles, it would be great if you could do it. Cheers! Jon On Mon, Dec 3, 2018 at 5:06 PM Roberto Cortez wrote: > Yes, I would be in favor on commenting these tests, but implement on our > tests that set up an endpoint and try to deploy and app to load the key > from the

Re: MicroProfile JWT 1.1

2018-12-03 Thread Roberto Cortez
Yes, I would be in favor on commenting these tests, but implement on our tests that set up an endpoint and try to deploy and app to load the key from the endpoint. At least we make sure that the feature is working as supposed. Do you want to do it, or should I do it? > On 3 Dec 2018, at 16:49,

Re: How can I help?

2018-12-03 Thread Daniel Dias Dos Santos
thanks Richard, : ) -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em seg, 3 de dez de 2018 às 09:55, Richard Monson-Haefel < monsonhae...@gmail.com>

Re: How can I help?

2018-12-03 Thread Daniel Dias Dos Santos
Hi Jon, It's good that you like MVC spec, it's a very simple and very cool spec, because it reuses our knowledge in Jax-RS. I would love to make an example for Tomee 8, would have problem in using RestEasy for this? so far the Apache CXF is not 100% in Ozark / Krazo, we are having some problems

Re: CMP/JPA mapping not accounting for in persistence.xml

2018-12-03 Thread Jonathan Gallimore
I have pushed some further work on this, but I'm now stuck. I have tried to ensure that this is working ok with CMP beans with a 1-m relationship, but I am getting a very weird NPE from here:

Re: MicroProfile JWT 1.1

2018-12-03 Thread Jonathan Gallimore
Interesting. I'd be in favor of commenting those tests out and merging the PR, if you think the rest of it is in shape. If the spec says there should be a deployment exception, then that makes sense. The TCK should probably start its own little embedded http server to supply these keys instead. We

[GitHub] tomee pull request #223: TOMEE-2301 - Concurrency utilities example

2018-12-03 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/223#discussion_r238347975 --- Diff: examples/concurrency-utils/pom.xml --- @@ -0,0 +1,68 @@ + +http://maven.apache.org/POM/4.0.0; +

Re: MicroProfile JWT 1.1

2018-12-03 Thread Roberto Cortez
Yes, I think that the current state of the TCK is actually wrong. Look here: https://github.com/eclipse/microprofile-jwt-auth/issues/118 And also from the spec: MicroProfile JWT implementations are required to throw a

Re: MicroProfile JWT 1.1

2018-12-03 Thread Jonathan Gallimore
Thanks for asking. There are 3 tests I can't get passing. These are the ones where the key is referred to by a HTTP url, which isn't available at deployment time where the keys are actually read. I spent quite a lot of time trying to make this happen later in lifecycle (like on first load, or

[GitHub] tomee pull request #223: TOMEE-2301 - Concurrency utilities example

2018-12-03 Thread brunobat
Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/223#discussion_r238332043 --- Diff: examples/concurrency-utils/pom.xml --- @@ -0,0 +1,68 @@ + +http://maven.apache.org/POM/4.0.0; +

Re: Documentation Contribution Opportunities

2018-12-03 Thread Matthew Broadhead
yes that is what i mean. also i was looking through the JBake docs and it is possible to define tags on pages.  this might be useful where a page is relevant to more than one index? On 03/12/2018 16:25, Bruno Baptista wrote: Hi Do you mean, the Apache license in header on the top of each

Re: Looking to contribute

2018-12-03 Thread Bruno Baptista
Hey Brant, Awesome to see you on the list! Looking forward for those PRs :D Cheers Bruno Baptista https://twitter.com/brunobat_ On 01/12/18 02:46, Brant Oliver wrote: Hi all, How can I get in on the fun and start contributing? I joined the list a few days ago and seems like a lot of cool

Re: Documentation Contribution Opportunities

2018-12-03 Thread Bruno Baptista
Hi Do you mean, the Apache license in header on the top of each source file? Cheers Bruno Baptista https://twitter.com/brunobat_ On 03/12/18 11:25, Matthew Broadhead wrote: Should the licence be stored centrally and appended to the top (or bottom) of each page? On 03/12/2018 04:21, David

Re: MicroProfile JWT 1.1

2018-12-03 Thread Roberto Cortez
Hi Jon, I’ve seen you made some changes in your branch. What is the current status? I would like to start pushing for MP 2.0 specs. Cheers, Roberto > On 21 Nov 2018, at 17:57, Jonathan Gallimore > wrote: > > Was going to have another look at those tests over the next couple of days. > >

Re: MP JWT example revisited

2018-12-03 Thread Bruno Baptista
Hi César, Looking forward to review it. Cheers. Bruno Baptista https://twitter.com/brunobat_ On 30/11/18 22:44, César Hernández Mendoza wrote: Hi, I'm planning to implement a couple of small improvements on the MicroProfile JWT example the project already has. I opened

Re: How can I help?

2018-12-03 Thread Daniel Dias Dos Santos
Hi David, I'll still try to look at other other issues. Thank you very much for your support. -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em seg, 3

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Richard Monson-Haefel
Hi Michael, I might be able to shed some light on this. The process I've used is as follows: 1. I go to the apache/TomEE git hub page and click on "Fork" (its a button on the top right) 2. Select your own account and it will clone the entire TomEE repo to your own account. On my its

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Ivan Junckes Filho
Hi Michael, I am not sure I understand you question. If I get it right, the instructions were in my previous email. Can you elaborate? On Mon, Dec 3, 2018 at 11:07 AM Michael Redlich wrote: > Hi Ivan: > > Ah, OK, cool. I will indeed do that. > > Since I’m new to the open-source community, I

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Michael Redlich
Hi Ivan: Ah, OK, cool. I will indeed do that. Since I’m new to the open-source community, I would appreciate knowing how I would use the forked TomEE repository on my own Github account relative to the repository I cloned on my local machine. I appreciate everyone’s patience as I get myself

Re: Hello World! - How can I help?

2018-12-03 Thread Richard Monson-Haefel
Welcome to TomEE, Richard! On Fri, Nov 30, 2018 at 3:18 PM Richard Zowalla wrote: > Hello everyone, > > my name is Richard. I had a nice mention on Twitter by @dblevins > (https://twitter.com/dblevins/status/1068594206577352704), so I decided > to join the mailing list. > My first contribution

Re: Looking to contribute

2018-12-03 Thread Richard Monson-Haefel
Welcome to TomEE, Brant! On Fri, Nov 30, 2018 at 8:46 PM Brant Oliver wrote: > Hi all, > > How can I get in on the fun and start contributing? I joined the list a few > days ago and seems like a lot of cool efforts are going on with > consolidating documentation and making it easy for the new

Re: How can I help?

2018-12-03 Thread Richard Monson-Haefel
Welcome to TomEE, Hayri! On Fri, Nov 30, 2018 at 1:12 PM Hayri Cicek wrote: > Hi everyone, > > My name is Hayri Cicek and we use TomEE everyday where I work and would > love to contribute back to the project and > I saw the how can I help and would love to try help but I started trying to >

[GitHub] tomee issue #230: Grouping documents for some unrevised pages

2018-12-03 Thread monsonhaefel
Github user monsonhaefel commented on the issue: https://github.com/apache/tomee/pull/230 Nice work! ---

[GitHub] tomee pull request #230: Grouping documents for some unrevised pages

2018-12-03 Thread sendilkumarn
GitHub user sendilkumarn opened a pull request: https://github.com/apache/tomee/pull/230 Grouping documents for some unrevised pages r? @dblevins You can merge this pull request into a Git repository by running: $ git pull https://github.com/sendilkumarn/tomee fix-links

Re: [GitHub] tomee pull request #228: documentation updates

2018-12-03 Thread Richard Monson-Haefel
Great start! On Mon, Dec 3, 2018 at 4:27 AM chongma wrote: > GitHub user chongma opened a pull request: > > https://github.com/apache/tomee/pull/228 > > documentation updates > > First stab at editing the documentation index groups. Correcting typo > for General Information > > You

Re: Upgrade Apache Johnzon

2018-12-03 Thread Daniel Cunha
Thank you Jon! :) Em seg, 3 de dez de 2018 às 08:22, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > I'll merge that in for you. Thanks for the patch! > > Jon > > On Mon, Dec 3, 2018 at 11:01 AM Daniel Cunha > wrote: > > > Hi folks, > > > > for now, TomEE 8 is using Johnzon

[GitHub] tomee pull request #227: TOMEE-2233 - Custom Configuration of TomEEJsonbProv...

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/227 ---

Re: How can I help?

2018-12-03 Thread Richard Monson-Haefel
Welcome to TomEE, Daniel! On Fri, Nov 30, 2018 at 8:28 PM Daniel Dias Dos Santos < daniel.dias.analist...@gmail.com> wrote: > Hi folks, > > My name is Daniel, today @dblevins me sent the following link ( > https://www.tomitribe.com/blog/tomee-for-the-holidays/) . > > I think an very good

Re: Hello World! - How can I help?

2018-12-03 Thread Richard Monson-Haefel
Welcome back to TomEE, Martin! On Fri, Nov 30, 2018 at 4:41 PM Wiesner, Martin < martin.wies...@hs-heilbronn.de> wrote: > Hi folks, > > my name is Martin. @dblevins and I were discussing how individuals could > contribute to #TomEE. He convinced me to join the mailing list. > In the past, I

[GitHub] tomee issue #227: TOMEE-2233 - Custom Configuration of TomEEJsonbProvider

2018-12-03 Thread jgallimore
Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/227 Awesome, thanks for the PR! I'll pull this, and get it merged for you. ---

Re: Hello World! - How can I help?

2018-12-03 Thread Jonathan Gallimore
Hi Martin Thanks for that - you should be in the group now. Any problems, please let us know! Jon On Sat, Dec 1, 2018 at 7:12 AM Wiesner, Martin < martin.wies...@hs-heilbronn.de> wrote: > Hi Jon, > > my JIRA ID simply is: "mawiesne" > > Best, > mawiesne > -- > https://twitter.com/mawiesne > >

Re: How can I help?

2018-12-03 Thread Jonathan Gallimore
Hi Daniel Thanks so much for posting! I really like the MVC spec, and use it for a system with TomEE here. I'd love us to have an example that shows TomEE 8 with an application using the latest Krazo version. Is that something you'd be interested in creating? This page hints at some issues

Re: Documentation Contribution Opportunities

2018-12-03 Thread Matthew Broadhead
Should the licence be stored centrally and appended to the top (or bottom) of each page? On 03/12/2018 04:21, David Blevins wrote: Hello hopeful contributors! As of this weekend we have two new index pages for our documentation on the website: - http://tomee.apache.org/tomee-8.0/docs/ -

[GitHub] tomee pull request #229: Upgrade johnzon for 1.1.10

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/229 ---

Re: Forking for new PRs

2018-12-03 Thread Bruno Baptista
Hi folks, I'm also not a big fan of squashing... I do however understand the need to easily find commits from a certain PR for portability reasons. There are 2 mitigating steps that can be done: 1. Always put the jira issue in the beginning of all comments, like: "TOMEE-1234 - some

Re: Upgrade Apache Johnzon

2018-12-03 Thread Jonathan Gallimore
I'll merge that in for you. Thanks for the patch! Jon On Mon, Dec 3, 2018 at 11:01 AM Daniel Cunha wrote: > Hi folks, > > for now, TomEE 8 is using Johnzon 1.1.9, but we already have the Johnzon > 1.1.10, any objection to update it? > > I've a PR for it case you are agree to update it. >

Re: Merging Old and New Websites - Volunteers Needed

2018-12-03 Thread Ivan Junckes Filho
It looks super cool :) On Mon, Dec 3, 2018 at 4:28 AM Karan Malhi wrote: > I will start taking a look at these this week. > > On Sun, Dec 2, 2018 at 4:07 AM David Blevins > wrote: > > > > On Dec 1, 2018, at 5:41 PM, David Blevins > > wrote: > > > > > > I'm attempting to get this to a point

Upgrade Apache Johnzon

2018-12-03 Thread Daniel Cunha
Hi folks, for now, TomEE 8 is using Johnzon 1.1.9, but we already have the Johnzon 1.1.10, any objection to update it? I've a PR for it case you are agree to update it. https://github.com/apache/tomee/pull/229 -- Daniel "soro" Cunha https://twitter.com/dvlc_

[GitHub] tomee pull request #229: Upgrade johnzon for 1.1.10

2018-12-03 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/229 Upgrade johnzon for 1.1.10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee johnzon-update Alternatively you can review and

Re: [TOMEE-2287] Histogram Prometheus Output

2018-12-03 Thread Ivan Junckes Filho
You need to have your own fork. If you don't have it, just go to the apache/tomee address and click "Fork". After that you need to add another remote branch. git remote add For example: git remote add ivan https://github.com/ivanjunckes/tomee.git Or if you use a ssh key: git remote add ivan

[GitHub] tomee pull request #228: documentation updates

2018-12-03 Thread chongma
GitHub user chongma opened a pull request: https://github.com/apache/tomee/pull/228 documentation updates First stab at editing the documentation index groups. Correcting typo for General Information You can merge this pull request into a Git repository by running: $ git

  1   2   >