Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94551352
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -68,7 +69,7 @@
/**
* A {@link KafkaConsumer
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797752#comment-15797752
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94551508
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -273,17 +274,19 @@ private MessageCallback wrapCallbac
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797757#comment-15797757
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94551691
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -273,17 +274,19 @@ private MessageCallback wrapCallbac
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797768#comment-15797768
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94551779
--- Diff:
twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java ---
@@ -170,11 +174,128 @@ public void testKafkaClient() throws Exception {
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94551913
--- Diff:
twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java ---
@@ -170,11 +174,128 @@ public void testKafkaClient() throws Exception {
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/16
There are checkstyle failure, please fix them as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797778#comment-15797778
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1579#comment-1579
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797779#comment-15797779
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on the issue:
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94555234
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -68,7 +69,7 @@
/**
* A {@link KafkaConsumer
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797824#comment-15797824
]
ASF GitHub Bot commented on TWILL-199:
--
Github user maochf commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797840#comment-15797840
]
ASF GitHub Bot commented on TWILL-199:
--
Github user maochf commented on a diff in the
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94556442
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -273,17 +274,19 @@ private MessageCallback wrapCallbac
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94557480
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -273,17 +274,19 @@ private MessageCallback wrapCallbac
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797849#comment-15797849
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94557551
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -68,7 +69,7 @@
/**
* A {@link KafkaConsumer
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797851#comment-15797851
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94558457
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -273,17 +274,19 @@ private MessageCallback wrapCallbac
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797861#comment-15797861
]
ASF GitHub Bot commented on TWILL-199:
--
Github user maochf commented on a diff in the
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94558645
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -68,7 +69,7 @@
/**
* A {@link KafkaConsumer
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797867#comment-15797867
]
ASF GitHub Bot commented on TWILL-199:
--
Github user maochf commented on a diff in the
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94559673
--- Diff:
twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java ---
@@ -170,11 +174,128 @@ public void testKafkaClient() throws Exception {
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797882#comment-15797882
]
ASF GitHub Bot commented on TWILL-199:
--
Github user maochf commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94561337
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -273,17 +274,19 @@ private MessageCallback wrapCallbac
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94561460
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -273,17 +274,19 @@ private MessageCallback wrapCallbac
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797901#comment-15797901
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797904#comment-15797904
]
ASF GitHub Bot commented on TWILL-199:
--
Github user maochf commented on a diff in the
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94658662
--- Diff:
twill-api/src/main/java/org/apache/twill/api/ServiceAnnouncer.java ---
@@ -32,7 +32,7 @@
Cancellable announce(String serviceName, int port);
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799233#comment-15799233
]
ASF GitHub Bot commented on TWILL-199:
--
Github user maochf commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94687750
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
@@ -35,12 +35,14 @@
* Invoked when new messages is available.
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94688058
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -273,17 +274,19 @@ private MessageCallback wrapCallbac
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94688950
--- Diff:
twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java ---
@@ -170,11 +172,57 @@ public void testKafkaClient() throws Exception {
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799722#comment-15799722
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799723#comment-15799723
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799721#comment-15799721
]
ASF GitHub Bot commented on TWILL-199:
--
Github user chtyim commented on a diff in the
38 matches
Mail list logo
