[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terence Yim resolved TWILL-240.
---
Resolution: Fixed
> Improve EventHandler to handle more application lifecycle events
>
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120944#comment-16120944
]
ASF GitHub Bot commented on TWILL-240:
--
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/twill/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120825#comment-16120825
]
ASF GitHub Bot commented on TWILL-240:
--
Github user maochf commented on the issue:
Github user maochf commented on the issue:
https://github.com/apache/twill/pull/58
squashed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
[
https://issues.apache.org/jira/browse/TWILL-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terence Yim resolved TWILL-242.
---
Resolution: Fixed
> Extra JVM options is dropped when custom classloader is used
>
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120804#comment-16120804
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on the issue:
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/58
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
[
https://issues.apache.org/jira/browse/TWILL-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120799#comment-16120799
]
ASF GitHub Bot commented on TWILL-242:
--
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/twill/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120748#comment-16120748
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322898
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -239,14 +359,8 @@ protected void doStop() throws Ex
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322804
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -239,14 +359,8 @@ protected void doStop() throws Ex
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120746#comment-16120746
]
ASF GitHub Bot commented on TWILL-240:
--
Github user maochf commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120745#comment-16120745
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322316
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -239,14 +359,8 @@ protected void doStop() throws Ex
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120743#comment-16120743
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322087
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -181,19 +190,130 @@ public Reader getInput() throws
[
https://issues.apache.org/jira/browse/TWILL-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120717#comment-16120717
]
ASF GitHub Bot commented on TWILL-242:
--
GitHub user chtyim opened a pull request:
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/60
(TWILL-242) Fixed the dropping of extra jvm opts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill
feature/TWILL-242-fix-extra-jvm-opts
Terence Yim created TWILL-242:
-
Summary: Extra JVM options is dropped when custom classloader is
used
Key: TWILL-242
URL: https://issues.apache.org/jira/browse/TWILL-242
Project: Apache Twill
Is
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120616#comment-16120616
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132298929
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
createEvent
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120614#comment-16120614
]
ASF GitHub Bot commented on TWILL-240:
--
Github user maochf commented on a diff in the
Github user maochf commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132298585
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
createEvent
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120612#comment-16120612
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132297954
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -401,6 +409,24 @@ void stopAll() {
// When we acq
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120609#comment-16120609
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132297305
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
createEvent
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120606#comment-16120606
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132296875
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
createEvent
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120603#comment-16120603
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120604#comment-16120604
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132296480
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
createEvent
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132296198
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
createEvent
[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120602#comment-16120602
]
ASF GitHub Bot commented on TWILL-240:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132295847
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -181,7 +189,6 @@ public Reader getInput() throws IO
37 matches
Mail list logo
