Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-22 Thread Shashika Karunatilaka
adding Suho On Fri, Jan 16, 2015 at 11:13 PM, KasunG Gajasinghe wrote: > Hi, > > This feature will be merged into Kernel 4.4.0-SNAPSHOT. The downstream > projects should depend on kernel 4.3.0. So, there won't be any build breaks. > > Further, repo is currently depending carbon-multitenancy kern

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-16 Thread KasunG Gajasinghe
Hi, This feature will be merged into Kernel 4.4.0-SNAPSHOT. The downstream projects should depend on kernel 4.3.0. So, there won't be any build breaks. Further, repo is currently depending carbon-multitenancy kernel 4.3.0. So, we might have to wait until a release happens from that repo. Otherwis

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-15 Thread Lakshman Udayakantha
Hi All, when I delete tenant in wso2as-6.0.0-SNAPSHOT, got the following exception Error executing query DELETE FROM UM_CLAIM_BEHAVIOR WHERE UM_TENANT_ID = ? for tenant: 1 org.h2.jdbc.JdbcSQLException: Table "UM_CLAIM_BEHAVIOR" not found; SQL statement: DELETE FROM UM_CLAIM_BEHAVIOR WHERE UM_TE

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-15 Thread Johann Nallathamby
Was this code reviewed ? The new method in the listener does not follow the same convention as others. It says "onPreDelete", but other methods don't follow "pre/post" convention and you don't have hooks for all pre process actions. Can you please add pre process hooks for all the methods in that

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-14 Thread Aruna Karunarathna
I believe we need to merge all these PR's related to tenant deletion at onetime coordinated manner. Otherwise there will be build breaks. Regards, Aruna On Wed, Jan 14, 2015 at 3:06 PM, Shashika Karunatilaka wrote: > Hi all, > > I have created PRs for the respective repositories(I have added a

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-14 Thread Shashika Karunatilaka
Hi all, I have created PRs for the respective repositories(I have added a comment in each PR). Please merge the Tenant deletion PRs and merge the following PRs. *carbon-multitenancy* JIRA : https://wso2.org/jira/browse/WSAS-1882 PR : https://github.com/wso2-dev/carbon-mu

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-11 Thread Shashika Karunatilaka
HI all, Below are my findings for the wso2 repos that uses the above listener class, please correct me if i missed any. Repo Componenent class carbon-multitenancy (org.wso2.carbon.theme.mgt.util) ThemeLoadingListener.java (org.wso2.carbon.keystore.mgt) KeystoreTenantMgtListener.java carb

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-10 Thread Shashika Karunatilaka
Hi Kishanthan Sure, I will find the relevant wso2 repos that uses the above listener class and send PRs with the fixes. Thank you On Sat, Jan 10, 2015 at 12:29 PM, Kishanthan Thangarajah < kishant...@wso2.com> wrote: > First can you find the wso2 repos that use the above listener class and > se

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-09 Thread Kishanthan Thangarajah
First can you find the wso2 repos that use the above listener class and send them PRs with the fixes? This update task has to be a one time coordinated task. We need to fix all the places at once and for this we need to be ready with the PRs. On Fri, Jan 9, 2015 at 1:02 PM, Lakshman Udayakantha w

Re: [Dev] Fwd: Pull request to include tenant deletion support

2015-01-09 Thread Shashika Karunatilaka
Hi all, I will include newly added method to all respective repositories of *TenantMgtListener* interface, and also will create necessary JIRAs Thank you On Fri, Jan 9, 2015 at 1:02 PM, Lakshman Udayakantha wrote: > [fowarding to dev] > > Since new method introduced in *TenantMgtListener *inte

[Dev] Fwd: Pull request to include tenant deletion support

2015-01-08 Thread Lakshman Udayakantha
[fowarding to dev] Since new method introduced in *TenantMgtListener *interface, There may be build failures after committing this. how should we proceed with that? Hi Carbon team, Please review and merge the pull requests [1] and [2] that is include the changes in tenant deletion support. [1]