[GitHub] zeppelin pull request #2877: ZEPPELIN-3345. Don't load interpreter setting w...

2018-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2877 ---

[GitHub] zeppelin issue #2873: ZEPPELIN-3340 Streaming support in builtin visualizati...

2018-03-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2873 Tried on local, works well. LGTM! ---

[GitHub] zeppelin pull request #2877: ZEPPELIN-3345. Don't load interpreter setting w...

2018-03-16 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2877 ZEPPELIN-3345. Don't load interpreter setting when it exist interpreter.json but no interpreter-setting.json found ### What is this PR for? It usually happens in dev enviroment. e.g. I have

[GitHub] zeppelin issue #2872: [ZEPPELIN-3089] Delete all notes for current user

2018-03-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2872 Thanks for the review will merge this if no more discussion. ---

[jira] [Created] (ZEPPELIN-3345) Don't load interpreter setting where it exist interpreter.json but no interpreter-setting.json found

2018-03-16 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-3345: Summary: Don't load interpreter setting where it exist interpreter.json but no interpreter-setting.json found Key: ZEPPELIN-3345 URL:

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2834 Thanks for the contribution. Regarding the interpolation property, I think it might be better to use paragraph level property instead of interpreter level property. e.g. here's what I imagine

[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...

2018-03-16 Thread mebelousov
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2876 ZEPPELIN-3344. Revert comments in queries in JDBC interpreter ### What is this PR for? The original purpose of https://github.com/apache/zeppelin/pull/2158 was correct processing of ';'.

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

2018-03-16 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2834 Here is one approach: define two new [zeppelin configurable properties](http://zeppelin.apache.org/docs/latest/install/configuration.html) as follows: 1) A boolean property named

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 @tinkoff-dwh I just realised that zeppelin already support hooks for interpreter. I think you don't need to do it specifically for jdbc interpreter, instead we could introduce one general property

[GitHub] zeppelin pull request #2875: ZEPPELIN-3343. Interpreter Hook is broken

2018-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2875 ---

[GitHub] zeppelin issue #2872: [ZEPPELIN-3089] Delete all notes for current user

2018-03-16 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2872 LGTM ---

[jira] [Created] (ZEPPELIN-3344) Revert comments in JDBC interpreter

2018-03-16 Thread Maxim Belousov (JIRA)
Maxim Belousov created ZEPPELIN-3344: Summary: Revert comments in JDBC interpreter Key: ZEPPELIN-3344 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3344 Project: Zeppelin Issue

[GitHub] zeppelin pull request #2875: ZEPPELIN-3343. Interpreter Hook is broken

2018-03-16 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2875 ZEPPELIN-3343. Interpreter Hook is broken ### What is this PR for? Currently the interpreter hook mechanism is broken. This PR fix this issue and also add unit test for interpreter hook,

[GitHub] zeppelin issue #2870: [ZEPPELIN-3335] trim property name of interpreter sett...

2018-03-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2870 can you check https://travis-ci.org/rockiee281/zeppelin/builds/353672192 ---

[GitHub] zeppelin pull request #2874: ZEPPELIN-3339. Add more test for ZeppelinContex...

2018-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2874 ---