[GitHub] zeppelin issue #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter for no...

2017-09-22 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2594 Ready to merge! 😄 ---

[GitHub] zeppelin pull request #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter...

2017-09-22 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/2594 [ZEPPELIN-2944] Cannot launch Spark interpreter for non-local mode ### What is this PR for? When I used Spark interpreter for non-local mode, I got ``` java.lang.RuntimeException

[GitHub] zeppelin pull request #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter...

2017-09-22 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/2594 ---

[GitHub] zeppelin issue #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter for no...

2017-09-21 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2594 Oops! I was looking at wrong place 😢 Thanks @felixcheung ! I restarted failed jobs. After that, should I re-open this PR? ---

[GitHub] zeppelin issue #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter for no...

2017-09-21 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2594 Hi! How can I make Jenkins green? All tests passed on my Travis: https://travis-ci.org/tae-jun/zeppelin/builds/277762975 ---

[GitHub] zeppelin pull request #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter...

2017-09-20 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/2594 [ZEPPELIN-2944] Cannot launch Spark interpreter for non-local mode ### What is this PR for? When I used Spark interpreter for non-local mode, I got ``` java.lang.RuntimeException

[GitHub] zeppelin pull request #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter...

2017-09-20 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/2594 ---

[GitHub] zeppelin pull request #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter...

2017-09-20 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/2594 [ZEPPELIN-2944] Cannot launch Spark interpreter for non-local mode ### What is this PR for? When I used Spark interpreter for non-local mode, I got ``` java.lang.RuntimeException

[GitHub] zeppelin pull request #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter...

2017-09-20 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/2594 ---

[GitHub] zeppelin issue #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter for no...

2017-09-20 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2594 @zjffdu Thanks for the review! 😄 ---

[GitHub] zeppelin pull request #2594: [ZEPPELIN-2944] Cannot launch Spark interpreter...

2017-09-20 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/2594 [ZEPPELIN-2944] Cannot launch Spark interpreter for non-local mode ### What is this PR for? When I used Spark interpreter for non-local mode, I got ``` java.lang.RuntimeException

[jira] [Created] (ZEPPELIN-2944) Cannot launch Spark interpreter

2017-09-20 Thread Tae Jun Kim (JIRA)
Tae Jun Kim created ZEPPELIN-2944: - Summary: Cannot launch Spark interpreter Key: ZEPPELIN-2944 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2944 Project: Zeppelin Issue Type: Bug

[GitHub] zeppelin issue #2547: Fix trivial typo

2017-08-22 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2547 LGTM! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2543: [ZEPPELIN-2860] Invalid last job execution time

2017-08-17 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2543 LGTM! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2543: [ZEPPELIN-2860] Invalid last job execution time

2017-08-16 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2543 @byung-u Oh, I didn't see the code and commented above...😅 But I found you missed something! The original code has an error because it always gets `lastRunningUnixTime`

[GitHub] zeppelin issue #2543: [ZEPPELIN-2860] Invalid last job execution time

2017-08-16 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2543 LGTM! 👍 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2451: [ZEPPELIN-2708][DOCS] feat: Add v scroll to setup, usa...

2017-06-29 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2451 Now it works perfectly 👍 LGTM! ![image](https://user-images.githubusercontent.com/8201019/27687030-32daeb38-5d10-11e7-8b20-8c4f350947dc.png) --- If your project is set up for

[GitHub] zeppelin pull request #2432: [ZEPPELIN-2652] Can't open spark tutorial note ...

2017-06-23 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/2432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2432: [ZEPPELIN-2652] Can't open spark tutorial note in 0.8....

2017-06-23 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2432 @zjffdu Ok. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2432: [ZEPPELIN-2652] Can't open spark tutorial note in 0.8....

2017-06-23 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2432 @zjffdu Thanks for the review! I see. Then would it better to close this PR and wait for it? What do you think? :) --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2432: [ZEPPELIN-2652] Can't open spark tutorial note in 0.8....

2017-06-23 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2432 @tinkoff-dwh @soralee Thanks for the reviews 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2432: [ZEPPELIN-2652] Can't open spark tutorial note in 0.8....

2017-06-22 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2432 @zjffdu Hi, could you please review this? I think this is related to #2245. I am not sure that I did the right thing. Is `Input` class is an abstract class? Thanks ð

[GitHub] zeppelin pull request #2432: [ZEPPELIN-2652] Can't open spark tutorial note ...

2017-06-22 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/2432 [ZEPPELIN-2652] Can't open spark tutorial note in 0.8.0-SNAPSHOT ### What is this PR for? Fix the bug which cannot open a note containing a dynamic form. It is not a probl

[GitHub] zeppelin issue #2317: [ZEPPELIN-2493] Visualization class should throw an er...

2017-05-21 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2317 @1ambda Thanks for the review! 😄 I didn't know that you asked me to add a test 😢 Was it added after the editing? But, since you said it is not necessary, I will

[GitHub] zeppelin pull request #2316: [DOC] Update documentation: JDK 1.7 -> 1.8

2017-05-03 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/2316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2316: [DOC] Update documentation: JDK 1.7 -> 1.8

2017-05-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2316 OK. Thanks for the review @1ambda! I'm closing myself 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2316: [DOC] Update documentation: JDK 1.7 -> 1.8

2017-05-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2316 Oh sorry I didn't see the last comment [here](https://issues.apache.org/jira/browse/ZEPPELIN-2405?focusedCommentId=15973784&page=com.atlassian.jira.plugin.system.issuetabpanels:comment

[GitHub] zeppelin pull request #2317: [ZEPPELIN-2493] Visualization class should thro...

2017-05-03 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/2317 [ZEPPELIN-2493] Visualization class should throw an error if an abstract method is not implemented ### What is this PR for? `Visualization` class should throw an error if an abstract method

[jira] [Created] (ZEPPELIN-2493) Visualization class should throw an error if an abstract method is not implemented

2017-05-03 Thread Tae Jun Kim (JIRA)
Tae Jun Kim created ZEPPELIN-2493: - Summary: Visualization class should throw an error if an abstract method is not implemented Key: ZEPPELIN-2493 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2493

[GitHub] zeppelin pull request #2316: [DOC] Update documentation: JDK 1.7 -> 1.8

2017-05-03 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/2316 [DOC] Update documentation: JDK 1.7 -> 1.8 ### What is this PR for? Zeppelin is built with JDK 1.8 since 0.7.1 as far as I know. But it is still 1.7 on [installation documentation](ht

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2274 Cool! Significantly better than before 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder

2017-04-10 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2228 Cool feature! LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium

2017-04-10 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2236 @AhyoungRyu Thanks! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium

2017-04-10 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2236 @AhyoungRyu Thanks for the review! I changed the sentence, and now it looks like this: > You can add any dependencies in package.json, but you **must include two dependenc

[GitHub] zeppelin pull request #2236: [DOC] Improve documents related to Helium

2017-04-09 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/2236 [DOC] Improve documents related to Helium ### What is this PR for? What I did for the documents: * Highlight codes * Follow JSON syntax * Remove white spaces And in my

[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization

2017-03-13 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2125 @conker84 FYI, you can simply just take a GIF using software called **LICEcap**, and upload it directly here with drag and drop :) --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2067: [DOCS][ZEPPELIN-2140] Add docs for notebookRepo REST A...

2017-02-25 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2067 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2065: [ZEPPELIN-2168] Fix typo on Elasticsearch interpreter ...

2017-02-25 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2065 LGTM 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1826: [ZEPPELIN-1859] Add MongoNotebookRepo

2017-02-19 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1826 @Leemoonsoo Thanks for the review! 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1826: [ZEPPELIN-1859] Add MongoNotebookRepo

2017-02-13 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1826 Ci failed on this PR, but it succeeded on my own CI! https://travis-ci.org/tae-jun/zeppelin/builds/200842368 --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #1826: [ZEPPELIN-1859] Add MongoNotebookRepo

2017-02-12 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1826 [ZEPPELIN-1859] Add MongoNotebookRepo ### What is this PR for? This PR adds Mongo notebook storage. The reason that I made this feature is for HA(High Availability). S3 and Git

[GitHub] zeppelin pull request #1826: [ZEPPELIN-1859] Add MongoNotebookRepo

2017-02-12 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1826 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1826: [WIP][ZEPPELIN-1859] Add MongoNotebookRepo

2017-02-12 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1826 Sorry for my late response! I added a documentation for MongoDB notebook storage and rebased. And now it's ready for a review 😄 Please test that it operates as I desc

[GitHub] zeppelin issue #1903: [DOCS] Reflect changed default storage to doc

2017-01-15 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1903 @AhyoungRyu @khalidhuseynov Thanks! 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #1903: [DOCS] Reflect changed default storage to doc

2017-01-15 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1903 [DOCS] Reflect changed default storage to doc ### What is this PR for? Reflect effects caused by changing the default notebook storage VFSNotebookRepo to GitNotebookRepo

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2017-01-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 @AhyoungRyu Finally, it's green!!! Thanks for your care 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2017-01-01 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2017-01-01 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2017-01-01 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2017-01-01 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-31 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 @AhyoungRyu Thanks!!! I fixed the test error thanks to you 👍 I guess CI will be green this time 😄 --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-31 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks @AhyoungRyu 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-30 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-30 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1826: [WIP][ZEPPELIN-1859] Add MongoNotebookRepo

2016-12-30 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1826 [WIP][ZEPPELIN-1859] Add MongoNotebookRepo ### What is this PR for? This PR adds Mongo notebook storage. The reason that I made this feature is for HA(High Availability). S3 and

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-30 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-30 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-30 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks for the review, @soralee! That was a big deal. I pushed a commit and now it looks like this: https://cloud.githubusercontent.com/assets/8201019/21564175/bc5fc4c2-cecd-11e6-88dd

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-27 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-27 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-25 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Conflict resolved 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-25 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1805 So coool! I tested following your instructions and it worked like a charm 👍 And live-reloading time remarkably decreased. LGTM!!! --- If your project is set up for it

[jira] [Created] (ZEPPELIN-1859) Add MongoNotebookRepo

2016-12-24 Thread Tae Jun Kim (JIRA)
Tae Jun Kim created ZEPPELIN-1859: - Summary: Add MongoNotebookRepo Key: ZEPPELIN-1859 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1859 Project: Zeppelin Issue Type: Improvement

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-23 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 @AhyoungRyu Yeah! Thanks :) Merry Christmas~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-23 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks @1ambda 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-22 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 @1ambda Thanks for your prompt response! I see what you mean now. Thanks for the explanation :) Now, only `remove permanently` and `restore` buttons are shown. https

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-22 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 @AhyoungRyu Always thanks for the review :) Also thanks for your understanding. @1ambda Thanks for the review! I appreciate it and sorry for my late response. That was a really nice

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-17 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-17 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-17 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 I changed `empty trash`, `remove folder permanently`, and `remove note permanently` icons to `X`. I'm not sure this is the best icon for it ^^; but we can change later when we find a sui

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-14 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1758 [Link for the note on ZeppelinHub](https://www.zeppelinhub.com/viewer/notebooks

[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-14 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1756 OMG hope that it passes this time... :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1760: Update DESCRIPTION

2016-12-14 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1760 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-14 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 @AhyoungRyu Always thanks for your nice review 😄 Yes, it's intended. A time stamp is generated only if a `folder` already exists in the trash. But it's not generated whe

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-13 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks @Leemoonsoo 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-11 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 ### CI is green! 😄 I **changed Selenium test codes** affected by my PR and it works now. Failed reason `remove note` button changed to `move to trash` but test code still

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-11 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-11 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-11 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-11 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-11 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks for your careful review @marchpig 😄 I fixed the bug you found! It turns out that I didn't normalize folder ID when creating a folder. It could be a serious bug if you d

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-08 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 @marchpig Sorry for my late response! I changed what you addressed except one thing. ### Korean note order ![image](https://cloud.githubusercontent.com/assets/8201019/21017141

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-07 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks @cuspymd 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-06 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks for the review @cuspymd! I think so, but I used HashSet because of consistency. Other methods used HashSet. I think if we want to change to 'Set', wouldn't it be bet

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-06 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 ![image](https://cloud.githubusercontent.com/assets/8201019/20929471/8897948a-bc0d-11e6-941b-4123bc09c8a7.png) It failed only at Selenium test twice. I guess it's because I **change

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-06 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks, @1ambda 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-06 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-06 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-06 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

2016-12-04 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1692 Cool! LGTM 👍 Korean Zeppelin community will love this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem

2016-12-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1723 I tested on Firefox and the error is gone. LGTM 👍 ![image](https://cloud.githubusercontent.com/assets/8201019/20860307/4507f57c-b9b8-11e6-9b15-fd6944ede2d5.png) And I guess

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-12-03 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 I found out bugs by adding loggers and fixed them! CI is green and it seems to work perfectly. I think it's good to go now 😄 Please when you have some time. Thanks! -

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-12-02 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1630 I've tested more and it was fine most times. But occasionally it doesn't work well. I think it should be tested more! I don't know why for now but I will figure it out and ping

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

2016-12-02 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1692 @cloverhearts Nice! Hope the new version will be released soon :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

  1   2   3   >