Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

> On Dec. 11, 2013, 8:06 p.m., German Blanco wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 387 > > > > > > Please remove spaces in this line. I do not understand because I didn't

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 12, 2013, 8:30 a.m.) Review request for zookeeper, German Blanco

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 12, 2013, 8:38 a.m.) Review request for zookeeper, German Blanco

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/#review30248 --- File Attachment: ZOOKEEPER-1814.patch - ZOOKEEPER-1814.patch

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 12, 2013, 8:42 a.m.) Review request for zookeeper, German Blanco

Re: Review Request 16202: Log all exceptions not caught by ZK threads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16202/ --- (Updated Dec. 12, 2013, 8:49 a.m.) Review request for zookeeper, Benjamin Reed,

[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Peon updated ZOOKEEPER-1814: --- Attachment: ZOOKEEPER-1814.patch New patch created after solving the warning. > Reductio

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 12, 2013, 8:53 a.m.) Review request for zookeeper, German Blanco

ZooKeeper-trunk-solaris - Build # 758 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/758/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 209487 lines...] [junit] 2013-12-12 09:01:30,711

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846190#comment-13846190 ] Hadoop QA commented on ZOOKEEPER-1814: -- +1 overall. Here are the results of test

Success: ZOOKEEPER-1814 PreCommit Build #1827

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827/ ### ## LAST 60 LINES OF THE CONSOLE ### [

ZooKeeper-3.4-WinVS2008_java - Build # 376 - Still Failing

See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/376/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 214413 lines...] [junit] 2013-12-12 10:08:5

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/#review30254 --- ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificatio

[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Peon updated ZOOKEEPER-1814: --- Attachment: ZOOKEEPER-1814.patch Uploaded new patch with correct test case indentation an

Status of 3.4.6

There are two issues blocking 3.4.6 now: - I don't understand why the 3.4 windows build in failing on Jenkins. Tests seem to pass fine on Windows for me. If anyone is willing to have a look, I would appreciate some help. - ZK-1430 needs to get in and I'd like to understand wh

Success: ZOOKEEPER-1814 PreCommit Build #1828

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846436#comment-13846436 ] Germán Blanco commented on ZOOKEEPER-1814: -- Sorry I didn't catch this before,

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846438#comment-13846438 ] Hadoop QA commented on ZOOKEEPER-1814: -- +1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846442#comment-13846442 ] Daniel Peon commented on ZOOKEEPER-1814: That's right, I should have thought a

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 12, 2013, 5:07 p.m.) Review request for zookeeper, German Blanco

[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Peon updated ZOOKEEPER-1814: --- Attachment: ZOOKEEPER-1814.patch In the test case, maxFleNotificationInterval parameter h

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 12, 2013, 5:12 p.m.) Review request for zookeeper, German Blanco

[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Peon updated ZOOKEEPER-1814: --- Attachment: ZOOKEEPER-1814.patch Updated with the right indentation in one line in the te

Success: ZOOKEEPER-1814 PreCommit Build #1829

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846489#comment-13846489 ] Hadoop QA commented on ZOOKEEPER-1814: -- +1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846493#comment-13846493 ] Raul Gutierrez Segales commented on ZOOKEEPER-1814: --- Some nits and s

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/#review30267 --- ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElecti

Success: ZOOKEEPER-1814 PreCommit Build #1830

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846507#comment-13846507 ] Hadoop QA commented on ZOOKEEPER-1814: -- +1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1382) Zookeeper server holds onto dead/expired session ids in the watch data structures

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846547#comment-13846547 ] Germán Blanco commented on ZOOKEEPER-1382: -- Thank you [~fournc]! > Zookeeper

Re: Status of 3.4.6

Hello Flavio, this looks great now, only one small problem and the deployment to go! Congratulations! I have taken a look at the windows build in Jenkins, and I am going to make a wild guess at what it might be happening, I hope it is worth anything. In many of the errors, the assertion in JMXEnv

Re: Status of 3.4.6

... there is a similar situation in JMXEnv.java:138. It seems that "ensureOnly" gets call before the previously invoked shutdown has completed. The problem here is that one needs the Jenkins build in order to test what is really happening :-( On Thu, Dec 12, 2013 at 7:57 PM, German Blanco < germa

[jira] [Created] (ZOOKEEPER-1835) dynamic configuration file renaming fails on Windows

Bruno Freudensprung created ZOOKEEPER-1835: -- Summary: dynamic configuration file renaming fails on Windows Key: ZOOKEEPER-1835 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1835 Project

[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846741#comment-13846741 ] Bruno Freudensprung commented on ZOOKEEPER-1691: Hi Alex, Thanks for

Re: Status of 3.4.6

Good points. I'm not sure if the client being being closed is what is causing the test failure, but it is not a bad guess. I think we need to execute ensureAll only in the case we add the client. The observation about ensureOnly seems right to me. We will need to get those in to get Jenkins to

[jira] [Assigned] (ZOOKEEPER-1833) fix 3.4 windows build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki reassigned ZOOKEEPER-1833: -- Assignee: Michi Mutsuzaki (was: some one) > fix 3.4 windows build > --

[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846779#comment-13846779 ] Bruno Freudensprung commented on ZOOKEEPER-1691: Here is my next test.

Re: Status of 3.4.6

I'm running the build on my local windows box right now. I am seeing some test failures, although the number of failures is much less. I'll update the jira when I finish running the test. Also, I just noticed that ZooKeeper-trunk-WinVS2008_java has been timing out. I didn't know ZooKeeper-trunk-Wi

[jira] [Commented] (ZOOKEEPER-1833) fix 3.4 windows build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846892#comment-13846892 ] Michi Mutsuzaki commented on ZOOKEEPER-1833: The following tests failed on

[jira] [Commented] (ZOOKEEPER-1833) fix 3.4 windows build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846906#comment-13846906 ] Michi Mutsuzaki commented on ZOOKEEPER-1833: ClientPortBindTest error seem

ZooKeeper-trunk-WinVS2008_java - Build # 622 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/622/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 271774 lines...] [junit] 2013-12-13 00:00

[jira] [Updated] (ZOOKEEPER-1833) fix windows build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-1833: --- Summary: fix windows build (was: fix 3.4 windows build) > fix windows build > --

[jira] [Updated] (ZOOKEEPER-1833) fix 3.4 windows build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-1833: --- Attachment: ZOOKEEPER-1833.patch > fix 3.4 windows build > -

Re: Status of 3.4.6

I uploaded a patch that fixes ClientPortBindTest. https://issues.apache.org/jira/browse/ZOOKEEPER-1833 On Thu, Dec 12, 2013 at 2:14 PM, Michi Mutsuzaki wrote: > I'm running the build on my local windows box right now. I am seeing some > test failures, although the number of failures is much less

[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846973#comment-13846973 ] Alexander Shraer commented on ZOOKEEPER-1691: - Hi Bruno, standaloneEnable

Failed: ZOOKEEPER-1833 PreCommit Build #1831

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1833 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1831/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1833) fix windows build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846983#comment-13846983 ] Hadoop QA commented on ZOOKEEPER-1833: -- -1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1833) fix windows build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846990#comment-13846990 ] Michi Mutsuzaki commented on ZOOKEEPER-1833: {quote} -1 tests included. Th

Failed: ZOOKEEPER-1833 PreCommit Build #1832

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1833 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1832/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-1833) fix windows build

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846993#comment-13846993 ] Hadoop QA commented on ZOOKEEPER-1833: -- -1 overall. Here are the results of test

[jira] [Created] (ZOOKEEPER-1836) addrvec_next() fails to set next parameter if addrvec_hasnext() returns false

Dutch T. Meyer created ZOOKEEPER-1836: - Summary: addrvec_next() fails to set next parameter if addrvec_hasnext() returns false Key: ZOOKEEPER-1836 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1836

[jira] [Updated] (ZOOKEEPER-1576) Zookeeper cluster - failed to connect to cluster if one of the provided IPs causes java.net.UnknownHostException

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jaton updated ZOOKEEPER-1576: -- Attachment: ZOOKEEPER-1576-3.4.patch Patch for 3.4 > Zookeeper cluster - failed to

[jira] [Commented] (ZOOKEEPER-1576) Zookeeper cluster - failed to connect to cluster if one of the provided IPs causes java.net.UnknownHostException

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847042#comment-13847042 ] Benjamin Jaton commented on ZOOKEEPER-1576: --- Hello, I adapted the existing p

[jira] [Commented] (ZOOKEEPER-1836) addrvec_next() fails to set next parameter if addrvec_hasnext() returns false

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847116#comment-13847116 ] Marshall McMullen commented on ZOOKEEPER-1836: -- Yes, that was what I inte

ZooKeeper_branch33_solaris - Build # 735 - Failure

See https://builds.apache.org/job/ZooKeeper_branch33_solaris/735/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 103129 lines...] [junit] 2013-12-13 07:07:26,

[jira] [Created] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

Germán Blanco created ZOOKEEPER-1837: Summary: Fix JMXEnv checks (potential race conditions) Key: ZOOKEEPER-1837 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837 Project: ZooKeeper

Re: Status of 3.4.6

I have also seen this failure in the logs: junit.framework.AssertionFailedError: QP failed to shutdown in 30 seconds: QuorumPeer[myid=0]/127.0.0.1:11251 at org.apache.zookeeper.test.QuorumBase.shutdown(QuorumBase.java:393) at org.apache.zookeeper.server.quorum.QuorumPeerTestBase$T