[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228885#comment-15228885
]
Hudson commented on ZOOKEEPER-2141:
---
FAILURE: Integrated in ZooKeeper-trunk #2880 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15224818#comment-15224818
]
Edward Ribeiro commented on ZOOKEEPER-2141:
---
Hi [~fournc], thank you for your consideration!
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222172#comment-15222172
]
Camille Fournier commented on ZOOKEEPER-2141:
-
OK I'm looking at this patch more carefully
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220677#comment-15220677
]
Hadoop QA commented on ZOOKEEPER-2141:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220636#comment-15220636
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I didn't notice which bit of whitespace was
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217962#comment-15217962
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I've provided the alternative patch for
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217934#comment-15217934
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I completely agree, I can't envisage a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217921#comment-15217921
]
Edward Ribeiro commented on ZOOKEEPER-2141:
---
Hi [~adammilnesmith], I will try to check your
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217794#comment-15217794
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I've provided a patch for using option 1.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217762#comment-15217762
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
Notes on the pre-commit build results
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217757#comment-15217757
]
Hadoop QA commented on ZOOKEEPER-2141:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217692#comment-15217692
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
Responses to each (now that I'm at a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217663#comment-15217663
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I had been tempted to move the equals out
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217648#comment-15217648
]
Flavio Junqueira commented on ZOOKEEPER-2141:
-
That's an option and I'm fine if you want
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217566#comment-15217566
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
To remove the deadlock concerns in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217529#comment-15217529
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
Thanks [~eribeiro] - I'll take a stab at
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217516#comment-15217516
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I checked it carefully before findbugs
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217511#comment-15217511
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I think I made a comment about being
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217496#comment-15217496
]
Flavio Junqueira commented on ZOOKEEPER-2141:
-
Ok, I checked the code [~eribeiro] has
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217445#comment-15217445
]
Flavio Junqueira commented on ZOOKEEPER-2141:
-
I'm changing the priority to blocker to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217052#comment-15217052
]
Camille Fournier commented on ZOOKEEPER-2141:
-
Nice catch Eddie. Issue #1 is worth
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216993#comment-15216993
]
Edward Ribeiro commented on ZOOKEEPER-2141:
---
Hi [~adammilnesmith] and [~fournc], I am
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216359#comment-15216359
]
Camille Fournier commented on ZOOKEEPER-2141:
-
This is great, +1 on all of it, I've
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213628#comment-15213628
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
QA bot tried to apply the 3.4 branch patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213625#comment-15213625
]
Hadoop QA commented on ZOOKEEPER-2141:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207709#comment-15207709
]
Hudson commented on ZOOKEEPER-2141:
---
SUCCESS: Integrated in ZooKeeper-trunk #2865 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207534#comment-15207534
]
Camille Fournier commented on ZOOKEEPER-2141:
-
Into 3.5 as well. Just waiting on 3.4.
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207522#comment-15207522
]
Camille Fournier commented on ZOOKEEPER-2141:
-
Reviewed the patch against trunk, +1 on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204840#comment-15204840
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
No problem - will do - I should have some
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204821#comment-15204821
]
Camille Fournier commented on ZOOKEEPER-2141:
-
Yes please just make a patch that applies
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204817#comment-15204817
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
Fixing this for the 3.4 branch too would be
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203108#comment-15203108
]
Hadoop QA commented on ZOOKEEPER-2141:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199206#comment-15199206
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I just ran the failing test locally 5 times
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197318#comment-15197318
]
Camille Fournier commented on ZOOKEEPER-2141:
-
It's failing in AsyncHammerTest. Not sure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200102#comment-15200102
]
Camille Fournier commented on ZOOKEEPER-2141:
-
This one failed on a cpp test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199812#comment-15199812
]
Hadoop QA commented on ZOOKEEPER-2141:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197532#comment-15197532
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
Thanks [~fournc]. AsyncHammerTest was
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196549#comment-15196549
]
Hadoop QA commented on ZOOKEEPER-2141:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195985#comment-15195985
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I don't think the test failure was related
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195968#comment-15195968
]
Hadoop QA commented on ZOOKEEPER-2141:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195613#comment-15195613
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
Thanks Patrick. It looks like I did it
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195603#comment-15195603
]
Patrick Hunt commented on ZOOKEEPER-2141:
-
Hi Adam. qabot only looks at jiras in the "patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188871#comment-15188871
]
Adam Milne-Smith commented on ZOOKEEPER-2141:
-
I'll take a look and fix these - thanks
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187012#comment-15187012
]
Hadoop QA commented on ZOOKEEPER-2141:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002206#comment-15002206
]
Hadoop QA commented on ZOOKEEPER-2141:
--
-1 overall. Here are the results of testing the latest
45 matches
Mail list logo