Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/Acpi/AcpiSmm: Add Standalone MM support

2021-03-26 Thread Michael Kubacki
Sending a review reminder since it's been a few weeks. Thanks, Michael On 3/8/2021 9:17 AM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3248 Adds a new module called AcpiStandaloneMm that serves the same role as AcpiSmm but in a Standalone

[edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

2021-03-26 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 Current SMM Save State routine does not check the number of bytes to be read, when it comse to read IO_INFO, before casting the incoming buffer to EFI_SMM_SAVE_STATE_IO_INFO. This could potentially cause memory corruption due to extra bytes

[edk2-devel] [PATCH v1 0/1] Add buffer size check before save state read

2021-03-26 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 This change added buffer width check before copying IO information into incoming buffer. This bug could potentially corrupt memory due to out of buffer boundary memory access. Patch v1 branch: https://github.com/kuqin12/edk2/tree/svst_width

Re: [edk2-devel] [edk2-platforms] [patch V3 25/35] Silicon/CoffeelakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Bi, Dandan Sent: Friday, March 26, 2021 1:39 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V Subject: [edk2-platforms] [patch V3 25/35] Silicon/CoffeelakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Re: [edk2-devel] [edk2-platforms] [patch V3 26/35] Silicon/IntelSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Bi, Dandan Sent: Friday, March 26, 2021 1:39 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platforms] [patch V3 26/35] Silicon/IntelSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib REF: https

Re: [edk2-devel] [edk2-platforms] [patch V3 27/35] Silicon/KabylakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Bi, Dandan Sent: Friday, March 26, 2021 1:39 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V Subject: [edk2-platforms] [patch V3 27/35] Silicon/KabylakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib R

Re: [edk2-devel] [edk2-platforms] [patch V3 29/35] Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Bi, Dandan Sent: Friday, March 26, 2021 1:39 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L ; Luo, Heng Subject: [edk2-platforms] [patch V3 29/35] Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc fo

Re: [edk2-devel] [edk2-platforms] [patch V3 29/35] Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Chaganty, Rangasai V
I see. That makes sense. Thanks for the clarification. Regards, Sai -Original Message- From: Kinney, Michael D Sent: Friday, March 26, 2021 11:07 AM To: devel@edk2.groups.io; Chaganty, Rangasai V ; Kinney, Michael D Subject: RE: [edk2-devel] [edk2-platforms] [patch V3 29/35] Silicon

Re: [edk2-devel] [RFC PATCH 09/19] MdePkg: Add AsmPvalidate() support

2021-03-26 Thread Andrew Fish via groups.io
> On Mar 25, 2021, at 3:54 AM, Brijesh Singh wrote: > > On 3/24/21 9:49 PM, gaoliming wrote: >> Is this API X64 only? Or IA32 and X64 both? > > > Theoretically the instruction is available on both IA32 and X64 but its > used only in X64. AMD SEV, SEV-ES and SEV-SNP support is available for >

Re: [edk2-devel] [edk2-platforms] [patch V3 29/35] Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Michael D Kinney
Hi Sai, The latest patch series adds [LibraryClasses] statement to the MdeLibs.dsc.inc on purpose so MdeLibs.dsc.inc can be extended to support multiple library classes sections for different CPU archs and different modules types as needed in the future. Putting the !include outside the [Library

Re: [edk2-devel] [edk2-platforms] [patch V3 22/35] Platform/Socionext: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Michael D Kinney
Hi Dandan, One more patch I think can be dropped to remove dsc.inc including dsc.inc from another package. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dandan Bi > Sent: Friday, March 26, 2021 1:39 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm

Re: [edk2-devel] [edk2-platforms] [patch V3 30/35] Silicon/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Michael D Kinney
Hi Dandan, Another patch I think can be dropped to remove dsc.inc including dsc.inc from another package. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dandan Bi > Sent: Friday, March 26, 2021 1:39 AM > To: devel@edk2.groups.io > Cc: Marcin Wojtas ; Leif Lindholm

Re: [edk2-devel] [edk2-platforms] [patch V3 31/35] Silicon/NXP: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Michael D Kinney
Hi Dandan, Another example of adsc.inc including a dsc.in from another package. I recommend this patch be dropped. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dandan Bi > Sent: Friday, March 26, 2021 1:39 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Meen

Re: [edk2-devel] [edk2-platforms] [patch V3 24/35] Silicon/Hisilicon: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Michael D Kinney
Hi Dandan, Here is another example of adding an include of a dsc.inc from another dsc.inc. I do not think we should do this. The NetworkPkg and UnitTestFranmeworkPkg have examples where it is ok for one dsc.inc to include another dsc.inc, and that is if the included dsc.inc is in the same package

Re: [edk2-devel] [patch V3 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Michael D Kinney
Dandan, I am not sure if one dsc.inc file should include another dsc.inc file. If a package/platform DSC file has a dependency on other packages to build, then that DSC file can include the dsc.inc files from those dependent packages. This limits the dsc.inc include depth is 1. Nesting includes

Re: [edk2-devel] [edk2-platforms] [patch V3 29/35] Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Chaganty, Rangasai V
Since this .dsc include is building some basic library instances from MdePkg, please move the include under [LibraryClasses.common] section, preferably under the #Basic category. Thanks, Sai -Original Message- From: Bi, Dandan Sent: Friday, March 26, 2021 1:39 AM To: devel@edk2.groups

[edk2-devel] [PATCH] BaseTools/GenFw: Fix casting result of comparison

2021-03-26 Thread Tim Crawford
The cast in IsDataShdr() is only applied the left side, causing it to always return FALSE. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3271 Signed-off-by: Tim Crawford --- BaseTools/Source/C/GenFw/Elf32Convert.c | 2 +- BaseTools/Source/C/GenFw/Elf64Convert.c | 2 +- 2 files changed, 2 i

Re: [edk2-devel] [patch V3 26/29] UefiPayloadPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Guo Dong
Reviewed-by: Guo Dong > -Original Message- > From: Bi, Dandan > Sent: Friday, March 26, 2021 12:24 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [patch V3 26/29] UefiPayloadPkg: Consume MdeLibs.dsc.inc for > RegisterFilterLib > > REF: https:

Re: [edk2-devel] [PATCH v2 2/2] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS

2021-03-26 Thread Mario Bălănică
> > - GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0, > ResourceConsumer, , ) { 128 } > + //GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0, > ResourceConsumer, , ) { 128 } > This line should be completely removed. BT_ON is configured by the firmware,

Re: [edk2-devel] [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h

2021-03-26 Thread Lendacky, Thomas
On 3/25/21 10:47 AM, Anthony PERARD wrote: > We are going to use the page table structure in yet another place, > collect the types and macro that can be used from another module > rather that making yet another copy. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 > Signed-off-by: An

[edk2-devel] [edk2-platforms] [patch V3 35/35] Silicon/TexasInstruments: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 27/35] Silicon/KabylakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 34/35] Silicon/Synopsys/DesignWare: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 23/35] Platform/SoftIron: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 33/35] Silicon/RISC_V: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 31/35] Silicon/NXP: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 32/35] Silicon/Openmoko: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 30/35] Silicon/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 22/35] Platform/Socionext: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 25/35] Silicon/CoffeelakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 24/35] Silicon/Hisilicon: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 29/35] Silicon/TigerlakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 26/35] Silicon/IntelSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 28/35] Silicon/QuarkSocPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 21/35] Platform/SiFive: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 19/35] Platform/RaspberryPi: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 13/35] Platform/BoardModulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 16/35] Platform/Vlv2TbltDevicePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 15/35] Platform/QuarkPlatformPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 14/35] Platform/MinPlatformPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 20/35] Platform/RISC-V: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 18/35] Platform/Qemu: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 17/35] Platform/LeMaker: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 12/35] Platform/BeagleBoard: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 08/35] Features/SystemInformation: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 10/35] Platform/AMD: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 11/35] Platform/ARM: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 04/35] Features/Debugging: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 09/35] Features/UserInterface: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 07/35] Features/PowerManagement: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 03/35] Drivers/OptionRomPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 06/35] Features/OutOfBandManagement: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 01/35] Drivers/ASIX: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 00/35] Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 RFC: https://edk2.groups.io/g/devel/message/72530 edk2 change: https://edk2.groups.io/g/devel/message/73315 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also adde

[edk2-devel] [edk2-platforms] [patch V3 05/35] Features/Network: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [edk2-platforms] [patch V3 02/35] Drivers/DisplayLink: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

Re: [edk2-devel] [patch V3 13/29] IntelFsp2WrapperPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Bi, Dandan > Sent: Friday, March 26, 2021 3:24 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [patch V3 13/29] IntelFsp2WrapperPkg: Consume MdeLibs.dsc.inc for > RegisterFilterLib

Re: [edk2-devel] [patch V3 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access

2021-03-26 Thread Ard Biesheuvel
On Fri, 26 Mar 2021 at 08:24, Dandan Bi wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > RFC: https://edk2.groups.io/g/devel/message/72530 > Branch for this change: > https://github.com/dandanbi/edk2/tree/RegisterFilterLibV3 > > Patch 1 is to add RegisterFilterLib Library Cla

Re: [edk2-devel] [PATCH] IntelSiliconPkg: Define PCDs for microcode location in flash

2021-03-26 Thread Ni, Ray
Please ignore this patch mail. I sent another series: cover: https://edk2.groups.io/g/devel/message/73346 1/2: https://edk2.groups.io/g/devel/message/73347 2/3: https://edk2.groups.io/g/devel/message/73348 3/3: https://edk2.groups.io/g/devel/message/73349 > -Original Message- > From: Ni,

Re: [edk2-devel] [patch V2 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg

2021-03-26 Thread Dandan Bi
Hi Mike and Liming, V3 version was sent out, please help review it. Thanks, Dandan > -Original Message- > From: Kinney, Michael D > Sent: Friday, March 26, 2021 8:49 AM > To: Bi, Dandan ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Liming Gao ; Liu, Zhiguang > ; Laszlo Ersek > Sub

Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg/IntelGvtGopDxe: Intel GVT-g GOP Implementation.

2021-03-26 Thread Colin Xu
On Fri, 19 Mar 2021, Gerd Hoffmann wrote: Hi, operations but handle the common logic. In this opregion case, QEMU and seabios only copies the raw data, but the contents are left to gvt to fill so that gvt could fill different data in different cases. Yes, gvt could do that. The big questio

[edk2-devel] [PATCH 3/3] MinPlatformPkg: Remove the microcode location PCDs

2021-03-26 Thread Ni, Ray
Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/

[edk2-devel] [PATCH 1/3] IntelSiliconPkg: Define PCDs for microcode location in flash

2021-03-26 Thread Ni, Ray
3 PCDs are defined assuming that microcode is put in the end of a FV: PcdFlashFvMicrocodeBase: The base address of the microcode FV PcdFlashFvMicrocodeSize: The size of the microcode FV PcdFlashMicrocodeOffset: The microcode offset relative to the FV base address The 3 new

[edk2-devel] [PATCH 2/3] MinPlatformPkg: Use the microcode PCDs defined in IntelSiliconPkg

2021-03-26 Thread Ni, Ray
The microcode PCDs in MinPlatformPkg will be removed in a separate patch. Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- .../Flash/SpiFvbService/SpiFvbServiceSmm.inf | 7 --- .../Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf|

[edk2-devel] [PATCH 0/3] Define microcode location PCDs in IntelSiliconPkg

2021-03-26 Thread Ni, Ray
Ray Ni (3): IntelSiliconPkg: Define PCDs for microcode location in flash MinPlatformPkg: Use the microcode PCDs defined in IntelSiliconPkg MinPlatformPkg: Remove the microcode location PCDs .../Flash/SpiFvbService/SpiFvbServiceSmm.inf | 7 --- .../Flash/SpiFvbService/SpiFvbS

Re: [edk2-devel] [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
Hi Bret, 1. We don't want to introduce duplicated codes and too many instances will also make people confused to consume. 2. If we add a new instance of IoLib, consumer will also only use one, I think should not have the symbol collision issue. Thanks, Dandan From: Bret Barkelew Sent:

[edk2-devel] [patch V3 26/29] UefiPayloadPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 29/29] MdePkg/Baseib: Filter/trace MSR access for IA32/X64

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Dandan Bi Reviewed-by: Liming Gao --- MdePkg/Library/BaseLib/BaseLib.inf | 5 ++- MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c | 38 +++--- MdePk

[edk2-devel] [patch V3 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Dandan Bi Reviewed-by: Liming Gao --- .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 3 +- .../BaseIoLibIntrinsicArmVirt.inf | 3 +- .../BaseIoLibIntri

[edk2-devel] [patch V3 19/29] RedfishPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 21/29] ShellPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 25/29] UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 24/29] StandaloneMmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 23/29] SourceLevelDebugPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 20/29] SecurityPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 18/29] PcAtChipsetPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 17/29] OvmfPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 22/29] SignedCapsulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 16/29] NetworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 15/29] MdePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 14/29] MdeModulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 13/29] IntelFsp2WrapperPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 10/29] FatPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 12/29] IntelFsp2Pkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 11/29] FmpDevicePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 08/29] EmbeddedPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 06/29] CryptoPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 09/29] EmulatorPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 07/29] DynamicTablesPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 03/29] ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 05/29] ArmVirtPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

[edk2-devel] [patch V3 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc is added for some default libraries provided by MdePkg. Platform can include MdeLibs.dsc.inc file to avoid some potential incompatible changes to platform dsc file in future. Only add RegisterFilterLib into it as the first v

[edk2-devel] [patch V3 01/29] MdePkg: Add RegisterFilterLib class and NULL instance

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 1. Add a new library class (RegisterFilterLib) to filter and trace port IO/MMIO/MSR access. 2. Add a NULL instance (RegisterFilterLibNull) can be used to keep current behavior. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-

[edk2-devel] [patch V3 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 RFC: https://edk2.groups.io/g/devel/message/72530 Branch for this change: https://github.com/dandanbi/edk2/tree/RegisterFilterLibV3 Patch 1 is to add RegisterFilterLib Library Class in edk2 to filter/trace port IO/MMIO/MSR access and add a

[edk2-devel] [patch V3 04/29] ArmPlatformPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-26 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re