Re: [edk2-devel] [PATCH V1 1/1] UefiCpuPkg/ResetVector: Cache Disable should not be set by default in CR0

This patch causes a regression when launching a vm guest with below command: $ /usr/libexec/qemu-kvm \ -name guestVM1 -machine q35 -accel kvm -m 10240 -smp 8 -cpu host -monitor pty \ -drive format=raw,file=/home/tdvf/centos-stream-9.img \ -bios /home/tdvf/OVMF.fd \ -nic

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw strings containing valid escape characters

@Gao, Liming @'Rebecca Cran' Could you please help to merge this PR? BaseTools: Fix raw strings containing valid escape characters by YuweiChen1110 · Pull Request #5238 · tianocore/edk2

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Junfeng Guan > 发送时间: 2023年12月28日 15:54 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Yi Li > > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function > description > >

[edk2-devel] [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in ConvertMemoryPageToNotPresent

After ConvertMemoryPageToNotPresent, there is always a flush TLB function. So, to improve performance, there is no need to write CR3 inside ConvertMemoryPageToNotPresent Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Zhiguang Liu ---

[edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4614 Fix issue that IsModified is wrongly set in PageTableMap. Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Crystal Lee Signed-off-by: Zhiguang Liu --- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 10

[edk2-devel] [PATCH] [Patch V3]IntelFsp2Pkg\Tools\ConfigEditor:Added new USF config workstream.

Config Editor utility addition/changes: Support to enable config editor tool to have a new feature that can load and view the configuration data of compiled VFR or HFR in form of YAML. This can help users to understand and track the configuration data when modifications are made. Requires

Re: [edk2-devel] [RFC PATCH v1 00/20] DynamicTablesPkg: Prepare to add RISC-V support

Hi Jeshua, On Tue, Jan 09, 2024 at 06:37:43PM +, Jeshua Smith wrote: > > From: devel@edk2.groups.io On Behalf Of Sunil V L > > via groups.io > > Sent: Tuesday, January 9, 2024 9:29 AM > > DynamicTablesPkg can be used by RISC-V platforms to generate ACPI tables > > from FDT passed from

Re: [edk2-devel] [PATCH v6 26/36] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull

Hi Bibo, Thanks, Chao On 2024/1/10 09:24, maobibo wrote: On 2024/1/5 下午5:45, Chao Li wrote: This Library is used to collect APs resources, but is currently NULL for OvmfPkg, because it is not used by the LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, January 9, 2024 7:13 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH v2] RedfishPkg/RedfishDebugLib: add function

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection of timer

Hi Nate, Ah, that makes sense. Thanks! Best regards, Benjamin On January 9, 2024 8:28:08 p.m. EST, "Desimone, Nathaniel L" wrote: >Hi Benjamin, > >We consider using the LAPIC as a timer to be technically superior because it >is closer to the CPU. The HPET is a PCH device, which means all

Re: [edk2-devel] [PATCH V2 1/6] NetworkPkg/HttpDxe: Refactor TlsCreateChild

[AMD Official Use Only - General] Thanks Saloni, I will create a PR and merge it. Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Saloni > Kasbekar via groups.io > Sent: Wednesday, January 10, 2024 7:26 AM > To: devel@edk2.groups.io; Chang, Abner > Cc:

Re: [edk2-devel] [PATCH v6 36/36] OvmfPkg/LoongArchVirt: Add self introduction file

On 2024/1/5 下午5:46, Chao Li wrote: Add self introduction file for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li ---

Re: [edk2-devel] [PATCH v6 35/36] OvmfPkg/LoongArchVirt: Add build file

On 2024/1/5 下午5:46, Chao Li wrote: Add infrastructure files to build edk2 for LoongArch QEMU virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection of timer

Hi Benjamin, We consider using the LAPIC as a timer to be technically superior because it is closer to the CPU. The HPET is a PCH device, which means all access to the timer needs go from CPU -> Home Agent -> Fabric/IO Ring -> DMI Controller -> PCH. Using the LAPIC cuts this path to just the

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection of timer

Hi Hua, Please make TIMER_SUPPORT a FixedAtBuiildPcd instead of a build flag. Something like PcdDxeTimerSelection or similar. Thanks, Nate > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ma, Hua > Sent: Thursday, January 4, 2024 9:39 PM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH v6 31/36] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

On 2024/1/5 下午5:46, Chao Li wrote: This library for PEI phase, and obtains the QemuFwCfg base address by directly parsing the FDT, reads and writes the data in QemuFwCfg by operating on the QemuFwCfg base address. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel

Re: [edk2-devel] [PATCH v6 30/36] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

On 2024/1/5 下午5:46, Chao Li wrote: Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li

Re: [edk2-devel] [PATCH v6 28/36] OvmfPkg/LoongArchVirt: Add the early serial port output library

On 2024/1/5 下午5:45, Chao Li wrote: Add a early serial port output library into LoongArchVirt that named EarlyFdtSerialPortLib16550, this library is referenced from MdeModulePkg. This library is used in the PEI phase. Since the serial port address can not be saved in memory of the LoongArch

Re: [edk2-devel] [PATCH v6 26/36] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull

On 2024/1/5 下午5:45, Chao Li wrote: This Library is used to collect APs resources, but is currently NULL for OvmfPkg, because it is not used by the LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc:

Re: [edk2-devel] [Patch V3 0/2] Change the usage of input parameter ProcessorNumber in MpInitLibGetProcessorInfo() of MpInitLibUp

Thank you so much! Thanks, Dun -Original Message- From: Laszlo Ersek Sent: Wednesday, January 10, 2024 12:35 AM To: devel@edk2.groups.io; Tan, Dun Subject: Re: [edk2-devel] [Patch V3 0/2] Change the usage of input parameter ProcessorNumber in MpInitLibGetProcessorInfo() of

Re: [edk2-devel] Memory Attribute for depex section

++ disc...@edk2.groups.io On 1/8/2024 5:11 PM, Nhi Pham wrote: > Hi Ard, all, > > Could you please help explain how the depex section in an image is > mapped in terms of memory attribute? > > As my observation, dispatcher locates[1] the depex section inside the > module image and write[2] an

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection of timer

Hi, Are there platforms that will use this? What advantages does using the LAPIC as a timer offer? Thanks. Regards, Benjamin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113496): https://edk2.groups.io/g/devel/message/113496 Mute

Re: [edk2-devel] [PATCH V2 1/6] NetworkPkg/HttpDxe: Refactor TlsCreateChild

Reviewed-by: Saloni Kasbekar -Original Message- From: devel@edk2.groups.io On Behalf Of Chang, Abner via groups.io Sent: Sunday, January 7, 2024 5:27 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Clark-williams, Zachary ; Michael Brown ; Nickle Wang ; Igor Kulchytskyy Subject:

Re: [edk2-devel] [PATCH V2 3/6] NetworkPkg/HttpDxe: Add HttpEventTlsConfigured HTTP callback event

Reviewed-by: Saloni Kasbekar -Original Message- From: abner.ch...@amd.com Sent: Sunday, January 7, 2024 5:27 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Clark-williams, Zachary ; Michael Brown ; Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 3/6] NetworkPkg/HttpDxe: Add

Re: [edk2-devel] [RFC PATCH v1 00/20] DynamicTablesPkg: Prepare to add RISC-V support

> From: devel@edk2.groups.io On Behalf Of Sunil V L > via groups.io > Sent: Tuesday, January 9, 2024 9:29 AM > DynamicTablesPkg can be used by RISC-V platforms to generate ACPI tables > from FDT passed from previous stage FW. However, DynamicTablesPkg > currently is ARM specific even though

[edk2-devel] [PATCH v2 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

From: Joseph Hemann -add test for GetEventLog() -test for valid and invalid event log format -test event log header -verify expected event log entry Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h

[edk2-devel] [PATCH v2 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

From: Joseph Hemann Define constants and data structure specified in the TCG EFI Protocol specification. Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 177 1 file changed, 177 insertions(+) diff --git

[edk2-devel] [PATCH v2 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

From: Joseph Hemann Add test verifying the functionality of the SubmitCommand function using the TPM command TPM2_HASH_COMMAND. Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h | 5 +

[edk2-devel] [PATCH v2 2/6] uefi-sct/SctPkg: TCG2 Protocol: add test infrastructure and GetCapability Test

From: Joseph Hemann -implement initial infrastructure for the TCG2 protocol test including updates to .dsc file, inf file, GUID source files, update to Category.ini. -add test case for GetCapability(), as defined in the TCG EFI Protocol Spec 6.4.4. -add checkpoint for NULL pointer passed

[edk2-devel] [PATCH v2 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

From: Joseph Hemann -add tests for HashLogExtendEvent() -tests with valid, invalid, and out of range parameters -do extend of data to PCR 16 Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h

[edk2-devel] [PATCH v2 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

From: Joseph Hemann -add test for GetActivePcrBanks() -checkpoint for NULL pointer passed for buffer -checkpoint for test of function with proper input Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h

[edk2-devel] [PATCH v2 0/6] Tests for TCG2 Protocol

This patch series adds tests for the TCG2 Protocol which is implemented by EDK2. The protocol is defined in chapter 6 in the TCG EFI Protocol Specification: https://trustedcomputinggroup.org/resource/tcg-efi-protocol-specification/ The definition of the test cases is in a specification that has

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

> > Two physical packages are on a multi-chip module and share resources on > the module. The module then plugs into the baseboard/motherboard. > > Is it possible to elaborate on the resource being shared ? In our specific case the problem is related to the PPTT's "Identical Implementation"

Re: [edk2-devel] [PATCH v5 3/3] OvmfPkg/VirtNorFlashDxe: sanity-check variables

On 1/9/24 15:11, Gerd Hoffmann wrote: > Hi, > >> Nit: to my knowledge, the coding style forbids initialization of "auto" >> storage class variables (more commonly put, "non-static local >> variables"). IOW, we should spell the above as: >> >> | diff --git

Re: [edk2-devel] [Patch V3 0/2] Change the usage of input parameter ProcessorNumber in MpInitLibGetProcessorInfo() of MpInitLibUp

On 1/8/24 06:08, duntan wrote: > Please ignore the V2 PATCH set. No other change except adding BaseMemoryLib > headfile and lib instance in .inf to pass build since ZeroMem() is used. > > Comparing to the V1 patch set: > In "set EXTENDED_PROCESSOR_INFORMATION to 0", set >

[edk2-devel] [RFC PATCH v1 20/20] DynamicTablesPkg.ci.yaml: Update exception and ignore list

GICV, GICH and MPIDR are variables defined in GicCInfo structure which probably needs to match AcpiTable.g to be all capital. But this is against EDK2 coding standards and somehow CI gives error now though it exists currently also. Add them to ignore list unless there is a better way. Add EARCH

[edk2-devel] [RFC PATCH v1 19/20] DynamicTablesPkg/AmlLib: Fix typo

For some reason, spell checker in CI finds this typo though it existed earlier. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 2 +-

[edk2-devel] [RFC PATCH v1 18/20] DynamicTablesPkg: X86: Add interfaces to succeed CI tests

CI tests builds DynamicTablesPkg even for X86. Though the current ACPI table list is very ARM specific, it looks like there is a value in building it for x86. So, add dummy interfaces to help CI tests to succeed. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar

[edk2-devel] [RFC PATCH v1 17/20] DynamicTablesPkg: DynamicTableManagerDxe: Refactor to allow other archs

mAcpiVerifyTables is an arch specific structure. So, move the structure and the function which refers this structure to ARM specific file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../DynamicTableManagerDxe.inf|

[edk2-devel] [RFC PATCH v1 15/20] DynamicTablesPkg: AcpiSsdtCpuTopologyLib: Move GICC from common code

GICC is ARM specific structure. Different architectures have different local interrupt controller structures from which CPU topology can be created. Avoid the GICC reference in common code by, - creating a wrapper CreateTopologyFromIntC() instead of CreateTopologyFromGicC() so that different

[edk2-devel] [RFC PATCH v1 16/20] DynamicTablesPkg: AcpiFadtLib: Move ArmBootArch to ARM specific file

ArmBootArch field in FADT is specific to ARM. To leverage most of the code in FADT generator for other architectures, this needs to be moved into ARM specific file. There may be other fields in future (ex: IA_PC_BOOT_ARCH) that need to be created in similar way. So, instead of adding the function

[edk2-devel] [RFC PATCH v1 14/20] DynamicTablesPkg/FdtHwInfoParserLib: Add function for INTC address cells

Parent interrupt controller's address cells is arch specific. So, create a function which can be implemented differently for different archs. Move current implementation to ARM specific file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L

[edk2-devel] [RFC PATCH v1 13/20] DynamicTablesPkg: FdtHwInfoParserLib: Move ARM utilities to separate file

The SPI/PPI ranges are ARM specific and the number of entries in "interrupt-map" property can be different across architectures. Hence, move these utility functions to ARM specific file so that common code is clean and other architectures can easily implement their version. Cc: Ard Biesheuvel

[edk2-devel] [RFC PATCH v1 12/20] DynamicTablesPkg: Add CreatorId in CM_STD_OBJ_CONFIGURATION_MANAGER_INFO

To support multiple CPU architectures and platforms, it is better to have the flexibility for the platforms to define their Creator ID in the ACPI tables. So, add a new field in the structure and use it while creating the ACPI tables instead of default ARM. Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2-devel] [RFC PATCH v1 11/20] DynamicTablesPkg: TableHelperLib: Populate OemTableId using ConfigManager

To support multiple CPU architectures/vendors, it is better to create OemTableId using the platform provided value instead of default ARM. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../Common/TableHelperLib/TableHelper.c | 24

[edk2-devel] [RFC PATCH v1 10/20] DynamicTablesPkg: FdtHwInfoParserLib: Move ArmLib.h to ArmGicCParser.c

ArmLib.h is required only for building GIC in ARM. So, move it to ARM specific file. Otherwise, FdtHwInfoParserInclude.h being a common header across architectures will have issue on other architectures. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by:

[edk2-devel] [RFC PATCH v1 09/20] DynamicTablesPkg: FdtHwInfoParserLib: Make Serial parser arch neutral

SerialPortParser is a generic concept and can be used by other architectures. Hence, rename to reflect it is common and updates the consumers. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../FdtHwInfoParserLib/FdtHwInfoParserLib.inf

[edk2-devel] [RFC PATCH v1 08/20] DynamicTablesPkg: FdtHwInfoParserLib: Pci: Make it common for architectures

PciConfigParser is a generic concept and can be used by other architectures. Hence, rename to reflect it is common and updates the consumers. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../FdtHwInfoParserLib/FdtHwInfoParserLib.inf

[edk2-devel] [RFC PATCH v1 07/20] DynamicTablesPkg: FdtHwInfoParserLib: Separate ARM specific code

HwInfoParserTable is an architecture specific structure. Hence, move it and the MainDispatcher function to ARCH specific file. Update INF file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../FdtHwInfoParserLib/FdtHwInfoParserLib.inf

[edk2-devel] [RFC PATCH v1 06/20] DynamicTablesPkg: Rename EObjNameSpaceArm to EObjNameSpaceArch

To support other architectures, it is better to use an architecture neutral name instead of EObjNameSpaceArm. Rename it as EObjNameSpaceArch and update its consumers. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L ---

[edk2-devel] [RFC PATCH v1 05/20] DynamicTablesPkg: DynamicPlatRepoLib: Rename ArmObjList as ArchObjList

DynamicPlatRepoLib maintains list of CmObjs and named as ArmObjList. However, to support other architectures, it is better to name this in a architecture neutral way. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L ---

[edk2-devel] [RFC PATCH v1 03/20] DynamicTablesPkg: Update ACPI common libraries BASE_NAME

Update the BASE_NAME in the libraries moved out of ARM. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../Acpi/Common/AcpiDbg2Lib/AcpiDbg2Lib.inf | 15 +++ .../Acpi/Common/AcpiFadtLib/AcpiFadtLib.inf | 9

[edk2-devel] [RFC PATCH v1 02/20] DynamicTablesPkg: Move common ACPI libraries from folder

Several ACPI tables are common across architectures. Move below common ACPI table generator libraries which are common for architectures out of Arm folder so that they can be used by other architectures like RISC-V. Common tables are: DBG2, FADT, MCFG, PCCT, PPTT, SPCR, SRAT, SSDT (CPU, PCIe)

[edk2-devel] [RFC PATCH v1 01/20] DynamicTablesPkg: FdtHwInfoParserLib: Move ARM parsers to Arm directory

GIC, GenericTimer and BootArch are ARM specific concepts. Move them to Arm folder and update the references. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../FdtHwInfoParserLib/FdtHwInfoParserLib.inf | 32 +-- .../{ =>

[edk2-devel] [RFC PATCH v1 00/20] DynamicTablesPkg: Prepare to add RISC-V support

DynamicTablesPkg can be used by RISC-V platforms to generate ACPI tables from FDT passed from previous stage FW. However, DynamicTablesPkg currently is ARM specific even though several parsers and ACPI generators can be used across architectures. For ex: SSDT (PCIe), SSDT (CPU), MCFG, SPCR, DBG2,

Re: [edk2-devel] [PATCH v2 4/4] OvmfPkg/RiscVVirt: Override Sstc extension

Reviewed-by: Andrei Warkentin > -Original Message- > From: Sunil V L > Sent: Monday, January 8, 2024 5:37 AM > To: devel@edk2.groups.io > Cc: Sunil V L ; Warkentin, Andrei > ; Ard Biesheuvel ; > Gerd Hoffmann ; Yao, Jiewen ; > Laszlo Ersek > Subject: [PATCH v2 4/4] OvmfPkg/RiscVVirt:

Re: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/CpuTimerDxeRiscV64: Add support for Sstc

Reviewed-by: Andrei Warkentin > -Original Message- > From: Sunil V L > Sent: Monday, January 8, 2024 5:37 AM > To: devel@edk2.groups.io > Cc: Sunil V L ; Gerd Hoffmann > ; Kumar, Rahul R ; Laszlo > Ersek ; Ni, Ray ; Warkentin, Andrei > > Subject: [PATCH v2 3/4]

Re: [edk2-devel] [PATCH v2 2/4] MdePkg/BaseLib: RISC-V: Add function to update stimecmp register

Reviewed-by: Andrei Warkentin > -Original Message- > From: Sunil V L > Sent: Monday, January 8, 2024 5:37 AM > To: devel@edk2.groups.io > Cc: Sunil V L ; Kinney, Michael D > ; Gao, Liming ; > Liu, Zhiguang ; Warkentin, Andrei > > Subject: [PATCH v2 2/4] MdePkg/BaseLib: RISC-V: Add

Re: [edk2-devel] [PATCH v2 1/4] MdePkg.dec: RISC-V: Define override bit for Sstc extension

Reviewed-by: Andrei Warkentin > -Original Message- > From: Sunil V L > Sent: Monday, January 8, 2024 5:37 AM > To: devel@edk2.groups.io > Cc: Sunil V L ; Gao, Liming > ; Kinney, Michael D > ; Liu, Zhiguang ; > Warkentin, Andrei > Subject: [PATCH v2 1/4] MdePkg.dec: RISC-V: Define

Re: [edk2-devel] [PATCH v10 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

For now, this is really something that ought to be hidden by DmaLib abstraction (Map/Unmap). This would allow the driver to be minimally aware of how the IP is integrated into the SoC. A > -Original Message- > From: Sunil V L > Sent: Monday, January 8, 2024 11:32 PM > To: Pedro

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

On 1/9/24 16:47, Jeshua Smith wrote: From: Pierre Gondois Sent: Tuesday, January 9, 2024 1:22 AM On 1/8/24 19:12, Jeshua Smith wrote: The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so the check is being removed.

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

> From: Pierre Gondois > Sent: Tuesday, January 9, 2024 1:22 AM > On 1/8/24 19:12, Jeshua Smith wrote: > > The code was incorrectly assuming that root nodes had to be physical > > package nodes and vice versa. This is not always true, so the check is > > being removed. > > Does it mean that you

[edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

From: "Pethaiyan, Madhan" UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing condition check under GetImageInfo function, if the PackageVersionName is NULL return EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney Cc: Wei6 Xu ---

Re: [edk2-devel] [PATCH 1/1] MdePkg:Updated the comments of EFI_FIRMWARE_MANAGEMENT_PROTOCOL

Hi all, any comments about this patch? -Original Message- From: devel@edk2.groups.io On Behalf Of GuoX Xu Sent: Monday, December 25, 2023 9:21 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Li, Yi1 Subject: [edk2-devel] [PATCH 1/1] MdePkg:Updated the

Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset

Reviewed-by: Amy Chan > -Original Message- > From: Chen, Christine > Sent: Monday, January 8, 2024 8:29 AM > To: S, Ashraf Ali ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Chan, > Amy ; Chaganty, Rangasai V > > Subject: RE: [PATCH] BaseTools: Remove

[edk2-devel] [PATCH] FmpDevicePkg: GetImageInfo Add missing condition

From: "Pethaiyan, Madhan" 23.1 Firmware Management Protocol , Added missing condition check under GetImageInfo function, if the PackageVersionName is NULL return EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney Cc: Wei6 Xu ---

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer.

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Nickle Wang Sent: Tuesday, January 9, 2024 6:13 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer.

Re: [edk2-devel] [PATCH v5 3/3] OvmfPkg/VirtNorFlashDxe: sanity-check variables

Hi, > Nit: to my knowledge, the coding style forbids initialization of "auto" > storage class variables (more commonly put, "non-static local > variables"). IOW, we should spell the above as: > > | diff --git a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c >

Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth?

On 1/9/24 13:28, Michael Brown wrote: > On 09/01/2024 12:13, Laszlo Ersek wrote: >> On 1/9/24 11:45, Ard Biesheuvel wrote: >>> Note that git am does support a 'From: ' header as the first line of >>> the commit log, and will use it correctly to supersede the From: >>> header in the SMTP envelope.

Re: [edk2-devel] [PATCH v5 3/3] OvmfPkg/VirtNorFlashDxe: sanity-check variables

On 1/9/24 12:29, Gerd Hoffmann wrote: > Extend the ValidateFvHeader function, additionally to the header checks > walk over the list of variables and sanity check them. > > In case we find inconsistencies indicating variable store corruption > return EFI_NOT_FOUND so the variable store will be

Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth?

On 09/01/2024 12:13, Laszlo Ersek wrote: On 1/9/24 11:45, Ard Biesheuvel wrote: Note that git am does support a 'From: ' header as the first line of the commit log, and will use it correctly to supersede the From: header in the SMTP envelope. OTOH, that doesn't help in this case, IIUC. When

Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth?

On 1/9/24 11:45, Ard Biesheuvel wrote: > On Tue, 9 Jan 2024 at 10:17, Laszlo Ersek wrote: >> >> On 1/5/24 01:05, Rebecca Cran via groups.io wrote: >>> I noticed recent commits by Jeff Brasen, Jake Garver, Joey Vagades and >>> Michael Roth have funky Author lines, which I think means .mailmap

[edk2-devel] [PATCH v5 1/3] OvmfPkg/RiscVVirt: use gEfiAuthenticatedVariableGuid unconditionally

ArmVirt and OVMF are doing the same. See commit d92eaabefbe0 ("OvmfPkg: simplify VARIABLE_STORE_HEADER generation") for details. Suggested-by: László Érsek Signed-off-by: Gerd Hoffmann Reviewed-by: Sunil V L Reviewed-by: Laszlo Ersek --- OvmfPkg/RiscVVirt/VarStore.fdf.inc | 9 + 1

[edk2-devel] [PATCH v5 0/3] OvmfPkg/VirtNorFlashDxe: sanity-check variables

v5: - pick up review tags - more variable check fine tuning. v4: - turn into a little patch series. - stop using gEfiVariableGuid in risc-v. - stop accepting gEfiVariableGuid in VirtNorFlashDxe. - refine variable checking. Gerd Hoffmann (3): OvmfPkg/RiscVVirt: use

[edk2-devel] [PATCH v5 2/3] OvmfPkg/VirtNorFlashDxe: stop accepting gEfiVariableGuid

Only accept gEfiAuthenticatedVariableGuid when checking the variable store header in ValidateFvHeader(). The edk2 code base has been switched to use the authenticated varstore format unconditionally (even in case secure boot is not used or supported) a few years ago. Suggested-by: László Érsek

[edk2-devel] [PATCH v5 3/3] OvmfPkg/VirtNorFlashDxe: sanity-check variables

Extend the ValidateFvHeader function, additionally to the header checks walk over the list of variables and sanity check them. In case we find inconsistencies indicating variable store corruption return EFI_NOT_FOUND so the variable store will be re-initialized. Signed-off-by: Gerd Hoffmann ---

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDebugLib: add function to print buffer.

Thanks for your review, @Chang, Abner! Version 2 patch is sent for review here: https://edk2.groups.io/g/devel/message/113439 Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Tuesday, January 9, 2024 4:00 PM > To: Nickle Wang ;

[edk2-devel] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer.

Introduce DumpBuffer function to print the buffer content. This helps developer to debug Redfish issue. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RedfishDebugLib.h | 20 -

Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth?

On Tue, 9 Jan 2024 at 10:17, Laszlo Ersek wrote: > > On 1/5/24 01:05, Rebecca Cran via groups.io wrote: > > I noticed recent commits by Jeff Brasen, Jake Garver, Joey Vagades and > > Michael Roth have funky Author lines, which I think means .mailmap needs > > updated? > > > > Author: Jeff Brasen

Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

Hi Liming, Thanks for review this Pull Request: https://github.com/tianocore/edk2/pull/5190. Since All checks have passed. Could you please help to push it? Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent:

Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth?

On 1/5/24 01:05, Rebecca Cran via groups.io wrote: > I noticed recent commits by Jeff Brasen, Jake Garver, Joey Vagades and > Michael Roth have funky Author lines, which I think means .mailmap needs > updated? > > Author: Jeff Brasen via groups.io > Author: Joey Vagedes via groups.io > Author:

Re: [edk2-devel] [PATCH v4 3/3] OvmfPkg/VirtNorFlashDxe: sanity-check variables

On 1/8/24 20:21, Gerd Hoffmann wrote: > Extend the ValidateFvHeader function, additionally to the header checks > walk over the list of variables and sanity check them. > > In case we find inconsistencies indicating variable store corruption > return EFI_NOT_FOUND so the variable store will be

Re: [edk2-devel] [Patch V3 2/2] UefiCpuPkg: Check lower 24 bits of ProcessorNumber

Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Monday, January 8, 2024 1:08 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Rahul R ; Gerd Hoffmann ; > Xu, Min M > Subject: [Patch V3 2/2] UefiCpuPkg: Check lower 24 bits of

Re: [edk2-devel] [Patch V3 1/2] UefiCpuPkg: set EXTENDED_PROCESSOR_INFORMATION to 0

Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Monday, January 8, 2024 1:08 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Rahul R ; Gerd Hoffmann ; > Xu, Min M > Subject: [Patch V3 1/2] UefiCpuPkg: set >

Re: [edk2-devel] [PATCH v4 2/3] OvmfPkg/VirtNorFlashDxe: stop accepting gEfiVariableGuid

On 1/8/24 20:21, Gerd Hoffmann wrote: > Only accept gEfiAuthenticatedVariableGuid when checking the variable > store header in ValidateFvHeader(). > > The edk2 code base has been switched to use the authenticated varstore > format unconditionally (even in case secure boot is not used or >

Re: [edk2-devel] [PATCH v4 1/3] OvmfPkg/RiscVVirt: use gEfiAuthenticatedVariableGuid unconditionally

On 1/8/24 20:21, Gerd Hoffmann wrote: > ArmVirt and OVMF are doing the same. > > See commit d92eaabefbe0 ("OvmfPkg: simplify VARIABLE_STORE_HEADER > generation") for details. > > Suggested-by: László Érsek > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/RiscVVirt/VarStore.fdf.inc | 9 +

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

Hi Liming, Have you tried with the new python tool? Any comments or concerns? Thanks, Christine > -Original Message- > From: Kinney, Michael D > Sent: Saturday, December 16, 2023 1:31 AM > To: Pedro Falcato ; devel@edk2.groups.io; Chen, > Christine > Cc: Gao, Liming ; Rebecca Cran > ;

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

Hello Jeshua, On 1/8/24 19:12, Jeshua Smith wrote: The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so the check is being removed. Does it mean that you have a topology where the top-level node is not a physical

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw strings containing valid escape characters

Liming: PR has been created: BaseTools: Fix raw strings containing valid escape characters by YuweiChen1110 · Pull Request #5238 · tianocore/edk2 (github.com) Thanks for reviewing. Thanks, Christine From: gaoliming Sent: Tuesday, January 9, 2024

Re: [edk2-devel] [PATCH v6 24/36] ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg

On 1/9/24 07:40, Chao Li wrote: > Hi Laszlo, > > > Thanks, > Chao > On 2024/1/8 22:02, Laszlo Ersek wrote: >> On 1/5/24 10:45, Chao Li wrote: >>> Moved the PlatformBootManagerLib to OvmfPkg and renamed to >>> PlatformBootManagerLibLight for easy use by other ARCH. >>> >>> Build-tested only (with