Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Move NestedInterruptTplLib to MdeModulePkg

2024-01-19 Thread Ni, Ray
Michael, Can you submit another patch to add Iret.h to the INF file [Sources] section? Without that, incremental build might not work if changes are made in Iret.h. It doesn't support non-x86 CPU. Will ARM have similar problems? +Ard, Thanks, Ray > -Original Message- > From: Michael Brow

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-19 Thread Ni, Ray
Mike, Tom, How about AsmCpuId() adds ASSERT() to reject those CPUID leaves that do not have sub-leaf? Another concern I have if AsmCpuid() zeros ECX is callers would call AsmCpuid(leaf) instead of AsmCpuidEx (leaf, 0). This would cause the caller code a mess. Thanks, Ray From: Kinney, Michael D

Re: [edk2-devel] [PATCH] MdePkg: fix the types of casting for TD MMIO read

2024-01-19 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5278 > -Original Message- > From: Kinney, Michael D > Sent: Friday, January 19, 2024 6:49 PM > To: devel@edk2.groups.io; Li, Zhiquan1 > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH] MdePkg: fix the types of casting for > TD MM

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions

2024-01-19 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5277 From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Tuesday, January 16, 2024 6:18 AM To: devel@edk2.groups.io; sami.muja...@arm.com; 'PierreGondois' Subject: 回复: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _P

Re: [edk2-devel] [PATCH] MdePkg: fix the types of casting for TD MMIO read

2024-01-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Please include Cc tags in commit message with the maintainers of the patch for review. Otherwise, the maintainers may miss the email patches. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhiquan > Li > Sent: Thursday, Ja

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

2024-01-19 Thread Michael D Kinney
Hi Suqiang, For the Browser/HII related changes to the MdePkg can you also prepare a patch to update the function headers in the implementation of these APIs and make sure the implementation conforms to the update header file changes? Thanks, Mike > -Original Message- > From: Ren, Suq

Re: [edk2-devel] [PATCH] BaseTools: Optimize GenerateByteArrayValue and CollectPlatformGuids APIs

2024-01-19 Thread Michael D Kinney
Hi Ashraf, What is captured in the file? What PCD/VPD changes will invalidate the cache? Just the number and type of PCD/VPD elements or their default values/sizes? How was this tested? Were all conditions that invalidate the cache tested? I ask because incremental build is a very important

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Remove the handle validation check in CoreGetProtocolInterface

2024-01-19 Thread Michael D Kinney
Hi Zhi, Some comments below. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhi Jin > Sent: Tuesday, January 16, 2024 10:45 PM > To: devel@edk2.groups.io > Cc: Jin, Zhi ; Liming Gao ; > Ni, Ray > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg: Remove the handle > v

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Optimize CoreConnectSingleController

2024-01-19 Thread Michael D Kinney
I agree that this implements the similar check as other optional protocols to adjust driver binding order to skip checks for which where are no instances of the optional protocol. Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhi Jin >

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-19 Thread Michael D Kinney
The issue is if AsmCpuid() is called for an Index value that does depend on ECX. That would be a bug on the caller's part and would not have deterministic behavior because ECX on input is not deterministic. That is the condition that would be good to catch. Mike From: Ni, Ray Sent: Friday,

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-19 Thread Michael Brown
On 19/01/2024 23:44, Ni, Ray wrote: I still want to see if the RestoreTpl2 that does not enable interrupt is added as a protocol, and how simple the lib could be. RestoreTpl() always has to enable interrupts during its execution, since interrupts must be allowed to occur while callbacks are ru

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-19 Thread Ni, Ray
Mike, For a certain Cupid leaf that does not have sub leaf, Cupid instruction does not consume ecx and it always fills ecx with a determined value, defined by sdm. So, I don't see any hurt to deterministic behavior if not zeroing ecx in AsmCpuid. thanks, ray From

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-19 Thread Ni, Ray
Michael, I still want to see if the RestoreTpl2 that does not enable interrupt is added as a protocol, and how simple the lib could be. The reason is about maintainability. I can image that one day people would question the Lib implementation if some timer event issue appears. If the Lib is easy

[edk2-devel] [PATCH 1/1] MdeModulePkg: Move NestedInterruptTplLib to MdeModulePkg

2024-01-19 Thread Michael Brown
NestedInterruptTplLib provides a way for timer interrupt handlers (which must support nested interrupts) to prevent unbounded stack consumption. The underlying issue was first observed in OvmfPkg, since interrupt storms can arise more easily in virtual machines due to CPU starvation. However, car

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-19 Thread Michael D Kinney
Hi Ray, It is about having deterministic behavior if a call if made for a CPUID EAX value that does depend on ECX. If ECX is not zeroed, then it will have a random value that may return different information. The problem statement from Tom is not about zeroing ECX. It is about avoiding code bug

Re: [edk2-devel] [PATCH v1 1/1] PrmPkg/PrmInfo: Drop -r parameter

2024-01-19 Thread Ankit Sinha
Reviewed-by: Ankit Sinha > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, January 10, 2024 5:20 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Sinha, Ankit > > Subject: [PATCH v1 1/1] PrmPkg/PrmInfo: Drop -r parameter > > From: Michael Kubacki >

Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned

2024-01-19 Thread Oliver Smith-Denny
On 1/19/2024 8:34 AM, Rebecca Cran wrote: On 1/18/2024 12:26 PM, Oliver Smith-Denny wrote: Does this solve your issue? I have to run to a meeting, but I can write this in actual patch form (and give it a quick test) later. Unfortunately that didn't work: I still get the assert. ... SmbiosCre

Re: [edk2-devel] [PATCH edk2-platforms v2 4/4] Platform/SbsaQemu: move FdtHandlerLib to SbsaQemuHardwareInfoLib

2024-01-19 Thread Leif Lindholm
On Tue, Jan 16, 2024 at 08:48:35 +0100, Marcin Juszkiewicz wrote: > There is no need for EDK2 to know that there is DeviceTree around. > All hardware information is read using functions from > SbsaQemuHardwareInfoLib library. > > Library fallbacks to parsing DT if needed (used with too old TF-A).

Re: [edk2-devel] [PATCH edk2-platforms v2 3/4] Platform/SbsaQemu: use PcdCoreCount directly

2024-01-19 Thread Leif Lindholm
On Tue, Jan 16, 2024 at 08:48:34 +0100, Marcin Juszkiewicz wrote: > During platform initialization we read amount of cpu cores and set > PcdCoreCount so there is no need to call FdtHandler. > > Signed-off-by: Marcin Juszkiewicz > --- > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf

Re: [edk2-devel] [PATCH edk2-platforms v2 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-01-19 Thread Leif Lindholm
On Tue, Jan 16, 2024 at 08:48:32 +0100, Marcin Juszkiewicz wrote: > This library provides functions to check for hardware information. > For now it covers CPU ones: > > - amount of cpu cores > - MPIDR value for cpu core > - NUMA node id for cpu core > > Values are read from TF-A using platform sp

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: update doc a bit

2024-01-19 Thread Leif Lindholm
On Tue, Jan 16, 2024 at 19:05:35 +0100, Marcin Juszkiewicz wrote: > We emulate XHCI controller already. No need to add it. > > Signed-off-by: Marcin Juszkiewicz > --- > Platform/Qemu/SbsaQemu/Readme.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Qemu/Sb

Re: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data

2024-01-19 Thread Leif Lindholm
Hi Ashish, On 2024-01-19 18:09, Ashish Singhal via groups.io wrote: Adding tianocore stewards to see if we can get some traction on this. You've not cc:d Zhichao - who maintains that component - on this patch, I've added them. Please use BaseTools/Scripts/GetMaintainer.py to see who to cc -

Re: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data

2024-01-19 Thread Ashish Singhal via groups.io
Adding tianocore stewards to see if we can get some traction on this. From: Ashish Singhal Sent: Monday, January 1, 2024 10:17 PM To: devel@edk2.groups.io ; gaolim...@byosoft.com.cn ; Jeff Brasen Subject: Re: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Rese

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-19 Thread Michael Brown
On 19/01/2024 13:14, Ni, Ray wrote: So, the interrupt re-entrance we want to avoid is “env:NOTIFY”  -> “env:NOTIFY”, or “env:CALLBACK” -> “env:CALLBACK”, or “env:APPLICATION” -> “env:APPLICATION”. Because it’s endless. NestedTplInterruptLib was written to avoid it. Yes, precisely this. 2.

Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned

2024-01-19 Thread Rebecca Cran via groups.io
On 1/18/2024 12:26 PM, Oliver Smith-Denny wrote: Does this solve your issue? I have to run to a meeting, but I can write this in actual patch form (and give it a quick test) later. Unfortunately that didn't work: I still get the assert. ... SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit t

[edk2-devel] [PATCH v4 0/3] ArmPkg: GenericWatchdogDxe fixes and improvements

2024-01-19 Thread Rebecca Cran via groups.io
Fixes and improvements to GenericWatchdogDxe. PR: https://github.com/tianocore/edk2/pull/5176 Changes between v3 and v4: - Check Interface Identification Register for architecture revision before setting the high offset register value. - Use @par for reference. - Move setting of EBS flag from

[edk2-devel] [PATCH v4 2/3] ArmPkg: Introduce global mTimerPeriod and remove calculation

2024-01-19 Thread Rebecca Cran via groups.io
The calculation of the timer period was broken. Introduce a global mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz is only used in one place, remove the global and make it a local variable. Do the same with mNumTimerTicks. Signed-off-by: Rebecca Cran --- ArmPkg/Drivers/Ge

[edk2-devel] [PATCH v4 1/3] ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset

2024-01-19 Thread Rebecca Cran via groups.io
The generic watchdog offset register is 48 bits wide, and can be set by performing two 32-bit writes. Add support for writing the high 16 bits of the offset register and update the signature of the WatchdogWriteOffsetRegister function to take a UINT64 value. Signed-off-by: Rebecca Cran --- ArmP

[edk2-devel] [PATCH v4 3/3] ArmPkg: Disable watchdog interaction after exiting boot services

2024-01-19 Thread Rebecca Cran via groups.io
Update GenericWatchdogDxe to disable watchdog interaction after exiting boot services. Also, move the mEfiExitBootServicesEvent event to the top of the file with the other static variables. Signed-off-by: Rebecca Cran --- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 17 ++

Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-19 Thread Pethaiyan, Madhan
Hi All, I had corrected the description, added the UEFI spec version and section details . Please check and approve it Thanks, P. Madhan -Original Message- From: Pethaiyan, Madhan Sent: Monday, January 8, 2024 12:13 PM To: devel@edk2.groups.io Cc: Pethaiyan, Madhan ; Gao, Liming ; K

[edk2-devel] [PATCH 00/33] Introduce AMD Vangogh platform reference code

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai This AMD reference platform BIOS supports AMD Vangogh B0 SOC and Chachani board. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang Duke Zhai (33): AMD/AmdPlatformPkg: Check in AMD S3 logo AMD/VanGoghBoard: Check in ACPI table

[edk2-devel] [PATCH 33/33] AMD/VanGoghBoard: Improvement coding style.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Improve coding style for EDk2 patch check rule. Add readme.md for ChachaniBoardPkg introduction. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../AmdPlatformPkg/Universal/LogoDxe/Logo.c | 2 +- .../AgesaPu

[edk2-devel] [PATCH 00/33] Introduce AMD Vangogh platform reference code

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai This AMD reference platform BIOS supports AMD Vangogh B0 SOC and Chachani board. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Duke Zhai (33): AMD/AmdPlatformPkg: Check in AMD S3 logo AMD/VanGoghBoard: Check in ACPI tables AMD/VanGoghBo

[edk2-devel] [PATCH 26/33] AMD/VanGoghBoard: Check in Smbios platform dxe drivers.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial Smbios platform DXE drivers. Static SMBIOS Table for Chachani platform. SmbiosLib provides detailed information of Chachani platform. Signed-off-by: Eric Xing Cc: Ken Yao Cc: Duke Zhai Cc: Igniculus Fu Cc: Abner Chang --- .../PlatformSmbiosDxe/P

[edk2-devel] [PATCH 29/33] AMD/VanGoghBoard: Check in SmramSaveState module.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial SmramSaveState module. This module provides services to access SMRAM Save State Map. Signed-off-by: Ken Yao Cc: Eric Xing Cc: Duke Zhai Cc: Igniculus Fu Cc: Abner Chang --- .../PiSmmCpuDxeSmm/SmramSaveState.c | 715 ++

[edk2-devel] [PATCH 31/33] AMD/VanGoghBoard: Check in AMD SmmControlPei module

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial AMD SmmControlPei module in Silicon folder. This module initializes SMM-related registers, and installs gPeiSmmControlPpi. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../Smm/SmmControlPei/SmmControlPe

[edk2-devel] [PATCH 24/33] AMD/VanGoghBoard: Check in FchSpi module.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial FchSpi module. FCH SPI Common Driver implements the SPI Host Controller Compatibility Interface. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../Universal/FchSpi/FchSpiProtect.c | 67 ++ ...

[edk2-devel] [PATCH 25/33] AMD/VanGoghBoard: Check in PlatformInitPei module.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial PlatformInitPei module. This is the Platform module to initialize whole platform on PEI phase. Signed-off-by: Ken Yao Cc: Eric Xing Cc: Duke Zhai Cc: Igniculus Fu Cc: Abner Chang --- .../Universal/PlatformInitPei/BootMode.c | 287 ++ .

[edk2-devel] [PATCH 21/33] AMD/VanGoghBoard: Check in SignedCapsule.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial SignedCapsule module for Signed Capsule. Produce FMP instance to update system firmware. Signed-off-by: Ken Yao Cc: Eric Xing Cc: Duke Zhai Cc: Igniculus Fu Cc: Abner Chang --- .../BaseTools/Source/Python/GenFds/Capsule.py | 261 +++ .../Syste

[edk2-devel] [PATCH 28/33] AMD/VanGoghBoard: Check in SmmCpuFeaturesLibCommon module.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial SmmCpuFeaturesLibCommon module. The CPU specific programming for PiSmmCpuDxeSmm module when STM support is not included. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../SmmCpuFeaturesLibCommon.c

[edk2-devel] [PATCH 22/33] AMD/VanGoghBoard: Check in Vtf0.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial Vtf0 module. This module includes all assembly code files of reset vector. Signed-off-by: Eric Xing Cc: Ken Yao Cc: Duke Zhai Cc: Igniculus Fu Cc: Abner Chang --- .../ResetVector/Vtf0/CommonMacros.inc | 34 +++ .../ResetVector/Vtf0/Deb

[edk2-devel] [PATCH 23/33] AMD/VanGoghBoard: Check in AcpiPlatform.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial Acpi platform dxe drivers. Use firmware volume protocol to update global NVS area for ASL and SMM init code. Signed-off-by: Eric Xing Cc: Ken Yao Cc: Duke Zhai Cc: Igniculus Fu Cc: Abner Chang --- .../Universal/AcpiPlatformDxe/AcpiPlatform.c |

[edk2-devel] [PATCH 11/33] AMD/VanGoghBoard: Check in FvbServices

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial FvbServices module. It describes platform flash IC information for FlashUpdate module to send command correctly. Different flash ICs may use the different Opcodes. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang

[edk2-devel] [PATCH 17/33] AMD/VanGoghBoard: Check in Smm access module.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial AMD Smm access module. Contains description files for ACPI SMM Platform handler module. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../Smm/AcpiSmm/AcpiSmmPlatform.c | 194 .../Sm

[edk2-devel] [PATCH 19/33] AMD/VanGoghBoard: Check in PcatRealTimeClockRuntimeDxe module.

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 This driver provides GetTime, SetTime, GetWakeupTime, SetWakeupTime services to Runtime Service Table. It will install a tagging protocol with gEfiRealTimeClockArchProtocolGuid. Signed-off-by: Ken Yao Cc: Eric Xing Cc: Duke Zhai Cc: Igniculus Fu Cc: Abner

[edk2-devel] [PATCH 12/33] AMD/VanGoghBoard: Check in AMD BaseSerialPortLib

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial FCH UART port for Serial log output. Chachani board uses this UART for outputting debug log. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../BaseSerialPortLib16550AmdFchUart.c| 473

[edk2-devel] [PATCH 15/33] AMD/VanGoghBoard: Check in SpiFlashDeviceLib

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial AMD SpiFlashDeviceLib for Chachani board flash IC. Chachani board use the W25Q256JW as flash IC. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../SpiFlashDeviceLib/SpiFlashDeviceLib.c | 42 +

[edk2-devel] [PATCH 14/33] AMD/VanGoghBoard: Check in SmbiosLib

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Provides library functions for common SMBIOS operations. Only available to DXE and UEFI module types. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../Include/Library/SmbiosLib.h | 179 ++

[edk2-devel] [PATCH 16/33] AMD/VanGoghBoard: Check in BaseTscTimerLib

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Provides basic TSC timer calibration based on the ACPI timer hardware. The performance counter features are provided by the processors time stamp counter. Signed-off-by: Ken Yao Cc: Eric Xing Cc: Duke Zhai Cc: Igniculus Fu Cc: Abner Chang --- .../Libra

[edk2-devel] [PATCH 13/33] AMD/VanGoghBoard: Check in PlatformFlashAccessLib

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial AMD PlatformFlashAccessLib, It provides flash access protocol for other modules. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../Include/Library/SpiFlashDeviceLib.h | 59 ++ .../VanGoghCommonPk

[edk2-devel] [PATCH 10/33] AMD/VanGoghBoard: Check in FlashUpdate

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Initial FlashUpdate module for Chachani platform flash IC. It provides mEfiSpiFlashUpdateProtocol for other module to access flash. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../FlashUpdate/FlashUpdateCommon

[edk2-devel] [PATCH 07/33] AMD/VanGoghBoard: Check in PciPlatform

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 BIOS detects current IGPU device ID and install corresponding VBIOS. Inital PciPlatform module to load VBIOS and to provide interface for other option ROMs if necessary. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang

[edk2-devel] [PATCH 06/33] AMD/VanGoghBoard: Check in AmdIdsExtLib

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 A small part of Chachani platform code and FSPWrapperPkg needs IdsHookExtLib. Initial AmdIdsHookExtLibNull for ChachaniBoardPkg module. Signed-off-by: Ken Yao Cc: Duke Zhai Cc: Eric Xing Cc: Igniculus Fu Cc: Abner Chang --- .../AmdIdsExtLibNull/AmdIdsHo

[edk2-devel] [PATCH 09/33] AMD/VanGoghBoard: Check in Flash_AB

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Chachani board supports AB recovery function. Initial Flash_AB module to create AB recovery header in BIOS binary. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../ImageSlotHeader/ImageSlotHeader_1.inf | 34

[edk2-devel] [PATCH 05/33] AMD/VanGoghBoard: Check in PlatformSecLib

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Chachani board jump to PlatformSec function after x86 releasing. This module provides the SEC entry function, which does platform-related early initialization. Signed-off-by: Ken Yao Cc: Duke Zhai Cc: Eric Xing Cc: Igniculus Fu Cc: Abner Chang --- .../

[edk2-devel] [PATCH 08/33] AMD/VanGoghBoard: Check in UDKFlashUpdate

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 UDKFlashUpdate is a uefi tool for BIOS binary updating. It depends on EDK2's flash access protocol. UDKFlashUpdate needs to run under EDK2 BIOS. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../UDKFlashUpdate/

[edk2-devel] [PATCH 03/33] AMD/VanGoghBoard: Check in Capsule update

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Chachani board supports "Capsule on Disk (CoD)" feature defined in UEFI Spec chapter 8.5.5 "Delivery of Capsules via file on Mass Storage Device". The BIOS capsule image is saved in hard disk as default setting. Signed-off-by: Ken Yao Cc: Duke Zhai Cc: Eric Xi

[edk2-devel] [PATCH 02/33] AMD/VanGoghBoard: Check in ACPI tables

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 This module creates ACPI trunk tables for Chachani board, e.g.: DSDT table,FADT table. Signed-off-by: Eric Xing Cc: Duke Zhai Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../Acpi/AcpiTables/AcpiTables.inf| 33 + .../Acpi/AcpiTables/Ds

[edk2-devel] [PATCH 04/33] AMD/VanGoghBoard: Check in AgesaPublic pkg

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 Chachani board platform code depends on some AGESA-related PCDs/GUIDs. Add AgesaPublicPkg for AGESA-related PCDs/GUIDs to support platfrom build. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../VanGoghBoard/Ag

[edk2-devel] [PATCH 01/33] AMD/AmdPlatformPkg: Check in AMD S3 logo

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai BZ #:4640 LogoDxe module displays boot logo. S3LogoDxe module is based on EDK2 LogoDxe module and update AMD S3 logo. Signed-off-by: Eric Xing Cc: Duke Zhai Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../AmdPlatformPkg/Universal/LogoDxe/Logo.c | 198 +

[edk2-devel] [PATCH 00/33] Introduce AMD Vangogh platform reference code

2024-01-19 Thread duke.zhai via groups.io
From: Duke Zhai This AMD reference platform BIOS supports AMD Vangogh B0 SOC and Chachani board. Duke Zhai (33): AMD/AmdPlatformPkg: Check in AMD S3 logo AMD/VanGoghBoard: Check in ACPI tables AMD/VanGoghBoard: Check in Capsule update AMD/VanGoghBoard: Check in AgesaPublic pkg

Re: [edk2-devel] Memory Attribute for depex section

2024-01-19 Thread Laszlo Ersek
On 1/19/24 05:43, Nhi Pham wrote: > On 1/18/2024 9:49 PM, Laszlo Ersek wrote: > but I'd prefer to just remove this > optimization from standalone MM, given that not only a) it shouldn't > have to deal with a large number of protocol GUIDs, but also b) the > driver dispatch is much m

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-19 Thread Laszlo Ersek
On 1/19/24 05:56, Nhi Pham wrote: > From: Laszlo Ersek > > The current dependency evaluator violates the memory access permission > when patching depex grammar directly in the read-only depex memory area. > > Laszlo pointed out the optimization issue in the thread (1) "Memory > Attribute for dep

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-19 Thread Laszlo Ersek
On 1/19/24 11:17, Ni, Ray wrote: > Chao, > >   > > In the plan A, CpuDxe.inf contains reference to > gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress in [Pcd] > section. But I guess it’s only needed by LoongArch64. That’s why I > didn’t like the common-inf idea. > >   > > But after lo

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-19 Thread Ni, Ray
Michael, Thanks for the explanation. I tried to expand the code flow in below and help the discussion.. TimerInterruptHandler() gBS->RaiseTPL (HIGH) gBS->RestoreTPL (APPLICATION) // expand in below. For Tpl = {NOTIFY, CALLBACK}: [for-loop] if PendingBit i

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-19 Thread levi.yun
Except, 8bit transfer encoding. Tested-by: levi.yun Reviewed-by: levi.yun On 19/01/2024 10:39, Ard Biesheuvel via groups.io wrote: On Fri, 19 Jan 2024 at 05:58, Nhi Pham via groups.io wrote: From: Laszlo Ersek The current dependency evaluator violates the memory access permission when pat

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/1] Platform/ARM/N1Sdp: Route the Debug Serial Port to IOFPGA UART1

2024-01-19 Thread Himanshu Sharma
Link to V1: [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Modify IRQ ID of Debug UART and routing to IOFPGA UART1 (groups.io) ( https://edk2.groups.io/g/devel/message/98064?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Chimanshu%2C20%2C2%2C0%2C96088965 ) -=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH V4 0/4] Add support to parse NT_FW_CONFIG

2024-01-19 Thread Sami Mujawar
Hi Sahil, On Thu, Jan 4, 2024 at 05:16 AM, sahil wrote: > > v4: > - Fixed code review comments > - Split the patch into four patches Can you add git notes for the patches in the future, please? See https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contr

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-19 Thread Ard Biesheuvel
On Fri, 19 Jan 2024 at 05:58, Nhi Pham via groups.io wrote: > > From: Laszlo Ersek > > The current dependency evaluator violates the memory access permission > when patching depex grammar directly in the read-only depex memory area. > > Laszlo pointed out the optimization issue in the thread (1)

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-19 Thread Ni, Ray
Chao, In the plan A, CpuDxe.inf contains reference to gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress in [Pcd] section. But I guess it’s only needed by LoongArch64. That’s why I didn’t like the common-inf idea. But after looking at the other INF changes, I changed my mind. I think t

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-19 Thread Ni, Ray
Mike, I agree with your words after "However". Zeroing ECX in AsmCpuid() is confusing to future code maintainer: If CPUID instruction does not consume "ECX", why is it needed to zero "ECX"? Thanks, Ray > -Original Message- > From: Kinney, Michael D > Sent: Friday, January 19, 2024 7:11 A

Re: [edk2-devel] [PATCH v3 0/4] Bz4166: Integer Overflow in CreateHob()

2024-01-19 Thread Sami Mujawar
Hi Gua, I don’t think handling the error one level up (i.e. only in the calling function) solves the problem in entirety, can you check please? Example, now the crash can happen in BuildGuidDataHob() see https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Library/PrePiHobLib/Hob.c#L488-L49

[edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: SgiPkg: Add serial debug port mapping.

2024-01-19 Thread levi.yun
The serial debug port must be initialised by the firmware. This is done by SetupDebugUart when DynamicTables Framework is used. However, the address range for the serial debug port must be mapped. Otherwise this results in a page fault when the serial port is accessed. Therefore, update the page

[edk2-devel] [PATCH RESEND edk2-platforms v1 1/3] Platform/Arm: FVP: Add a NorFlashLib instance for StandaloneMm

2024-01-19 Thread levi.yun
The NOR Flash1 is used for UEFI Variable storage. When Standalone MM is enabled the variable storage is managed in the secure world by Standalone MM. Therefore, add a new instance of NorFlashLib for that has the NOR Flash1 definitions for Standalone MM. Also, disable the NOR Flash1 definitions fr

[edk2-devel] [PATCH RESEND edk2-platforms v1 3/3] Platform/Arm: Add Standalone MM support for FVP

2024-01-19 Thread levi.yun
Add Standalone MM support for FVP model. Signed-off-by: levi.yun --- Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc | 208 Platform/ARM/VExpressPkg/PlatformStandaloneMm.fdf | 106 ++ 2 files changed, 314 insertions(+) diff --git a/Platform/ARM/VExpressPkg/Platfor

[edk2-devel] [PATCH RESEND edk2-platforms v1 2/3] Platform/Arm: Enable UEFI Secure Variable support for FVP

2024-01-19 Thread levi.yun
UEFI Secure variable support can be enabled using Standalone MM for FVP RevC model. The following steps enable UEFI variable service using StandaloneMm: 1. Add MmComminucationDxe. - Enables communication with StandaloneMm. The PcdMmBufferBase & PcdBufferSize definitions are used

[edk2-devel] [PATCH RESEND edk2-platforms v1 0/3] Platform/Arm: StandloneMm support for FVP.

2024-01-19 Thread levi.yun
This patch adds StandloneMm feature on FVP RevC & AEMvA. StandaloneMm will be used for UEFI secure Variable support on these models. levi.yun (3): Platform/Arm: FVP: Add a NorFlashLib instance for StandaloneMm Platform/Arm: Enable UEFI Secure Variable support for FVP Platform/Arm: Add Stan

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add EFI_UNSUPPORTED return for some Runtime Service functions

2024-01-19 Thread Ren, Suqiang
Hi All, Any comments about this patch? Thanks Ren, Suqiang -Original Message- From: Ren, SuqiangX Sent: Thursday, January 11, 2024 5:05 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Add EFI

Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-19 Thread Ren, Suqiang
Hi All, Any comments about this patch? Thanks Ren, Suqiang -Original Message- From: Ren, SuqiangX Sent: Thursday, January 11, 2024 5:04 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg: Upda

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: fix wrong parameter issue

2024-01-19 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Friday, January 19, 2024 2:23 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] > RedfishClientPkg/Redf