Re: [OpenSIPS-Devel] [opensips] [1.11] Crash on TCP read (#813)

2016-03-04 Thread Saúl Ibarra Corretgé
Thanks Razvan! On Fri, Mar 4, 2016 at 3:43 PM, Răzvan Crainea wrote: > Closed #813 . > > — > Reply to this email directly or view it on GitHub > . > >

Re: [OpenSIPS-Devel] [opensips] [1.11] Crash on TCP read (#813)

2016-03-04 Thread Saúl Ibarra Corretgé
Yep, good old `malloc` :-) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/813#issuecomment-192299774___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] [1.11] Crash on TCP read (#813)

2016-03-04 Thread Saúl Ibarra Corretgé
There you go: (gdb) bt #0 tcp_read_req (con=con@entry=0xa773e948, bytes_read=bytes_read@entry=0xbfb3b8cc) at tcp_read.c:711 #1 0x080e08a2 in handle_io (fm=0x99015c8, idx=idx@entry=-1, event_type=event_type@entry=1) at tcp_read.c:1036 #2 0x080e271c in io_wait_loop_epoll (repeat=, h=, t=)

Re: [OpenSIPS-Devel] [opensips] [1.11] Crash on TCP read (#813)

2016-03-04 Thread Saúl Ibarra Corretgé
@razvancrainea it crashed here: https://github.com/OpenSIPS/opensips/blob/1.11/tcp_read.c#L711 My guess is that it accesses freed memory, hence the crash. It might work sometimes, but if a hardened system memory allocator is used it will. --- Reply to this email directly or view it on GitHub:

[OpenSIPS-Devel] [opensips] [1.11] Crash on TCP read (#813)

2016-02-29 Thread Saúl Ibarra Corretgé
I found a crashed OpenSIPS process with the following backtrace: (gdb) bt #0 tcp_read_req (con=con@entry=0xa773e948, bytes_read=bytes_read@entry=0xbfb3b8cc) at tcp_read.c:711 #1 0x080e08a2 in handle_io (fm=0x99015c8, idx=idx@entry=-1, event_type=event_type@entry=1) at tcp_read.c:1036 #2

Re: [OpenSIPS-Devel] [opensips] Proposed fix for erratic nat_traversal keepalives (#751)

2016-01-13 Thread Saúl Ibarra Corretgé
Hey @bogdan-iancu, thanks for chiming in :-) > that may simplify your patch a lot - the nat_helper timer routing is > registered with "TIMER_FLAG_DELAY_ON_DELAY" - this guarantees that (even > executed in various processes) the handler will not be run in parallel (all > its executions will be

Re: [OpenSIPS-Devel] [opensips] Proposed fix for erratic nat_traversal keepalives (#751)

2016-01-12 Thread Saúl Ibarra Corretgé
Hi, thanks for the patch! Can you please elaborate / link some documentation on why this is needed? According to the [development guide](http://www.opensips.org/Documentation/Development-Manual#toc23) `register_timer` works on some "global timer process" which doesn't appear to be the case

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

2015-12-22 Thread Saúl Ibarra Corretgé
Tested it, works just fine, thanks @ionutrazvanionita! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166567951___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

2015-12-21 Thread Saúl Ibarra Corretgé
Actually, I was wrong. We are using a bit of custom logic to set the received_uri AVP manually. So it is set. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166305988___ Devel mailing

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

2015-12-21 Thread Saúl Ibarra Corretgé
Nice, thanks! I'll make a new build and test it out. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166312303___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

2015-12-21 Thread Saúl Ibarra Corretgé
Hi @ionutrazvanionita, You're right, I was using nat_traversal, so I guess the same applies. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/729#issuecomment-166280193___ Devel mailing list

Re: [OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

2015-12-18 Thread Saúl Ibarra Corretgé
Hi Razvan! Thanks for the tip! As for the fix, I think OpenSIPS should make sure the data is correct before putting it on the DB, so that REGISTER should have been rejected. Now, data might end up bogus on the DB due to bugs, so ignoring the broken records on startup sounds like a sensible

[OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

2015-12-17 Thread Saúl Ibarra Corretgé
(Tested on OpenSIPS 1.11 as of commit 95f5f79) OpenSIPS accepts a registration with a broken Contact header and saves it in the location table. Example REGISTER: REGISTER sip:sip2sip.info SIP/2.0 Via: SIP/2.0/UDP 127.0.1.1:5060;branch=z9hG4bK-1605-1-0 Max-Forwards: 70 From: "sipp"

[OpenSIPS-Devel] [opensips] xcap: make the 'doc' column a LONGBLOB on MySQL (#634)

2015-09-14 Thread Saúl Ibarra Corretgé
A normal-sized XCAP document with external references easily exceedes the default column size, leading to all sorts of problems. You can view, comment on, or merge this pull request online at: https://github.com/OpenSIPS/opensips/pull/634 -- Commit Summary -- * xcap: make the 'doc' column a

Re: [OpenSIPS-Devel] [opensips] xcap: make the 'doc' column a LONGBLOB on MySQL (#634)

2015-09-14 Thread Saúl Ibarra Corretgé
@OpenSIPS/contributors please review. Once it lands, mind if I backport it to 1.11? --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/634#issuecomment-140046585___ Devel mailing list

Re: [OpenSIPS-Devel] [opensips] xcap: make the 'doc' column a LONGBLOB on MySQL (#634)

2015-09-14 Thread Saúl Ibarra Corretgé
Thanks, Razvan! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/634#issuecomment-140103647___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] Fix setting LIBDIR (#626)

2015-09-11 Thread Saúl Ibarra Corretgé
Guys, can you also merge this into the 1.11 branch? Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/626#issuecomment-139573746___ Devel mailing list Devel@lists.opensips.org

[OpenSIPS-Devel] [opensips] Fix setting LIBDIR (#626)

2015-08-28 Thread Saúl Ibarra Corretgé
Should fix #624 (untested) You can view, comment on, or merge this pull request online at: https://github.com/OpenSIPS/opensips/pull/626 -- Commit Summary -- * build: fix setting HOST_ARCH on Solaris * build: fix setting LIBDIR correctly -- File Changes -- M Makefile.defs (263)

Re: [OpenSIPS-Devel] [opensips] Fix setting LIBDIR (#626)

2015-08-28 Thread Saúl Ibarra Corretgé
@etamme tested it and it works! Gotta go now, so can you merge it @razvancrainea or @bogdan-iancu? Otherwise I will when I get back. Thanks. --- Reply to this email directly or view it on GitHub:

Re: [OpenSIPS-Devel] [opensips] makefile: detect target architecture using the compiler (#603)

2015-08-19 Thread Saúl Ibarra Corretgé
Closed #603. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/603#event-386477257___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] makefile: detect target architecture using the compiler (#605)

2015-08-19 Thread Saúl Ibarra Corretgé
/cc @razvancrainea --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/605#issuecomment-132588268___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [opensips] makefile: detect target architecture using the compiler (#605)

2015-08-19 Thread Saúl Ibarra Corretgé
Fixes producing a 32bit build in a 64bit system. Original patch by Andrei Pelinescu-Onciul: https://github.com/kamailio/kamailio/commit/c46e79709216c4975abc83869fbce9fa696eac74 You can view, comment on, or merge this pull request online at: https://github.com/OpenSIPS/opensips/pull/605 --

[OpenSIPS-Devel] [opensips] makefile: detect target architecture using the compiler (#603)

2015-08-18 Thread Saúl Ibarra Corretgé
Fixes producing a 32bit build in a 64bit system. Original patch by Andrei Pelinescu-Onciul: https://github.com/kamailio/kamailio/commit/c46e79709216c4975abc83869fbce9fa696eac74 You can view, comment on, or merge this pull request online at: https://github.com/OpenSIPS/opensips/pull/603 --

Re: [OpenSIPS-Devel] [opensips] makefile: detect target architecture using the compiler (#603)

2015-08-18 Thread Saúl Ibarra Corretgé
/cc @bogdan-iancu If you're fine with the change let me know to what branches you want me to apply it. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/603#issuecomment-132199170___ Devel mailing list

Re: [OpenSIPS-Devel] New Transport Interface

2015-01-14 Thread Saúl Ibarra Corretgé
this all the way through, but the advantage would be that the kernel does the filtering. It’s not a big deal anyway, just checking if you folks gave the idea any thought. Keep up the good work! -- Saúl Ibarra Corretgé AG Projects signature.asc Description: Message signed with OpenPGP using

Re: [OpenSIPS-Devel] New Transport Interface

2015-01-13 Thread Saúl Ibarra Corretgé
this helps. Cheers, -- Saúl Ibarra Corretgé AG Projects signature.asc Description: Message signed with OpenPGP using GPGMail ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] fix for RFC5245 15.1 compliant candidate injection (#264)

2015-01-06 Thread Saúl Ibarra Corretgé
LGTM :+1: --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/264#issuecomment-68852110___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [OpenSIPS/opensips] 4642e3: Revert Changes to stop keepalives on unregisters

2014-11-27 Thread Saúl Ibarra Corretgé
Branch: refs/heads/1.11 Home: https://github.com/OpenSIPS/opensips Commit: 4642e3232d5fc5bb662c75d81caac23f604885a5 https://github.com/OpenSIPS/opensips/commit/4642e3232d5fc5bb662c75d81caac23f604885a5 Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2014-11-27 (Thu, 27 Nov

[OpenSIPS-Devel] [OpenSIPS/opensips] e41c5e: Revert Changes to stop keepalives on unregisters

2014-11-27 Thread Saúl Ibarra Corretgé
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: e41c5e37a8a82f0400c3bf3e81b4cb442a60e7d8 https://github.com/OpenSIPS/opensips/commit/e41c5e37a8a82f0400c3bf3e81b4cb442a60e7d8 Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2014-11-27 (Thu, 27 Nov

Re: [OpenSIPS-Devel] [opensips] Changes to stop keepalives on unregisters (#366)

2014-11-24 Thread Saúl Ibarra Corretgé
This fix is incorrect and I will revert it. The provided patch solves the problem in 2 cases, but fails to do so in others such as when the Contact header has a *. But most importantly, it breaks when a single user agent registers multiple accounts from the same IP and port. In this case

Re: [OpenSIPS-Devel] [opensips] TLS: remove support for SSLv2 and SSLv3 (#367)

2014-10-23 Thread Saúl Ibarra Corretgé
Since support for the old SSL (both v2 and v3) is completely disabled, should we obsolete the SSLv23 keyword and add a different one, something like TLSany? Lots of software took that from OpenSSL, even if it doesn't necessarily mean SSLv2 or SSLv3 are used. I will add an alias for that

Re: [OpenSIPS-Devel] [opensips] TLS: remove support for SSLv2 and SSLv3 (#367)

2014-10-23 Thread Saúl Ibarra Corretgé
@razvancrainea added TLSAny alias for tls_method config option. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/367#issuecomment-60202463___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] TLS: remove support for SSLv2 and SSLv3 (#367)

2014-10-22 Thread Saúl Ibarra Corretgé
@bogdan-iancu @razvancrainea any comment on this? --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/367#issuecomment-60128079___ Devel mailing list Devel@lists.opensips.org

[OpenSIPS-Devel] [opensips] TLS: disable support for SSLv2 and SSLv3 (#367)

2014-10-21 Thread Saúl Ibarra Corretgé
Time to support crypto built this century only :-) I know POODLE doesn#39;t affect SIP, but who knows what else is broken in SSLv2 / SSLv3 that we don#39;t know about. You can merge this Pull Request by running: git pull https://github.com/saghul/opensips crypto_fixes Or you can view,

Re: [OpenSIPS-Devel] [opensips] opensipsctl compatibility (#322)

2014-09-09 Thread Saúl Ibarra Corretgé
Please stop opening duplicated pull requests. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/322#issuecomment-54958178___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] opensipsctl compatibility (#322)

2014-09-09 Thread Saúl Ibarra Corretgé
Closed #322. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/322#event-163025696___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] store registration problem (#325)

2014-09-09 Thread Saúl Ibarra Corretgé
Closed #325. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/325#event-163026144___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] store registration problem (#323)

2014-09-09 Thread Saúl Ibarra Corretgé
Closed #323. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/323#event-163026056___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] store registration problem (#324)

2014-09-09 Thread Saúl Ibarra Corretgé
Closed #324. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/324#event-163026111___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] store registration problem (#326)

2014-09-09 Thread Saúl Ibarra Corretgé
Closed #326. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/326#event-163026219___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] opensipsctl compatibility (#328)

2014-09-09 Thread Saúl Ibarra Corretgé
Closed #328. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/328#event-163026274___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] opensipsctl compatibility (#330)

2014-09-09 Thread Saúl Ibarra Corretgé
Closed #330. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/330#event-163026347___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] opensipsctl compatibility (#329)

2014-09-09 Thread Saúl Ibarra Corretgé
Closed #329. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/329#event-163026301___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] opensipsctl compatibility (#322)

2014-09-09 Thread Saúl Ibarra Corretgé
You don't need to open the PR multiple times, the commit can be cherry picked. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/322#issuecomment-54960885___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [FYI] OpenSIPS Social networks

2014-09-03 Thread Saúl Ibarra Corretgé
, The Facebook page seems to be a person called “Opensips Server, not an actual page people can “like”. That was common practice before Facebook introduced “Pages”, but not anymore. Regards, -- Saúl Ibarra Corretgé AG Projects signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [OpenSIPS-Devel] [OpenSIPS-Users] Asynchronous processing in OpenSIPS 1.12

2014-09-03 Thread Saúl Ibarra Corretgé
On 03 Sep 2014, at 11:59, Bogdan-Andrei Iancu bog...@opensips.org wrote: On 03.09.2014 12:06, Saúl Ibarra Corretgé wrote: On 02 Sep 2014, at 18:26, Răzvan Crainea raz...@opensips.org wrote: Hi all, Among the last discussion of the last IRC meeting[1] was related to Asynchronous

Re: [OpenSIPS-Devel] [OpenSIPS-Users] Asynchronous processing in OpenSIPS 1.12

2014-09-03 Thread Saúl Ibarra Corretgé
. Of course, we can detect that at script parsing and decide how to handle it: - ignore and do it blocking - warning and do it blocking - error and do not start. I’d say we shouldn’t start :-) Regards, -- Saúl Ibarra Corretgé AG Projects signature.asc Description: Message signed

Re: [OpenSIPS-Devel] [OpenSIPS-Users] OpenSIPS Public Meetings

2014-08-22 Thread Saúl Ibarra Corretgé
, kudos! I’ll try to make it to the meeting. Can I get “Asynchronous TLS” added to the list? :-) Regards, -- Saúl Ibarra Corretgé AG Projects signature.asc Description: Message signed with OpenPGP using GPGMail ___ Devel mailing list Devel

Re: [OpenSIPS-Devel] Supported RFCs

2014-07-23 Thread Saúl Ibarra Corretgé
are supported by OpenSIPS? ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel -- Saúl Ibarra Corretgé AG Projects This email (including any attachments) is proprietary to Aspect

Re: [OpenSIPS-Devel] Supported RFCs

2014-07-18 Thread Saúl Ibarra Corretgé
@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel -- Saúl Ibarra Corretgé AG Projects signature.asc Description: Message signed with OpenPGP using GPGMail ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-07-01 Thread Saúl Ibarra Corretgé
In-dialog requests (re-INVITEs) would also have the CSeq modified if dialog pinging is enabled. We need to get the updated CSeq for both requests and responses, is this handled? --- Reply to this email directly or view it on GitHub:

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-07-01 Thread Saúl Ibarra Corretgé
@bogdan-iancu what we need is a way to fetch the actual cseq for a given request or reply. Regardless of cseq mangling happening or not. Otherwise MediaProxy could get confused because it relies on incrementing cseqs.The code there was written before dialog pinging was a thing, so it may need

Re: [OpenSIPS-Devel] [OpenSIPS-Users] Fwd: RTPproxy project

2014-05-27 Thread Saúl Ibarra Corretgé
features are those? -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] One Way or No Audio/Video Opensips 1.9.1 , Mediaproxy 2.5.2 and iptables 1.4.16.2 (#171)

2014-03-12 Thread Saúl Ibarra Corretgé
Hi @jalung. Thanks for comment. Do you have any links/docs regarding NOTRACK vs CT targets and supported versions? As for why we need it, we first create those NOTRACK entries in the PREROUTING (table raw), then, after the conntrack rule has been created they are removed. --- Reply to this

[OpenSIPS-Devel] GEtting the proper CSeq value from a module

2014-03-12 Thread Saúl Ibarra Corretgé
Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] xcap_client: Fix two mem corruptions. (#176)

2014-03-12 Thread Saúl Ibarra Corretgé
LGTM. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/176#issuecomment-37389015___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] GEtting the proper CSeq value from a module

2014-03-12 Thread Saúl Ibarra Corretgé
parser/parse_cseq.h to extract the actual CSEQ number. Actually, I'm not sure what I'm doing is correct, if the cseq_n from the transaction supposed to be updated already in case dialog ping is enabled? Regards, -- Saúl Ibarra Corretgé AG Projects

Re: [OpenSIPS-Devel] [OpenSIPS/opensips] 618546: update ChangeLog file for 1.9.2

2014-03-12 Thread Saúl Ibarra Corretgé
...8fd8407c5078___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http

Re: [OpenSIPS-Devel] [opensips] Fix examples, some presence settings have moved (#76)

2014-03-11 Thread Saúl Ibarra Corretgé
Ah, sorry about that! Thanks Liviu! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/76#issuecomment-37323061___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] Fix examples, some presence settings have moved (#76)

2014-03-10 Thread Saúl Ibarra Corretgé
I think I did fix the examples, but please do doublecheck :-) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/76#issuecomment-37233880___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] call_control: Passthrough sip_application (#170)

2014-02-20 Thread Saúl Ibarra Corretgé
@@ -228,6 +232,7 @@ struct module_exports exports = { str call_token; char* prepaid_account; int call_limit; +str sip_application; Please move this after call_token. --- Reply to this email directly or view it on GitHub:

Re: [OpenSIPS-Devel] [opensips] call_control: Passthrough sip_application (#170)

2014-02-18 Thread Saúl Ibarra Corretgé
@@ -177,6 +180,7 @@ {call_token_avp, STR_PARAM, (call_token_avp.spec.s)}, {prepaid_account_flag,STR_PARAM, prepaid_account_str}, {prepaid_account_flag,INT_PARAM, prepaid_account_flag}, +{sip_application_avp, STR_PARAM, (sip_application_avp.spec.s)},

Re: [OpenSIPS-Devel] [opensips] call_control: Passthrough sip_application (#170)

2014-02-18 Thread Saúl Ibarra Corretgé
@@ -640,6 +662,7 @@ struct module_exports exports = { prepaid: %s\r\n call_limit: %d\r\n call_token: %.*s\r\n + application: %.*s\r\n sip_application --- Reply to this email directly or view it on

Re: [OpenSIPS-Devel] [opensips] call_control: Passthrough sip_application (#170)

2014-02-18 Thread Saúl Ibarra Corretgé
@@ -406,6 +411,22 @@ struct module_exports exports = { return value.s; } +// Get SIP application type +static str +get_sip_application(struct sip_msg* msg) +{ +int_str value; + +if (!search_first_avp(sip_application_avp.type | AVP_VAL_STR, +

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-02-14 Thread Saúl Ibarra Corretgé
Ah, I see. The fun fact here is that, that field should contain just the number (according to the comments in the code), yet it doesn't. In the initial version of the code I advanced the pointer by CSEQ_LEN, which is defined as the length of CSeq: (note the space after the colon). I think

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-02-13 Thread Saúl Ibarra Corretgé
Hum, something feels wrong here. I did some git archeolgy and looks like I modified that code to look the way it does now in order for it to work with dialog pings: https://github.com/OpenSIPS/opensips/commit/80511207e9acec1bfabed7807a83329a8adebbce When dialog ping is used OpenSIPS needs to

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-02-13 Thread Saúl Ibarra Corretgé
Here is another patch: https://gist.github.com/saghul/8983424 can you please try it out? @vladpaiu, IIRC you wrote the dialog ping logic, does what I did there look good to you? --- Reply to this email directly or view it on GitHub:

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-02-12 Thread Saúl Ibarra Corretgé
@adrien-martin can you please test if it works after applying the following patch? https://gist.github.com/saghul/8952340 --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/165#issuecomment-34851588___

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-02-12 Thread Saúl Ibarra Corretgé
Thanks for confirming, I'll commit the changes later today. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/165#issuecomment-34868870___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-02-10 Thread Saúl Ibarra Corretgé
Hum, I'll look into it, thanks for the test! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/165#issuecomment-34614574___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] CSeq header handling in mediaproxy (#165)

2014-02-07 Thread Saúl Ibarra Corretgé
I just checked and we don't really parse the packet but use the provided functions to extract the value. Does pseudo-variable which extracts the CSeq work for you? --- Reply to this email directly or view it on GitHub:

[OpenSIPS-Devel] [OpenSIPS/opensips] 359db7: mediaproxy: always parse To header

2013-12-20 Thread Saúl Ibarra Corretgé
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 359db7f8713921042d14beffd83b5b07e40536fe https://github.com/OpenSIPS/opensips/commit/359db7f8713921042d14beffd83b5b07e40536fe Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-12-20 (Fri, 20

[OpenSIPS-Devel] [OpenSIPS/opensips] 3b1761: mediaproxy: always parse To header

2013-12-20 Thread Saúl Ibarra Corretgé
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: 3b1761a303f93a0fae7209e0577c8fcdb12bddbe https://github.com/OpenSIPS/opensips/commit/3b1761a303f93a0fae7209e0577c8fcdb12bddbe Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-12-20 (Fri, 20 Dec

[OpenSIPS-Devel] [OpenSIPS/opensips] c3931c: mediaproxy: always parse To header

2013-12-20 Thread Saúl Ibarra Corretgé
Branch: refs/heads/1.9 Home: https://github.com/OpenSIPS/opensips Commit: c3931c5800c61cd31e746f95bd65f11c2fa7625c https://github.com/OpenSIPS/opensips/commit/c3931c5800c61cd31e746f95bd65f11c2fa7625c Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-12-20 (Fri, 20 Dec

Re: [OpenSIPS-Devel] [opensips] Via branch non RFC 3261 compliant (#145)

2013-12-06 Thread Saúl Ibarra Corretgé
I have not tested the code, but looks good to me :-) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/145#issuecomment-30035248___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] Via branch non RFC 3261 compliant (#145)

2013-12-05 Thread Saúl Ibarra Corretgé
FWIW, I think nat_traversal does the same. @ibc shouldn't OverSIP be gentle in what it accepts? ;-) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/145#issuecomment-29925741___ Devel mailing list

Re: [OpenSIPS-Devel] [opensips] Feature request #77 fulfilled (#138)

2013-11-26 Thread Saúl Ibarra Corretgé
@@ -346,6 +420,11 @@ int verify_callback(int pre_verify_ok, X509_STORE_CTX *ctx) { ssl_methods[TLS_USE_SSLv23_cli - 1] = SSLv23_client_method(); ssl_methods[TLS_USE_SSLv23_srv - 1] = SSLv23_server_method(); ssl_methods[TLS_USE_SSLv23 - 1] = SSLv23_method(); + +

[OpenSIPS-Devel] [OpenSIPS/opensips] 9b786a: Fixed residential example when using presence

2013-11-24 Thread Saúl Ibarra Corretgé
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: 9b786aac8c18e908516932a98c19e94202d220ef https://github.com/OpenSIPS/opensips/commit/9b786aac8c18e908516932a98c19e94202d220ef Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-11-24 (Sun, 24 Nov

[OpenSIPS-Devel] [OpenSIPS/opensips] 7d2387: Fixed residential example when using presence

2013-11-24 Thread Saúl Ibarra Corretgé
Branch: refs/heads/1.9 Home: https://github.com/OpenSIPS/opensips Commit: 7d2387013ebaf3cfd1f9ac95f19bccd38e481004 https://github.com/OpenSIPS/opensips/commit/7d2387013ebaf3cfd1f9ac95f19bccd38e481004 Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-11-24 (Sun, 24 Nov

[OpenSIPS-Devel] [OpenSIPS/opensips] a80248: Load xcap module, presence_xml depends on it

2013-11-24 Thread Saúl Ibarra Corretgé
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: a802488848e9f28701ede84cac16b762ad97d9c8 https://github.com/OpenSIPS/opensips/commit/a802488848e9f28701ede84cac16b762ad97d9c8 Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-11-24 (Sun, 24

[OpenSIPS-Devel] [OpenSIPS/opensips] 8d93a2: Load xcap module, presence_xml depends on it

2013-11-24 Thread Saúl Ibarra Corretgé
Branch: refs/heads/1.9 Home: https://github.com/OpenSIPS/opensips Commit: 8d93a219a142269af21e1e7bcb336efd3a0c8251 https://github.com/OpenSIPS/opensips/commit/8d93a219a142269af21e1e7bcb336efd3a0c8251 Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-11-24 (Sun, 24 Nov

[OpenSIPS-Devel] [OpenSIPS/opensips] 669efa: Load xcap module, presence_xml depends on it

2013-11-24 Thread Saúl Ibarra Corretgé
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: 669efafb150caae9ed757051adff65284c14a8be https://github.com/OpenSIPS/opensips/commit/669efafb150caae9ed757051adff65284c14a8be Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-11-24 (Sun, 24 Nov

Re: [OpenSIPS-Devel] [RELEASES] Planing OpenSIPS 1.11.0 major release

2013-11-04 Thread Saúl Ibarra Corretgé
___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman

Re: [OpenSIPS-Devel] eyeBeam NAT ping packets

2013-10-18 Thread Saúl Ibarra Corretgé
and hex content. Comments? That looks like the double CRLF technique used in SIP outbound (http://tools.ietf.org/html/rfc5626#section-3.5.1), so I guess the right thing to do here would be to reply with CRLF. Regards, -- Saúl Ibarra Corretgé AG Projects

Re: [OpenSIPS-Devel] eyeBeam NAT ping packets

2013-10-18 Thread Saúl Ibarra Corretgé
are properly handled by opensips. It's UDP that is having issues. Oh. I guess OpenSIPS should reply with CRLF like if it was TCP. Be gentle in what you accept… :-) Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel

[OpenSIPS-Devel] [OpenSIPS/opensips] 6e3b16: Fixed crash if send_subscribe fails early

2013-08-07 Thread Saúl Ibarra Corretgé
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 6e3b16ec6d3fe59b5a1b415b548394be401e69af https://github.com/OpenSIPS/opensips/commit/6e3b16ec6d3fe59b5a1b415b548394be401e69af Author: Saúl Ibarra Corretgé sag...@gmail.com Date: 2013-08-07 (Wed, 07

Re: [OpenSIPS-Devel] OpenSIPS Tracker Migration on GitHub

2013-06-04 Thread Saúl Ibarra Corretgé
compromise. I think it's a good thing to do, this will probably also help in removing old tickets that have been lingering around for too long ;-) Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http

Re: [OpenSIPS-Devel] [OpenSIPS-Users] OpenSIPS.org web site REFURBISH - FIRST PHASE - Completed

2013-05-14 Thread Saúl Ibarra Corretgé
as headlines at the top of the page and also on the bar to the right. I'd leave only the bar on the right, so the first thing newcomers see on the website is What OpenSIPS is. My 2 cents :-) -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASE] 1.9 Major Release becomes stable GA today!

2013-02-27 Thread Saúl Ibarra Corretgé
, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT

2013-02-19 Thread Saúl Ibarra Corretgé
:-) Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT

2013-02-18 Thread Saúl Ibarra Corretgé
up over time ;-) Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT

2013-02-18 Thread Saúl Ibarra Corretgé
On Feb 18, 2013, at 6:14 PM, Peter Lemenkov wrote: 2013/2/18 Saúl Ibarra Corretgé s...@ag-projects.com: Also I'd like to propose a switch to a new issue tracker at SF.net. Just compare that one we have to use now with the newest one: * http://sourceforge.net/p/sipp/bugs/ * http

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASES] Drafting OpenSIPS 1.10.0 TODO list

2013-02-11 Thread Saúl Ibarra Corretgé
, that is). Right now it doesn't, and if a client sends a broken document then the aggregated PIDF document will also be broken. Those broken docs should not be stored. I can elaborate on any of the points in case there are any doubts :-) Thanks for letting us fill-up your TODO list ;-) -- Saúl Ibarra

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASES] Drafting OpenSIPS 1.10.0 TODO list

2013-02-11 Thread Saúl Ibarra Corretgé
On Feb 11, 2013, at 12:38 PM, Saúl Ibarra Corretgé wrote: Hi Bogdan and team, On Feb 9, 2013, at 7:40 PM, Bogdan-Andrei Iancu wrote: Hi all, According the the release policy (http://www.opensips.org/Development/Development), I would like to call for a brainstorming, ideas

Re: [OpenSIPS-Devel] SF.net SVN: opensips:[9700] trunk/modules/siptrace/siptrace.c

2013-01-29 Thread Saúl Ibarra Corretgé
/mailman/listinfo/devel -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] SF.net SVN: opensips:[9700] trunk/modules/siptrace/siptrace.c

2013-01-29 Thread Saúl Ibarra Corretgé
Awesome, thanks! On Jan 29, 2013, at 7:34 PM, Bogdan-Andrei Iancu wrote: yes, indeed - loosing or having extra garbage :) Regards, Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com On 01/29/2013 07:33 PM, Saúl Ibarra Corretgé wrote: Does this fix

Re: [OpenSIPS-Devel] [RELEASE] OpenSIPS 1.9.0 - a new major release is out

2013-01-29 Thread Saúl Ibarra Corretgé
, I've been running OpenSIPS straight from trunk for a while now without major problems, everyone go test! Cheers, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo

Re: [OpenSIPS-Devel] Improved socket error messages

2013-01-28 Thread Saúl Ibarra Corretgé
is not correct because it doesn't deal with IPv6 addresses, you need to check the sa_family field of the sockaddr struct before casting it to sockaddr_in or sockaddr_in6. Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel

Re: [OpenSIPS-Devel] Improved socket error messages

2013-01-28 Thread Saúl Ibarra Corretgé
. It would be nice to have a generic function/macro which would print the given error string + IP (port) + error description with the given error severity , for example :-) Then we can use it in more places later on. Regards, -- Saúl Ibarra Corretgé AG Projects

Re: [OpenSIPS-Devel] Please stop retagging versions and releasing new tarballs under the same version number.

2013-01-15 Thread Saúl Ibarra Corretgé
:) Here is a proposal: There could be 2 types of files: releases and svn snapshots. Releases look like opensips-1.8.3.tar.gz and svn snapshot like opensips-1.8-svn1234.tar.gz Regards, -- Saúl Ibarra Corretgé AG Projects ___ Devel mailing list Devel

  1   2   >