Re: [PATCH iio] imu: inv_mpu6050: adds device tree bindings

2015-04-27 Thread Varka Bhadram
On 04/24/2015 02:53 PM, Varka Bhadram wrote: Signed-off-by: Varka Bhadram var...@cdac.in --- .../devicetree/bindings/iio/imu/inv_mpu6050.txt| 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt diff

Re: [PATCH v7 0/3] Add ktd2692 Flash LED driver using LED Flash class

2015-04-24 Thread Varka Bhadram
+ 5 files changed, 493 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt create mode 100644 drivers/leds/leds-ktd2692.c Reviewed-by: Varka Bhadram varkabhad...@gmail.com Thanks -- Varka Bhadram -- To unsubscribe from this list: send the line

[PATCH iio] imu: inv_mpu6050: adds device tree bindings

2015-04-24 Thread Varka Bhadram
Signed-off-by: Varka Bhadram var...@cdac.in --- .../devicetree/bindings/iio/imu/inv_mpu6050.txt| 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt diff --git a/Documentation/devicetree/bindings/iio/imu

Re: [PATCH v4 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-03-24 Thread Varka Bhadram
timeout ranges from 0 to 1835000us and + default is 1049000us. + +Example: + +flash-led { + compatible = kinetic,ktd2692; + ctrl-gpio = gpc0 1 0; + aux-gpio = gpc0 2 0; + flash-timeout-us = 1835000; + vin-supply = vbat; +}; -- Varka Bhadram

Re: [PATCH v4 3/3] leds: Add ktd2692 flash LED driver

2015-03-24 Thread Varka Bhadram
= ktd2692_match, + }, + .probe = ktd2692_probe, + .remove = ktd2692_remove, +}; + +module_platform_driver(ktd2692_driver); + +MODULE_AUTHOR(Ingi Kim ingi2@samsung.com); +MODULE_DESCRIPTION(Kinetic KTD2692 LED driver); +MODULE_LICENSE(GPL v2); -- Varka Bhadram -- To unsubscribe from

Re: [PATCH v4] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-20 Thread Varka Bhadram
, mma); + dev_dbg(client-dev, unregistered accelerometer\n); + kfree(mma); same as above.. -- Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Varka Bhadram
) { + dev_err(client-dev, ov2659_get_pdata: DT Node found\n); ov2659_get_pdata: DT Node *not* found...? -- Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 3/3] leds: Add ktd2692 flash LED driver

2015-02-26 Thread Varka Bhadram
, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
() + up-mapbase = res-start; + up-membase = devm_ioremap_resource(pdev-dev, res); + if (IS_ERR(up-membase)) + return PTR_ERR(up-membase); + -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
On Thursday 29 January 2015 08:56 PM, Varka Bhadram wrote: Hi, On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Originally-by: Lanqing Liu lanqing

Re: [PATCH v6 6/8] input: touchscreen: imx25 tcq driver

2015-01-29 Thread Varka Bhadram
mx25_tcq_remove(struct platform_device *pdev) +{ + struct mx25_tcq_priv *priv = platform_get_drvdata(pdev); + + free_irq(priv-irq, priv); This also.. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord

Re: [PATCH v6 5/8] iio: adc: fsl,imx25-gcq driver

2015-01-29 Thread Varka Bhadram
); + free_irq(priv-irq, priv); Dto... -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 3/7] iio: Add support for DA9150 GPADC

2015-01-21 Thread Varka Bhadram
-dev, sizeof(*gpadc)); You can directly use *dev* instead of *pdev-dev* -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v6 5/7] power: Add support for DA9150 Charger

2015-01-21 Thread Varka Bhadram
= devm_kzalloc(dev, sizeof(struct da9150_charger), GFP_KERNEL); + if (charger == NULL) + return -ENOMEM; sizeof(struct da9150_charger) can be replaced with sizeof(*charger)... *!* operator can be used in comparison with NULL... (...) -- Thanks and Regards, Varka Bhadram

Re: [PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Varka Bhadram
-info.html -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver

2015-01-08 Thread Varka Bhadram
, + .remove = tlc59116_remove, + .id_table = tlc59116_id, +}; + +module_i2c_driver(tlc59116_driver); + +MODULE_AUTHOR(Andrew Lunn and...@lunn.ch); +MODULE_LICENSE(GPL); +MODULE_DESCRIPTION(TLC59116 LED driver); -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send

Re: [PATCHv5 3/9] devfreq: event: Add exynos-ppmu devfreq-event driver

2014-12-22 Thread Varka Bhadram
the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message

Re: [PATCH 1/4] i2c: iProc: define Broadcom iProc I2C binding

2014-12-09 Thread Varka Bhadram
of statements. Why cant they be with single line statement, like: compatible: Must be brcm,iproc-i2c reg:Define the base and range of the I/O address space that contain the iProc I2C controller registers -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH 2/4] i2c: iproc: Add Broadcom iProc I2C Driver

2014-12-09 Thread Varka Bhadram
, + }, + .probe = bcm_iproc_i2c_probe, + .remove = bcm_iproc_i2c_remove, +}; +module_platform_driver(bcm_iproc_i2c_driver); + +MODULE_AUTHOR(Ray Jui r...@broadcom.com); +MODULE_DESCRIPTION(Broadcom iProc I2C Driver); +MODULE_LICENSE(GPL v2); -- Thanks and Regards, Varka Bhadram

Re: [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-10-27 Thread Varka Bhadram
sky81452_bl_platform_data *pdata; + int ret; + + if (!np) { + dev_err(dev, backlight node not found); Missed terminating new line all over the driver for debug error messages.. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 4/6] uio: Add X-Gene QMTM UIO driver

2014-10-21 Thread Varka Bhadram
; + + platform_set_drvdata(pdev, qmtm_dev); + return 0; + +out_clk: + clk_disable_unprepare(qmtm_dev-qmtm_clk); + +out_err: + return ret; +} -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 4/6] uio: Add X-Gene QMTM UIO driver

2014-10-21 Thread Varka Bhadram
On 10/21/2014 11:46 AM, Ankit Jindal wrote: On 21 October 2014 11:34, Varka Bhadram varkabhad...@gmail.com wrote: On 10/21/2014 11:26 AM, Ankit Jindal wrote: The Applied Micro X-Gene SOC has on-chip QMTM (Queue manager and Traffic manager) which is hardware based Queue or Ring manager

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Varka Bhadram
); + spin_lock_init(pd-dev_lock); + + pm_genpd_init(pd-base, NULL, false); + + return of_genpd_add_provider_simple(pdev-dev.of_node, pd-base); +} + -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord

Re: [PATCH v6 1/2] mtd: nand: add sunxi NAND flash controller support

2014-10-20 Thread Varka Bhadram
); +MODULE_DESCRIPTION(Allwinner NAND Flash Controller driver); +MODULE_ALIAS(platform:sunxi_nand); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 4/6] drivers: uio: Add X-Gene QMTM UIO driver

2014-09-30 Thread Varka Bhadram
, + }, + .probe = qmtm_probe, + .remove = qmtm_remove, +}; + +module_platform_driver(qmtm_driver); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
it will [1]. Thanks for the clarification. [1]:http://lxr.free-electrons.com/source/lib/devres.c#L117 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
On 09/29/2014 04:43 PM, Anders Berg wrote: On Mon, Sep 29, 2014 at 12:07 PM, Varka Bhadram varkabhad...@gmail.com wrote: On 09/29/2014 03:02 PM, Anders Berg wrote: Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The driver implements 10-bit addressing and SMBus

Re: [PATCH v3 1/2] bcma: register bcma as device tree driver

2014-09-20 Thread Varka Bhadram
); +} + +void __exit bcma_host_soc_unregister_driver(void) +{ + platform_driver_unregister(bcma_host_soc_driver); +} +#endif /* CONFIG_OF */ Why dont you use module_platform_driver(...)...? -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree

Re: [PATCH v3 1/2] bcma: register bcma as device tree driver

2014-09-20 Thread Varka Bhadram
On Saturday 20 September 2014 09:13 PM, Hauke Mehrtens wrote: On 09/20/2014 05:40 PM, Varka Bhadram wrote: On Saturday 20 September 2014 06:32 PM, Hauke Mehrtens wrote: This driver is used by the bcm53xx ARM SoC code. Now it is possible to give the address of the chipcommon core in device

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
name)... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
On 09/02/2014 04:08 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram varkabhad...@gmail.com wrote: + switch (((np == bitclkmaster) 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10

Re: [PATCH v4 1/2] rc: Add DT bindings for hix5hd2

2014-08-31 Thread Varka Bhadram
= 0xf8001000 0x1000; + interrupts = 0 47 4; + clocks = clock HIX5HD2_FIXED_24M; + hisilicon,power-syscon = sysctrl; + linux,rc-map-name = rc-tivo; + }; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v4 3/5] ARM: tegra: Initialize interrupt controller from DT

2014-08-28 Thread Varka Bhadram
[] = { + { .compatible = arm,cortex-a15-gic, }, + { .compatible = arm,cortex-a9-gic, }, + { } +}; + Missed MODULE_DEVICE_TABLE(of, ...)? -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/3] rc: Add DT bindings for hix5hd2

2014-08-28 Thread Varka Bhadram
; + interrupts = 0 47 4; + clocks = clock HIX5HD2_FIXED_24M; + hisilicon,power-syscon = sysctrl; + linux,rc-map-name = rc-tivo; + }; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body

Re: [PATCH 1/3] Document: fsl,spdif: Adjust the document making it read more comfortably.

2014-08-20 Thread Varka Bhadram
On Tuesday 19 August 2014 10:08 AM, Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com Cc: Varka Bhadram varkabhad...@gmail.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 82 +++--- 1 file changed, 41 insertions(+), 41 deletions(-) Looks good

Re: [PATCH 2/3] Document: fsl,esai: Adjust the document making it read more comfortably.

2014-08-20 Thread Varka Bhadram
On Tuesday 19 August 2014 10:08 AM, Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com Cc: Varka Bhadram varkabhad...@gmail.com --- .../devicetree/bindings/sound/fsl,esai.txt | 73 -- 1 file changed, 39 insertions(+), 34 deletions(-) Reviewed

Re: [PATCH 3/3] Document: fsl-sai: Adjust the document making it read more comfortably.

2014-08-20 Thread Varka Bhadram
On Tuesday 19 August 2014 10:08 AM, Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com Cc: Varka Bhadram varkabhad...@gmail.com --- .../devicetree/bindings/sound/fsl-sai.txt | 54 -- 1 file changed, 29 insertions(+), 25 deletions(-) Reviewed

Re: [PATCH] ASoC: fsl-asrc: Convert to use regmap framework's endianness method.

2014-08-18 Thread Varka Bhadram
://lkml.org/lkml/2014/7/15/7 Documentation/devicetree/bindings/sound/fsl,asrc.txt | 10 +++--- sound/soc/fsl/fsl_asrc.c | 6 +- 2 files changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Varka Bhadram varkabhad...@gmail.com -- Regards, Varka Bhadram

Re: [PATCH v3 2/2] DTS: serial: Add bindings documention for the Mediatek UARTs

2014-08-08 Thread Varka Bhadram
/mtk-uart.txt @@ -0,0 +1,19 @@ +* Mediatek Universal Asynchronous Receiver/Transmitter (UART) + Missing Required Properties:? -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-08 Thread Varka Bhadram
() Thanks. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

2014-08-05 Thread Varka Bhadram
and receive data by following their own bit clocks and frame sync clocks separately. . -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

2014-08-05 Thread Varka Bhadram
On 08/05/2014 04:37 PM, Nicolin Chen wrote: Hi Varka, On Tue, Aug 05, 2014 at 04:29:50PM +0530, Varka Bhadram wrote: diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt index 0f4e238..77864f4 100644 --- a/Documentation

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
= mtk8250_pm_ops, + .of_match_table = mtk8250_of_match, + }, + .probe = mtk8250_probe, + .remove = mtk8250_remove, +}; +module_platform_driver(mtk8250_platform_driver); -- Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH v2 1/2] dma: Add Xilinx Central DMA DT Binding Documentation

2014-08-05 Thread Varka Bhadram
properties: - compatible: Should be xlnx,axi-cdma-1.00.a - #dma-cells: Should be 1, see dmas property below - reg : Should contain cdma registers location and length. . -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
On 08/05/2014 05:32 PM, Alan Cox wrote: On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include linux/io.h +#include linux/module.h +#include linux/serial_8250.h +#include linux/of_irq.h +#include linux/of_platform.h +#include

Re: [PATCH v3 1/2] ASoC: Add support for CS35L32 Boosted Amplifier

2014-08-05 Thread Varka Bhadram
On Tuesday 05 August 2014 08:01 PM, Brian Austin wrote: On Mon, 4 Aug 2014, Varka Bhadram wrote: On 08/05/2014 01:41 AM, Brian Austin wrote: +#include linux/module.h +#include linux/moduleparam.h +#include linux/version.h +#include linux/kernel.h +#include linux/init.h +#include linux

Re: [PATCH v3 2/2] Documentation: dt: bindings: sound: Add bindings for CS35L32

2014-08-05 Thread Varka Bhadram
On Tuesday 05 August 2014 07:58 PM, Brian Austin wrote: On Mon, 4 Aug 2014, Varka Bhadram wrote: + 0 = Left/right channels VMON[11:0], IMON[11:0], VPMON[7:0]. + 1 = Left/right channels VMON[11:0], IMON[11:0], STATUS. + 2 = (Default) left/right channels VMON[15:0], IMON [15:0]. + 3 = Left

Re: [PATCH v3 1/2] ASoC: Add support for CS35L32 Boosted Amplifier

2014-08-04 Thread Varka Bhadram
(cs35l32_i2c_driver); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] Documentation: dt: bindings: sound: Add bindings for CS35L32

2014-08-04 Thread Varka Bhadram
, adapting for low-power .. +Example: + +codec: codec@40 { + compatible = cirrus,cs35l32; + reg = 0x40; + reset-gpios = gpio 10 0; + cirrus,boost-manager = 0x03; + cirrus,sdout-datacfg = 0x02; + VA-supply = reg_audio; +}; -- Regards, Varka Bhadram

Re: [PATCH v4 1/6] rtc: sun6i: Add sun6i RTC driver

2014-07-30 Thread Varka Bhadram
in the bindings. Sure. It's just a minor change here and in the example: - interrupts : IRQ lines for the RTC alarm 0 and alarm 1, in that order. Varka, may I keep your Reviewed-by with the changes? Reviewed-by: Varka Bhadram varkabhad...@gmail.com -- Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH v4 1/6] rtc: sun6i: Add sun6i RTC driver

2014-07-28 Thread Varka Bhadram
hardware (a regulator and RTC block GPIO pin latches), while also having separate interrupts for the alarms. The hardware is different enough to make a different driver for it. Signed-off-by: Chen-Yu Tsai w...@csie.org --- Reviewed-by: Varka Bhadram varkabhad...@gmail.com -- Regards, Varka

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
Hi Nicolin, On 07/25/2014 11:24 AM, Nicolin Chen wrote: Hi Varka, Regarding a point you suggested. On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: On 07/25/2014 09:33 AM, Nicolin Chen wrote: (...) + +static const struct platform_device_id fsl_asrc_devtype

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
, np-full_name); + return irq; + } + + ret = devm_request_irq(pdev-dev, irq, fsl_asrc_isr, 0, + asrc_priv-name, asrc_priv); same... Thanks... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree

Re: [PATCH] mtd: add driver for the flash in Lattice machxo2 FPGAs

2014-07-25 Thread Varka Bhadram
); Same again - is it just too much indenting? I don't see anything wrong here same... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
On 07/25/2014 01:27 PM, Nicolin Chen wrote: Hi Varka, Thank you for the comments! On Fri, Jul 25, 2014 at 01:05:05PM +0530, Varka Bhadram wrote: On 07/25/2014 12:49 PM, Nicolin Chen wrote: (...) +static const struct platform_device_id fsl_asrc_devtype[] = { + { + .name

Re: [PATCH v3 1/6] rtc: sun6i: Add sun6i RTC driver

2014-07-25 Thread Varka Bhadram
... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mtd: add driver for the flash in Lattice machxo2 FPGAs

2014-07-24 Thread Varka Bhadram
(struct device *dev, struct machxo2_busops *busops); This patch has coding style problems.. run checkpatch on this patch.. Thanx. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Varka Bhadram
= { + .probe = fsl_asrc_probe, + .driver = { + .name = fsl-asrc, + .of_match_table = fsl_asrc_ids, + .pm = fsl_asrc_pm, + }, +}; +module_platform_driver(fsl_asrc_driver); Thanks... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send

Re: [PATCH v10 3/3] ASoC: fsl: add imx-es8328 machine driver

2014-07-23 Thread Varka Bhadram
()... No need to do manually.. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] irqchip: add keystone irq controller ip driver

2014-07-23 Thread Varka Bhadram
= keystone_irq, + .owner = THIS_MODULE, No need to update it. Its done by module_platform_driver().. + .of_match_table = of_match_ptr(keystone_irq_dt_ids), This driver is always populate through the dts file. So no need to use of_match_ptr -- -Varka Bhadram

Re: [PATCH v2] gpio: keystone: add dsp gpio controller driver

2014-07-23 Thread Varka Bhadram
...? + + return (val bit) 1; +} -- -Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/6] rtc: sun6i: Add sun6i RTC driver

2014-07-23 Thread Varka Bhadram
, + }, +}; + +module_platform_driver(sun6i_rtc_driver); + +MODULE_DESCRIPTION(sun6i RTC driver); +MODULE_AUTHOR(Chen-Yu Tsai w...@csie.org); +MODULE_LICENSE(GPL); -- -Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord

Re: [PATCH v2] irqchip: add keystone irq controller ip driver

2014-07-23 Thread Varka Bhadram
On Wednesday 23 July 2014 11:31 PM, Grygorii Strashko wrote: Hi, On 07/23/2014 06:32 PM, Varka Bhadram wrote: On Wednesday 23 July 2014 08:10 PM, Grygorii Strashko wrote: On Keystone SOCs, DSP cores can send interrupts to ARM host using the IRQ controller IP. It provides 28 IRQ signals

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-07-22 Thread Varka Bhadram
= { + .name = driver_name, + .owner = THIS_MODULE, We can drop the owner field update... It updated automatically by module_platform_driver(). Please run checkpatch.pl on this patch. You may get more warnings and errors. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send

Re: [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

2014-07-22 Thread Varka Bhadram
= request_threaded_irq(gpio_to_irq(dsi-te_gpio), + exynos_dsi_te_irq_handler, NULL, + IRQF_TRIGGER_RISING, TE, dsi); why don't we use devm_request_threaded_irq()..? -- Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

2014-07-22 Thread Varka Bhadram
. So I don't use devm_* APIs. You meant to say that in-case of GPIOs also you are following the same thing ..? Means requesting the GPIOs and Releasing several times ..? -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body

Re: [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

2014-07-22 Thread Varka Bhadram
On 07/22/2014 05:23 PM, YoungJun Cho wrote: Hi Varka, On 07/22/2014 08:14 PM, Varka Bhadram wrote: On 07/22/2014 04:40 PM, YoungJun Cho wrote: Hi Varka, This irq handler should be registered in attach() and unregistered in detach(). The devm_* APIs are released(freed) in remove(), right

Re: [PATCH v4 04/11] pwm: add DT bindings documentation for atmel-hlcdc-pwm driver

2014-07-22 Thread Varka Bhadram
. The third cell encodes the PWM flags (the only supported flag is PWM_POLARITY_INVERTED) -- Regards, Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v4 02/11] mfd: add documentation for atmel-hlcdc DT bindings

2014-07-22 Thread Varka Bhadram
. - clock-names : the name of the 3 clocks requested by the HLCDC device. Should contain periph_clk, sys_clk and slow_clk. - clocks : should contain the 3 clocks requested by the HLCDC device. .. -- Regards, Varka Bhadram -- To unsubscribe from this list: send the line

Re: [PATCH v10 1/8] phy: add a driver for the Berlin SATA PHY

2014-07-18 Thread Varka Bhadram
with module_platform_driver(). see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
); + + return 0; +} + +static struct platform_driver phy_berlin_usb_driver = { + .probe = phy_berlin_usb_probe, + .driver = { + .name = phy-berlin-usb, + .owner = THIS_MODULE, No need to update owner field. -- Regards, Varka Bhadram

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const struct of_device_id phy_berlin_sata_of_match[] = { + { + .compatible = marvell,berlin2-usb-phy

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 03:17 PM, Antoine Ténart wrote: On Wed, Jul 16, 2014 at 03:03:14PM +0530, Varka Bhadram wrote: On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const

Re: [PATCH v1] gpio: keystone: add dsp gpio controller driver

2014-07-16 Thread Varka Bhadram
= { + .probe = keystone_gpio_probe, + .remove = keystone_gpio_remove, + .driver = { + .name = keystone-dsp-gpio, + .owner = THIS_MODULE, We can drop owner field... :-) .It will update by module_platform_driver -- Regards, Varka

Re: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Varka Bhadram
100644 drivers/hwmon/pwm-fan.c This version addressed all of my comments.. Thanks :-) Reviewed-by: Varka Bhadram varkabhad...@gmail.com -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v4 2/2] can: m_can: add Bosch M_CAN controller support

2014-07-15 Thread Varka Bhadram
On 07/15/2014 11:57 AM, Dong Aisheng wrote: On Mon, Jul 14, 2014 at 06:17:17PM +0530, Varka Bhadram wrote: +/* Test Register (TEST) */ +#define TEST_LBCK BIT(4) + +/* CC Control Register(CCCR) */ +#define CCCR_TEST BIT(7) +#define CCCR_MON BIT(5) +#define CCCR_CCE BIT(1

Re: [PATCH v4 2/2] can: m_can: add Bosch M_CAN controller support

2014-07-15 Thread Varka Bhadram
On 07/15/2014 12:40 PM, Marc Kleine-Budde wrote: On 07/15/2014 08:56 AM, Varka Bhadram wrote: On 07/15/2014 11:57 AM, Dong Aisheng wrote: On Mon, Jul 14, 2014 at 06:17:17PM +0530, Varka Bhadram wrote: +/* Test Register (TEST) */ +#define TEST_LBCKBIT(4) + +/* CC Control Register(CCCR

Re: [PATCH v4 2/2] can: m_can: add Bosch M_CAN controller support

2014-07-15 Thread Varka Bhadram
On 07/15/2014 12:44 PM, Dong Aisheng wrote: On Tue, Jul 15, 2014 at 12:45:15PM +0530, Varka Bhadram wrote: On 07/15/2014 12:40 PM, Marc Kleine-Budde wrote: On 07/15/2014 08:56 AM, Varka Bhadram wrote: On 07/15/2014 11:57 AM, Dong Aisheng wrote: On Mon, Jul 14, 2014 at 06:17:17PM +0530, Varka

Re: [RFC v5 1/2] backlight: add new tps611xx backlight driver

2014-07-15 Thread Varka Bhadram
platform_driver tps611xx_backlight_driver = { + .driver = { + .name = TPS611XX_NAME, + .owner = THIS_MODULE, No need to update .owner see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190 -- Regards, Varka Bhadram. -- To unsubscribe from this list

Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Varka Bhadram
. So no need of using 'of_match_ptr' here. + }, +}; + +module_platform_driver(pwm_fan_driver); + +MODULE_AUTHOR(Kamil Debski k.deb...@samsung.com); +MODULE_ALIAS(platform:pwm-fan); +MODULE_DESCRIPTION(PWM FAN driver); +MODULE_LICENSE(GPL); -- Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Varka Bhadram
this... Required properties: - compatible: should be pwm-fan - pwms : The PWM that is used to control the PWM fan -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3 2/2] can: m_can: add Bosch M_CAN controller support

2014-07-14 Thread Varka Bhadram
On 07/14/2014 01:54 PM, Dong Aisheng wrote: On Mon, Jul 14, 2014 at 01:05:55PM +0530, Varka Bhadram wrote: On 07/14/2014 12:51 PM, Dong Aisheng wrote: +dev_dbg(pdev-dev, mram_base %p sidf 0x%x %d xidf 0x%x %d rxf0 0x%x %d rxf1 0x%x %d rxb 0x%x %d txe 0x%x %d txb 0x%x %d\n, +priv

Re: [PATCH v4 2/2] can: m_can: add Bosch M_CAN controller support

2014-07-14 Thread Varka Bhadram
= m_can_plat_probe, + .remove = m_can_plat_remove, +}; + +module_platform_driver(m_can_plat_driver); + +MODULE_AUTHOR(Dong Aisheng b29...@freescale.com); +MODULE_LICENSE(GPL v2); +MODULE_DESCRIPTION(CAN bus driver for Bosch M_CAN controller); -- Regards, Varka Bhadram. -- To unsubscribe from this list

Re: [PATCH v4 2/2] can: m_can: add Bosch M_CAN controller support

2014-07-14 Thread Varka Bhadram
On 07/14/2014 06:31 PM, Marc Kleine-Budde wrote: On 07/14/2014 02:47 PM, Varka Bhadram wrote: On 07/14/2014 05:10 PM, Dong Aisheng wrote: (...) diff --git a/drivers/net/can/m_can/Makefile b/drivers/net/can/m_can/Makefile new file mode 100644 index 000..a6aae67 --- /dev/null +++ b/drivers

Re: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for endianness

2014-07-14 Thread Varka Bhadram
: CPU in BE mode device in LE mode. +dev: dev@40031000 { + compatible = name; + reg = 0x40031000 0x1000; + ... + little-endian; +}; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe devicetree in the body

Re: [PATCH v9 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-07-14 Thread Varka Bhadram
{ + compatible = ethernet-phy-id001c.c915; + reg = 0x3; + }; + + }; + }; + +/* Board-specific peripheral configurations */ +menet { +status = ok; +}; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send

Re: [PATCH v3 1/2] can: m_can: add device tree binding documentation

2014-07-13 Thread Varka Bhadram
On 07/14/2014 08:54 AM, Dong Aisheng wrote: On Fri, Jul 11, 2014 at 04:11:03PM +0530, Varka Bhadram wrote: On 07/11/2014 03:59 PM, Dong Aisheng wrote: add M_CAN device tree binding documentation Cc: Wolfgang Grandegger w...@grandegger.com Cc: Marc Kleine-Budde m...@pengutronix.de Cc: Mark

Re: [PATCH v3 2/2] can: m_can: add Bosch M_CAN controller support

2014-07-11 Thread Varka Bhadram
On 07/11/2014 05:33 PM, Marc Kleine-Budde wrote: On 07/11/2014 01:13 PM, Varka Bhadram wrote: On 07/11/2014 03:59 PM, Dong Aisheng wrote: (...) +/* m_can private data structure */ +struct m_can_priv { +struct can_priv can;/* must be the first member */ +struct napi_struct napi

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-04 Thread Varka Bhadram
txe %d txb %d\n, + priv-mram_base, priv-mram_off, priv-sidf_elems, + priv-xidf_elems, priv-rxf0_elems, priv-rxf1_elems, + priv-rxb_elems, priv-txe_elems, priv-txb_elems); quoted string split across lines... -- Cheers, Varka Bhadram. -- To unsubscribe from

Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

2014-07-01 Thread Varka Bhadram
checkpatch.pl on patches and fix them. Thanks... -- Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-24 Thread Varka Bhadram
On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote: The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. The mode selection can let us think this PHY can be configured to fit other purposes. But there are reasons to

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-24 Thread Varka Bhadram
On 06/24/2014 05:45 PM, Lee Jones wrote: On Tue, 24 Jun 2014, Varka Bhadram wrote: On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote: On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote: The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. The mode selection can let us

Re: [PATCH net-next v6 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio

2014-06-20 Thread Varka Bhadram
Hi Alex, On 06/20/2014 02:02 PM, Alexander Aring wrote: Hi Varka, sorry for my careful reviewing...,, but I had also some patch series which was at v8 or something like that. :-) mhhh.. More careful review produces the best code ... On Fri, Jun 20, 2014 at 11:18:12AM +0530, Varka Bhadram

[PATCH net-next v6 3/3] devicetree: add device tree bindings for cc2520 driver

2014-06-19 Thread Varka Bhadram
DT bindings for cc2520 radio driver Signed-off-by: Varka Bhadram var...@cdac.in --- .../devicetree/bindings/net/ieee802154/cc2520.txt | 29 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ieee802154/cc2520.txt diff --git

[PATCH net-next v6 2/3] ieee802154: cc2520: add driver to kernel build system

2014-06-19 Thread Varka Bhadram
Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/net/ieee802154/Kconfig | 11 +++ drivers/net/ieee802154/Makefile |1 + 2 files changed, 12 insertions(+) diff --git a/drivers/net/ieee802154/Kconfig b/drivers/net/ieee802154/Kconfig index 3e89bea..8b7ae51 100644

[PATCH net-next v6 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio

2014-06-19 Thread Varka Bhadram
. Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/net/ieee802154/cc2520.c | 1045 +++ include/linux/spi/cc2520.h | 26 + 2 files changed, 1071 insertions(+) create mode 100644 drivers/net/ieee802154/cc2520.c create mode 100644 include/linux/spi

[PATCH net-next v6 0/3] Driver for TI CC2520 Radio

2014-06-19 Thread Varka Bhadram
changes for v1: - improvements in the locking mechanism in Tx and SFD ISR - proper checkings for GPIO pins - avoids the memory leak for priv - used devm_* APIs - moved the code from header file to .c file - removed cc2520_unregister() Varka Bhadram

Re: [PATCH v5] hwmon: Driver for TI TMP103 temperature sensor

2014-06-18 Thread Varka Bhadram
On 06/18/2014 11:42 AM, Guenter Roeck wrote: On 06/17/2014 10:46 PM, Varka Bhadram wrote: Hi, On 06/18/2014 11:07 AM, Heiko Schocher wrote: Driver for the TI TMP103. The TI TMP103 is similar to the TMP102. It differs from the TMP102 by having only 8 bit registers. Signed-off-by: Heiko

Re: [PATCH v5] hwmon: Driver for TI TMP103 temperature sensor

2014-06-18 Thread Varka Bhadram
On 06/18/2014 11:46 AM, Heiko Schocher wrote: Hello Varka, Am 18.06.2014 07:46, schrieb Varka Bhadram: Hi, On 06/18/2014 11:07 AM, Heiko Schocher wrote: Driver for the TI TMP103. The TI TMP103 is similar to the TMP102. It differs from the TMP102 by having only 8 bit registers. Signed-off

  1   2   >