[xwiki-devs] Clover TPC evolution

2018-05-14 Thread Vincent Massol
Hi devs, I’ve recomputed the global Clover TPC by excluding all tests from the result and found the following results: * 2012-07-02: 62.21% * 2016-12-20: 65.29% => +3.08% * 2017-11-09: 68.59% => +3.3% * 2018-04-03: 68.34% => -0.25% * 2018-05-11: 68.77% => +0.43% So: * From mid 2012 to end of 2

Re: [xwiki-devs] Activating Wiki on a single host in fleet clears security cache for entire fleet

2018-05-14 Thread Denis Gervalle
Hi Ktc, The unexpected behavior is the event sent by the XWikiServerXwikiDocumentInitializer. Upon starting a new node, there is no reason that the main wiki descriptor gets updated, and therefore no reason for an DocumentUpdatedEvent to be triggered. I hardly suggest trying to understand why

[xwiki-devs] GSoC Goals for Improving Dokuwiki importer

2018-05-14 Thread Neha Gupta
Hey everyone, I’m working on improving dokuwiki importer this GSoC and have designed a proposal defining goals according to the current issues and some proposed ideas, for this summer. I’ll be glad if developers can share their views and let me know if you feel something more can be added to it

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Vincent Massol
> On 14 May 2018, at 15:30, Thomas Mortagne wrote: > > On Mon, May 14, 2018 at 2:57 PM, Vincent Massol wrote: >> >> >>> On 14 May 2018, at 14:13, Eduard Moraru wrote: >>> >>> On Mon, May 14, 2018 at 12:46 PM, Vincent Massol wrote: >>> FYI we dropped the installer because it was a pa

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Thomas Mortagne
On Mon, May 14, 2018 at 2:57 PM, Vincent Massol wrote: > > >> On 14 May 2018, at 14:13, Eduard Moraru wrote: >> >> On Mon, May 14, 2018 at 12:46 PM, Vincent Massol wrote: >> >>> FYI we dropped the installer because it was a pain to maintain and causing >>> too much trouble (FTR izpack allowed to

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Vincent Massol
> On 14 May 2018, at 14:13, Eduard Moraru wrote: > > On Mon, May 14, 2018 at 12:46 PM, Vincent Massol wrote: > >> FYI we dropped the installer because it was a pain to maintain and causing >> too much trouble (FTR izpack allowed to bundled the JRE too). >> >> I’m not sure a this stage we sho

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Eduard Moraru
On Mon, May 14, 2018 at 12:46 PM, Vincent Massol wrote: > FYI we dropped the installer because it was a pain to maintain and causing > too much trouble (FTR izpack allowed to bundled the JRE too). > > I’m not sure a this stage we should go back to that. > FTR, I never suggested adding an install

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy

2018-05-14 Thread Vincent Massol
> On 14 May 2018, at 13:48, Marius Dumitru Florea > wrote: [snip] > >> ** Find new packages introduced that have a TPC < the average computed TPC >> > > What is the average computed TPC currently? It’s about 70%, see for example: http://maven.xwiki.o

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy

2018-05-14 Thread Marius Dumitru Florea
On Mon, May 14, 2018 at 2:41 PM, Vincent Massol wrote: > > > > On 14 May 2018, at 13:30, Marius Dumitru Florea < > mariusdumitru.flo...@xwiki.com> wrote: > > > > On Mon, May 14, 2018 at 2:17 PM, Vincent Massol > wrote: > > > >> > >> > >>> On 14 May 2018, at 12:28, Marius Dumitru Florea < > >> ma

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy

2018-05-14 Thread Vincent Massol
> On 14 May 2018, at 13:30, Marius Dumitru Florea > wrote: > > On Mon, May 14, 2018 at 2:17 PM, Vincent Massol wrote: > >> >> >>> On 14 May 2018, at 12:28, Marius Dumitru Florea < >> mariusdumitru.flo...@xwiki.com> wrote: >>> >>> On Thu, May 10, 2018 at 10:03 PM, Vincent Massol >> wrote:

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy

2018-05-14 Thread Marius Dumitru Florea
On Mon, May 14, 2018 at 2:17 PM, Vincent Massol wrote: > > > > On 14 May 2018, at 12:28, Marius Dumitru Florea < > mariusdumitru.flo...@xwiki.com> wrote: > > > > On Thu, May 10, 2018 at 10:03 PM, Vincent Massol > wrote: > > > >> Hi devs, > >> > >> Our current Test coverage strategy is to fail th

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy

2018-05-14 Thread Vincent Massol
> On 14 May 2018, at 12:28, Marius Dumitru Florea > wrote: > > On Thu, May 10, 2018 at 10:03 PM, Vincent Massol wrote: > >> Hi devs, >> >> Our current Test coverage strategy is to fail the build when new code >> added results in a coverage lower than the threshold for the module, using >> j

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy

2018-05-14 Thread Marius Dumitru Florea
On Thu, May 10, 2018 at 10:03 PM, Vincent Massol wrote: > Hi devs, > > Our current Test coverage strategy is to fail the build when new code > added results in a coverage lower than the threshold for the module, using > jacoco. > > This has 2 limitations causing our global TPC to go down from tim

Re: [xwiki-devs] [Proposal] New extension point: content header

2018-05-14 Thread Ecaterina Moraru (Valica)
Issue fixed in https://jira.xwiki.org/browse/XWIKI-15252 and will be available starting with 10.4-rc-1. Documentation at http://www.xwiki.org/xwiki/bin/view/Documentation/DevGuide/ExtensionPoint/AfterContentHeaderUIX Thanks Stéphane, Caty On Mon, May 14, 2018 at 12:09 PM, Marius Dumitru Florea <

Re: [xwiki-devs] [Proposal] New extension point: content header

2018-05-14 Thread Marius Dumitru Florea
+1 Thanks, Marius On Wed, May 9, 2018 at 5:16 PM, Stéphane Laurière < stephane.lauri...@xwiki.com> wrote: > Hi all, > > I'd like to propose a new UI extension point: content header (or before > content). My current motivation for it relates to the page-relations > application that will display t

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Vincent Massol
FYI we dropped the installer because it was a pain to maintain and causing too much trouble (FTR izpack allowed to bundled the JRE too). I’m not sure a this stage we should go back to that. Here’s an idea: * Merge Try and Download on xwiki.org into a single entry point * Have a wizard in that en

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Eduard Moraru
There seem to be some resources on the topic: https://github.com/libgdx/libgdx/wiki/Bundling-a-JRE https://stackoverflow.com/questions/7071133/how-to-bundle-a-jre-with-launch4j https://codeiseasy.wordpress.com/2012/07/31/including-a-jre-in-a-tycho-build/ ...so it's not such an uncommon practice.

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Thomas Mortagne
On Mon, May 14, 2018 at 10:49 AM, Eduard Moraru wrote: > AFAIR, Eclipse also does this (i.e. bundle their own JRE), we could look > into how they do it. Eclipse JDT comes with its own Java compiler but you are supposed to install Java to run Eclipse itself. > > On a quick check, OpenJDK's JRE is

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Eduard Moraru
Correction to the correction: They are OpenJDK, got confused by the Oracle logo. :) On Mon, May 14, 2018 at 11:51 AM, Eduard Moraru wrote: > Correction, the above are Oracle builds, not OpenJDK :) > > On Mon, May 14, 2018 at 11:49 AM, Eduard Moraru > wrote: > >> AFAIR, Eclipse also does this (i

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Eduard Moraru
Correction, the above are Oracle builds, not OpenJDK :) On Mon, May 14, 2018 at 11:49 AM, Eduard Moraru wrote: > AFAIR, Eclipse also does this (i.e. bundle their own JRE), we could look > into how they do it. > > On a quick check, OpenJDK's JRE is only 38.4 MB ( > http://jdk.java.net/java-se-ri/

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Eduard Moraru
AFAIR, Eclipse also does this (i.e. bundle their own JRE), we could look into how they do it. On a quick check, OpenJDK's JRE is only 38.4 MB ( http://jdk.java.net/java-se-ri/8) ... I find that acceptable. FTR, the JDK is 164 MB. Thanks, Eduard On Mon, May 14, 2018 at 11:40 AM, Thomas Mortagne

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Thomas Mortagne
One issue with embedded Java (OpenJDK I guess) is that it would make the zip quite huge. On Mon, May 14, 2018 at 10:30 AM, Eduard Moraru wrote: > Hi, > > On the palliative side (i.e. not actually fixing, but at least making life > a bit easier), we might consider a naming scheme for the downloada

Re: [xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Eduard Moraru
Hi, On the palliative side (i.e. not actually fixing, but at least making life a bit easier), we might consider a naming scheme for the downloadable that includes that supported java version, e.g. xwiki-10.3-java8.zip (though this might also lead users to thinking that the java 8 runtime is includ

Re: [xwiki-devs] [Brainstorming] What XAR file type for Mail Template pages?

2018-05-14 Thread Eduard Moraru
Hi, On Fri, May 11, 2018 at 7:21 PM, Vincent Massol wrote: > > > > On 11 May 2018, at 14:22, Thomas Mortagne > wrote: > > > > On Fri, May 11, 2018 at 11:00 AM, Vincent Massol > wrote: > >> Hi Edy, > >> > >>> On 8 May 2018, at 12:38, Eduard Moraru wrote: > >>> > >>> Hi, > >>> > >>> IMO, it's j

[xwiki-devs] Fwd: Get started with XWiki

2018-05-14 Thread Vincent Massol
Hi devs, here’s a feedback we received, FYI. Ideas? Thanks -Vincent > Begin forwarded message: > > From: Vincent Massol > Subject: Re: Get started with XWiki > Date: 14 May 2018 at 09:10:06 CEST > To: XXX > Cc: XXX > > Hi Christian, > >> On 12 May 2018, at 14:25, Christian XXX wrote: >> >> I