Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-23 Thread Marius Dumitru Florea
On Wed, Jan 23, 2019 at 3:08 PM Adel Atallah wrote: > On Wed, Jan 23, 2019 at 11:31 AM Marius Dumitru Florea > wrote: > > It's not that simple.. If the reference parameter already has a value > that > > is not a document reference then by showing the document picker that > value > > will be

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-23 Thread Adel Atallah
On Wed, Jan 23, 2019 at 11:31 AM Marius Dumitru Florea wrote: > It's not that simple.. If the reference parameter already has a value that > is not a document reference then by showing the document picker that value > will be parsed / resolved as a document reference and thus displayed as if > a

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-23 Thread Marius Dumitru Florea
On Wed, Jan 23, 2019 at 12:36 PM Vincent Massol wrote: > > > > On 23 Jan 2019, at 11:30, Marius Dumitru Florea < > mariusdumitru.flo...@xwiki.com> wrote: > > > > On Mon, Jan 21, 2019 at 4:10 PM Adel Atallah > wrote: > > > >> To sum up, here is what I can do: > >> > >> On XWiki Commons: > >> *

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-23 Thread Vincent Massol
> On 23 Jan 2019, at 11:30, Marius Dumitru Florea > wrote: > > On Mon, Jan 21, 2019 at 4:10 PM Adel Atallah wrote: > >> To sum up, here is what I can do: >> >> On XWiki Commons: >> * Introduce a PropertyDisplayType annotation that we can use to >> specify with which type the macro

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-23 Thread Marius Dumitru Florea
On Mon, Jan 21, 2019 at 4:10 PM Adel Atallah wrote: > To sum up, here is what I can do: > > On XWiki Commons: > * Introduce a PropertyDisplayType annotation that we can use to > specify with which type the macro parameter should be rendered. > * Add the *display type* in the property descriptor

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-23 Thread Thomas Mortagne
Sounds good. +1 for me I would also add: * Use the PropertyDisplayType annotation, on page macro parameters, with the PageReference type (for the include and display macro). Does not cost anything and won't have any effect yet but it prepare for the future since that's what we'll want to do. On

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-21 Thread Adel Atallah
To sum up, here is what I can do: On XWiki Commons: * Introduce a PropertyDisplayType annotation that we can use to specify with which type the macro parameter should be rendered. * Add the *display type* in the property descriptor (use the existing *property type* as default) On XWiki

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-21 Thread Adel Atallah
On Sat, Jan 19, 2019 at 11:33 AM Vincent Massol wrote: > > Hi Adel, > > > On 18 Jan 2019, at 11:59, Adel Atallah wrote: > > > > On Fri, Jan 18, 2019 at 11:27 AM Vincent Massol wrote: > >> > >> Hi Adel, > >> > >>> On 17 Jan 2019, at 11:05, Adel Atallah wrote: > >>> > >>> Hi devs, > >>> > >>>

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-19 Thread Vincent Massol
Hi Adel, > On 18 Jan 2019, at 11:59, Adel Atallah wrote: > > On Fri, Jan 18, 2019 at 11:27 AM Vincent Massol wrote: >> >> Hi Adel, >> >>> On 17 Jan 2019, at 11:05, Adel Atallah wrote: >>> >>> Hi devs, >>> >>> After discussing with Marius and Thomas, we thought it might be a good >>> idea

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-18 Thread Adel Atallah
On Fri, Jan 18, 2019 at 11:27 AM Vincent Massol wrote: > > Hi Adel, > > > On 17 Jan 2019, at 11:05, Adel Atallah wrote: > > > > Hi devs, > > > > After discussing with Marius and Thomas, we thought it might be a good > > idea to do the following to have a document picker in the include and > >

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-18 Thread Vincent Massol
Hi Adel, > On 17 Jan 2019, at 11:05, Adel Atallah wrote: > > Hi devs, > > After discussing with Marius and Thomas, we thought it might be a good > idea to do the following to have a document picker in the include and > display maros: > * Remove the deprecation of the document parameter (only

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-17 Thread Thomas Mortagne
On Thu, Jan 17, 2019 at 11:05 AM Adel Atallah wrote: > > Hi devs, > > After discussing with Marius and Thomas, we thought it might be a good > idea to do the following to have a document picker in the include and > display maros: > * Remove the deprecation of the document parameter (only for the

[xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-17 Thread Adel Atallah
Hi devs, After discussing with Marius and Thomas, we thought it might be a good idea to do the following to have a document picker in the include and display maros: * Remove the deprecation of the document parameter (only for the include macro). * Introduce a new annotation to macro parameters to