Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread Steven Schveighoffer
On Mon, 12 Mar 2012 01:26:54 -0400, Jose Armando Garcia jsan...@gmail.com wrote: On Wed, Mar 7, 2012 at 6:39 AM, Steven Schveighoffer schvei...@yahoo.com wrote: On Wed, 07 Mar 2012 07:09:17 -0500, Steven Schveighoffer schvei...@yahoo.com wrote: What is wrong with import std.log;

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread Steven Schveighoffer
On Mon, 12 Mar 2012 01:05:33 -0400, Jose Armando Garcia jsan...@gmail.com wrote: On Sun, Mar 11, 2012 at 3:28 PM, Andrei Alexandrescu seewebsiteforem...@erdani.org wrote: I thought more about the point made about mixing throwing and logging levels. I agree that it's awkward to e.g. log to

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread Geoffrey Biggs
On Mar 12, 2012, at 7:28 AM, Andrei Alexandrescu wrote: On 3/11/12 4:49 PM, David Nadlinger wrote: Unfortunately, the discussion has ground to a halt again, so consider this a friendly reminder that there is still one day left until the end of the review period. David I thought more

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread Jose Armando Garcia
On Mon, Mar 12, 2012 at 1:11 PM, Robert Jacques sandf...@jhu.edu wrote: On Mon, 12 Mar 2012 00:15:14 -0500, Jose Armando Garcia jsan...@gmail.com wrote: On Wed, Mar 7, 2012 at 7:16 AM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 21:22:21 -0600, Andrei Alexandrescu

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread David Nadlinger
On Monday, 12 March 2012 at 05:05:43 UTC, Jose Armando Garcia wrote: I think there is currently too much disagreement on std.log. I am honestly too busy juggling family, friends, school and work. I am currently leaning towards removing std.log from the review queue and spending some time

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread Andrei Alexandrescu
On 3/12/12 5:35 PM, David Nadlinger wrote: On Monday, 12 March 2012 at 05:05:43 UTC, Jose Armando Garcia wrote: I think there is currently too much disagreement on std.log. I am honestly too busy juggling family, friends, school and work. I am currently leaning towards removing std.log from the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread Jose Armando Garcia
On Mon, Mar 12, 2012 at 4:01 PM, Andrei Alexandrescu seewebsiteforem...@erdani.org wrote: On 3/12/12 5:35 PM, David Nadlinger wrote: On Monday, 12 March 2012 at 05:05:43 UTC, Jose Armando Garcia wrote: I think there is currently too much disagreement on std.log. I am honestly too busy

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread James Miller
On 13 March 2012 12:34, Jose Armando Garcia jsan...@gmail.com wrote: On Mon, Mar 12, 2012 at 4:01 PM, Andrei Alexandrescu I think that's a wise decision, thanks Jose and David. One possibility is that Jose transfers the code to someone else who takes it through the review process and makes

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-12 Thread Jose Armando Garcia
On Mon, Mar 12, 2012 at 4:44 PM, James Miller ja...@aatch.net wrote: On 13 March 2012 12:34, Jose Armando Garcia jsan...@gmail.com wrote: On Mon, Mar 12, 2012 at 4:01 PM, Andrei Alexandrescu I think that's a wise decision, thanks Jose and David. One possibility is that Jose transfers the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread David Nadlinger
Unfortunately, the discussion has ground to a halt again, so consider this a friendly reminder that there is still one day left until the end of the review period. David

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread David Nadlinger
On Sunday, 11 March 2012 at 22:09:54 UTC, Robert Jacques wrote: Has Jose updated anything? Not sure what you mean – the latest state of the code is at https://github.com/D-Programming-Language/phobos/pull/432. I was more referring to the design-level discussions anyway, though. David

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread Andrei Alexandrescu
On 3/11/12 4:49 PM, David Nadlinger wrote: Unfortunately, the discussion has ground to a halt again, so consider this a friendly reminder that there is still one day left until the end of the review period. David I thought more about the point made about mixing throwing and logging levels. I

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread H. S. Teoh
On Sun, Mar 11, 2012 at 05:28:44PM -0500, Andrei Alexandrescu wrote: [...] I thought more about the point made about mixing throwing and logging levels. I agree that it's awkward to e.g. log to critical without throwing etc. I personally think in that case you really want the error log, but

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread Robert Jacques
On Sun, 11 Mar 2012 17:14:37 -0500, David Nadlinger s...@klickverbot.at wrote: On Sunday, 11 March 2012 at 22:09:54 UTC, Robert Jacques wrote: Has Jose updated anything? Not sure what you mean – the latest state of the code is at https://github.com/D-Programming-Language/phobos/pull/432. I

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread Jose Armando Garcia
On Sun, Mar 11, 2012 at 3:28 PM, Andrei Alexandrescu seewebsiteforem...@erdani.org wrote: On 3/11/12 4:49 PM, David Nadlinger wrote: Unfortunately, the discussion has ground to a halt again, so consider this a friendly reminder that there is still one day left until the end of the review

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread Jose Armando Garcia
On Wed, Mar 7, 2012 at 7:16 AM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 21:22:21 -0600, Andrei Alexandrescu seewebsiteforem...@erdani.org wrote: On 3/6/12 6:05 PM, Geoffrey Biggs wrote: That approach means that if I actually do have a fatal error, I can't mark it as such.

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread Jose Armando Garcia
On Wed, Mar 7, 2012 at 4:21 AM, Steven Schveighoffer schvei...@yahoo.com wrote: On Tue, 06 Mar 2012 19:59:09 -0500, Andrei Alexandrescu seewebsiteforem...@erdani.org wrote: On 3/6/12 4:31 PM, Geoffrey Biggs wrote: On 07/03/12 09:25, Jonathan M Davis wrote: On Tuesday, March 06, 2012

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread Jose Armando Garcia
On Wed, Mar 7, 2012 at 4:31 AM, Steven Schveighoffer schvei...@yahoo.com wrote: On Tue, 06 Mar 2012 22:54:39 -0500, James Miller ja...@aatch.net wrote: Surprisingly, I agree with the idea that fatal and critical shouldn't throw, or at least shouldn't throw by default, maybe a configuration

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread Jose Armando Garcia
On Wed, Mar 7, 2012 at 6:39 AM, Steven Schveighoffer schvei...@yahoo.com wrote: On Wed, 07 Mar 2012 07:09:17 -0500, Steven Schveighoffer schvei...@yahoo.com wrote: On Tue, 06 Mar 2012 14:39:28 -0500, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 12:25 AM, Jonathan M

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-11 Thread Sean Kelly
On Mar 11, 2012, at 10:26 PM, Jose Armando Garcia jsan...@gmail.com wrote: On Wed, Mar 7, 2012 at 6:39 AM, Steven Schveighoffer schvei...@yahoo.com wrote: alternatively: log_info(cool); linfo(cool); lginfo(cool); There are so many choices besides just info. We should use something

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Tue, 06 Mar 2012 14:32:37 -0500, Jose Armando Garcia jsan...@gmail.com wrote: On Mon, Mar 5, 2012 at 5:30 PM, Steven Schveighoffer schvei...@yahoo.com wrote: Except 'info', 'error', 'warning' are all common names, likely to be a very attractive name for something that has nothing to do

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Tue, 06 Mar 2012 14:39:28 -0500, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 12:25 AM, Jonathan M Davis jmdavisp...@gmx.com wrote: On Tuesday, March 06, 2012 09:14:16 so wrote: On Tuesday, 6 March 2012 at 07:46:14 UTC, Jacob Carlborg wrote: On 2012-03-06 02:32,

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Tue, 06 Mar 2012 19:59:09 -0500, Andrei Alexandrescu seewebsiteforem...@erdani.org wrote: On 3/6/12 4:31 PM, Geoffrey Biggs wrote: On 07/03/12 09:25, Jonathan M Davis wrote: On Tuesday, March 06, 2012 13:08:42 Brad Roberts wrote: On Tue, 6 Mar 2012, Jose Armando Garcia wrote: Fix now:

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Tue, 06 Mar 2012 23:10:58 -0500, Andrei Alexandrescu seewebsiteforem...@erdani.org wrote: On 3/6/12 7:43 PM, Jonathan M Davis wrote: Because the level that you log something at and what you want to do in terms of exceptions aren't necessarily related at all. It could easily be that you

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Tue, 06 Mar 2012 22:54:39 -0500, James Miller ja...@aatch.net wrote: Surprisingly, I agree with the idea that fatal and critical shouldn't throw, or at least shouldn't throw by default, maybe a configuration option would allow for that functionality. Logging probably shouldn't affect program

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Wed, 07 Mar 2012 02:33:05 -0500, Dmitry Olshansky dmitry.o...@gmail.com wrote: Exception is a graceful shutdown, as it calls destructors finally blocks while unrolling the stack. You're assuming the program uses finally/scope exit blocks to do shutdown logic. This is not always the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Tue, 06 Mar 2012 14:27:17 -0500, Jose Armando Garcia jsan...@gmail.com wrote: On Mon, Mar 5, 2012 at 5:32 PM, Jonathan M Davis jmdavisp...@gmx.com wrote: On Tuesday, March 06, 2012 02:22:05 so wrote: That is not a counter-argument to something related to this library but everything that

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Wed, 07 Mar 2012 07:09:17 -0500, Steven Schveighoffer schvei...@yahoo.com wrote: On Tue, 06 Mar 2012 14:39:28 -0500, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 12:25 AM, Jonathan M Davis jmdavisp...@gmx.com wrote: On Tuesday, March 06, 2012 09:14:16 so wrote:

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Steven Schveighoffer
On Tue, 06 Mar 2012 14:19:27 -0500, Jose Armando Garcia jsan...@gmail.com wrote: On Mon, Mar 5, 2012 at 1:55 PM, Steven Schveighoffer schvei...@yahoo.com wrote: On Mon, 13 Feb 2012 10:50:04 -0500, David Nadlinger s...@klickverbot.at wrote: There are several modules in the review queue right

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Robert Jacques
On Tue, 06 Mar 2012 21:22:21 -0600, Andrei Alexandrescu seewebsiteforem...@erdani.org wrote: On 3/6/12 6:05 PM, Geoffrey Biggs wrote: That approach means that if I actually do have a fatal error, I can't mark it as such. Use log.fatal for those. Andrei But fatal Logs a fatal severity

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread David Gileadi
On 3/6/12 5:39 PM, H. S. Teoh wrote: I don't like the current state of dlang.org docs either. There is little or no intro paragraph to explain what on earth the module is used for or why you should bother reading the rest of the page for the next hour or so. It also doesn't give any motivating

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Dmitry Olshansky
On 07.03.2012 16:34, Steven Schveighoffer wrote: On Wed, 07 Mar 2012 02:33:05 -0500, Dmitry Olshansky dmitry.o...@gmail.com wrote: Exception is a graceful shutdown, as it calls destructors finally blocks while unrolling the stack. You're assuming the program uses finally/scope exit blocks

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread kennytm
Richard van Scheijen dl...@mesadu.net wrote: When logging the severity level should convey a certain insight that the developer has about the code. This can be done with a 3 bit field. These are: known-cause, known-effect and breaks-flow. This creates the following matrix: KC KE BF

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread David Nadlinger
On Monday, 13 February 2012 at 15:50:05 UTC, David Nadlinger wrote: Barring any objections, the review period starts now and ends in three weeks, on March 6th, followed by a week of voting. Okay, everyone, by the original schedule, the review period would have ended yesterday. However, I

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-07 Thread Jose Armando Garcia
On Wed, Mar 7, 2012 at 1:53 PM, David Nadlinger s...@klickverbot.at wrote: On Monday, 13 February 2012 at 15:50:05 UTC, David Nadlinger wrote: Barring any objections, the review period starts now and ends in three weeks, on March 6th, followed by a week of voting. Okay, everyone, by the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread so
On Tuesday, 6 March 2012 at 07:46:14 UTC, Jacob Carlborg wrote: On 2012-03-06 02:32, Jonathan M Davis wrote: The user can then alias log!info to info if he/she wants to. Again, you are now forcing 2 common names instead of one as it is now. When you instantiate log!info where do you get

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jacob Carlborg
On 2012-03-06 08:54, Jonathan M Davis wrote: On Tuesday, March 06, 2012 08:46:14 Jacob Carlborg wrote: On 2012-03-06 02:32, Jonathan M Davis wrote: On Tuesday, March 06, 2012 02:22:05 so wrote: That is not a counter-argument to something related to this library but everything that lies in

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread so
On Tuesday, 6 March 2012 at 03:11:11 UTC, Robert Jacques wrote: Please don't forget that you are _submitting_ a library into Phobos and the D ecosystem at large. Yes, new code can be expected to avoid these names, but all existing code has to be retrofitted and fixed. Probably it is the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jonathan M Davis
On Tuesday, March 06, 2012 09:14:16 so wrote: On Tuesday, 6 March 2012 at 07:46:14 UTC, Jacob Carlborg wrote: On 2012-03-06 02:32, Jonathan M Davis wrote: The user can then alias log!info to info if he/she wants to. Again, you are now forcing 2 common names instead of one as it is now.

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Mon, Feb 27, 2012 at 10:10 AM, Kalle Svensson ka...@ieee.org wrote: Since I'm D n00b I'll just post a couple of observations: * I agree that it is a good idea just to use few log levels. * I think is it is a misstake not to let formatting of the whole log message be pluggable (i.e. not

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Wed, Feb 29, 2012 at 4:13 PM, Richard van Scheijen dl...@mesadu.net wrote: When logging the severity level should convey a certain insight that the developer has about the code. This can be done with a 3 bit field. These are: known-cause, known-effect and breaks-flow. This creates the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Thu, Mar 1, 2012 at 6:38 AM, H. S. Teoh hst...@quickfur.ath.cx wrote: On Thu, Mar 01, 2012 at 10:09:28AM +0100, Mikael Lindsten wrote: On Monday, 27 February 2012 at 18:10:15 UTC, Kalle Svensson wrote: * I agree that it is a good idea just to use few log levels. [...] I second what Kalle

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Thu, Mar 1, 2012 at 4:59 PM, Sean Kelly s...@invisibleduck.org wrote: On Feb 29, 2012, at 4:13 PM, Richard van Scheijen wrote: When logging the severity level should convey a certain insight that the developer has about the code. This can be done with a 3 bit field. These are:

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Robert Jacques
On Tue, 06 Mar 2012 11:01:19 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Wed, Feb 29, 2012 at 4:13 PM, Richard van Scheijen dl...@mesadu.net wrote: When logging the severity level should convey a certain insight that the developer has about the code. This can be done with a 3 bit

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Thu, Mar 1, 2012 at 6:24 PM, Robert Jacques sandf...@jhu.edu wrote: On Wed, 29 Feb 2012 18:13:30 -0600, Richard van Scheijen dl...@mesadu.net wrote: When logging the severity level should convey a certain insight that the developer has about the code. This can be done with a 3 bit field.

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 9:32 AM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 11:01:19 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Wed, Feb 29, 2012 at 4:13 PM, Richard van Scheijen dl...@mesadu.net wrote: When logging the severity level should convey a certain

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Robert Jacques
On Tue, 06 Mar 2012 11:44:13 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 9:32 AM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 11:01:19 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Wed, Feb 29, 2012 at 4:13 PM, Richard van Scheijen

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Robert Jacques
On Tue, 06 Mar 2012 11:34:21 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Thu, Mar 1, 2012 at 6:24 PM, Robert Jacques sandf...@jhu.edu wrote: On Wed, 29 Feb 2012 18:13:30 -0600, Richard van Scheijen dl...@mesadu.net wrote: When logging the severity level should convey a certain

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Fri, Mar 2, 2012 at 12:56 AM, Brad Roberts bra...@puremagic.com wrote: On 2/13/2012 7:50 AM, David Nadlinger wrote: There are several modules in the review queue right now, and to get things going, I have volunteered to manage the review of Jose's std.log proposal. Barring any objections,

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Mon, Mar 5, 2012 at 1:55 PM, Steven Schveighoffer schvei...@yahoo.com wrote: On Mon, 13 Feb 2012 10:50:04 -0500, David Nadlinger s...@klickverbot.at wrote: There are several modules in the review queue right now, and to get things going, I have volunteered to manage the review of Jose's

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Mon, Mar 5, 2012 at 3:51 PM, Steven Schveighoffer schvei...@yahoo.com wrote: On Mon, 05 Mar 2012 18:30:03 -0500, David Nadlinger s...@klickverbot.at wrote: On Monday, 5 March 2012 at 21:55:08 UTC, Steven Schveighoffer wrote: The log aliases use names that are too common.  I think log.info

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Mon, Mar 5, 2012 at 5:32 PM, Jonathan M Davis jmdavisp...@gmx.com wrote: On Tuesday, March 06, 2012 02:22:05 so wrote: That is not a counter-argument to something related to this library but everything that lies in global namespace. At its first state both severity levels and the log was in

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Mon, Mar 5, 2012 at 5:30 PM, Steven Schveighoffer schvei...@yahoo.com wrote: On Mon, 05 Mar 2012 20:22:05 -0500, so s...@so.so wrote: On Monday, 5 March 2012 at 23:51:29 UTC, Steven Schveighoffer wrote: On Mon, 05 Mar 2012 18:30:03 -0500, David Nadlinger s...@klickverbot.at wrote: On

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Mon, Mar 5, 2012 at 7:11 PM, Robert Jacques sandf...@jhu.edu wrote: On Mon, 05 Mar 2012 19:22:05 -0600, so s...@so.so wrote: On Monday, 5 March 2012 at 23:51:29 UTC, Steven Schveighoffer wrote: On Mon, 05 Mar 2012 18:30:03 -0500, David Nadlinger s...@klickverbot.at wrote: On Monday, 5

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 12:25 AM, Jonathan M Davis jmdavisp...@gmx.com wrote: On Tuesday, March 06, 2012 09:14:16 so wrote: On Tuesday, 6 March 2012 at 07:46:14 UTC, Jacob Carlborg wrote: On 2012-03-06 02:32, Jonathan M Davis wrote: The user can then alias log!info to info if he/she wants

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 10:11 AM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 11:44:13 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 9:32 AM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 11:01:19 -0600, Jose Armando Garcia

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrei Alexandrescu
On 3/6/12 11:39 AM, Jose Armando Garcia wrote: Seriously everyone. What are we spending some much effort on this? What is wrong with: import log = std.log; log.info(cool); Indeed I think that should be fine. Thanks, Andrei

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrei Alexandrescu
On 3/6/12 11:36 AM, Jose Armando Garcia wrote: import someSymboleThatDoesntCollide = std.log; I think this works better: static import log = std.log; Andrei

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread H. S. Teoh
On Tue, Mar 06, 2012 at 11:45:47AM -0800, Andrei Alexandrescu wrote: On 3/6/12 11:39 AM, Jose Armando Garcia wrote: Seriously everyone. What are we spending some much effort on this? What is wrong with: import log = std.log; log.info(cool); Indeed I think that should be fine. [...] +1.

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Mon, Feb 13, 2012 at 7:50 AM, David Nadlinger s...@klickverbot.at wrote: There are several modules in the review queue right now, and to get things going, I have volunteered to manage the review of Jose's std.log proposal. Barring any objections, the review period starts now and ends in

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread David Nadlinger
On Tuesday, 6 March 2012 at 19:47:50 UTC, Andrei Alexandrescu wrote: On 3/6/12 11:36 AM, Jose Armando Garcia wrote: import someSymboleThatDoesntCollide = std.log; I think this works better: static import log = std.log; Isn't this just another case of DMD silently accepting superfluous

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Sean Kelly
On Mar 6, 2012, at 11:59 AM, Jose Armando Garcia wrote: Future: 1. Allowing filtering of regular log messages (like info, warning, etc) based on the module. Similar to how vlog works. 2. Add support for custom line formatters 3. Talk about adding config.setSeverity(...) which is a union

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Sean Kelly
On Mar 6, 2012, at 11:39 AM, Jose Armando Garcia wrote: Seriously everyone. What are we spending some much effort on this? What is wrong with: import log = std.log; log.info(cool); Why should the default be unqualified names? Is this simply a desire to not change std.log so we can just

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Brad Roberts
On Tue, 6 Mar 2012, Jose Armando Garcia wrote: Future: 1. Allowing filtering of regular log messages (like info, warning, etc) based on the module. Similar to how vlog works. Once you add module filtering to the regularly log messages, what's the point of having the separate vlog? I think

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 12:43 PM, Sean Kelly s...@invisibleduck.org wrote: On Mar 6, 2012, at 11:39 AM, Jose Armando Garcia wrote: Seriously everyone. What are we spending some much effort on this? What is wrong with: import log = std.log; log.info(cool); Why should the default be

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 1:08 PM, Brad Roberts bra...@puremagic.com wrote: On Tue, 6 Mar 2012, Jose Armando Garcia wrote: Future: 1. Allowing filtering of regular log messages (like info, warning, etc) based on the module. Similar to how vlog works. Once you add module filtering to the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Robert Jacques
On Tue, 06 Mar 2012 13:41:32 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 10:11 AM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 11:44:13 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 9:32 AM, Robert Jacques

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Robert Jacques
On Tue, 06 Mar 2012 13:32:37 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Mon, Mar 5, 2012 at 5:30 PM, Steven Schveighoffer schvei...@yahoo.com wrote: On Mon, 05 Mar 2012 20:22:05 -0500, so s...@so.so wrote: On Monday, 5 March 2012 at 23:51:29 UTC, Steven Schveighoffer wrote:

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 1:08 PM, Brad Roberts bra...@puremagic.com wrote: On Tue, 6 Mar 2012, Jose Armando Garcia wrote: Future: 1. Allowing filtering of regular log messages (like info, warning, etc) based on the module. Similar to how vlog works. Once you add module filtering to the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrej Mitrovic
I still don't understand how to set the filename of the log file. Has this been added yet?

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 2:44 PM, Andrej Mitrovic andrej.mitrov...@gmail.com wrote: I still don't understand how to set the filename of the log file. Has this been added yet? http://jsancio.github.com/phobos/phobos/std_log.html#fileNamePrefixes

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 2:03 PM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 13:41:32 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 10:11 AM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 11:44:13 -0600, Jose Armando Garcia

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrej Mitrovic
On 3/7/12, Jose Armando Garcia jsan...@gmail.com wrote: http://jsancio.github.com/phobos/phobos/std_log.html#fileNamePrefixes That was what I was looking for but I didn't find it at first. I think that info about what the defaults are ([program].[hostname].[user].[severity].log.[datetime].[pid])

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Mon, Mar 5, 2012 at 3:26 PM, David Nadlinger c...@klickverbot.at wrote: Just a quick reply, more tomorrow: On 6 Mar 2012, at 0:03, Jose Armando Garcia wrote: What is your objection here? I don't remember reading your thoughts on critical. Darn, my longer review post apparently didn't

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 3:27 PM, Andrej Mitrovic andrej.mitrov...@gmail.com wrote: On 3/7/12, Jose Armando Garcia jsan...@gmail.com wrote: http://jsancio.github.com/phobos/phobos/std_log.html#fileNamePrefixes That was what I was looking for but I didn't find it at first. I think that info

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jonathan M Davis
On Tuesday, March 06, 2012 13:08:42 Brad Roberts wrote: On Tue, 6 Mar 2012, Jose Armando Garcia wrote: Future: 1. Allowing filtering of regular log messages (like info, warning, etc) based on the module. Similar to how vlog works. Once you add module filtering to the regularly log

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Geoffrey Biggs
On 07/03/12 09:25, Jonathan M Davis wrote: On Tuesday, March 06, 2012 13:08:42 Brad Roberts wrote: On Tue, 6 Mar 2012, Jose Armando Garcia wrote: Fix now: 1. Add thread name attribute to the default logger 2. Check that the example compile 3. Come up with a better name for Rich and rich

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread H. S. Teoh
On Tue, Mar 06, 2012 at 03:52:56PM -0800, Jose Armando Garcia wrote: On Tue, Mar 6, 2012 at 3:27 PM, Andrej Mitrovic andrej.mitrov...@gmail.com wrote: On 3/7/12, Jose Armando Garcia jsan...@gmail.com wrote: http://jsancio.github.com/phobos/phobos/std_log.html#fileNamePrefixes That was

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread H. S. Teoh
On Tue, Mar 06, 2012 at 07:25:23PM -0500, Jonathan M Davis wrote: On Tuesday, March 06, 2012 13:08:42 Brad Roberts wrote: [...] I still believe pretty strongly that the logger must not affect application flow, ie, not throw or exit the app. From the feed back, I am not alone in thinking

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrei Alexandrescu
On 3/6/12 4:31 PM, Geoffrey Biggs wrote: On 07/03/12 09:25, Jonathan M Davis wrote: On Tuesday, March 06, 2012 13:08:42 Brad Roberts wrote: On Tue, 6 Mar 2012, Jose Armando Garcia wrote: Fix now: 1. Add thread name attribute to the default logger 2. Check that the example compile 3. Come up

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jonathan M Davis
On Tuesday, March 06, 2012 16:59:09 Andrei Alexandrescu wrote: I don't see why the agitation around this particular matter. It's a matter of convenience, much like writeln (as opposed to just write). Let's admit that it often happens that you want to log some troublesome stuff just before

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 6:05 PM, Geoffrey Biggs geoffrey.bi...@aist.go.jp wrote: On 07/03/12 09:59, Andrei Alexandrescu wrote: I don't see why the agitation around this particular matter. It's a matter of convenience, much like writeln (as opposed to just write). Let's admit that it often

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jose Armando Garcia
On Tue, Mar 6, 2012 at 5:07 PM, Jonathan M Davis jmdavisp...@gmx.com wrote: On Tuesday, March 06, 2012 16:59:09 Andrei Alexandrescu wrote: I don't see why the agitation around this particular matter. It's a matter of convenience, much like writeln (as opposed to just write). Let's admit that

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Geoffrey Biggs
On 07/03/12 11:12, Jose Armando Garcia wrote: On Tue, Mar 6, 2012 at 6:05 PM, Geoffrey Biggs geoffrey.bi...@aist.go.jp wrote: That approach means that if I actually do have a fatal error, I can't mark it as such. It gets conflated with the non-fatal errors, both in the source and in the

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Robert Jacques
On Tue, 06 Mar 2012 17:20:29 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 2:03 PM, Robert Jacques sandf...@jhu.edu wrote: On Tue, 06 Mar 2012 13:41:32 -0600, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 10:11 AM, Robert Jacques

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jonathan M Davis
On Tuesday, March 06, 2012 18:19:23 Jose Armando Garcia wrote: Fatal and Critical are exactly these continence functions... To reiterate. fatal will always assert and critical will always throw. It is impossible for the user to disable these things. No, because they affect the log level. The

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Sean Kelly
Sorry. For some reason I thought info was callable directly without the leading log portion. On Mar 6, 2012, at 1:37 PM, Jose Armando Garcia jsan...@gmail.com wrote: On Tue, Mar 6, 2012 at 12:43 PM, Sean Kelly s...@invisibleduck.org wrote: On Mar 6, 2012, at 11:39 AM, Jose Armando Garcia

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jonathan M Davis
On Tuesday, March 06, 2012 19:10:14 Sean Kelly wrote: Sorry. For some reason I thought info was callable directly without the leading log portion. It _is_ callable that way. Just look at the example at the top: http://jsancio.github.com/phobos/phobos/std_log.html - Jonathan M Davis

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrei Alexandrescu
On 3/6/12 5:07 PM, Jonathan M Davis wrote: As it stands, std.log is conflating two separate concepts - logging and and error handling. Throwing an exception is not error handling. If it were, so many entities would do so, the whole concept would become devoid of meaning. Andrei

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrei Alexandrescu
On 3/6/12 6:05 PM, Geoffrey Biggs wrote: That approach means that if I actually do have a fatal error, I can't mark it as such. Use log.fatal for those. Andrei

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrei Alexandrescu
On 3/6/12 7:04 PM, Jonathan M Davis wrote: On Tuesday, March 06, 2012 18:19:23 Jose Armando Garcia wrote: Fatal and Critical are exactly these continence functions... To reiterate. fatal will always assert and critical will always throw. It is impossible for the user to disable these things.

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jonathan M Davis
On Tuesday, March 06, 2012 19:27:35 Andrei Alexandrescu wrote: On 3/6/12 7:04 PM, Jonathan M Davis wrote: On Tuesday, March 06, 2012 18:19:23 Jose Armando Garcia wrote: Fatal and Critical are exactly these continence functions... To reiterate. fatal will always assert and critical will

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread James Miller
On 7 March 2012 16:43, Jonathan M Davis jmdavisp...@gmx.com wrote: On Tuesday, March 06, 2012 19:27:35 Andrei Alexandrescu wrote: On 3/6/12 7:04 PM, Jonathan M Davis wrote: On Tuesday, March 06, 2012 18:19:23 Jose Armando Garcia wrote: Fatal and Critical are exactly these continence

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Andrei Alexandrescu
On 3/6/12 7:43 PM, Jonathan M Davis wrote: Because the level that you log something at and what you want to do in terms of exceptions aren't necessarily related at all. It could easily be that you want to log something and then do some series of operations before throwing - even if the log level

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Jonathan M Davis
On Tuesday, March 06, 2012 20:10:58 Andrei Alexandrescu wrote: On 3/6/12 7:43 PM, Jonathan M Davis wrote: Because the level that you log something at and what you want to do in terms of exceptions aren't necessarily related at all. It could easily be that you want to log something and then

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-06 Thread Dmitry Olshansky
On 07.03.2012 7:54, James Miller wrote: On 7 March 2012 16:43, Jonathan M Davisjmdavisp...@gmx.com wrote: On Tuesday, March 06, 2012 19:27:35 Andrei Alexandrescu wrote: On 3/6/12 7:04 PM, Jonathan M Davis wrote: On Tuesday, March 06, 2012 18:19:23 Jose Armando Garcia wrote: Fatal and

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-05 Thread Steven Schveighoffer
On Mon, 13 Feb 2012 10:50:04 -0500, David Nadlinger s...@klickverbot.at wrote: There are several modules in the review queue right now, and to get things going, I have volunteered to manage the review of Jose's std.log proposal. Barring any objections, the review period starts now and ends

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-05 Thread David Nadlinger
On Monday, 5 March 2012 at 21:55:08 UTC, Steven Schveighoffer wrote: The log aliases use names that are too common. I think log.info is a better symbol for logging than just 'info', which could be a symbol in a myriad of places. Given that D's symbol lookup rules allow shadowing of global

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-05 Thread Steven Schveighoffer
On Mon, 05 Mar 2012 18:30:03 -0500, David Nadlinger s...@klickverbot.at wrote: On Monday, 5 March 2012 at 21:55:08 UTC, Steven Schveighoffer wrote: The log aliases use names that are too common. I think log.info is a better symbol for logging than just 'info', which could be a symbol in

Re: Review of Jose Armando Garcia Sancio's std.log

2012-03-05 Thread so
On Monday, 5 March 2012 at 23:51:29 UTC, Steven Schveighoffer wrote: On Mon, 05 Mar 2012 18:30:03 -0500, David Nadlinger s...@klickverbot.at wrote: On Monday, 5 March 2012 at 21:55:08 UTC, Steven Schveighoffer wrote: The log aliases use names that are too common. I think log.info is a

  1   2   >