Re: std.benchmark ready for review. Manager sought after

2013-09-27 Thread Nordlöw
On Sunday, 8 April 2012 at 03:25:16 UTC, Andrei Alexandrescu wrote: Hello, I finally found the time to complete std.benchmark. I got to a very simple API design, starting where I like it: one line of code. Code is in the form of a pull request at https://github.com/D-Programming-Language/p

Re: std.benchmark ready for review. Manager sought after

2012-04-18 Thread SomeDude
On Wednesday, 18 April 2012 at 09:44:12 UTC, Marco Leise wrote: Am Tue, 17 Apr 2012 16:15:43 -0500 In a supermarket, there are three people in front of you in the queue. Then they all decide they forgot something and disappear in the back. You exchange some looks with the cashier and decide th

Re: std.benchmark ready for review. Manager sought after

2012-04-18 Thread Marco Leise
Am Tue, 17 Apr 2012 16:15:43 -0500 schrieb Andrei Alexandrescu : > On 4/17/12 2:53 PM, Jens Mueller wrote: > > Andrei is already preparing. Review will start soon. > > I'd like to gather a bit of confidence that it's okay with people that > std.benchmark skips to the front of the queue instead o

Re: std.benchmark ready for review. Manager sought after

2012-04-17 Thread H. S. Teoh
On Tue, Apr 17, 2012 at 06:56:16PM -0700, Jonathan M Davis wrote: > On Tuesday, April 17, 2012 18:55:07 H. S. Teoh wrote: > > On Tue, Apr 17, 2012 at 04:15:43PM -0500, Andrei Alexandrescu wrote: > > > On 4/17/12 2:53 PM, Jens Mueller wrote: > > > >Andrei is already preparing. Review will start soon

Re: std.benchmark ready for review. Manager sought after

2012-04-17 Thread Jonathan M Davis
On Tuesday, April 17, 2012 18:55:07 H. S. Teoh wrote: > On Tue, Apr 17, 2012 at 04:15:43PM -0500, Andrei Alexandrescu wrote: > > On 4/17/12 2:53 PM, Jens Mueller wrote: > > >Andrei is already preparing. Review will start soon. > > > > I'd like to gather a bit of confidence that it's okay with peop

Re: std.benchmark ready for review. Manager sought after

2012-04-17 Thread H. S. Teoh
On Tue, Apr 17, 2012 at 04:15:43PM -0500, Andrei Alexandrescu wrote: > On 4/17/12 2:53 PM, Jens Mueller wrote: > >Andrei is already preparing. Review will start soon. > > I'd like to gather a bit of confidence that it's okay with people > that std.benchmark skips to the front of the queue instead

Re: std.benchmark ready for review. Manager sought after

2012-04-17 Thread Jonathan M Davis
On Tuesday, April 17, 2012 16:15:43 Andrei Alexandrescu wrote: > On 4/17/12 2:53 PM, Jens Mueller wrote: > > Andrei is already preparing. Review will start soon. > > I'd like to gather a bit of confidence that it's okay with people that > std.benchmark skips to the front of the queue instead of wa

Re: std.benchmark ready for review. Manager sought after

2012-04-17 Thread SomeDude
On Tuesday, 17 April 2012 at 21:15:31 UTC, Andrei Alexandrescu wrote: On 4/17/12 2:53 PM, Jens Mueller wrote: Andrei is already preparing. Review will start soon. I'd like to gather a bit of confidence that it's okay with people that std.benchmark skips to the front of the queue instead of w

Re: std.benchmark ready for review. Manager sought after

2012-04-17 Thread Andrei Alexandrescu
On 4/17/12 2:53 PM, Jens Mueller wrote: Andrei is already preparing. Review will start soon. I'd like to gather a bit of confidence that it's okay with people that std.benchmark skips to the front of the queue instead of waiting in line. Please reply to this if agree/disagree. Thanks, Andr

Re: std.benchmark ready for review. Manager sought after

2012-04-17 Thread Jens Mueller
Dmitry Olshansky wrote: > On 17.04.2012 1:00, Jens Mueller wrote: > >Lars T. Kyllingstad wrote: > >>On Sunday, 15 April 2012 at 16:23:32 UTC, Jens Mueller wrote: > >>>Andrei Alexandrescu wrote: > There have been quite a few good comments, but no review manager > offer. Could someone please

Re: std.benchmark ready for review. Manager sought after

2012-04-17 Thread Dmitry Olshansky
On 17.04.2012 1:00, Jens Mueller wrote: Lars T. Kyllingstad wrote: On Sunday, 15 April 2012 at 16:23:32 UTC, Jens Mueller wrote: Andrei Alexandrescu wrote: There have been quite a few good comments, but no review manager offer. Could someone please take this role? I will do this. But I will

Re: std.benchmark ready for review. Manager sought after

2012-04-16 Thread Jens Mueller
Lars T. Kyllingstad wrote: > On Sunday, 15 April 2012 at 16:23:32 UTC, Jens Mueller wrote: > >Andrei Alexandrescu wrote: > >>There have been quite a few good comments, but no review manager > >>offer. Could someone please take this role? > > > >I will do this. > >But I will need to get more familia

Re: std.benchmark ready for review. Manager sought after

2012-04-16 Thread Lars T. Kyllingstad
On Sunday, 15 April 2012 at 16:23:32 UTC, Jens Mueller wrote: Andrei Alexandrescu wrote: There have been quite a few good comments, but no review manager offer. Could someone please take this role? I will do this. But I will need to get more familiar with the process. And add it to http://p

Re: std.benchmark ready for review. Manager sought after

2012-04-16 Thread Jonathan M Davis
On Sunday, April 15, 2012 13:41:28 Jacob Carlborg wrote: > On 2012-04-15 04:58, Andrei Alexandrescu wrote: > > There have been quite a few good comments, but no review manager offer. > > Could someone please take this role? > > > > Again, it would be great to get std.benchmark in sooner rather tha

Re: std.benchmark ready for review. Manager sought after

2012-04-15 Thread Jens Mueller
Andrei Alexandrescu wrote: > There have been quite a few good comments, but no review manager > offer. Could someone please take this role? I will do this. But I will need to get more familiar with the process. And add it to http://prowiki.org/wiki4d/wiki.cgi?ReviewQueue for future review managers

Re: std.benchmark ready for review. Manager sought after

2012-04-15 Thread Jens Mueller
Andrei Alexandrescu wrote: > On 4/10/12 5:40 AM, Jens Mueller wrote: > >How come that the times based relative report and the percentage based > >relative report are mixed in one result? And how do I choose which one > >I'd like to see in the output. > > It's in the names. If the name of a benchma

Re: std.benchmark ready for review. Manager sought after

2012-04-15 Thread Famous
Maybe the layout is not destroyed, this time: BenchmarkTimePerformance --- name s/iter iter/s fa

Re: std.benchmark ready for review. Manager sought after

2012-04-15 Thread Famous
Instead of the originally proposed layout Benchmark relative ns/iter iter/s ---[ module_one ]---

Re: std.benchmark ready for review. Manager sought after

2012-04-15 Thread Jacob Carlborg
On 2012-04-15 04:58, Andrei Alexandrescu wrote: There have been quite a few good comments, but no review manager offer. Could someone please take this role? Again, it would be great to get std.benchmark in sooner rather than later because it can be used by subsequent submissions (many of which a

Re: std.benchmark ready for review. Manager sought after

2012-04-14 Thread Andrei Alexandrescu
There have been quite a few good comments, but no review manager offer. Could someone please take this role? Again, it would be great to get std.benchmark in sooner rather than later because it can be used by subsequent submissions (many of which allege efficiency as a major advantage) to show

Re: std.benchmark ready for review. Manager sought after

2012-04-14 Thread Andrei Alexandrescu
On 4/10/12 5:40 AM, Jens Mueller wrote: How come that the times based relative report and the percentage based relative report are mixed in one result? And how do I choose which one I'd like to see in the output. It's in the names. If the name of a benchmark starts with benchmark_relative_, th

Re: std.benchmark ready for review. Manager sought after

2012-04-14 Thread Andrei Alexandrescu
(Resuming a few past discussions about std.benchmark.) On 4/9/12 1:26 PM, Manfred Nowak wrote: Andrei Alexandrescu wrote: I disagree with running two benchmarks in parallel because that exposes them to even more noise (scheduling, CPU count, current machine load etc). I did not mean to run tw

Re: std.benchmark ready for review. Manager sought after

2012-04-10 Thread Denis Shelomovskij
09.04.2012 17:26, Andrei Alexandrescu пишет: On 4/9/12 2:06 AM, Denis Shelomovskij wrote: Why will recording the average produce so much noise? As I explained, the average takes noise and outliers (some very large, e.g. milliseconds in a benchmark that takes microseconds) into account. The min

Re: std.benchmark ready for review. Manager sought after

2012-04-10 Thread Martin Nowak
I've analyzed this quite a bit at work and the average and median are not very informative. You need the mode, but in most benchmarks the mode is very close to the minimum, so using the minimum is even better. How is it better? In speed measurements, all noise is additive (there's no noise

Re: std.benchmark ready for review. Manager sought after

2012-04-10 Thread Jens Mueller
Andrei Alexandrescu wrote: > Hello, > > > I finally found the time to complete std.benchmark. I got to a very > simple API design, starting where I like it: one line of code. > > Code is in the form of a pull request at > https://github.com/D-Programming-Language/phobos/pull/529. (There's > some

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Manfred Nowak
Andrei Alexandrescu wrote: >> For example by running more than one instance of the benchmarked >> program in paralell and use the thereby gathered statistical >> routines to spread T into the additiv components A, Q and N. > I disagree with running two benchmarks in parallel because that > expos

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Andrei Alexandrescu
On 4/9/12 11:44 AM, Somedude wrote: It helps benchmarking being as standard as unit testing. We don't want to have to write again and again the same boilerplate code for such trivial uses. Yes, I had unittest in mind when writing the library. If one needs more than one statement to get an info

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Andrei Alexandrescu
On 4/9/12 11:29 AM, Francois Chabot wrote: Which is great, unless the program wants to measure the cache memory itself, in which case it would use special assembler instructions or large memset()s. (We do such at Facebook.) I disagree. If a regression suddenly causes a function to become heavil

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Somedude
Le 09/04/2012 17:23, Francois Chabot a écrit : > Why is there so much emphasis on printBenchmarks()? > > benchmark() and runBenchmarks() are clearly the core of this library, > and yet they are relegated to second-class citizen: "Oh, I guess you can > use this". Normally, I wouldn't be so picky, b

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Francois Chabot
Which is great, unless the program wants to measure the cache memory itself, in which case it would use special assembler instructions or large memset()s. (We do such at Facebook.) I disagree. If a regression suddenly causes a function to become heavily cache-bound, it should show up in benchma

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Andrei Alexandrescu
On 4/9/12 9:25 AM, Manfred Nowak wrote: Andrei Alexandrescu wrote: all noise is additive (there's no noise that may make a benchmark appear to run faster) This is in doubt, because you yourself wrote "the machine itself has complex interactions". This complex interactions might lower the time

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Andrei Alexandrescu
On 4/9/12 10:23 AM, Francois Chabot wrote: Why is there so much emphasis on printBenchmarks()? benchmark() and runBenchmarks() are clearly the core of this library, and yet they are relegated to second-class citizen: "Oh, I guess you can use this". Normally, I wouldn't be so picky, but this is a

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Francois Chabot
Why is there so much emphasis on printBenchmarks()? benchmark() and runBenchmarks() are clearly the core of this library, and yet they are relegated to second-class citizen: "Oh, I guess you can use this". Normally, I wouldn't be so picky, but this is a standard library. Focus should be on fun

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Steven Schveighoffer
Added to trello. -Steve

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Manfred Nowak
Andrei Alexandrescu wrote: > all noise is additive (there's no noise that may make a benchmark > appear to run faster) This is in doubt, because you yourself wrote "the machine itself has complex interactions". This complex interactions might lower the time needed for an operation of the bench

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Andrei Alexandrescu
On 4/9/12 2:06 AM, Denis Shelomovskij wrote: Why will recording the average produce so much noise? As I explained, the average takes noise and outliers (some very large, e.g. milliseconds in a benchmark that takes microseconds) into account. The minimum is shielded from this issue. In the lim

Re: std.benchmark ready for review. Manager sought after

2012-04-09 Thread Denis Shelomovskij
08.04.2012 21:31, Andrei Alexandrescu пишет: On 4/8/12 11:59 AM, Denis Shelomovskij wrote: Very good but minimum isn't a best guess. Personally I (and there will be a lot of such maniacs I suppose) will think that this (minimum) time can be significantly smaller than average time. I've analyze

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Andrei Alexandrescu
On 4/8/12 3:03 PM, Manfred Nowak wrote: Andrei Alexandrescu wrote: Clearly there is noise during normal use as well, but incorporating it in benchmarks as a matter of course reduces the usefulness of benchmarks On the contrary: 1) The "noise during normal use" has to be measured in order to d

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Somedude
Le 08/04/2012 17:48, Dmitry Olshansky a écrit : > On 08.04.2012 12:16, Somedude wrote: > [snip] >> >> Like it. Would it be a good idea to add a column with an average memory >> used ? > > In general it's next to impossible and/or entirely OS-specific. > What can be done I think is adding a query f

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Somedude
Le 08/04/2012 18:21, Marco Leise a écrit : > Am Sun, 08 Apr 2012 09:35:14 -0500 > schrieb Andrei Alexandrescu : > >> On 4/8/12 3:16 AM, Somedude wrote: >>> Like it. Would it be a good idea to add a column with an average memory >>> used ? >> >> Interesting idea. I saw >> http://stackoverflow.com/

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Manfred Nowak
Andrei Alexandrescu wrote: > Clearly there is noise during normal use as well, but > incorporating it in benchmarks as a matter of course reduces the > usefulness of benchmarks On the contrary: 1) The "noise during normal use" has to be measured in order to detect the sensibility of the benchma

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Andrei Alexandrescu
On 4/8/12 1:03 PM, Caligo wrote: On Sat, Apr 7, 2012 at 10:25 PM, Andrei Alexandrescu wrote: Hello, I finally found the time to complete std.benchmark. I got to a very simple API design, starting where I like it: one line of code. Andrei I probably missed this somewhere, but what happens

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Dmitry Olshansky
On 08.04.2012 21:40, Andrei Alexandrescu wrote: On 4/8/12 12:35 PM, Dmitry Olshansky wrote: Another cool addition IMHO would be parametric benchmarks, so there is a function and a set of parameters (one parameter is fine too) to benchmark on. It makes that much more sense with graphs as algorith

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Caligo
On Sat, Apr 7, 2012 at 10:25 PM, Andrei Alexandrescu wrote: > Hello, > > I finally found the time to complete std.benchmark. I got to a very simple > API design, starting where I like it: one line of code. > > Andrei I probably missed this somewhere, but what happens to `std.datetime : benchmark

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Andrei Alexandrescu
On 4/8/12 12:35 PM, Dmitry Olshansky wrote: Another cool addition IMHO would be parametric benchmarks, so there is a function and a set of parameters (one parameter is fine too) to benchmark on. It makes that much more sense with graphs as algorithm profile plotted for various inputs (sizes) can

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Dmitry Olshansky
On 08.04.2012 20:59, Denis Shelomovskij wrote: Very good but minimum isn't a best guess. Personally I (and there will be a lot of such maniacs I suppose) will think that this (minimum) time can be significantly smaller than average time. Prime example is networking. So a parameter (probably

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Andrei Alexandrescu
On 4/8/12 11:59 AM, Denis Shelomovskij wrote: Very good but minimum isn't a best guess. Personally I (and there will be a lot of such maniacs I suppose) will think that this (minimum) time can be significantly smaller than average time. I've analyzed this quite a bit at work and the average and

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Denis Shelomovskij
Very good but minimum isn't a best guess. Personally I (and there will be a lot of such maniacs I suppose) will think that this (minimum) time can be significantly smaller than average time. So a parameter (probably with a default value) should be added. Something like enum of flags telling wh

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Marco Leise
Am Sun, 08 Apr 2012 09:35:14 -0500 schrieb Andrei Alexandrescu : > On 4/8/12 3:16 AM, Somedude wrote: > > Like it. Would it be a good idea to add a column with an average memory > > used ? > > Interesting idea. I saw > http://stackoverflow.com/questions/1674652/c-c-memory-usage-api-in-linux-wind

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Dmitry Olshansky
On 08.04.2012 12:16, Somedude wrote: [snip] Like it. Would it be a good idea to add a column with an average memory used ? In general it's next to impossible and/or entirely OS-specific. What can be done I think is adding a query function to GC interface that returns amount of RAM currently a

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Andrei Alexandrescu
On 4/8/12 5:46 AM, Piotr Szturmaj wrote: Andrei Alexandrescu wrote: I finally found the time to complete std.benchmark. I got to a very simple API design, starting where I like it: one line of code. Code is in the form of a pull request at https://github.com/D-Programming-Language/phobos/pull/5

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Andrei Alexandrescu
On 4/8/12 3:16 AM, Somedude wrote: Like it. Would it be a good idea to add a column with an average memory used ? Interesting idea. I saw http://stackoverflow.com/questions/1674652/c-c-memory-usage-api-in-linux-windows and it looks like it's not an easy problem. Should we make this part of t

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Andrei Alexandrescu
On 4/8/12 2:02 AM, Vladimir Panteleev wrote: The "benchmark_relative_" prefix makes sense for function names (for scheduleForBenchmarking), but not so much for string literals for benchmark names. The string literal "benchmark_relative_file read" looks like the words "benchmark relative file" are

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Piotr Szturmaj
Andrei Alexandrescu wrote: I finally found the time to complete std.benchmark. I got to a very simple API design, starting where I like it: one line of code. Code is in the form of a pull request at https://github.com/D-Programming-Language/phobos/pull/529. (There's some noise in there caused by

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Somedude
Le 08/04/2012 05:25, Andrei Alexandrescu a écrit : > Hello, > > > I finally found the time to complete std.benchmark. I got to a very > simple API design, starting where I like it: one line of code. > > Code is in the form of a pull request at > https://github.com/D-Programming-Language/phobos/p

Re: std.benchmark ready for review. Manager sought after

2012-04-08 Thread Vladimir Panteleev
On Sunday, 8 April 2012 at 05:41:11 UTC, Andrei Alexandrescu wrote: 3) "benchmark_relative_file read" should be replaced with a language construct. E.g. a function call like relativeBenchmark("file read"), or an enum value like getopt's. No can do. Need a function name-based convention so we

Re: std.benchmark ready for review. Manager sought after

2012-04-07 Thread Andrei Alexandrescu
On 4/7/12 11:45 PM, Vladimir Panteleev wrote: On Sunday, 8 April 2012 at 03:25:16 UTC, Andrei Alexandrescu wrote: Hello, I finally found the time to complete std.benchmark. I got to a very simple API design, starting where I like it: one line of code. Nice, some comments: 1) Is it possible

Re: std.benchmark ready for review. Manager sought after

2012-04-07 Thread Vladimir Panteleev
On Sunday, 8 April 2012 at 03:25:16 UTC, Andrei Alexandrescu wrote: Hello, I finally found the time to complete std.benchmark. I got to a very simple API design, starting where I like it: one line of code. Nice, some comments: 1) Is it possible to do something about the "kilonanoseconds",

std.benchmark ready for review. Manager sought after

2012-04-07 Thread Andrei Alexandrescu
Hello, I finally found the time to complete std.benchmark. I got to a very simple API design, starting where I like it: one line of code. Code is in the form of a pull request at https://github.com/D-Programming-Language/phobos/pull/529. (There's some noise in there caused by my git n00bine