Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-08 Thread Zilvinas Valinskas
On Fri, Jun 08, 2001 at 03:01:03AM -0700, Joaquin Cuenca Abela wrote: > > --- "R. Reucher" <[EMAIL PROTECTED]> wrote: > > Andrew James Richardson wrote: > > > > > Brian, > > > > > >I thought that in the C specs you can't be > > guarenteed the order of > > > evaluation in an if brace. Surely

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-08 Thread Zilvinas Valinskas
> >I thought that in the C specs you can't be guarenteed the order of > evaluation in an if brace. Surely a safer bet is > > if(!image){ > if(!image->Data){ > ... > } > } > > If you know better I stand corrected, I'm just think

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-08 Thread Dan Maas
> Brian, > >I thought that in the C specs you can't be guarenteed the order of > evaluation in an if brace. Surely a safer bet is > > if(!image){ > if(!image->Data){ > ... > } > } Order of operations is actually guaranteed in this case. See http://www.faqs.org/faqs/C-faq/faq/ (item 3.5). You

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-08 Thread Joaquin Cuenca Abela
--- "R. Reucher" <[EMAIL PROTECTED]> wrote: > Andrew James Richardson wrote: > > > Brian, > > > >I thought that in the C specs you can't be > guarenteed the order of > > evaluation in an if brace. Surely a safer bet is > > > > if(!image){ > > if(!image->Data){ > >

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-08 Thread R. Reucher
Andrew James Richardson wrote: > Brian, > >I thought that in the C specs you can't be guarenteed the order of > evaluation in an if brace. Surely a safer bet is > > if(!image){ > if(!image->Data){ > ... > } > } You're r

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-08 Thread Andrew James Richardson
On Thu, 7 Jun 2001, Brian Paul wrote: > Pontus Hedman wrote: > > > > > Either submit the patch here if it's small enough, or submit > > > to patches on the DRI sourceforge page. > > > > Ok; it's a trivial one-liner to r128ConvertTexture32bpp. > > See below. > > > > It's probably more of a work

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-07 Thread Brian Paul
Pontus Hedman wrote: > > > Either submit the patch here if it's small enough, or submit > > to patches on the DRI sourceforge page. > > Ok; it's a trivial one-liner to r128ConvertTexture32bpp. > See below. > > It's probably more of a workaround than a fix > (the image passed in from r128UploadS

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-07 Thread Pontus Hedman
> Either submit the patch here if it's small enough, or submit > to patches on the DRI sourceforge page. Ok; it's a trivial one-liner to r128ConvertTexture32bpp. See below. It's probably more of a workaround than a fix (the image passed in from r128UploadSubImage() had dimensions but no Data for

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-07 Thread Jeffrey W. Baker
On Thu, 7 Jun 2001, Pontus Hedman wrote: > Hello all, > > I have a bugfix that I don't know what to do with. > > I built X11R6-DRI on tuesday from CVS via > [EMAIL PROTECTED]:/cvsroot/dri > because my Descent3 that I bought last week > was locking up up XFree86 4.0.3 incessantly. > As in, within

Re: [Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-07 Thread Alan Hourihane
On Thu, Jun 07, 2001 at 11:17:01AM -0400, Pontus Hedman wrote: > Hello all, > > I have a bugfix that I don't know what to do with. > > I built X11R6-DRI on tuesday from CVS via > [EMAIL PROTECTED]:/cvsroot/dri > because my Descent3 that I bought last week > was locking up up XFree86 4.0.3 incess

[Dri-devel] I have a bugfix to the xc/lib/GL/mesa/src/drv/r128/r128_tex.c

2001-06-07 Thread Pontus Hedman
Hello all, I have a bugfix that I don't know what to do with. I built X11R6-DRI on tuesday from CVS via [EMAIL PROTECTED]:/cvsroot/dri because my Descent3 that I bought last week was locking up up XFree86 4.0.3 incessantly. As in, within a minute or two of play. Gah! I came up with a fix to xc