Re: Savage DRM problem: multiple framebuffer mappings

2004-09-08 Thread David
El Martes, 7 de Septiembre del 2004 11:08 PM, Felix Kühling escribió: Thanks. This reenables 3D accel on the Savage. I havn't tested it on any other driver. But the patch looks good to me. Tested on Savage4. It works. --- This SF.Net email

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-07 Thread Felix Kühling
On Mon, 6 Sep 2004 20:16:12 -0400 Jon Smirl [EMAIL PROTECTED] wrote: I decided my loop was too fancy so I just deleted it and replaced it with a simple flag. If the driver uses permanent maps the flag gets set and addmaps from user space have no effect. If the driver doesn't use permanent

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-07 Thread Felix Kühling
On Mon, 6 Sep 2004 19:56:49 -0400 Jon Smirl [EMAIL PROTECTED] wrote: AddMap has the loop to find the existing mapping and replace it. initmap doesn't have that loop so it allows multiple adds. I wanted to just make AddMap refuse a REG/FB map request but I was trying to be compatible while we

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-07 Thread Jon Smirl
Here's a new version that should be compatible with all of the cases: 1) multiple maps 2) old X doing AddMap 3) fixed X doing GetMap - X needs to switch to this after all the drivers get fixed 4) drivers that have implemented permanent maps 4) drivers that have not implemented permanent maps I

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-07 Thread Keith Whitwell
Jon Smirl wrote: Here's a new version that should be compatible with all of the cases: 1) multiple maps 2) old X doing AddMap 3) fixed X doing GetMap - X needs to switch to this after all the drivers get fixed 4) drivers that have implemented permanent maps 4) drivers that have not implemented

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-07 Thread Jon Smirl
New version of same patch without the whitespace clean up On Tue, 07 Sep 2004 16:59:09 +0100, Keith Whitwell [EMAIL PROTECTED] wrote: Ugh. If we're going to do whitespace changes can we do them seperately to proper changes, please? Keith -- Jon Smirl [EMAIL PROTECTED] =

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-07 Thread Felix Kühling
Thanks. This reenables 3D accel on the Savage. I havn't tested it on any other driver. But the patch looks good to me. Regards, Felix On Tue, 7 Sep 2004 11:39:59 -0400 Jon Smirl [EMAIL PROTECTED] wrote: Here's a new version that should be compatible with all of the cases: 1) multiple maps

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-07 Thread Jon Smirl
I'd be interested to know if you can get permanent maps working in the Savage driver. I sent the example of how the radeon does it. On Tue, 7 Sep 2004 23:08:00 +0200, Felix Kühling [EMAIL PROTECTED] wrote: Thanks. This reenables 3D accel on the Savage. I havn't tested it on any other driver.

Savage DRM problem: multiple framebuffer mappings

2004-09-06 Thread Felix Kühling
Hi, after upgrading the DRM (it has been a while since the last cvs update) the Savage driver stopped working. I tracked it down to the DRM refusing to create multiple framebuffer-type mappings. If it finds an existing mapping it returns it instead of creating a new one. However, the Savage

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-06 Thread Dave Airlie
Anyway, I suspect the behaviour of DRM(addmap) changed recently. The only addmap-related comment I could find on dri-patches is this: addmap-base-2 patch from Jon Smirl: sets up the DRM to have the ability to have permanent maps while the driver is loaded... Is it really necessary

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-06 Thread Jon Smirl
The plan for the addMap changes is to get rid of the loop where the user space code asks the driver where the resources are and then sets those values back into the driver. Since the driver already knows these values it should just create the maps itself. This removes the possibility of the user

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-06 Thread Dave Airlie
But does the new code deal with multiple mappings.. the radeon doesn't do this at the moment they call multiple addmaps for the framebuffer, A permanently mapped framebuffer, shouldn't stop you adding another mapping for tiling/whatever... or should it.. Dave. On Mon, 6 Sep 2004, Jon

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-06 Thread Jon Smirl
AddMap has the loop to find the existing mapping and replace it. initmap doesn't have that loop so it allows multiple adds. I wanted to just make AddMap refuse a REG/FB map request but I was trying to be compatible while we changed the drivers over. Can we just switch the drivers over right now

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-06 Thread Jon Smirl
I decided my loop was too fancy so I just deleted it and replaced it with a simple flag. If the driver uses permanent maps the flag gets set and addmaps from user space have no effect. If the driver doesn't use permanent maps everything should work the old way. If this looks good I can check it

Re: Savage DRM problem: multiple framebuffer mappings

2004-09-06 Thread Jon Smirl
On Mon, 6 Sep 2004 16:55:10 +0200, Felix Kühling [EMAIL PROTECTED] wrote: after upgrading the DRM (it has been a while since the last cvs update) the Savage driver stopped working. I tracked it down to the DRM refusing to create multiple framebuffer-type mappings. If it finds an existing