Hi Jonathan,
On Sunday 15 September 2013 12:50:09 Jonathan Cameron wrote:
On 09/11/13 09:18, Juergen Beisert wrote:
Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at
least for the 4 wire touchscreen.
Note: support for the remaining LRADC channels is not tested on
Hi Jonathan,
On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote:
[...]
+static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg)
+{
+ writel(val, lradc-base + reg + STMP_OFFSET_REG_SET);
+}
+
+static void mxs_lradc_reg_clear(struct mxs_lradc *lradc, u32
The main thing is that could you improve the error handling in
hv_kbd_on_channel_callback() explained inline.
On Sun, Sep 15, 2013 at 10:28:54PM -0700, K. Y. Srinivasan wrote:
Add a new driver to support synthetic keyboard. On the next generation
Hyper-V guest firmware, many legacy devices will
Hi Jonathan,
On Sunday 15 September 2013 18:10:18 Jonathan Cameron wrote:
On 09/15/13 11:56, Jonathan Cameron wrote:
On 09/11/13 09:18, Juergen Beisert wrote:
For battery driven systems it is a very bad idea to collect the
touchscreen data within a kernel busy loop.
This change uses
Hi Jonathan,
On Monday 16 September 2013 10:10:22 Jürgen Beisert wrote:
[...]
While this driver is placed in IIO within staging at the moment, these
changes are definitely input related. Hence I have cc'd Dmitry and the
input list.
I am personaly a little uncomfortable that we have
On Fri, 13 Sep 2013, wei_w...@realsil.com.cn wrote:
From: Wei WANG wei_w...@realsil.com.cn
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
It is a little different between
The previously used printk lacked the warning level, now we've got a more
accurate way to know the error.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/wb35tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/wbusb.c | 2 +-
1 file changed, 1 insertion(+), 1
First of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/reg.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/winbond/reg.c
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/wb35rx.c | 4 ++--
1 file changed, 2
Deleted an space before a tabulation.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/wb35reg_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35reg_s.h
b/drivers/staging/winbond/wb35reg_s.h
index dc79faa..cdbbf35
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
In the first revision Greg KH pointed out that this change broke the build. In
my computer it builds properly so if someone has
First of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/phy_calibration.c | 46 ++-
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git
Erased all the errors given by checkpatch stating trailing whitespace.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/reg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/reg.c
The following function declarations have been removed because they aren't
implemented.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/mto.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c
index
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/wbusb.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index
Third of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c
Seventh of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/reg.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/reg.c
White space deleted before semicolons.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/reg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 5883d23..80b4b34 100644
---
Deleted declaration of external functions that weren't used on this driver.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/mto.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h
index
Second of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/phy_calibration.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git
Fixes some coding style issues from drivers/staging/winbond
Iker Pedrosa (24):
Staging: winbond: mto: removed function declaration
Staging: winbond: mto: avoided use of extern functions
Staging: winbond: mto: deleted extern functions
Staging: winbond: phy_calibration: first of the patches
Fourth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c
Prototype of two functions added to the header to avoid the use of extern.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/mto.c | 4 +---
drivers/staging/winbond/mto.h | 4 ++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/wb35rx.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c
index 48ed95c..999b7046
Second of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c
Dear Jürgen Beisert,
Hi Jonathan,
On Sunday 15 September 2013 12:50:09 Jonathan Cameron wrote:
On 09/11/13 09:18, Juergen Beisert wrote:
Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC
at least for the 4 wire touchscreen.
Note: support for the remaining
Dear Jürgen Beisert,
Hi Jonathan,
On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
On 09/11/13 09:18, Juergen Beisert wrote:
For battery driven systems it is a very bad idea to collect the
touchscreen data within a kernel busy loop.
This change uses the features of
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 16, 2013 1:21 AM
To: KY Srinivasan
Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; linux-in...@vger.kernel.org;
dmitry.torok...@gmail.com;
On Mon, Sep 16, 2013 at 02:46:24PM +, KY Srinivasan wrote:
+ case VM_PKT_DATA_INBAND:
+ hv_kbd_on_receive(device, desc);
This is the error handling I mentioned at the top. hv_kbd_on_receive()
doesn't take into consideration the amount of
Dear Jürgen Beisert,
Hi Marek,
On Monday 16 September 2013 16:23:48 Marek Vasut wrote:
On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
On 09/11/13 09:18, Juergen Beisert wrote:
For battery driven systems it is a very bad idea to collect the
touchscreen data
Hi K. Y.
On Sun, Sep 15, 2013 at 10:28:54PM -0700, K. Y. Srinivasan wrote:
Add a new driver to support synthetic keyboard. On the next generation
Hyper-V guest firmware, many legacy devices will not be emulated and this
driver will be required.
I would like to thank Vojtech Pavlik
On Sun, Sep 15, 2013 at 11:56:25AM +0100, Jonathan Cameron wrote:
On 09/11/13 09:18, Juergen Beisert wrote:
For battery driven systems it is a very bad idea to collect the touchscreen
data within a kernel busy loop.
This change uses the features of the hardware to delay and accumulate
Jürgen Beisert j...@pengutronix.de wrote:
Hi Jonathan,
On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
On 09/11/13 09:18, Juergen Beisert wrote:
For battery driven systems it is a very bad idea to collect the
touchscreen data within a kernel busy loop.
This change uses the
-Original Message-
From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
Sent: Monday, September 16, 2013 8:20 AM
To: KY Srinivasan
Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; linux-in...@vger.kernel.org; vojt...@suse.cz;
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 16, 2013 8:06 AM
To: KY Srinivasan
Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com;
dmitry.torok...@gmail.com; linux-ker...@vger.kernel.org; vojt...@suse.cz;
On Mon, Sep 16, 2013 at 03:52:18PM +, KY Srinivasan wrote:
-Original Message-
From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
Sent: Monday, September 16, 2013 8:20 AM
To: KY Srinivasan
Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
Hi Thomas,
A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
it was found that reverting the following commit resolved
this bug:
commit a4a23f6d68ad2c86ee8df6a6f89c9d315c0a761c
Author: Thomas Meyer tho...@m3y3r.de
Date: Sat Jun 1 11:40:31 2013 +0200
HID: hyperv:
On 09/16/13 09:17, Jürgen Beisert wrote:
Hi Jonathan,
On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote:
[...]
+static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg)
+{
+ writel(val, lradc-base + reg + STMP_OFFSET_REG_SET);
+}
+
+static void
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 16, 2013 11:33 AM
To: KY Srinivasan
Cc: Dmitry Torokhov; o...@aepfle.de; gre...@linuxfoundation.org;
jasow...@redhat.com; linux-ker...@vger.kernel.org; vojt...@suse.cz; linux-
On Mon, Sep 16, 2013 at 06:42:25PM +, KY Srinivasan wrote:
Dan,
Rolling the changes you have indicated is not the issue; this can trivially
be done.
My contention is that it is not needed given that the underlying function is
already
doing that. Look at the function
On 09/16/2013 04:38 PM, Dan Carpenter wrote:
On Mon, Sep 16, 2013 at 01:42:35PM -0400, Joseph Salisbury wrote:
Reverting the patch changes the driver back to useing kzalloc() and
memcpy() instead of kmemdup. Doing so has uncovered another bug, which
causes an oops on memcpy()[1]. We are in
On Mon, Sep 16, 2013 at 04:49:29PM -0400, Joseph Salisbury wrote:
On 09/16/2013 04:38 PM, Dan Carpenter wrote:
On Mon, Sep 16, 2013 at 01:42:35PM -0400, Joseph Salisbury wrote:
Reverting the patch changes the driver back to useing kzalloc() and
memcpy() instead of kmemdup. Doing so has
On Mon, Sep 16, 2013 at 01:42:35PM -0400, Joseph Salisbury wrote:
Reverting the patch changes the driver back to useing kzalloc() and
memcpy() instead of kmemdup. Doing so has uncovered another bug, which
causes an oops on memcpy()[1]. We are in the process of bisecting that
one now and
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 16, 2013 1:13 PM
To: KY Srinivasan
Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; Dmitry
Torokhov; linux-ker...@vger.kernel.org; vojt...@suse.cz; linux-
Don't return success if the buffer has not been initialized.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 6de6c98..b05293c 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -855,6 +855,6 @@ int
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 16, 2013 2:59 PM
To: KY Srinivasan
Cc: Haiyang Zhang; de...@linuxdriverproject.org
Subject: [patch] hv: vmbus: fix vmbus_recvpacket_raw() return code
Don't return success if the
On Mon, Sep 16, 2013 at 09:55:44PM +, KY Srinivasan wrote:
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 16, 2013 1:13 PM
To: KY Srinivasan
Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; Dmitry
On Mon, Sep 16, 2013 at 06:29:45PM +, KY Srinivasan wrote:
-Original Message-
From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
Sent: Monday, September 16, 2013 10:10 AM
To: KY Srinivasan
Cc: Dan Carpenter; o...@aepfle.de; gre...@linuxfoundation.org;
On Mon, Sep 16, 2013 at 05:53:57PM -0400, Mike Snitzer wrote:
- variable names need to be a bit more verbose (arr = array)
struct array is a horrible name. :P Please don't use either arr
or array.
regards,
dan carpenter
___
devel mailing list
2013/5/17 Robert Love rl...@google.com:
On Thu, May 16, 2013 at 1:19 PM, Andrew Morton
a...@linux-foundation.org wrote:
On Thu, 16 May 2013 13:08:17 -0400 Robert Love rl...@google.com wrote:
This problem seems a rare proper use of mutex_trylock.
Not really. The need for a trylock is often
51 matches
Mail list logo
