Hi Long,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v4.16-rc6]
[cannot apply to linus/master net-next/master net/master next-20180323]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
Hi Sergio,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20180323]
[cannot apply to v4.16-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url
Prefer the direct use of octal for permissions.
Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
and some typing.
Miscellanea:
o Whitespace neatening around these conversions.
Signed-off-by: Joe Perches
---
drivers/net/bonding/bond_procfs.c | 2 +-
On Fri, Mar 23, 2018 at 07:00:27PM +0100, Valentin Vidic wrote:
> You are right, here is what kfifo.h says:
>
> /*
> * Note about locking : There is no locking required until only * one reader
> * and one writer is using the fifo and no kfifo_reset() will be * called
> * kfifo_reset_out() can
v4.16-rc6]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Roy-Pledge/staging-fsl-mc-Move-DPIO-from-staging-to-drivers-soc-fsl/20180323-102325
> config: arm-allmodconfig (attac
In the current implementation, `rmmod snd_bcm2835` does not release
resources properly. It causes an oops when trying to list sound devices.
This commit fixes it.
The details WRT allocation / free are described below.
Device structure WRT allocation:
pdev
\childdev[]
\card
\chip
On 03/23/18 17:23, Andy Shevchenko wrote:
> On Thu, Mar 22, 2018 at 11:37 PM, Kirill Marinushkin
> wrote:
>
>
>> +static void snd_devm_release(struct device *dev)
>> +{
>> + struct bcm2835_chip *chip = dev_get_drvdata(dev);
>> +
>> + kfree(chip);
>> +}
>> +
On Fri, Mar 23, 2018 at 04:38:50PM +0100, Marcus Wolf wrote:
> I had no time to work on the code for monthes now and the memorisation
> of my thoughts when I was programming that (approx. one year ago) is
> quite pale.
>
> As far as I remember, I read something, that the fifo has an integrated
>
From: Colin Ian King
The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain
typos and don't match the #if guard check. Defined them correctly.
Cleans up clang warnings:
warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
by #define of a
> Subject: RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring
> buffer percentage
>
>
>
> > -Original Message-
> > From: Haiyang Zhang
> > Sent: Friday, March 23, 2018 8:01 AM
> > To: Long Li ; KY Srinivasan
> > ; Stephen
On 23/03/18 17:36, Colin King wrote:
> From: Colin Ian King
>
> The #define for __PHYDMKFREE_H__ is missing a character and is not
> the same as the guard check. Defined this correctly.
>
> Cleans up clang warning:
> warning: '__PHYDMKFREE_H__' is used as a header
From: Colin Ian King
The #define for __PHYDMKFREE_H__ is missing a character and is not
the same as the guard check. Defined this correctly.
Cleans up clang warning:
warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
by #define of a different macro
This commit renames function get_DWORD into get_dword to avoid
camel case.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git
This commit removes death code which is not being used at all because
it is inside a preprocessor if 0 directive. This change improves a bit
readability of ks_wlan_set_essid function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 15
This commit factors out some init functions from hostif_init
to improve readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 76 ++
1 file changed, 52 insertions(+), 24 deletions(-)
diff --git
This commit renames get_WORD function into get_word to avoid
camel case.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git
This commits replaces custom defines that were been used
to define a mask using GENMASK macro from linux bitops
header file.
With this change the "WARNING: line over 80 characters"
warning message reported by checkpatch script is also
removed.
Signed-off-by: Sergio Paracuellos
This commit renames get_BYTE function in favour of get_byte
to avoid camel case.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git
The following patch series makes several changes to improve readability of
some functions around several header and source files.
One checkpatch script warning and some camel cases are removed also.
v2:
* Remove compilation warning because a declaration after initialization
in
On Fri, Mar 23, 2018 at 04:12:58PM +, Sridhar Pitchai wrote:
> When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual
> PCI bus to the guest, Hyper-V always provides unique PCI domain.
>
> commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> overrode unique
On Fri, Mar 23, 2018 at 04:41:02PM +, Sridhar Pitchai wrote:
> Please read the link I sent you in relation to email formatting.
>
> Then add your description above in a way that anyone not 100% familiar
> with hyperv can understand it - that's what the commit log is for.
>
Please read the link I sent you in relation to email formatting.
Then add your description above in a way that anyone not 100% familiar
with hyperv can understand it - that's what the commit log is for.
You are sending this patch to stable kernels, patch above has been in
When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual
PCI bus to the guest, Hyper-V always provides unique PCI domain.
commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
overrode unique domain with the serial number of the first device added
to the virtual PCI
This commit removes death code which is not being used at all because
it is inside a preprocessor if 0 directive. This change improves a bit
readability of ks_wlan_set_essid function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 15
This commit renames get_WORD function into get_word to avoid
camel case.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git
This commits replaces custom defines that were been used
to define a mask using GENMASK macro from linux bitops
header file.
With this change the "WARNING: line over 80 characters"
warning message reported by checkpatch script is also
removed.
Signed-off-by: Sergio Paracuellos
This commit renames get_BYTE function in favour of get_byte
to avoid camel case.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git
This commit factors out some init functions from hostif_init
to improve readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 76 ++
1 file changed, 52 insertions(+), 24 deletions(-)
diff --git
The following patch series makes several changes to improve readability of
some functions around several header and source files.
One checkpatch script warning and some camel cases are removed also.
Sergio Paracuellos (6):
staging: ks7010: use GENMASK instead of custom defines in
This commit renames function get_DWORD into get_dword to avoid
camel case.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git
> Previously, when using the bond driver, unique and persistent VF NIC name
> was required, so we used serial number as PCI domain which is included as
> part of the VF NIC name. Transparent SRIOV mode puts VF NIC based on MAC
> match as a slave of synthetic NIC, so VF NIC’s name
On Thu, Mar 22, 2018 at 11:37 PM, Kirill Marinushkin
wrote:
> +static void snd_devm_release(struct device *dev)
> +{
> + struct bcm2835_chip *chip = dev_get_drvdata(dev);
> +
> + kfree(chip);
> +}
> + device->release = snd_devm_release;
This is not
Hello,
I am Mr. Abdulahi Issa, from Burkina Faso in West African region. I
work with the Bank of Africa here Which i am the audit manager . Can
you safe Guard these amount( $18 Million USD) for me in your Country??
Further Details will be given to you if you show Interest.
Regards
Mr. Abdulahi
> -Original Message-
> From: Vitaly Kuznetsov
> Sent: Friday, March 23, 2018 11:17 AM
> To: Haiyang Zhang
> Cc: da...@davemloft.net; net...@vger.kernel.org; Haiyang Zhang
> ; KY Srinivasan ;
Hi Valentin,
I had no time to work on the code for monthes now and the memorisation
of my thoughts when I was programming that (approx. one year ago) is
quite pale.
As far as I remember, I read something, that the fifo has an integrated
protection, so no external protection is needed. But
Dear Friend
My name is Munny Sopheap a Personal accountant to a deseaed client with Finance
Investment Bank of Asia/Europe Regional.
A late investor of our bank died and left a huge amount of money with Our Bank
for some years now and no next of kin has come forward all these years for
claim.
> -Original Message-
> From: Long Li
> Sent: Thursday, March 22, 2018 8:16 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger ;
> James E . J . Bottomley ; Martin
The driver remove() function prints a message when the operation
is completed. Make this a debug level message to avoid polluting
the kernel log wih too much information.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +-
1 file
Haiyang Zhang writes:
> From: Haiyang Zhang
>
> This patch adds range checking for rx packet offset and length.
> It may only happen if there is a host side bug.
>
> Signed-off-by: Haiyang Zhang
> ---
>
> -Original Message-
> From: Haiyang Zhang
> Sent: Friday, March 23, 2018 8:01 AM
> To: Long Li ; KY Srinivasan
> ; Stephen Hemminger ;
> James E . J . Bottomley ; Martin K . Petersen
>
Free allocated memory for failure scenario while processing the
information message received from the firmware. Added NULL check and used
kmemdup in the flow of handling information message.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 48
Free memory allocated in wilc_add_rx_gtk() before returing from the
function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
Fix 'Too many leading tabs' issue found by checkpatch.pl script in
handle_rcvd_gnrl_async_info().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 286 --
1 file changed, 149 insertions(+), 137 deletions(-)
diff
Free allocated memory after completing wilc_send_config_pkt() function.
Remove unncessary use of 'stamac' pointer in handle_get_inactive_time().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 8 +---
1 file changed, 5 insertions(+), 3
Added 'NULL' check before accessing the allocated memory. Free up the
memory incase of failure to enqueue the command. Used kmemdup instead of
kmalloc & memcpy.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 9 ++---
1 file changed, 6
Free memory allocated for wep key when command enqueue is failed.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
Free allocated memory in wilc_add_ptk() when it fails to enqueue the
command.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
Cleanup patch to remove the unused global variables defined for p2p.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 59 ---
1 file changed, 59 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
This patch series contains changes to fix memory leaks, avoid NULL pointer
exceptions and checkpatch reported issue fixes.
Ajay Singh (9):
staging: wilc1000: remove unused global variables related to p2p
staging: wilc1000: avoid 'NULL' pointer access in
wilc_network_info_received()
Added fix to free the allocated memory in case of failure to enqueue
the command.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
On Fri, Mar 23, 2018 at 03:03:29PM +, Ruxandra Ioana Ciocoi Radulescu wrote:
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Friday, March 23, 2018 5:01 PM
> > To: Ruxandra Ioana Ciocoi Radulescu
> > Cc:
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, March 23, 2018 5:01 PM
> To: Ruxandra Ioana Ciocoi Radulescu
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH 2/9] staging:
On Fri, Mar 23, 2018 at 08:44:06AM -0500, Ioana Radulescu wrote:
> Let the driver remove() function print an informative message
> after it finishes removing the network interface, not at an
> arbitrary point during cleanup.
>
> Signed-off-by: Ioana Radulescu
> ---
>
> -Original Message-
> From: Long Li
> Sent: Thursday, March 22, 2018 8:16 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger ;
> James E . J . Bottomley ; Martin
On Thu, Mar 22, 2018 at 10:07:41PM -0700, Quytelda Kahja wrote:
> Most of the request structures defined in ks_hostif.h have common
> members:
> * __le16 phy_type;
> * __le16 cts_mode;
> * __le16 scan_type;
> * __le16 capability;
> * struct rate_set16_t rate_set;
>
> Factor out these members into
The original code had a read function per data size; after updates, all
read functions tasks were centralized in a single function, but the old
signature was kept to maintain the module working without problems. This
patch removes a set of duplications associated with read_reg_*, and
update the
The read operation for the I2C function has many duplications that can
be generalized into a single function. This patch reworks the read
operation for I2C to centralizes all similar code in a single function.
It is possible to remove all the old interface to use the new one,
however, for keeping
Rework read SPI function to reduce the code duplication and centralizes
all the task in a single function.
Signed-off-by: Rodrigo Siqueira
---
Changes in v3:
- Remove the use of defines that not improve the readability
- Replace variable name "bytes" for "bits"
This patch removes code duplications related to the write_reg_*
functions and centralizes them in a single function. Also, it eliminates
the legacy functions and replaces them by a unique signature that is
used by SPI and I2C.
Signed-off-by: Rodrigo Siqueira
---
The write operation using SPI has a many code duplications (similar to
I2C) and four different interfaces per data size. This patch introduces
a single function that centralizes the main task related to SPI.
Signed-off-by: Rodrigo Siqueira
---
Changes in v3:
-
The write operation using I2C has many code duplications and four
different interfaces per data size. This patch introduces a single
function that centralizes the main tasks.
The central function inserted by this patch can easily replace all the
four functions related to the data size. However,
Fixes: correctly handle the data size in the read operation for I2C
The function ade7854_i2c_read_reg_32() have to invoke the
i2c_master_recv() for read 32 bits values, however, the counter is set
to 3 which means 24 bits. This patch fixes the wrong size of 24 bits, to
32 bits.
Signed-off-by:
Fixes: correctly handle errors on the read and write operation for I2C
The original code does not correctly handle the error related to I2C
read and write. This patch fixes the error handling related to all
read/write functions for I2C.
Signed-off-by: John Syne
This patchset reworks the I2C/SPI code from meter module. The set of
patches try to reduce the code duplication and make the communication
reliable. The current version of the module had many code duplications,
which make the code more error-prone and hard to read. Jonh Syne
identified some wrong
`external_ai_queue_in_use()` is supposed to return 1 if the external
channel sequencer is in use by an AI command, else return 0. If the
"read" subdevice (which is the AI subdevice) is not busy then no AI
command is running so the external channel sequencer is not in use, so
the function should
Fix a couple of problems in the external_ai_queue_in_use() function.
Patch 1 reverts a patch that turns out to be bogus, although it did mask
a null pointer deference problem fixed by patch 2. Patch 2 fixes an
inverted test that has been wrong since before Comedi was imported into
the kernel,
This reverts commit f5f3a2c6569e ("staging: comedi: cb_pcidas64: change
params to external_ai_queue_in_use()"). The
`external_ai_queue_in_use()` was being called from `ao_cmd()` with
pointers to the "write" subdevice and AO command, but is supposed to
check whether the external AI queue is
Cleanup code in free_tx_fd() that deals with S/G frames:
- remove local variables that aren't really needed
- in the frame sw annotation area, store the actual SG table
buffer size, which is needed on free, rather then recompute
it based on number of S/G entries
Signed-off-by: Ioana Radulescu
We mistakenly allocate space for too many entries in the
scatter-gather table of multi buffer egress frames.
While it doesn't have a negative impact from a functional
point of view, it wastes resources so fix it.
Signed-off-by: Ioana Radulescu
---
We use DPAA2_ETH_MAX_TX_QUEUES to dimension the array holding
information on Tx queues. At most, we can have one queue per cpu.
Until now we used the NR_CPUS macro to set the upper limit on number
of Tx queues. However, the platforms that the DPAA2 Ethernet driver
supports have at most 16 cores,
Newer MC versions allow us to change link settings while the
interface is up. Only check interface status if we are using
an old version.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 15 +--
1 file changed, 9
Remove dpio_id field in struct dpaa2_eth_channel, which wasn't
used anywhere in the code.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 -
1 file changed, 1 deletion(-)
diff --git
The DPAA2 Ethernet driver assumes the DPNI objects that it
uses to build network interfaces have a minimum supported
API version, but until now it did nothing to enforce this
requirement.
Add a check at probe time to make sure the DPNI object is
compatible with the set of MC commands we intend to
Structure dpaa2_fas is naturally aligned, so no need to use
the __packed attribute explicitly.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
For the link state interrupt, we used a dummy non-threaded
irq handler, which had the same implementation as the generic
irq_default_primary_handler() function.
Give up on using our own irq handler and let the kernel use
the generic one instead.
Signed-off-by: Ioana Radulescu
A set of cleanup patches with limited functional impact.
Ioana Radulescu (9):
staging: fsl-dpaa2/eth: Use generic irq handler
staging: fsl-dpaa2/eth: Move print message
staging: fsl-dpaa2/eth: Remove unused field
staging: fsl-dpaa2/eth: Remove packed attribute
staging: fsl-dpaa2/eth:
Let the driver remove() function print an informative message
after it finishes removing the network interface, not at an
arbitrary point during cleanup.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++-
1 file changed, 2
On Fri, 23 Mar 2018 00:42:42 +0530
Himanshu Jha wrote:
> Remove few unused headers files since the adis core handles the buffer and
> sysfs support.
>
> Signed-off-by: Himanshu Jha
Please avoid sending a series in reply to a previous
The following changes since commit c698ca5278934c0ae32297a8725ced2e27585d7f:
Linux 4.16-rc6 (2018-03-18 17:48:42 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.16-rc7
for you to fetch changes up to
On Sun, 18 Mar 2018 14:37:22 +0100
David Veenstra wrote:
> Signed-off-by: David Veenstra
Please disable git move detection for a patch moving an IIO driver
out of staging. It provides the opportunity for a full review of the
code as
On Sun, 18 Mar 2018 14:37:04 +0100
David Veenstra wrote:
> The angle channel is not defined in sysfs iio ABI. So it is replaced
> with an inclination channel, because it is defined in the ABI, and has the
> semantics of an angle.
>
> In addition, a fractional
On Sun, 18 Mar 2018 14:36:33 +0100
David Veenstra wrote:
> The legacy, integer based gpio ABI is replaced with the descriptor
> based ABI.
>
> For compatibility, it is first tried to use the platform data to
> request the gpio's. Otherwise, it looks for the
On Sun, 18 Mar 2018 14:36:15 +0100
David Veenstra wrote:
> After a successful spi transaction, a udelay(1) is needed.
> This doesn't happen for the default case of the switch statement
> in ad2s1200_read_raw. This patch makes sure that it does.
>
> Signed-off-by:
On Sun, 18 Mar 2018 14:35:46 +0100
David Veenstra wrote:
> Add variable to hold >dev in ad2s1200_probe. This value is repeatedly
> used in ad2s1200_probe.
>
> Signed-off-by: David Veenstra
I'm a little unconvinced by this one. It
This commit replaces param which is uint8_t in michael_append
function in favour of preferred one u8.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
This commit replaces GetUInt32 with inline function renaming
it to get_uint32.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git
This commit replaces MichaelBlockFunction macro with similar
inline function renaming it to michael_block.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 30 +++---
1 file changed, 15 insertions(+), 15
This commit avoid camel cases in MichaelAppend function and params
renaming it to michael_append.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 45 ++--
1 file changed, 22 insertions(+), 23 deletions(-)
This commit avoid camel cases in MichaelGetMIC function and params
renaming it to michael_get_mic.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff
This commit avoid camel cases in MichaelInitFunction signature and params
renaming it to michael_init.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
This commit replaces uint8_t parameter for preferred one u8 in
michael_get_mic function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This commit replaces uint8_t for preferred one u8 in parameter
of michael_init function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This commit replaces PutUInt32 macro in favour of inline function
renaming it to put_uint32.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
Replace upper case fields and camel cases for fields included in
michael_mic_t structure
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 8 +++---
drivers/staging/ks7010/michael_mic.c | 54 ++--
The following patch series clean michael_mic source and header files.
Changes are as follows:
* avoid camel cases in some structs and function definitions
* replace macros with inline functions
* use u8 type replacing some uint8_t types and avoid some no more
needed casts.
v2:
Patches 9 and
This commit replace camel cases for name and params used in
MichaelMICFunction. This improves a bit readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/michael_mic.c | 15
This commit replaces MichaelClear macro with similar inline function
renaming it to michael_clear.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/michael_mic.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
On 23/03/18 10:49, Jian Zhang wrote:
This is a patch to the cb_pcidas64.c file that fixes up a multiple line
dereference warning found by the checkpatch.pl tool.
Signed-off-by: Jian Zhang
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 19 ++-
1
On Fri, Mar 23, 2018 at 07:56:48AM -0400, Mauro Carvalho Chehab wrote:
> The logic at find_format() is a little bit confusing even for
> humans, and it tricks static code analyzers:
>
> drivers/staging/media/imx/imx-media-utils.c:259 find_format() error:
> buffer overflow 'array' 14 <= 20
The logic at find_format() is a little bit confusing even for
humans, and it tricks static code analyzers:
drivers/staging/media/imx/imx-media-utils.c:259 find_format() error:
buffer overflow 'array' 14 <= 20
Rewrite the logic in a way that it makes it clearer to understand,
while
1 - 100 of 111 matches
Mail list logo